[Lldb-commits] [PATCH] D96307: [lldb] Fix crash in FormatEntity for mangled-name

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7dc324aafa2b: [lldb] Fix crash in FormatEntity for mangled-name (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 7dc324a - [lldb] Fix crash in FormatEntity for mangled-name

Author: Dave Lee Date: 2021-02-08T18:38:08-08:00 New Revision: 7dc324aafa2b17a4f9a992b9727a3642505053a6 URL: https://github.com/llvm/llvm-project/commit/7dc324aafa2b17a4f9a992b9727a3642505053a6 DIFF: https://github.com/llvm/llvm-project/commit/7dc324aafa2b17a4f9a992b9727a3642505053a6.diff LOG:

[Lldb-commits] [PATCH] D96307: [lldb] Fix crash in FormatEntity for mangled-name

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. LGTM! Thanks for catching that! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96307/new/ https://reviews.llvm

[Lldb-commits] [PATCH] D96307: [lldb] Fix crash in FormatEntity for mangled-name

kastiglione created this revision. kastiglione added a reviewer: mib. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Check a `Block` pointer before dereferencing. Using `function.mangled-name` led to a crash for a frame where

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

jrtc27 accepted this revision. jrtc27 added a comment. In D95947#2549599 , @mgorny wrote: > @jrtc27 , does this look good? Yep, assuming it still works. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95947/new/ https://reviews.llvm.org/D95947 _

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

jingham added a comment. In D96276#2549406 , @kastiglione wrote: > In D96276#2549007 , @jingham wrote: > >> It still seems to me like a trampoline which knew that to implement itself, >> all it had to do was a coup

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

mgorny marked 6 inline comments as done. mgorny added a comment. @jrtc27 , does this look good? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95947/new/ https://reviews.llvm.org/D95947 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

mgorny updated this revision to Diff 322208. mgorny added a comment. Improve consistency of trap opcodes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95947/new/ https://reviews.llvm.org/D95947 Files: lldb/source/Host/common/NativeProcessProtocol.cpp lldb/source/Plugins/Platform/F

Re: [Lldb-commits] [lldb] 5a63045 - [LLDB] Fix `Wunused-result` warning

Might be worth making an "execution override" object that has a dtor to do the cleanup? On Mon, Feb 8, 2021 at 9:10 AM Frederik Gossen via lldb-commits wrote: > > > Author: Frederik Gossen > Date: 2021-02-08T18:10:08+01:00 > New Revision: 5a63045fe78834937785ed5081052e083a98077f > > URL: > https

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

jrtc27 added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08, 0x00

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

krytarowski added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08,

[Lldb-commits] [PATCH] D96202: [lldb/test] Automatically find debug servers to test

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This will break my "run the tests against an Xcode install", but it seems like I should be able to work around that looking for debugserver in the LLDB.framework in `get_debugserve

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

jrtc27 added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08, 0x00

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

mgorny added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08, 0x00

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

mgorny added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08, 0x00

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

kastiglione added a comment. In D96276#2549007 , @jingham wrote: > It still seems to me like a trampoline which knew that to implement itself, > all it had to do was a couple of stepi's - for instance if a dyld stub knew > that the stub had been filled i

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

jrtc27 added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08, 0x00

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

mgrang added a comment. Herald added a subscriber: JDevlieghere. Hi @jfb This patch results in a compiler crash when building a simple C program on a Windows X86 Debug build. I have filed this issue to track it. Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

krytarowski added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08,

[Lldb-commits] [PATCH] D95947: [lldb] [Process/FreeBSDRemote] Introduce powerpc support

jrtc27 added inline comments. Comment at: lldb/source/Host/common/NativeProcessProtocol.cpp:525-526 static const uint8_t g_s390x_opcode[] = {0x00, 0x01}; + static const uint8_t g_ppc_opcode[] = {0x7f, 0xc0, 0x00, 0x08}; static const uint8_t g_ppc64le_opcode[] = {0x08, 0x00

[Lldb-commits] [PATCH] D96277: [lldb] Minor cleanups to ThreadPlan.h (NFC)

jingham added a comment. This is okay. It seems like CachePlanExplainsStop wasn't used because it's done by hand instead. A better patch might be to stop doing that and use the function instead? But the argument's not terribly compelling either way... Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu added a comment. Landed in 11.1 https://github.com/llvm/llvm-project/commit/1fdec59bffc11ae37eb51a1b9869f0696bfd5312#diff-2fa23ad0cf1839955ddaf4a0d78a9d9b5fd9b88933f82f6433035916a2655c6c. Patch needs to be rebased for trunk now. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

jingham added a comment. I can't think of a really good reason why you would need to override the general "step in avoids nodebug" behavior. I'm pretty sure I was thinking of a trampoline that got you half way to somewhere interesting, at which point you would want to negotiate again for the t

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

kastiglione added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCTrampolineHandler.cpp:1163 - // stop_others value passed in to us here: - const bool trampoline_stop_others = fals

[Lldb-commits] [lldb] 8244fc5 - [lldb] [Process/FreeBSDRemote] Introduce mips64 support

Author: Michał Górny Date: 2021-02-08T18:27:26+01:00 New Revision: 8244fc505def67f1094713202a2345f0c39d33dd URL: https://github.com/llvm/llvm-project/commit/8244fc505def67f1094713202a2345f0c39d33dd DIFF: https://github.com/llvm/llvm-project/commit/8244fc505def67f1094713202a2345f0c39d33dd.diff

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

This revision was automatically updated to reflect the committed changes. Closed by commit rG8244fc505def: [lldb] [Process/FreeBSDRemote] Introduce mips64 support (authored by mgorny). Herald added a subscriber: jrtc27. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm

[Lldb-commits] [PATCH] D96277: [lldb] Minor cleanups to ThreadPlan.h (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While learning about ThreadPlan, I did a bit of cleanup: - Remove unused code - Move functions to protect

[Lldb-commits] [PATCH] D96276: [lldb] Inline invariant params to AppleThreadPlanStepThrough (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. These two `AppleThreadPlanStepThrough` thread plans have parameterized behavior that is unutilized. To mak

[Lldb-commits] [lldb] 5a63045 - [LLDB] Fix `Wunused-result` warning

Author: Frederik Gossen Date: 2021-02-08T18:10:08+01:00 New Revision: 5a63045fe78834937785ed5081052e083a98077f URL: https://github.com/llvm/llvm-project/commit/5a63045fe78834937785ed5081052e083a98077f DIFF: https://github.com/llvm/llvm-project/commit/5a63045fe78834937785ed5081052e083a98077f.dif

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 01/08: Pass main DWARFUnit * along DWARFDIEs

jankratochvil planned changes to this revision. jankratochvil added a comment. I will try to update it, I agree with your comment, thanks for the review. I agree this first patch needs to be decided first before looking at the other parts 02..08. Repository: rG LLVM Github Monorepo CHANGES S

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Ok, seems reasonable. Comment at: lldb/source/Plugins/Process/Utility/NativeProcessSoftwareSingleStep.cpp:20 + +namespace lldb_private { + This should be an

[Lldb-commits] [PATCH] D96260: [lldb/test] Test lldb-server named pipe functionality on windows

labath created this revision. labath added reviewers: amccarth, stella.stamenova. labath requested review of this revision. Herald added a project: LLDB. lldb-server can use a named pipe to communicate the port number it is listening on. This windows bits of this are already implemented, but we di

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

mgorny added a comment. @labath, done. Does it look reasonably good now? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95802/new/ https://reviews.llvm.org/D95802 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D95802: [lldb] [Process/FreeBSDRemote] Introduce mips64 support

mgorny updated this revision to Diff 322088. mgorny added a comment. Switch to `SetBreakpoint()`. remove `friend` and refactor `size_hint` to a variable while at it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95802/new/ https://reviews.llvm.org/D95802 Files: lldb/source/Plugins/P

[Lldb-commits] [PATCH] D96236: [lldb] DWZ 01/08: Pass main DWARFUnit * along DWARFDIEs

labath added a comment. I stopped looking after the first file, as the introduction of DWARF-ness to the CompileUnit class is a show-stopper. These classes are supposed to be independent of the actual format used to represent the data, and having them know anything about DWARF breaks that. What

[Lldb-commits] [lldb] 05d7d69 - [lldb/tests] Removed add_test_categories decorator for python API tests, NFC

Author: Tatyana Krasnukha Date: 2021-02-08T15:10:48+03:00 New Revision: 05d7d6949c7cd3f1566d4c8394fa59160a7ffd05 URL: https://github.com/llvm/llvm-project/commit/05d7d6949c7cd3f1566d4c8394fa59160a7ffd05 DIFF: https://github.com/llvm/llvm-project/commit/05d7d6949c7cd3f1566d4c8394fa59160a7ffd05.d

[Lldb-commits] [lldb] 36de94c - Reland "[lldb] Make CommandInterpreter's execution context the same as debugger's one"

Author: Tatyana Krasnukha Date: 2021-02-08T15:09:09+03:00 New Revision: 36de94cf54efbad967a9a0fa41329a8b59bc35c4 URL: https://github.com/llvm/llvm-project/commit/36de94cf54efbad967a9a0fa41329a8b59bc35c4 DIFF: https://github.com/llvm/llvm-project/commit/36de94cf54efbad967a9a0fa41329a8b59bc35c4.d

[Lldb-commits] [lldb] f9c5e16 - [lldb/tests] Un-skip TestGuiBasicDebug.py on Arm and AArch64

Author: Tatyana Krasnukha Date: 2021-02-08T15:09:09+03:00 New Revision: f9c5e1664e081031e7deec3df49953952771d21b URL: https://github.com/llvm/llvm-project/commit/f9c5e1664e081031e7deec3df49953952771d21b DIFF: https://github.com/llvm/llvm-project/commit/f9c5e1664e081031e7deec3df49953952771d21b.d

[Lldb-commits] [lldb] a39bcbc - [lldb] Debugger: reuse ExecutionContextRef to create ExecutionContext from Target

Author: Tatyana Krasnukha Date: 2021-02-08T15:09:08+03:00 New Revision: a39bcbca92e169baeb8b2c55dff90141ddd53888 URL: https://github.com/llvm/llvm-project/commit/a39bcbca92e169baeb8b2c55dff90141ddd53888 DIFF: https://github.com/llvm/llvm-project/commit/a39bcbca92e169baeb8b2c55dff90141ddd53888.d

[Lldb-commits] [PATCH] D96254: [ELFObjectWriter] Fix `symbol-binding.test` to conform to unsorted local symbols

frgossen abandoned this revision. frgossen added a comment. Already fixed in d813c37fc7ce507e008bdee1fc1726a57bc76df5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96254/new/ ht

[Lldb-commits] [PATCH] D96254: [ELFObjectWriter] Fix `symbol-binding.test` to conform to unsorted local symbols

frgossen created this revision. frgossen requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Commit 980d28d9556a (ELFObjectWriter: Don't sort local symbols) caused `symbol-

[Lldb-commits] [lldb] d813c37 - [LLDB] Fix buildbot regression in symbol-binding.test

Author: Muhammad Omair Javaid Date: 2021-02-08T15:20:39+05:00 New Revision: d813c37fc7ce507e008bdee1fc1726a57bc76df5 URL: https://github.com/llvm/llvm-project/commit/d813c37fc7ce507e008bdee1fc1726a57bc76df5 DIFF: https://github.com/llvm/llvm-project/commit/d813c37fc7ce507e008bdee1fc1726a57bc76d

[Lldb-commits] [PATCH] D77043: Use remote regnums in expedited list, value regs and invalidate regs

This revision was automatically updated to reflect the committed changes. Closed by commit rG8561ad9296b7: Use remote regnums in expedited list, value regs and invalidate regs (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8561ad9 - Use remote regnums in expedited list, value regs and invalidate regs

Author: Muhammad Omair Javaid Date: 2021-02-08T14:09:15+05:00 New Revision: 8561ad9296b70b5a2af1574a1576090520d62a7c URL: https://github.com/llvm/llvm-project/commit/8561ad9296b70b5a2af1574a1576090520d62a7c DIFF: https://github.com/llvm/llvm-project/commit/8561ad9296b70b5a2af1574a1576090520d62a

[Lldb-commits] [lldb] bec6b5e - [LLDB] Disable TestExprsChar.py, still fails on Arm/Linux

Author: Muhammad Omair Javaid Date: 2021-02-08T14:05:36+05:00 New Revision: bec6b5e3cec71a9560cc761fd7804f354c3aca02 URL: https://github.com/llvm/llvm-project/commit/bec6b5e3cec71a9560cc761fd7804f354c3aca02 DIFF: https://github.com/llvm/llvm-project/commit/bec6b5e3cec71a9560cc761fd7804f354c3aca

[Lldb-commits] [PATCH] D93939: [elf-core] Improve reading memory from core file

This revision was automatically updated to reflect the committed changes. Closed by commit rG9abd8c1a4c38: [elf-core] Improve reading memory from core file (authored by djtodoro). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D93939/new/ https://revi

[Lldb-commits] [lldb] 9abd8c1 - [elf-core] Improve reading memory from core file

Author: Djordje Todorovic Date: 2021-02-08T00:14:32-08:00 New Revision: 9abd8c1a4c3870f2831ee805cd3c0cec516a1c17 URL: https://github.com/llvm/llvm-project/commit/9abd8c1a4c3870f2831ee805cd3c0cec516a1c17 DIFF: https://github.com/llvm/llvm-project/commit/9abd8c1a4c3870f2831ee805cd3c0cec516a1c17.d