[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

shafik added inline comments. Comment at: lldb/source/Core/Value.cpp:574 switch (m_value_type) { -case eValueTypeScalar: // raw scalar value +case ValueType::Invalid: +case ValueType::Scalar: // raw scalar value aprantl wrote: > shafik wrote: > >

Re: [Lldb-commits] [lldb] 2dbe88d - [lldb] Fix up SysV ABI implementations after 057efa9916cdc354ef4653bcd128a578cc43125e

Thanks! -- adrian > On Feb 12, 2021, at 4:34 PM, Benjamin Kramer via lldb-commits > wrote: > > > Author: Benjamin Kramer > Date: 2021-02-13T01:34:00+01:00 > New Revision: 2dbe88db5804f32c6dfc1aa474881c3cb7a61d03 > > URL: > https://github.com/llvm/llvm-project/commit/2dbe88db5804f32c6dfc1aa4

[Lldb-commits] [lldb] 2dbe88d - [lldb] Fix up SysV ABI implementations after 057efa9916cdc354ef4653bcd128a578cc43125e

Author: Benjamin Kramer Date: 2021-02-13T01:34:00+01:00 New Revision: 2dbe88db5804f32c6dfc1aa474881c3cb7a61d03 URL: https://github.com/llvm/llvm-project/commit/2dbe88db5804f32c6dfc1aa474881c3cb7a61d03 DIFF: https://github.com/llvm/llvm-project/commit/2dbe88db5804f32c6dfc1aa474881c3cb7a61d03.dif

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl added a comment. > (Btw, if you intend to cherry-pick this into swift/main for some reason then > please let me know as this probably will cause a bunch of conflicts with the > temporarily reverted patch from Pavel). I don't //need// to cherry-pick it, so I won't for now. ===

[Lldb-commits] [lldb] 188b074 - Support dereferencing a DWARF scalar stack value

Author: Adrian Prantl Date: 2021-02-12T16:12:32-08:00 New Revision: 188b0747c1664d962e94f00b5e3caac529fa1e26 URL: https://github.com/llvm/llvm-project/commit/188b0747c1664d962e94f00b5e3caac529fa1e26 DIFF: https://github.com/llvm/llvm-project/commit/188b0747c1664d962e94f00b5e3caac529fa1e26.diff

[Lldb-commits] [lldb] 057efa9 - Make the error condition in Value::ValueType explicit (NFC)

Author: Adrian Prantl Date: 2021-02-12T16:12:31-08:00 New Revision: 057efa9916cdc354ef4653bcd128a578cc43125e URL: https://github.com/llvm/llvm-project/commit/057efa9916cdc354ef4653bcd128a578cc43125e DIFF: https://github.com/llvm/llvm-project/commit/057efa9916cdc354ef4653bcd128a578cc43125e.diff

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

This revision was automatically updated to reflect the committed changes. Closed by commit rG188b0747c166: Support dereferencing a DWARF scalar stack value (authored by aprantl). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D96549?vs=323489&id=323496#toc Repo

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

aprantl added inline comments. Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:347 + ExecutionContext exe_ctx(process_sp); + EXPECT_THAT_EXPECTED(Evaluate({DW_OP_lit4, DW_OP_deref}, {}, {}, &exe_ctx), + llvm::HasValue(GetScalar(32, 0x07060504

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

vsk accepted this revision. vsk added a comment. This revision is now accepted and ready to land. Thanks, lgtm. Comment at: lldb/unittests/Expression/DWARFExpressionTest.cpp:347 + ExecutionContext exe_ctx(process_sp); + EXPECT_THAT_EXPECTED(Evaluate({DW_OP_lit4, DW_OP_deref},

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

aprantl updated this revision to Diff 323489. aprantl added a comment. There's actually no reason to fill a second memory buffer. Replaced all of DoReadMemory with a single for loop. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96549/new/ https://reviews.llvm.org/D96549 Files: lldb

[Lldb-commits] [PATCH] D96549: Support dereferencing a DWARF scalar stack value

aprantl updated this revision to Diff 323488. aprantl added a comment. Herald added a subscriber: mgorny. That took me a little to get right, but here you go! Mock process. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96549/new/ https://reviews.llvm.org/D96549 Files: lldb/source/Exp

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

mib updated this revision to Diff 323484. mib marked 3 inline comments as done. mib edited the summary of this revision. mib added a comment. Herald added a subscriber: mgorny. Address @JDevlieghere comments: - Instead of having the ScriptedProcess python base class in a SWIG file, I moved it to

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

aadsm created this revision. aadsm added reviewers: mgorny, labath, emaste. aadsm requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This issue was introduced in https://reviews.llvm.org/D92187. The guard I'm changing were is supposed to act w

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

mib updated this revision to Diff 323481. mib marked 3 inline comments as done. mib added a comment. Address @JDevlieghere comments: - Fix namespace closing comment in `SBData.h` - Remove `ScriptInterpreter` overload by making the `ScriptedProcessInterface` a default argument. - Replace inline c

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews.llvm.org/D96537 ___ lldb-commits mailing list lldb-commits@l

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

sgraenitz created this revision. sgraenitz added reviewers: labath, teemperor, JDevlieghere, lhames. sgraenitz requested review of this revision. Herald added a project: LLDB. LLVM OrcJIT is shifting from RuntimeDyld to JITLink. Starting with D96627 I am planning

[Lldb-commits] [PATCH] D96537: Make the error condition in Value::ValueType explicit (NFC)

aprantl updated this revision to Diff 323467. aprantl marked 9 inline comments as done. aprantl added a comment. Address review feedback! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96537/new/ https://reviews.llvm.org/D96537 Files: lldb/include/lldb/Core/Value.h lldb/include/lldb

[Lldb-commits] [PATCH] D96623: [lldb-vscode] Fix lldb init file stdout issue

yinghuitan created this revision. yinghuitan added reviewers: clayborg, aadsm. yinghuitan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. VScode DAP client uses stdout to receive protocol message. This means any stdout/stderr from debugger

[Lldb-commits] [lldb] 9f17599 - [LLDB] Fix LLDB_LOG calls to use correct formatting

Author: Shafik Yaghmour Date: 2021-02-12T11:09:39-08:00 New Revision: 9f175998debcbb14e95d7e94ca5fee26f4acc63b URL: https://github.com/llvm/llvm-project/commit/9f175998debcbb14e95d7e94ca5fee26f4acc63b DIFF: https://github.com/llvm/llvm-project/commit/9f175998debcbb14e95d7e94ca5fee26f4acc63b.dif

[Lldb-commits] [PATCH] D96550: Fix LLDB_LOG calls to use correct formatting

This revision was automatically updated to reflect the committed changes. Closed by commit rG9f175998debc: [LLDB] Fix LLDB_LOG calls to use correct formatting (authored by shafik). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. A few small nits, but overall this LGTM. Comment at: lldb/include/lldb/API/SBData.h:16 +class ScriptInterpreter; +} + The linter

[Lldb-commits] [PATCH] D96550: Fix LLDB_LOG calls to use correct formatting

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96550/new/ https://reviews.llvm.org/D96550 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D95683: [lldb] Fix fallout caused by D89156 on 11.0.1 for MacOS

Abpostelnicu abandoned this revision. Abpostelnicu added a comment. This has landed and trunk is already fixed. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95683/new/ https://reviews.llvm.org/D95683 __

[Lldb-commits] [PATCH] D96556: [lldb] Let TestPExpectTest test the right test class

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c118831a37a: [lldb] Let TestPExpectTest test the right test class (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] 0c11883 - [lldb] Let TestPExpectTest test the right test class

Author: Raphael Isemann Date: 2021-02-12T09:56:43+01:00 New Revision: 0c118831a37a058f5ff196a4be3c4d5b1cf25e63 URL: https://github.com/llvm/llvm-project/commit/0c118831a37a058f5ff196a4be3c4d5b1cf25e63 DIFF: https://github.com/llvm/llvm-project/commit/0c118831a37a058f5ff196a4be3c4d5b1cf25e63.dif

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

omjavaid added a comment. For anyone reviewing this: Orignal RFC with all the required documentation insight into Arm Memory Tagging Extension can be found here: https://lists.llvm.org/pipermail/lldb-dev/2020-August/016402.html @DavidSpickett this calls for some documentation update in a futur