[Lldb-commits] [lldb] 7181104 - [debugserver] Correctly pass argv[0] to execl

Author: Jonas Devlieghere Date: 2021-02-15T18:42:21-08:00 New Revision: 71811048c0061c2ecf9aa6ce14c41f3f6ecf8aa9 URL: https://github.com/llvm/llvm-project/commit/71811048c0061c2ecf9aa6ce14c41f3f6ecf8aa9 DIFF: https://github.com/llvm/llvm-project/commit/71811048c0061c2ecf9aa6ce14c41f3f6ecf8aa9.d

[Lldb-commits] [lldb] 4946f37 - [lldb] Remove very old misleading comment (NFC)

Author: Dave Lee Date: 2021-02-15T18:14:57-08:00 New Revision: 4946f37d842fe7bca1b4a30962e7b6acdd7a4a9d URL: https://github.com/llvm/llvm-project/commit/4946f37d842fe7bca1b4a30962e7b6acdd7a4a9d DIFF: https://github.com/llvm/llvm-project/commit/4946f37d842fe7bca1b4a30962e7b6acdd7a4a9d.diff LOG:

[Lldb-commits] [PATCH] D96666: [lldb] Remove unused ThreadPlan tracer utilities (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG22f0aa0d9ebd: [lldb] Remove unused ThreadPlan tracer utilities (NFC) (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/

[Lldb-commits] [PATCH] D96687: [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2a2464eb7651: [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANG

[Lldb-commits] [lldb] 22f0aa0 - [lldb] Remove unused ThreadPlan tracer utilities (NFC)

Author: Dave Lee Date: 2021-02-15T17:59:25-08:00 New Revision: 22f0aa0d9ebddb004cbf2d0e7c8c015422351d2b URL: https://github.com/llvm/llvm-project/commit/22f0aa0d9ebddb004cbf2d0e7c8c015422351d2b DIFF: https://github.com/llvm/llvm-project/commit/22f0aa0d9ebddb004cbf2d0e7c8c015422351d2b.diff LOG:

[Lldb-commits] [lldb] 2a2464e - [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC)

Author: Dave Lee Date: 2021-02-15T17:59:24-08:00 New Revision: 2a2464eb7651dc89290e9e3bf6928c99453bed99 URL: https://github.com/llvm/llvm-project/commit/2a2464eb7651dc89290e9e3bf6928c99453bed99 DIFF: https://github.com/llvm/llvm-project/commit/2a2464eb7651dc89290e9e3bf6928c99453bed99.diff LOG:

[Lldb-commits] [PATCH] D96688: [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG65d91b40ae1d: [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC) (authored by kastiglione). Changed prior to commit: https://reviews

[Lldb-commits] [lldb] 65d91b4 - [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC)

Author: Dave Lee Date: 2021-02-15T17:57:13-08:00 New Revision: 65d91b40ae1d273586a8265d7cf598f0e56e17a3 URL: https://github.com/llvm/llvm-project/commit/65d91b40ae1d273586a8265d7cf598f0e56e17a3 DIFF: https://github.com/llvm/llvm-project/commit/65d91b40ae1d273586a8265d7cf598f0e56e17a3.diff LOG:

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

omjavaid added a comment. In D95601#2563613 , @DavidSpickett wrote: > To get the review going consider further splitting up these patches into > separate chunks containing, for example MemoryTagHandler API and related unit > tests, GDB remote addons,

[Lldb-commits] [PATCH] D96687: [lldb] Lower GetRealStopInfo into ThreadPlanCallFunction (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. It does seem odd to peek behind the back of a thread plan to figure out how to proceed, so making this special to the UserExpression thread plans, which are special in a bunch of ways, isn't

[Lldb-commits] [PATCH] D96666: [lldb] Remove unused ThreadPlan tracer utilities (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. At some point I had the idea that there would be a whole plugin architecture where you could add observers on all the stops & steps the lldb's execution control did. But for lldb command li

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading for lldb

omjavaid added a comment. This patch also looks quite good. Some minor nits inline and also move gdb* changes into a single patch with both client and server side code. Comment at: lldb/include/lldb/Target/Process.h:1701 + /// handler that can be used to maniupulate those mem

[Lldb-commits] [PATCH] D96688: [lldb] Minor refinements to ThreadPlan::RestoreThreadState (NFC)

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. It is possible that the stub could fail to restore the checkpointed state, though apparently it either never has or never has mattered because no one if setting or checking the bool return.

[Lldb-commits] [lldb] c2123a8 - [LLDB] Skip TestMultipleTargets.py on Arm/AArch64 Linux

Author: Muhammad Omair Javaid Date: 2021-02-16T01:28:16+05:00 New Revision: c2123a82cd0076c548d2b8c2acc14408681d7f89 URL: https://github.com/llvm/llvm-project/commit/c2123a82cd0076c548d2b8c2acc14408681d7f89 DIFF: https://github.com/llvm/llvm-project/commit/c2123a82cd0076c548d2b8c2acc14408681d7f

[Lldb-commits] [PATCH] D96689: [lldb] Remove ThreadPlan::ShouldAutoContinue (NFC)

kastiglione abandoned this revision. kastiglione added a comment. Even though the tests pass, I see that my logic was flawed. In theory, if autocontinue is true, and `MischiefManaged` returns true, then previous (parent) plans will be asked whether to `ShouldStop`. So the semantics of `ShouldAu

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleThreadPlanStepThroughObjCTrampoline.cpp:72 +m_func_sp->SetIsMasterPlan(false); m_func_sp->SetOkayToDiscard(true); PushPlan(m_func_sp); Thi

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support [WIP]

mgorny updated this revision to Diff 323779. mgorny added a comment. Switch to `LLDB_LOG_ERROR`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96548/new/ https://reviews.llvm.org/D96548 Files: lldb/packages/Python/lldbsuite/test/dotest.py lldb/source/Plugins/Process/FreeBSD/NativeP

[Lldb-commits] [PATCH] D96558: [lldb] [Process/FreeBSD] Ensure that errors are always handled

mgorny updated this revision to Diff 323774. mgorny retitled this revision from "[lldb] [Process/FreeBSDRemote] Ensure that errors are always handled" to "[lldb] [Process/FreeBSD] Ensure that errors are always handled". mgorny edited the summary of this revision. CHANGES SINCE LAST ACTION http

[Lldb-commits] [PATCH] D96558: [lldb] [Process/FreeBSD] Ensure that errors are always handled

mgorny added a comment. In D96558#2563105 , @labath wrote: > This is precisely the reason we have the LLDB_LOG_ERROR macro :) Updated. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96558/new/ https://reviews.llvm.org/D96558 ___

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1518 + Status error = NativeProcessLinux::PtraceWrapper( + details->ptrace_read_req, GetID(), + reinterpret_cast(range.GetRangeBase()), omjavaid w

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add MTE memory tag reading to lldb-server

DavidSpickett added a comment. To get the review going consider further splitting up these patches into separate chunks containing, for example MemoryTagHandler API and related unit tests, GDB remote addons, ptrace work etc. Also add reference to GDB mailing list discussion where design of qM

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione updated this revision to Diff 323765. kastiglione added a comment. Herald added a subscriber: JDevlieghere. Restore a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96715/new/ https://reviews.llvm.org/D96715 Files: lldb/inclu

[Lldb-commits] [PATCH] D96715: [lldb] Decouple IsMasterPlan and OkayToDiscard (NFC)

kastiglione created this revision. kastiglione added a reviewer: jingham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While learning the semantics of `IsMasterPlan` and `OkayToDiscard`, and guided by the FIXME comment in Th

[Lldb-commits] [lldb] bee4d6e - [lldb] Rename FreeBSDRemote to FreeBSD (NFC)

Author: Michał Górny Date: 2021-02-15T13:04:11+01:00 New Revision: bee4d6efe1781365cb82dcc94ad959309354af6f URL: https://github.com/llvm/llvm-project/commit/bee4d6efe1781365cb82dcc94ad959309354af6f DIFF: https://github.com/llvm/llvm-project/commit/bee4d6efe1781365cb82dcc94ad959309354af6f.diff

[Lldb-commits] [PATCH] D96557: [lldb] Rename FreeBSDRemote to FreeBSD (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rGbee4d6efe178: [lldb] Rename FreeBSDRemote to FreeBSD (NFC) (authored by mgorny). Herald added a subscriber: jrtc27. Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D96557

[Lldb-commits] [PATCH] D96194: Defer the decision whether to use the CU or TU index until after reading the unit header.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:808-809 + if (cu_index && (header.m_unit_type == llvm::dwarf::DW_UT_compile || + header.m_unit_type == llvm::dwarf::DW_UT_split_compile)) { +header.m_index_entry

[Lldb-commits] [PATCH] D96558: [lldb] [Process/FreeBSDRemote] Ensure that errors are always handled

labath added a comment. This is precisely the reason we have the LLDB_LOG_ERROR macro :) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96558/new/ https://reviews.llvm.org/D96558 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https:

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. sounds reasonable. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96634/new/ https://reviews.llvm.org/D96634 ___

[Lldb-commits] [PATCH] D95712: [lldb/bindings] Add Python ScriptedProcess base class to lldb module

labath added a comment. Unfortunately I don't have the bandwidth to review this, though I feel that this should have a wider discussion, given that its destined to become a pretty big chunk of our public immutable api surface. Some questions to seed that discussion: get_num_memory_regions() -

[Lldb-commits] [PATCH] D95711: [lldb/Interpreter] Add ScriptInterpreter Wrapper for ScriptedProcess

labath added inline comments. Comment at: lldb/unittests/ScriptInterpreter/Python/CMakeLists.txt:6 LINK_LIBS +liblldb lldbHost This is a bad idea -- it makes the binary get two copies of everything. Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

labath added a comment. And thanks for catching this. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96637/new/ https://reviews.llvm.org/D96637 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D96637: Make sure the interpreter module was loaded before making checks against it

labath added a comment. I'd like @mgorny to confirm this, but I think this should be fine -- the `m_rendezvous.IsValid()` branch does not do any funky module loading, so funky **un**loading should also be unnecessary. From the description is seems like trigerring this bug should be relatively

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D96555#2558465 , @mgorny wrote: > @labath, any clue if I'm missing some no-longer-necessary code? I feel like I > was supposed to also remove someth