This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGe7361c8eccb7: [lldb] Rename QueueFundamentalPlan to
QueueBasePlan (NFC) (authored by kastiglione).
Repository:
rG LLVM Github Monorepo
CHANGES
Author: Dave Lee
Date: 2021-03-04T21:46:49-08:00
New Revision: e7361c8eccb7663146096622549dc03240414157
URL:
https://github.com/llvm/llvm-project/commit/e7361c8eccb7663146096622549dc03240414157
DIFF:
https://github.com/llvm/llvm-project/commit/e7361c8eccb7663146096622549dc03240414157.diff
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97999/new/
https://reviews.llvm.org/D97999
JDevlieghere added a comment.
Test?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D98001/new/
https://reviews.llvm.org/D98001
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
mib created this revision.
mib added reviewers: JDevlieghere, teemperor, jingham.
mib added a project: LLDB.
mib requested review of this revision.
Herald added a subscriber: lldb-commits.
This patch exposes the getter and setter methods for the command
interpreter `print_errors` run option.
mib created this revision.
mib added a reviewer: JDevlieghere.
mib requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
This patch introduces a new interpreter setting to prevent LLDB from
re-executing the previous command when passing an empty
mhorne added inline comments.
Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:807
+if lldb.SBPlatform.GetHostPlatform().GetOSMajorVersion() < 14:
+return False, "Watchpoint support on arm64 requires FreeBSD 14.0"
return True, "watchpoint
jingham accepted this revision.
jingham added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.
Yeah, apparently I got tired of typing Fundamental pretty quickly...
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
kastiglione created this revision.
kastiglione added a reviewer: jingham.
kastiglione requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Minor change for naming consistency.
Repository:
rG LLVM Github Monorepo
wallace added a comment.
This looks really nice. The only thought I have is that you should accept
multiple callbacks instead of only one, as the current implementation discards
any existing callback if SetProgressCallback is called twice. I know that it'd
be rare that two or more callbacks
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc16fef19f6b0: [lldb/Interpreter] Make
OptionGroupPythonClassWithDict options non-required (authored by mib).
Repository:
rG LLVM Github Monorepo
Author: Med Ismail Bennani
Date: 2021-03-04T20:24:26+01:00
New Revision: c16fef19f6b002ba6ec7104d9f7dc44fef99ef57
URL:
https://github.com/llvm/llvm-project/commit/c16fef19f6b002ba6ec7104d9f7dc44fef99ef57
DIFF:
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97910/new/
https://reviews.llvm.org/D97910
mib updated this revision to Diff 328228.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97910/new/
https://reviews.llvm.org/D97910
Files:
lldb/include/lldb/Interpreter/OptionGroupPythonClassWithDict.h
mib updated this revision to Diff 328213.
mib added a comment.
Replace `std::bitset` by `lldb_private::Flags` as suggested by @JDevlieghere
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97910/new/
https://reviews.llvm.org/D97910
Files:
cmtice updated this revision to Diff 328191.
cmtice added a comment.
Update to incorporate Pavel's suggested simplification.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D97786/new/
https://reviews.llvm.org/D97786
Files:
lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp
mgorny updated this revision to Diff 328189.
mgorny added a comment.
Updated version conditions since watchpoint support was backported to FreeBSD
13.0-BETA4
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96548/new/
https://reviews.llvm.org/D96548
Files:
cmtice added a comment.
I'm not sure about using target.debug-file-search-paths, and what the changes
Pavel is suggesting would entail. But the real question I am trying to resolve
here is not "what are all the places we should be searching for the .dwo
files?" but "When we're given a
DavidSpickett marked an inline comment as done.
DavidSpickett added inline comments.
Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357
+
+ if (error.Fail())
+return error;
DavidSpickett wrote:
> omjavaid wrote:
> > ptrace request is
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbf3ac994c4d5: [lldb] Apply gdb-remote timeout to platform
connections as well (authored by labath).
Repository:
rG LLVM Github Monorepo
CHANGES
Author: Pavel Labath
Date: 2021-03-04T14:46:02+01:00
New Revision: bf3ac994c4d526b74044a977176e8e07d83f2049
URL:
https://github.com/llvm/llvm-project/commit/bf3ac994c4d526b74044a977176e8e07d83f2049
DIFF:
https://github.com/llvm/llvm-project/commit/bf3ac994c4d526b74044a977176e8e07d83f2049.diff
labath added a comment.
Having a setting for this would not be unreasonable.
But what about reusing an existing setting for this purpose? I thinking of the
(global) `target.debug-file-search-paths` setting and the associated logic
(`Symbols::LocateExecutableSymbolFile` and friends). If we used
mgorny added a comment.
Gentle ping.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D96548/new/
https://reviews.llvm.org/D96548
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
23 matches
Mail list logo
