[Lldb-commits] [PATCH] D98272: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformAppleSimulator.cpp:533 static PlatformSP CreateInstance(bool force, const ArchSpec *arch) { +if (arch && arch->IsValid() && !arch->TripleEnvironmentWasSpecified()) + return

[Lldb-commits] [lldb] ea659ea - Log in SetPrivateState when unwind logging enabled

Author: Jason Molenda Date: 2021-03-09T16:22:46-08:00 New Revision: ea659ea101a56a08c73be65ab62c3e180e37ca38 URL: https://github.com/llvm/llvm-project/commit/ea659ea101a56a08c73be65ab62c3e180e37ca38 DIFF: https://github.com/llvm/llvm-project/commit/ea659ea101a56a08c73be65ab62c3e180e37ca38.diff

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil created this revision. jankratochvil added reviewers: labath, grimar. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. jankratochvil requested review of this revision. `DW_AT_ranges` can use `DW_FORM_sec_offset` (instead of `DW_FORM_rnglistx`). In such

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid marked 2 inline comments as done. nealsid added a comment. In D98153#2610953 , @teemperor wrote: > Thanks for cleaning this up! Are the `if (!sc) ...` stuff are missing nullptr > checks that affect a normal LLDB session (not sure if we can ever

[Lldb-commits] [lldb] b4825a6 - [lldb][gui] Fix uninitialized variable in SourceFileWindowDelegate.

Author: Jordan Rupprecht Date: 2021-03-09T10:57:00-08:00 New Revision: b4825a6d9c18bdb3e241d709f2f76573aba9f91b URL: https://github.com/llvm/llvm-project/commit/b4825a6d9c18bdb3e241d709f2f76573aba9f91b DIFF:

[Lldb-commits] [PATCH] D98272: [lldb/Platform] Skip very slow xcrun queries for simulator platforms, NFC

vsk created this revision. vsk added reviewers: aprantl, JDevlieghere. vsk requested review of this revision. Herald added a project: LLDB. GetXcodeSDK() consistently takes over 1 second to complete if the queried SDK is missing, because `xcrun` doesn't cache negative lookups. Because there are

[Lldb-commits] [PATCH] D98219: [lldb] Update crashlog script for JSON changes

This revision was automatically updated to reflect the committed changes. Closed by commit rGcc52ea30012d: [lldb] Update crashlog script for JSON changes (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] cc52ea3 - [lldb] Update crashlog script for JSON changes

Author: Jonas Devlieghere Date: 2021-03-09T10:44:34-08:00 New Revision: cc52ea30012d3d9495a41255be50dccc77464cad URL: https://github.com/llvm/llvm-project/commit/cc52ea30012d3d9495a41255be50dccc77464cad DIFF:

[Lldb-commits] [lldb] 080ded7 - [lldb] Use lit.with_system_environment to propagate env variables

Author: Jonas Devlieghere Date: 2021-03-09T10:44:34-08:00 New Revision: 080ded7445cc670cf2628e660690a06503d226d7 URL: https://github.com/llvm/llvm-project/commit/080ded7445cc670cf2628e660690a06503d226d7 DIFF:

[Lldb-commits] [lldb] c2d2adb - [lldb] Propagate XDG_CACHE_HOME environment variable to tests

Author: Jonas Devlieghere Date: 2021-03-09T10:44:34-08:00 New Revision: c2d2adbce9299e562abd00b8f3139933beb97e17 URL: https://github.com/llvm/llvm-project/commit/c2d2adbce9299e562abd00b8f3139933beb97e17 DIFF:

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 added a comment. In D96176#2546777 , @labath wrote: > I'm not sure this new functionality is really worth the new packet (or two), > but if it solves a use case you care about, then I suppose that's fine. To be honest, I started this as I

[Lldb-commits] [PATCH] D96176: Implement jAttachWait

augusto2112 updated this revision to Diff 329385. augusto2112 marked 7 inline comments as done and an inline comment as not done. augusto2112 added a comment. Address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96176/new/

[Lldb-commits] [PATCH] D98219: [lldb] Update crashlog script for JSON changes

JDevlieghere added inline comments. Comment at: lldb/examples/python/crashlog.py:446 +low = int(json_image['base']) +high = int(0) +name = json_image['name'] aprantl wrote: > Time for me to learn some dark Python: What is 0

[Lldb-commits] [PATCH] D98219: [lldb] Update crashlog script for JSON changes

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/examples/python/crashlog.py:446 +low = int(json_image['base']) +high = int(0) +name = json_image['name']

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

DavidSpickett added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1345 + + tags.resize((range.GetByteSize() / details->manager->GetGranuleSize()) * + details->manager->GetBytesPerTag()); omjavaid wrote: > is

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2614101 , @labath wrote: > In D96458#2614076 , @omjavaid wrote: > >> In D96458#2613948 , @labath wrote: >> >>> In D96458#2613894

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. In D96458#2614076 , @omjavaid wrote: > In D96458#2613948 , @labath wrote: > >> In D96458#2613894 , @omjavaid wrote: >> >>> ConfigureRegisterContext

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.h:169 + void QueryAuxvForOptionalRegset(Flags _regsets); + This should be a result instead of a by-ref argument. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

labath requested changes to this revision. labath added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2038 + return m_aux_vector->GetAuxValue(type); +} DavidSpickett wrote: >

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2613948 , @labath wrote: > In D96458#2613894 , @omjavaid wrote: > >> ConfigureRegisterContext is called only once in the lifetime of a core from >>

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. In D96458#2613894 , @omjavaid wrote: > ConfigureRegisterContext is called only once in the lifetime of a core from > RegisterContextCorePOSIX_arm64 constructor. A process registers cannot change > during execution which is what

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. In D96458#2613244 , @labath wrote: > In D96458#2578760 , @omjavaid wrote: > >> In D96458#2566347 , @labath wrote: >> >>> I'm sorry, my response

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid added a comment. @labath @rovka any further comments on this one? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1345 + + tags.resize((range.GetByteSize() / details->manager->GetGranuleSize()) * + details->manager->GetBytesPerTag()); is there a difference

[Lldb-commits] [lldb] 2e82608 - [lldb] Fix a bug in D96779 (shared lib directory logic)

Author: Pavel Labath Date: 2021-03-09T15:15:45+01:00 New Revision: 2e826088b9832067994e0348fc768b81632be687 URL: https://github.com/llvm/llvm-project/commit/2e826088b9832067994e0348fc768b81632be687 DIFF: https://github.com/llvm/llvm-project/commit/2e826088b9832067994e0348fc768b81632be687.diff

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1357 + + if (error.Fail()) +return error; DavidSpickett wrote: > DavidSpickett wrote: > > DavidSpickett wrote: > > > omjavaid wrote: > > > > ptrace request

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/main.c:13 + // Wait for lldb-server to stop us + while (1) { + } infinite loop in test program may not be a good idea. Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2ff533cba18a: [lldb][JITLoaderGDB] Test debug support in JITLink (authored by sgraenitz). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 2ff533c - [lldb][JITLoaderGDB] Test debug support in JITLink

Author: Stefan Gränitz Date: 2021-03-09T14:10:52+01:00 New Revision: 2ff533cba18af853fa0688c101f7ac7e7b594db7 URL: https://github.com/llvm/llvm-project/commit/2ff533cba18af853fa0688c101f7ac7e7b594db7 DIFF:

[Lldb-commits] [PATCH] D96634: [lldb][JITLoaderGDB] Test debug support in llvm-jitlink

sgraenitz updated this revision to Diff 329301. sgraenitz added a comment. For the entry point, prefer lli over llvm-jitlink. D97339 added debug support for JITLink in lli. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329280. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic_regset/Makefile

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM with that one thing fixed. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/main.c:4-10 +#ifndef HWCAP2_MTE +#define

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added a comment. In D96463#2613498 , @DavidSpickett wrote: > Did you forget to add the changes? I don't see any diff for the last update. Sorry about that. Check the latest diff should be fixed now. CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329273. omjavaid added a comment. FIxes stale diff uploaded by mistake. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added a comment. Did you forget to add the changes? I don't see any diff for the last update. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:96 +if 'Scalable Vector Extension Registers' in registerSet.GetName(): +self.assertTrue(self.isAArch64SVE( +

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329269. omjavaid added a comment. fixes review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid marked 3 inline comments as done. nealsid added inline comments. Comment at: lldb/include/lldb/Core/FormatEntity.h:144 +num_children(num_children), children(children), +keep_separator(keep_separator) {} }; teemperor wrote: >

[Lldb-commits] [PATCH] D98153: Some FormatEntity.cpp cleanup and unit testing

nealsid updated this revision to Diff 329266. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98153/new/ https://reviews.llvm.org/D98153 Files: lldb/include/lldb/Core/FormatEntity.h lldb/source/Core/FormatEntity.cpp

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

DavidSpickett added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:96 +if 'Scalable Vector Extension Registers' in registerSet.GetName(): +self.assertTrue(self.isAArch64SVE( +

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcf806d91d562: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC) (authored by jankratochvil). Changed prior to commit:

[Lldb-commits] [lldb] cf806d9 - [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

Author: Jan Kratochvil Date: 2021-03-09T10:23:05+01:00 New Revision: cf806d91d562736192f91478eb47daa29c2230bf URL: https://github.com/llvm/llvm-project/commit/cf806d91d562736192f91478eb47daa29c2230bf DIFF:

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

labath added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-implicit-const.s:3 + +# UNSUPPORTED: system-darwin, system-windows +# REQUIRES: x86 jankratochvil wrote: > labath wrote: > > I hope these are not necessary, since you don't run the

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D98197#2613227 , @jankratochvil wrote: >> I guess we should also delete >> `test/Shell/Breakpoint/implicit_const_form_support.test`, as it's not

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath added a comment. In D96458#2578760 , @omjavaid wrote: > In D96458#2566347 , @labath wrote: > >> I'm sorry, my response times are pretty slow these days. >> >> I'm thinking about this `ConfigureRegisterInfos`

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil marked 2 inline comments as done. jankratochvil added a comment. In D98197#2613149 , @labath wrote: > Could you simplify the test case? done > I guess we should also delete > `test/Shell/Breakpoint/implicit_const_form_support.test`, as

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

jankratochvil updated this revision to Diff 329243. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98197/new/ https://reviews.llvm.org/D98197 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFAbbreviationDeclaration.cpp

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid added inline comments. Comment at: lldb/test/API/commands/register/register/aarch64_dynamic_regset/TestArm64DynamicRegsets.py:45 + +self.expect("register read ffr", substrs=[p_regs_value]) + DavidSpickett wrote: > omjavaid wrote: > >

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 329240. omjavaid added a comment. Minor fix to write unique value to all z/p registers when writing them using register write command. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files:

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 329239. omjavaid added a comment. Rebased after changes to parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp

[Lldb-commits] [PATCH] D96459: [LLDB] Pull AuxVec info into NativeRegisterContextLinux_arm64

omjavaid updated this revision to Diff 329235. omjavaid added a comment. Rebased after changes in parent. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96459/new/ https://reviews.llvm.org/D96459 Files: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp

[Lldb-commits] [PATCH] D96766: [lldb] [Process/FreeBSD] Introduce mips64 FPU reg support

labath added a comment. In D96766#2599440 , @nitesh.jain wrote: > In D96766#2596701 , @labath wrote: > >> Hm I'm very tempted to delete the linux mips implementation -- it uses >> several techniques which are

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 329232. omjavaid added a comment. This update fixes review comments highlighted by @rovka CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files:

[Lldb-commits] [PATCH] D98197: [lldb] Fix DWARF-5 DW_FORM_implicit_const (used by GCC)

labath added a comment. Could you simplify the test case? It sounds like all you need is a single global variable (`int foo = 47;`), without any functions or that stuff. I guess we should also delete `test/Shell/Breakpoint/implicit_const_form_support.test`, as it's not very useful (the numbers