[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. This is a work-in-progress to provide minimal support for multiprocess GDB protocol extension. For a start, a new function to parse thread-ids accounting for the possible

[Lldb-commits] [PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra abandoned this revision. amilendra added a comment. Herald added a subscriber: JDevlieghere. Abandoning this revision because I think I messed up something when using arcanist to fix pre-merge errors. https://buildkite.com/llvm-project/diff-checks/builds/32719 I'll submit a new review.

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 329613. davezarzycki added a comment. I believe I have addressed all of the feedback to date. For people that care about easily identifying the failures from the previous testing run, that is now encoded via the sign of the test time (please remember t

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jhenderson added inline comments. Comment at: llvm/utils/lit/lit/Test.py:216 +with open(test_times_file, 'r') as time_file: +for line in time_file.readlines(): +time, path = line.split(' ', 1) I believe you don't ne

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

mehdi_amini added inline comments. Herald added a subscriber: JDevlieghere. Comment at: llvm/utils/lit/lit/cl_arguments.py:157 selection_group.add_argument("-i", "--incremental", -help="Run modified and failing tests first (updates mtimes)", +help="St

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 329659. davezarzycki added a comment. I renamed the `file` variable as requested. I also found a workaround to the performance problem I referred to earlier. Now no new parameter is required during test discovery and therefore the diff is both simpler

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

yln added a comment. Very happy with the patch! Thanks for all your hard work! :) I have a few small nits and one ask: can we model "test failed" explicitly instead of making their execution time really large? Comment at: llvm/utils/lit/lit/discovery.py:141 +test_times =

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki removed 1 blocking reviewer(s): libc++. davezarzycki added a comment. I'm downgrading libcxx as a reviewer to non-blocking because the latest patch no longer requires changes to their project. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.o

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 329277. davezarzycki added a comment. Herald added subscribers: libcxx-commits, lldb-commits, arichardson. Herald added projects: LLDB, libc++. Herald added a reviewer: libc++. I believe I've addressed all of the feedback to date. I've also fixed the reg

[Lldb-commits] [PATCH] D98255: [release][docs] List all cores Arm has added support for in LLVM 12.

amilendra updated this revision to Diff 329380. amilendra added a comment. Herald added subscribers: llvm-commits, libcxx-commits, openmp-commits, lldb-commits, Sanitizers, jansvoboda11, frasercrmck, dexonsmith, ecnelises, wenlei, dang, jdoerfert, sstefan1, omjavaid, jvesely, phosek, kerbowa, lu

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jhenderson added a comment. In D98179#2615130 , @yln wrote: > can we model "test failed" explicitly instead of making their execution time > really large? I am strongly in favour of this, if it can be done. My team have wanted an option to rerun just fa

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jhenderson added a comment. I've skimmed the implementation, and it looks good to me, but I haven't got the time right now to review thoroughly. I'm pleased to see the ease of implementing "only-failures" on top of this too, thanks for illustrating. Comment at: llvm/utils/lit

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

jankratochvil added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:116 + Optional getOffsetEntry(DataExtractor Data, uint32_t Index) const { +if (Index > HeaderData.OffsetEntryCount) + return None; That is going to be ad

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 330181. jankratochvil edited the summary of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llv

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:116 Optional getOffsetEntry(DataExtractor Data, uint32_t Index) const { -if (Index > HeaderData.OffsetEntryCount) +if (Index >= HeaderData.OffsetEntryCount) retur

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 330185. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil updated this revision to Diff 330186. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289/new/ https://reviews.llvm.org/D98289 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

omjavaid updated this revision to Diff 330187. omjavaid added a comment. This update incorporates changes written by @labath CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458 Files: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_ar

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

omjavaid updated this revision to Diff 330189. omjavaid added a comment. Updated after changes in parent. Also removed D96459 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new/ https://reviews.llvm.org/D96460 Files: lldb/source/Plugins/Process

[Lldb-commits] [PATCH] D96463: [LLDB] Arm64/Linux test case for MTE and Pointer Authentication regset

omjavaid updated this revision to Diff 330190. omjavaid added a comment. Rebased. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96463/new/ https://reviews.llvm.org/D96463 Files: lldb/packages/Python/lldbsuite/test/lldbtest.py lldb/test/API/commands/register/register/aarch64_dynamic

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

jhenderson added inline comments. Comment at: llvm/utils/lit/lit/Test.py:217 +for line in time_file.readlines(): +time, path = line.split(' ', 1) +self.test_times[path.strip('\n')] = float(time) jhenderson w

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 330194. davezarzycki added a comment. I've made all of the requested changes to date. Two notes: 1. One cannot simply omit the first argument to `split()` if the second is provided. As I just learned, python will complain. I switched the first paramete

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

thopre added a comment. In D98179#2621706 , @davezarzycki wrote: > I've made all of the requested changes to date. Two notes: > > 1. One cannot simply omit the first argument to `split()` if the second is > provided. As I just learned, python will compla

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki updated this revision to Diff 330200. davezarzycki added a comment. I fixed the call to split as requested. Being unfamiliar with python, I didn't know that it supported keyword arguments / parameter labels. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny updated this revision to Diff 330225. mgorny edited the summary of this revision. mgorny added a comment. Updated to include `multiprocess` in `qSupported`, and proposed how to handle it server-side on the example of `H` packet. Basically, accept the correct PID of current process, reject

[Lldb-commits] [lldb] f3b07f9 - [lldb] Remove unused StackFrame::TrackGlobalVariable

Author: Dave Lee Date: 2021-03-12T08:51:25-08:00 New Revision: f3b07f9c5d97a53b7253f4ffa2133bf6d31e3aec URL: https://github.com/llvm/llvm-project/commit/f3b07f9c5d97a53b7253f4ffa2133bf6d31e3aec DIFF: https://github.com/llvm/llvm-project/commit/f3b07f9c5d97a53b7253f4ffa2133bf6d31e3aec.diff LOG:

[Lldb-commits] [PATCH] D98529: Strip pointer authentication codes from aarch64 pc.

justincohen created this revision. Herald added subscribers: omjavaid, danielkiss, kristof.beyls. justincohen requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98529 Files: l

[Lldb-commits] [PATCH] D96237: [lldb] DWZ 02/08: More support for .gnu_debugaltlink

jankratochvil updated this revision to Diff 330322. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96237/new/ https://reviews.llvm.org/D96237 Files: lldb/source/Plugins/SymbolFile/DWARF/DWARFContext.cpp lldb/source/Plugins/SymbolFile/DWARF/DWARFC

[Lldb-commits] [PATCH] D96238: [lldb] [nfc] DWZ 03/08: rename TypeUnitSupportFiles -> SharedUnitSupportFiles

jankratochvil updated this revision to Diff 330323. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96238/new/ https://reviews.llvm.org/D96238 Files: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp lldb/source/Plugins/SymbolFile/DWARF/Sym

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

labath added a comment. Some initial remarks: - the parsing function is clearly gdb-related, so it should go into StringExtractorGDBRemote.h, and not its base class - the universalness of the function makes its interface pretty complicated, and bloats the call sites. Its probably good for the l

[Lldb-commits] [PATCH] D96239: [lldb] DWZ 04/08: DIERef support

jankratochvil updated this revision to Diff 330324. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96239/new/ https://reviews.llvm.org/D96239 Files: lldb/source/Plugins/SymbolFile/DWARF/DIERef.cpp lldb/source/Plugins/SymbolFile/DWARF/DIERef.h l

[Lldb-commits] [PATCH] D96240: [lldb] DWZ 05/08: Main functionality

jankratochvil updated this revision to Diff 330325. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96240/new/ https://reviews.llvm.org/D96240 Files: lldb/include/lldb/Utility/ConstString.h lldb/include/lldb/Utility/FileSpec.h lldb/source/Plugin

[Lldb-commits] [PATCH] D96241: [lldb] DWZ 06/08: New testsuite category 'dwz'

jankratochvil updated this revision to Diff 330326. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96241/new/ https://reviews.llvm.org/D96241 Files: lldb/packages/Python/lldbsuite/test/builders/builder.py lldb/packages/Python/lldbsuite/test/dotes

[Lldb-commits] [PATCH] D96242: [lldb] DWZ 07/08: New testcases

jankratochvil updated this revision to Diff 330327. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96242/new/ https://reviews.llvm.org/D96242 Files: lldb/test/Shell/SymbolFile/DWARF/dump-debug-types.cpp lldb/unittests/SymbolFile/CMakeLists.txt

[Lldb-commits] [PATCH] D96243: [lldb] DWZ 08/08: Fix symlinked /usr/lib/debug/.build-id/**.debug files

jankratochvil updated this revision to Diff 330328. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96243/new/ https://reviews.llvm.org/D96243 Files: lldb/packages/Python/lldbsuite/test/decorators.py lldb/packages/Python/lldbsuite/test/linux/build

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen updated this revision to Diff 330331. justincohen added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98529/new/ https://reviews.llvm.org/D98529 Files: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/source/Pl

[Lldb-commits] [PATCH] D98289: [lldb] Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

dblaikie added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:116 Optional getOffsetEntry(DataExtractor Data, uint32_t Index) const { -if (Index > HeaderData.OffsetEntryCount) +if (Index >= HeaderData.OffsetEntryCount) return Non

[Lldb-commits] [PATCH] D86110: [WIP][DebugInfo] Lazily parse debug_loclist offsets

dblaikie added inline comments. Comment at: llvm/include/llvm/DebugInfo/DWARF/DWARFListTable.h:116 + Optional getOffsetEntry(DataExtractor Data, uint32_t Index) const { +if (Index > HeaderData.OffsetEntryCount) + return None; jankratochvil wrote: > That

[Lldb-commits] [lldb] 22e9753 - Don't load kexts/kernels without dSYMs present

Author: Jason Molenda Date: 2021-03-12T17:20:44-08:00 New Revision: 22e9753271b71e2c067aadd5b877eef8198cadd2 URL: https://github.com/llvm/llvm-project/commit/22e9753271b71e2c067aadd5b877eef8198cadd2 DIFF: https://github.com/llvm/llvm-project/commit/22e9753271b71e2c067aadd5b877eef8198cadd2.diff