[Lldb-commits] [PATCH] D98842: [lldb] Make the api, shell and unit tests independent lit test suites

JDevlieghere created this revision. JDevlieghere added reviewers: labath, teemperor, stella.stamenova, kastiglione. Herald added a subscriber: mgorny. JDevlieghere requested review of this revision. Make the api, shell and unit tests independent lit test suites. This allows us to specify

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny updated this revision to Diff 331417. mgorny added a comment. Added option setting to the Linux plugin. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

clayborg added a comment. If anyone wants to try this out, you can yaml2obj the yaml file and then do manual lookups. If you are on a mac, you can also debug any binary with inline function calls and stop anywhere and compare "bt" to the "image lookup --address $pc" to verify this works as

[Lldb-commits] [PATCH] D98761: Fix "image lookup --address" Summary results for inline functions.

clayborg updated this revision to Diff 331404. clayborg added a comment. Remove extra parameter call to SymbolContext::DumpStopContext() recrusive call that was left over from iterating on my patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98826: [lldb] DWZ 6/9: Workaround DWZ bug dropping DW_TAG_namespace::DW_AT_export_symbols

jankratochvil created this revision. jankratochvil added a reviewer: labath. jankratochvil added a project: LLDB. Herald added a subscriber: JDevlieghere. Herald added a reviewer: shafik. jankratochvil requested review of this revision. I have filed for dwz tool: Multifile drops

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:2026 +llvm::Error NativeProcessLinux::SetEnabledExtensions(uint32_t flags) { + return llvm::createStringError(llvm::inconvertibleErrorCode(), +

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. mgorny requested review of this revision. So far no real meat yet, just taking the API for a test drive. https://reviews.llvm.org/D98822 Files: lldb/include/lldb/Host/common/NativeProcessProtocol.h

[Lldb-commits] [lldb] a233d72 - [lldb/Docs] Update docs with new buildbot URLs

Author: Jan Kratochvil Date: 2021-03-17T20:09:03+01:00 New Revision: a233d72f0e1a5fdbc93bb9ccc4b57667b65272be URL: https://github.com/llvm/llvm-project/commit/a233d72f0e1a5fdbc93bb9ccc4b57667b65272be DIFF:

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

jasonmolenda added a comment. In D98529#2632424 , @justincohen wrote: > uint32_t addressing_bits; > size_t len = sizeof (uint32_t); > ret = sysctlbyname("machdep.virtual_address_size", _bits, , > NULL, 0); > > returns ret == -1 on an iOS 14.4

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added a comment. uint32_t addressing_bits; size_t len = sizeof (uint32_t); ret = sysctlbyname("machdep.virtual_address_size", _bits, , NULL, 0); returns ret == -1 on an iOS 14.4 device. I do see this work on an m1 mac. Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

pcc added a comment. In D98529#2631946 , @DavidSpickett wrote: > TCR_ELx begins at 1 (see `D13.2.123 TCR_EL1, Translation Control Register > (EL1)` in the armarm) and covers EL0 and 1. Looking at the pseudocode access > to this is undefined at EL0. > >

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

jasonmolenda added a comment. In D98529#2631860 , @justincohen wrote: > In the meantime, I'll look into adding something to the Crashpad minidump > format to store an `addrable bits` mask, although I'm not clear how to grab > this in userspace. Should

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

jasonmolenda added a comment. In D98529#2631876 , @amccarth wrote: > Before reading Jason's response, I was independently wondering whether it > makes sense to temporarily introduce a variable to let the user set the mask, > just until the workaround is

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

jasonmolenda added a comment. In D98529#2631946 , @DavidSpickett wrote: > TCR_ELx begins at 1 (see `D13.2.123 TCR_EL1, Translation Control Register > (EL1)` in the armarm) and covers EL0 and 1. Looking at the pseudocode access > to this is undefined at

[Lldb-commits] [lldb] 76c8a01 - [lldb] [test] Skip vCont tests on Windows

Author: Michał Górny Date: 2021-03-17T19:22:58+01:00 New Revision: 76c8a016a1b5003447c1f875d857660e74343942 URL: https://github.com/llvm/llvm-project/commit/76c8a016a1b5003447c1f875d857660e74343942 DIFF: https://github.com/llvm/llvm-project/commit/76c8a016a1b5003447c1f875d857660e74343942.diff

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

mgorny added a comment. In D98749#2632299 , @stella.stamenova wrote: > This broke the windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/4725 Just seen the mail, will commit a skip. I see that other similar tests are apparently skipped

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny updated this revision to Diff 331327. mgorny marked 2 inline comments as done. mgorny added a comment. - switched thread-id parsing to use `view.consumeInteger()` and replaced `m_index` manipulations with a single update at the very end - added additional test for parsing multiple

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/4725 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98749/new/

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

This revision was automatically updated to reflect the committed changes. Closed by commit rG9cf21da776b5: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 9cf21da - [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

Author: Michał Górny Date: 2021-03-17T17:30:28+01:00 New Revision: 9cf21da776b5e71da46826ba941147495285f106 URL: https://github.com/llvm/llvm-project/commit/9cf21da776b5e71da46826ba941147495285f106 DIFF: https://github.com/llvm/llvm-project/commit/9cf21da776b5e71da46826ba941147495285f106.diff

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny added a comment. In D98482#2631817 , @labath wrote: > In D98482#2626237 , @mgorny wrote: > >> Create a new `GDBRemoteError` class to pass gdb-remote `$E` codes through >> cleanly. > > The error codes we use

[Lldb-commits] [lldb] 96927ba - [lldb] Correct unsigned decimal argument check in memory write

Author: David Spickett Date: 2021-03-17T16:08:54Z New Revision: 96927bafa41397f3f053ad705a57f5d834e3fb03 URL: https://github.com/llvm/llvm-project/commit/96927bafa41397f3f053ad705a57f5d834e3fb03 DIFF: https://github.com/llvm/llvm-project/commit/96927bafa41397f3f053ad705a57f5d834e3fb03.diff

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

DavidSpickett added a comment. TCR_ELx begins at 1 (see `D13.2.123 TCR_EL1, Translation Control Register (EL1)` in the armarm) and covers EL0 and 1. Looking at the pseudocode access to this is undefined at EL0. So the OS would have to provide you some other way to read that, I know this is

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

amccarth added a comment. Minidumps should have the registers in the processor context. It seems LLDB knows about TCR_ELn for n > 0. Maybe TCR_EL0 is special? If it's not available in the minidump, we'll need a plan for how to deal with these regardless of when Jason's implementation lands.

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added a comment. In the meantime, I'll look into adding something to the Crashpad minidump format to store an `addrable bits` mask, although I'm not clear how to grab this in userspace. Should `sysctl machdep.virtual_address_size` work on iOS? Can I grab TCR_ELx.T0SZ directly?

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

labath added a comment. In D98482#2626237 , @mgorny wrote: > Create a new `GDBRemoteError` class to pass gdb-remote `$E` codes through > cleanly. The error codes we use right now are completely meaningless, so don't bother preserving them. I don't

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I remember seeing this that this (duplicated) code was not dwarf5 ready, but I did not want to change it without understanding when it actually gets used. It looks like you've found that.

[Lldb-commits] [PATCH] D91524: Make iteration over the DeclContext::lookup_result safe.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0cb7e7ca0c86: Make iteration over the DeclContext::lookup_result safe. (authored by v.g.vassilev). Herald added projects: clang, LLDB. Herald added

[Lldb-commits] [PATCH] D91524: Make iteration over the DeclContext::lookup_result safe.

v.g.vassilev added a comment. Herald added a subscriber: JDevlieghere. argh... I only now see the pre-merge suggestions -- almost all of them seem not super essential -- let me know if I should address them in a subsequent commit... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

yln added a comment. In D98179#2629578 , @davezarzycki wrote: > ... I think we should use slash as the canonical separator for the timing > data file. +1 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. Ah yes, of course. I've marked that test as unavailable on Window for now: 61ca706461c5e1edc18526c9ddc3250fe074ed94 In the long run, We'll need to figure out a way for people to commit

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. I've run out of time for today, but for the record, I think we should use slash as the canonical separator for the timing data file. The actual separator doesn't matter because these strings are never used as paths, just as keys into a dictionary. (Therefore any

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension [WIP]

mgorny updated this revision to Diff 331220. mgorny edited the summary of this revision. mgorny added a comment. I've just discovered that `LLDB_INVALID_*_ID` isn't -1/UINT_MAX as I thought, so I've had to introduce additional constants. That said, I'm not convinced about the current 0/-1 API.

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

DavidSpickett updated this revision to Diff 331209. DavidSpickett added a comment. - Use PRIx64 to properly print 64 bit addresses in invalid range error message. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D95602/new/

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG4b513b2458d9: [lldb] Correct typo in memory read error (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 4b513b2 - [lldb] Correct typo in memory read error

Author: David Spickett Date: 2021-03-17T10:38:31Z New Revision: 4b513b2458d93a77ce6c45013ffc3e6838f4645f URL: https://github.com/llvm/llvm-project/commit/4b513b2458d93a77ce6c45013ffc3e6838f4645f DIFF: https://github.com/llvm/llvm-project/commit/4b513b2458d93a77ce6c45013ffc3e6838f4645f.diff

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

teemperor added a comment. Thanks! (and thanks for the patch) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98770/new/ https://reviews.llvm.org/D98770 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

DavidSpickett added a comment. Thanks, I'll do that in future. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98770/new/ https://reviews.llvm.org/D98770 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM (You can just land these straightforward patches directly without waiting for review, the dev policy allows that) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D98770: [lldb] Correct typo in memory read error

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D98770 Files: lldb/source/Commands/CommandObjectMemory.cpp Index:

[Lldb-commits] [PATCH] D98749: [lldb] [test] Fix TestGdbRemote_vContThreads.py logic

mgorny updated this revision to Diff 331176. mgorny edited the summary of this revision. mgorny added a comment. Added a helper `send_and_check_signal` method to reduce code duplication. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98749/new/ https://reviews.llvm.org/D98749 Files: