[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg updated this revision to Diff 332523. clayborg added a comment. Don't store a debugger pointer in the lldb_private::Progress class, store a debugger ID as an optional value. Then use this value in the debugger report progress function to do the right thing. Repository: rG LLVM Githu

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:857 +error = m_opaque_sp->GetTargetList().CreateTarget( +*m_opaque_sp, filename, arch, eLoadDependentsYes, platform_sp, +target_sp); dblaikie wrote: > jingh

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

dblaikie added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:857 +error = m_opaque_sp->GetTargetList().CreateTarget( +*m_opaque_sp, filename, arch, eLoadDependentsYes, platform_sp, +target_sp); jingham wrote: > claybo

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98996/new/ https://reviews.llvm.org/D98996 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

aprantl updated this revision to Diff 332493. aprantl added a comment. Updated the patch to compute the classification on the fly and take composition operators into account. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98996/new/ https://reviews.llvm.org/D98996 Files: lldb/source/

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

jingham added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:857 +error = m_opaque_sp->GetTargetList().CreateTarget( +*m_opaque_sp, filename, arch, eLoadDependentsYes, platform_sp, +target_sp); clayborg wrote: > I subm

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg marked 4 inline comments as done. clayborg added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:857 +error = m_opaque_sp->GetTargetList().CreateTarget( +*m_opaque_sp, filename, arch, eLoadDependentsYes, platform_sp, +target_sp

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg updated this revision to Diff 332485. clayborg added a comment. Added the option for people to add a debugger to a lldb_private::Progress instance. This allows progress to be reported only to specific debuggers. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

aprantl added a comment. @dblaikie wrote: > (idle question: Is this code remotely related to any code in LLVM's > libDebugInfoDWARF? Does this patch take us closer to or further away from > unifying them? If it takes us further away, any chance of designing it in a > direction that points towa

[Lldb-commits] [PATCH] D99120: [lldb] Silence GCC warnings about format not being a string literal in LLDB_SCOPED_TIMER

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99120/new/ https://reviews.llvm.org/D99120 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

jingham added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:46 + static const char *GetBroadcasterClass(); + clayborg wrote: > @jingham: do we need this GetBroadcasterClass()? Or would this only be used > to listen to all debugger events as

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

mgorny added a comment. I'm certainly not planning to put any obstacles to full multiprocess debugging in the future, and I'm going to try to pave the way for it whenever possible. One thing I'm considering right now is adding some support for tracking additional `NativeProcess*` instances to L

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

jingham added a comment. This seems like the right way to go. I made a couple trivial comment comments. But also: the feature has the problem that when multiple debuggers are present, there's no way to tell what debugger actually triggered the work, and in that case all Debuggers will get the

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg added inline comments. Comment at: lldb/include/lldb/API/SBDebugger.h:46 + static const char *GetBroadcasterClass(); + @jingham: do we need this GetBroadcasterClass()? Or would this only be used to listen to all debugger events as new debuggers are c

[Lldb-commits] [PATCH] D99120: [lldb] Silence GCC warnings about format not being a string literal in LLDB_SCOPED_TIMER

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. Looks right to me Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99120/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D99120: [lldb] Silence GCC warnings about format not being a string literal in LLDB_SCOPED_TIMER

mstorsjo created this revision. mstorsjo added a reviewer: labath. mstorsjo requested review of this revision. Herald added a project: LLDB. Pass "%s" as the format string literal and LLVM_PRETTY_FUNCTION as argument to it. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D99120

[Lldb-commits] [lldb] eb26afb - Re-land "[lldb] Make the API, Shell and Unit tests independent lit test suites"

Author: Jonas Devlieghere Date: 2021-03-22T14:36:43-07:00 New Revision: eb26afbafe8b6fb115aac7f5e7ba80edc32138ab URL: https://github.com/llvm/llvm-project/commit/eb26afbafe8b6fb115aac7f5e7ba80edc32138ab DIFF: https://github.com/llvm/llvm-project/commit/eb26afbafe8b6fb115aac7f5e7ba80edc32138ab.d

[Lldb-commits] [lldb] 683590a - [lldb] config.test_exec_root is set by lit.cfg.py

Author: Jonas Devlieghere Date: 2021-03-22T14:36:43-07:00 New Revision: 683590a203004df0e395824be6f2408a952a424e URL: https://github.com/llvm/llvm-project/commit/683590a203004df0e395824be6f2408a952a424e DIFF: https://github.com/llvm/llvm-project/commit/683590a203004df0e395824be6f2408a952a424e.d

[Lldb-commits] [PATCH] D97739: Add a progress class that can track and report long running operations that happen in LLDB.

clayborg updated this revision to Diff 332383. clayborg added a comment. Removed all callback related code and now only use events. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97739/new/ https://reviews.llvm.org/D97739 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D98886: Strip pointer authentication codes from MacOSX arc pc.

justincohen updated this revision to Diff 332374. justincohen edited the summary of this revision. justincohen added a comment. Fix length of crashpad structure / use ulittleXX Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98886/new/ https://review

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

jingham added a comment. In D98822#2640881 , @labath wrote: > In D98822#2637871 , @jingham wrote: > >> The gdb model - since gdb only supports one debugee per gdb - is to either >> follow the fork or follow the par

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

nlopes added a comment. In D98179#2639565 , @davezarzycki wrote: > In D98179#2639554 , @nlopes wrote: > >> In D98179#2639491 , @davezarzycki >> wrote: >> >>> In D98179#2639

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2639554 , @nlopes wrote: > In D98179#2639491 , @davezarzycki > wrote: > >> In D98179#2639476 , @nlopes wrote: >> >>> Why are timeouts

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

nlopes added a comment. In D98179#2639491 , @davezarzycki wrote: > In D98179#2639476 , @nlopes wrote: > >> Why are timeouts important? Our use case is running Alive2 with the test >> suite. Alive2 is heavy machine

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2639476 , @nlopes wrote: > I'm talking about sorting just the summary of failed tests, not the whole > output. We need the whole -vv output, but that can be out of order. > > Why are timeouts important? Our use case

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

lebedev.ri added a comment. @nlopes are you talking about sorting *all* lit output, or the summary? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98179/new/ https://reviews.llvm.org/D98179 ___ lldb-commi

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2639483 , @lebedev.ri wrote: > In D98179#2639476 , @nlopes wrote: > >> I'm talking about sorting just the summary of failed tests, not the whole >> output. We need the whole

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

lebedev.ri added a comment. In D98179#2639476 , @nlopes wrote: > I'm talking about sorting just the summary of failed tests, not the whole > output. We need the whole -vv output, but that can be out of order. Aha! +1 then, i think sorting summary should

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2638837 , @nlopes wrote: > In D98179#2638801 , @mehdi_amini > wrote: > >>> Can we revert to the previous behavior please? The current behavior is not >>> user friendly. Than

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

nlopes added a comment. I'm talking about sorting just the summary of failed tests, not the whole output. We need the whole -vv output, but that can be out of order. Why are timeouts important? Our use case is running Alive2 with the test suite. Alive2 is heavy machinery and runs into timeouts.

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

davezarzycki added a comment. In D98179#2638882 , @mehdi_amini wrote: >> No, I'm running lit and dumping into a file. sorting is not as easy as >> piping through sort, as I'm running with -vv (required). > > Since tests run in parallel, don't you already

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

mehdi_amini added a comment. > Can we revert to the previous behavior please? The current behavior is not > user friendly. Thanks! To be clear: you car about the order in the final summary, not the actually execution order, right? How are you diffing? Copy-pasting the terminal output to a file

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

mehdi_amini added a comment. > No, I'm running lit and dumping into a file. sorting is not as easy as piping > through sort, as I'm running with -vv (required). Since tests run in parallel, don't you already have some non-determinism in the -vv output? Isn't it printing as test finish? (just cu

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

nlopes added a comment. This patch makes the order of the list of failing tests non-deterministic. This is extremely annoying because you can't do a simple diff between test dumps anymore. Before the list of failed tests used to be sorted. Can we revert to the previous behavior please? The curr

[Lldb-commits] [PATCH] D98179: [lit] Sort test start times based on prior test timing data

nlopes added a comment. In D98179#2638801 , @mehdi_amini wrote: >> Can we revert to the previous behavior please? The current behavior is not >> user friendly. Thanks! > > To clarify: you care about the order in the final summary, not the actual > execut

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:741 if (response.GetChar() == 'C') { - m_curr_pid = response.GetHexMaxU32(false, LLDB_INVALID_PROCESS_ID); + m_curr_pid = response.GetHexM

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

mgorny updated this revision to Diff 332324. mgorny added a comment. try uploading again CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h lldb/packages/Python/lldbsuite/test/tools/ll

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

mgorny updated this revision to Diff 332322. mgorny added a comment. Added client support for PIDs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98482/new/ https://reviews.llvm.org/D98482 Files: lldb/include/lldb/Utility/StringExtractorGDBRemote.h lldb/packages/Python/lldbsuite/te

[Lldb-commits] [PATCH] D98879: [lldb/PlatformPOSIX] Change LoadImage default to RTLD_LAZY

vsk added a comment. Sorry about that. The file was removed in 8248dd91d7f042893d4a605e98d19cb1b89a44d4 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98879/new/ https://reviews.llvm.org/D98879

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

JDevlieghere added inline comments. Comment at: lldb/source/Expression/DWARFExpression.cpp:992 +case DW_OP_regx: + dwarf4_location_description_kind = Register; + break; Could you return the kind and do `LocationDescriptionKind dwarf4_location_descr

[Lldb-commits] [lldb] d9643af - [lldb] Re-disable dwarf5-debug_line-file-index.s

Author: Pavel Labath Date: 2021-03-22T16:29:06+01:00 New Revision: d9643af11958db7c7079a04788d8342e365324be URL: https://github.com/llvm/llvm-project/commit/d9643af11958db7c7079a04788d8342e365324be DIFF: https://github.com/llvm/llvm-project/commit/d9643af11958db7c7079a04788d8342e365324be.diff

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

kimanh added a comment. I'm very sorry for the incorrect reduction, and thanks for fixing this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98619/new/ https://reviews.llvm.org/D98619 ___ lldb-commits m

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

labath added a comment. The backtrace was very helpful. Thanks. I think I've found the problem and I believe it should be fixed by 10d54e2f8d (though I couldn't actually check right now). The problem was (sort of) in the inc

[Lldb-commits] [lldb] 10d54e2 - [lldb] Attempt to fix dwarf5-debug_line-file-index.s

Author: Pavel Labath Date: 2021-03-22T15:27:25+01:00 New Revision: 10d54e2f8de11e65de8a3fe7e4673ede4d2c82c2 URL: https://github.com/llvm/llvm-project/commit/10d54e2f8de11e65de8a3fe7e4673ede4d2c82c2 DIFF: https://github.com/llvm/llvm-project/commit/10d54e2f8de11e65de8a3fe7e4673ede4d2c82c2.diff

[Lldb-commits] [lldb] 8248dd9 - [lldb] Fix test_exec_root of API tests

Author: Pavel Labath Date: 2021-03-22T15:15:48+01:00 New Revision: 8248dd91d7f042893d4a605e98d19cb1b89a44d4 URL: https://github.com/llvm/llvm-project/commit/8248dd91d7f042893d4a605e98d19cb1b89a44d4 DIFF: https://github.com/llvm/llvm-project/commit/8248dd91d7f042893d4a605e98d19cb1b89a44d4.diff

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

omjavaid added a comment. In D98619#2641136 , @labath wrote: > In D98619#2641104 , @omjavaid wrote: > >> In D98619#2640734 , @labath wrote: >> >>> `REQUIRES: x86` disables th

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

kimanh added a comment. It seems as if it's the same for windows (I don't have windows unfortunately to check): https://lab.llvm.org/buildbot/#/builders/83/builds/4884 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98619/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D96460: [LLDB] Arm64/Linux Add MTE and Pointer Authentication registers

labath requested changes to this revision. labath added a comment. This revision now requires changes to proceed. This still suffers from the duplication of the auxv reading code from NativeProcessELF. Other than that, it's ok-ish. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96460/new

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

labath added a comment. In D98619#2641104 , @omjavaid wrote: > In D98619#2640734 , @labath wrote: > >> `REQUIRES: x86` disables the test in those builds, which don't have the X86 >> target enabled (in the build con

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

labath added a comment. In D98482#2641041 , @mgorny wrote: > In D98482#2640981 , @labath wrote: > >> This should be fine, assuming the following statement is true: "all thread >> id's that we're passing from server

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

mgorny updated this revision to Diff 332255. mgorny edited the summary of this revision. mgorny added a comment. Move 0/-1 value checking down to StringExtractorGDBRemote. Reject 0 unconditionally, since we do not use it. TODO: client support CHANGES SINCE LAST ACTION https://reviews.llvm.or

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

omjavaid added a comment. In D98619#2640734 , @labath wrote: > `REQUIRES: x86` disables the test in those builds, which don't have the X86 > target enabled (in the build config). That is exactly what we want here -- > the test is not actually running thi

[Lldb-commits] [lldb] 89aab75 - [LLDB] XFAIL dwarf5-debug_line-file-index.s on arm-linux

Author: Muhammad Omair Javaid Date: 2021-03-22T17:06:53+05:00 New Revision: 89aab750b0650c0d4394642df26a63046ca0f29e URL: https://github.com/llvm/llvm-project/commit/89aab750b0650c0d4394642df26a63046ca0f29e DIFF: https://github.com/llvm/llvm-project/commit/89aab750b0650c0d4394642df26a63046ca0f2

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

mgorny added a comment. In D98482#2640981 , @labath wrote: > This should be fine, assuming the following statement is true: "all thread > id's that we're passing from server to client are in the form of some > lldb-specific extension to the gdb-remote pr

[Lldb-commits] [PATCH] D98482: [lldb] Support for multiprocess extension

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. This should be fine, assuming the following statement is true: "all thread id's that we're passing from server to client are in the form of some lldb-specific extension to the gdb-remote proto

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

kimanh added a comment. Thanks for having a look, and for the explanation! Please let me know if I can do anything to help debugging this! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98619/new/ https://reviews.llvm.org/D98619 __

[Lldb-commits] [PATCH] D98822: [lldb] follow-fork/vfork support [WIP]

labath added a comment. In D98822#2637871 , @jingham wrote: > The gdb model - since gdb only supports one debugee per gdb - is to either > follow the fork or follow the parent. It would be more in keeping with > lldb's model to make a new target for the

[Lldb-commits] [PATCH] D96458: [LLDB] Add support for Arm64/Linux dynamic register sets

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I very happy with how this has turned out. Thanks for your patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D96458/new/ https://reviews.llvm.org/D96458

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

labath added a subscriber: omjavaid. labath added a comment. `REQUIRES: x86` disables the test in those builds, which don't have the X86 target enabled (in the build config). That is exactly what we want here -- the test is not actually running this code, so it should succeed regardless of the

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

kimanh marked an inline comment as done. kimanh added a comment. Unfortunately the test seems to run and fail on the ARM. I thoughty adding REQUIRES: x85 would skip no x86 ones, but maybe I did something wrong. Comment at: lldb/test/Shell/SymbolFile/DWARF/dwarf5-debug_line-fil

[Lldb-commits] [PATCH] D98996: Teach DWARFExpression about DWARF 4+ Location Descriptions

labath added a comment. Are you sure that this logic is correct in presence of DW_OP(_bit)_piece? If I follow this right, then the final value type will be determined by the last operand. That sounds like it could be right for regular dwarf expressions, but I'm not sure about those with pieces.

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

labath added a comment. In D98619#2634472 , @kimanh wrote: > Thanks a lot for the review Pavel! I've updated the test. If it looks fine > like this, could you help me to commit this change? Done. Thanks for the patch. Comment at: lldb

[Lldb-commits] [PATCH] D98619: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG68dafe40a69f: [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF (authored by kimanh, committed by labath). Repository: rG LLVM Githu

[Lldb-commits] [lldb] 68dafe4 - [lldb] Use CompileUnit::ResolveSymbolContext in SymbolFileDWARF

Author: Kim-Anh Tran Date: 2021-03-22T08:44:16+01:00 New Revision: 68dafe40a69f799f69eeeb1f658da6e129c6d832 URL: https://github.com/llvm/llvm-project/commit/68dafe40a69f799f69eeeb1f658da6e129c6d832 DIFF: https://github.com/llvm/llvm-project/commit/68dafe40a69f799f69eeeb1f658da6e129c6d832.diff