[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

JDevlieghere updated this revision to Diff 333464. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address @aprantl's comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99315/new/ https://reviews.llvm.org/D99315 Files:

[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h:305 + /// named classes. + class GetClassInfo { + public: aprantl wrote: >

[Lldb-commits] [lldb] c315253 - [LLDB] Skip TestVSCode_launch.test_progress_events arm/linux

Author: Muhammad Omair Javaid Date: 2021-03-26T04:38:31+05:00 New Revision: c3152536fda152b0956a0865059be8517697c921 URL: https://github.com/llvm/llvm-project/commit/c3152536fda152b0956a0865059be8517697c921 DIFF:

[Lldb-commits] [PATCH] D99314: [lldb] Add IsSafeToCallAPI to DynamicLoader

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbb419151cc8: [lldb] Add IsFullyInitialized to DynamicLoader (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] bbb4191 - [lldb] Add IsFullyInitialized to DynamicLoader

Author: Jonas Devlieghere Date: 2021-03-25T15:44:37-07:00 New Revision: bbb419151cc8994b3447f184fe841e87e159e5a3 URL: https://github.com/llvm/llvm-project/commit/bbb419151cc8994b3447f184fe841e87e159e5a3 DIFF:

[Lldb-commits] [PATCH] D99314: [lldb] Add IsSafeToCallAPI to DynamicLoader

aprantl added inline comments. Comment at: lldb/include/lldb/Target/DynamicLoader.h:260 + /// safe to call certain APIs or SPIs. + virtual bool IsSafeToCallAPI() { return true; } + *Perhaps* IsFullyInitialized() ? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

aprantl added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.h:305 + /// named classes. + class GetClassInfo { + public: GetClassInfo is an odd name for a class. It sounds more like a function. I'm

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added a comment. > Clearing PAC bits is a little more complicated than just clearing the bits, > though. Bit 55 tells us whether the high bits are all 0's or all 1's (on > Darwin, in EL0 processes they're all 0's, in EL1, all 1's). If we had a > setting to provide a mask

[Lldb-commits] [PATCH] D98822: [lldb] [Process] Watch for fork/vfork notifications

mgorny updated this revision to Diff 333441. mgorny retitled this revision from "[lldb] [Process/Linux] Watch for fork/vfork notifications" to "[lldb] [Process] Watch for fork/vfork notifications". mgorny added a comment. Now includes initial FreeBSD support. The watchpoint test still fails, we

[Lldb-commits] [PATCH] D99314: [lldb] Add IsSafeToCallAPI to DynamicLoader

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp:1118 +bool DynamicLoaderMacOSXDYLD::IsSafeToCallAPI() { + if (ReadAllImageInfosStructure()) +return m_dyld_all_image_infos.libSystemInitialized;

[Lldb-commits] [PATCH] D99314: [lldb] Add IsSafeToCallAPI to DynamicLoader

aprantl accepted this revision. aprantl added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/DynamicLoader/MacOSX-DYLD/DynamicLoaderMacOSXDYLD.cpp:1118 +bool DynamicLoaderMacOSXDYLD::IsSafeToCallAPI() { + if

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

davezarzycki added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, mib wrote: >

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

jasonmolenda added a comment. In D98529#2651468 , @justincohen wrote: > > Were you able to confirm if sysctlbyname "machdep.virtual_address_size" works > on iOS? I'm currently hard coding this information in minidump creation, as > it's failing for

[Lldb-commits] [lldb] 414412d - [lldb/Commands] Fix spelling of target.move-to-nearest-code in helptext

Author: Vedant Kumar Date: 2021-03-25T14:25:10-07:00 New Revision: 414412d3dcbcf1fae0dc217085b63ab08ac41f37 URL: https://github.com/llvm/llvm-project/commit/414412d3dcbcf1fae0dc217085b63ab08ac41f37 DIFF: https://github.com/llvm/llvm-project/commit/414412d3dcbcf1fae0dc217085b63ab08ac41f37.diff

[Lldb-commits] [PATCH] D98529: [lldb] Strip pointer authentication codes from aarch64 pc.

justincohen added a comment. > OK we may need to retain the manual setting when I upstream this, instead of > going with the pure Process-maintained value determined dynamically by gdb > packet or corefile metadata. If this is something you need for your own > FixCodeAddress prelim patch, I

[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:199 + +ClassInfo *class_infos = (ClassInfo *)class_infos_ptr; + shafik wrote: > Is this pointer and `realized_class_list` always

[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

JDevlieghere updated this revision to Diff 94. JDevlieghere marked 4 inline comments as done. JDevlieghere added a comment. Address @shafik's code review comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99315/new/ https://reviews.llvm.org/D99315 Files:

[Lldb-commits] [PATCH] D98886: Strip pointer authentication codes from MacOSX arc pc.

markmentovai added inline comments. Comment at: lldb/source/Plugins/Process/minidump/MinidumpParser.cpp:241-242 + + const CrashpadInfo *crashpad_info = + reinterpret_cast(data.data()); + Check that crashpad_info->version is 1 before attempting to treat

[Lldb-commits] [PATCH] D99315: [lldb] Support lazily named classes in the Objective-C classes

shafik added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:199 + +ClassInfo *class_infos = (ClassInfo *)class_infos_ptr; + Is this pointer and `realized_class_list` always non-NULL?

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Raphael is right. The default values of the target.process.thread.step-avoid-regexp are set such that if lldb finds itself in a function inlined from std:: it will automatically

[Lldb-commits] [PATCH] D95713: [lldb/Plugins] Add ScriptedProcess Process Plugin

mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:69 + + StructuredData::ObjectSP object_sp = GetInterface().CreatePluginObject( + m_launch_info.GetClassName().c_str(), target_sp, stella.stamenova wrote: > This

[Lldb-commits] [lldb] c83cd8f - [NFC] Reordering parameters in getFile and getFileOrSTDIN

Author: Abhina Sreeskantharajan Date: 2021-03-25T09:47:49-04:00 New Revision: c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6 URL: https://github.com/llvm/llvm-project/commit/c83cd8feef7eb8319131d968bb8c94fdc8dbb6a6 DIFF:

[Lldb-commits] [PATCH] D81810: LLDB step-instruction gets stuck on jump to self

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Herald added subscribers: JDevlieghere, pengfei. (Marking as requested-changes to get this out of my review queue) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

teemperor edited reviewers, added: jingham; removed: LLVM. teemperor added a comment. Thanks for the patch! A few general notes: - You probably want to upload the diffs with more context (`git diff -U` or something like that) to get rid of the "Context not available" in the source changes

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

jhenderson accepted this revision. jhenderson added a comment. This revision is now accepted and ready to land. LGTM, with nit. Comment at: llvm/lib/Support/MemoryBuffer.cpp:275 + return getFileAux( + Filename, /*MapSize=*/-1, 0, /*IsText=*/false, +

[Lldb-commits] [PATCH] D99182: [NFC] Reordering parameters in getFile and getFileOrSTDIN

abhina.sreeskantharajan updated this revision to Diff 333266. abhina.sreeskantharajan added a comment. Rebase and fix formatting. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99182/new/ https://reviews.llvm.org/D99182 Files:

[Lldb-commits] [PATCH] D99331: [TESTS] Fix TestInlineStepping with ccac compiler

vasilyev created this revision. vasilyev added a reviewer: LLVM. vasilyev added projects: LLVM, LLDB test suite on simulator. vasilyev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The tests expect the debugger steps into the function,

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

mgorny updated this revision to Diff 333254. mgorny added a comment. Move saved breakpoint list directly into `NativeProcessProtocol`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98822/new/ https://reviews.llvm.org/D98822 Files:

[Lldb-commits] [lldb] d90b123 - [lldb] Fix TestVSCode.test_progress_events on Linux due to vdso

Author: Raphael Isemann Date: 2021-03-25T10:48:58+01:00 New Revision: d90b1230ea62eb9738ea369df38607551ea412e0 URL: https://github.com/llvm/llvm-project/commit/d90b1230ea62eb9738ea369df38607551ea412e0 DIFF:

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

mgorny added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:145 + // Remove all software breakpoints and return a vector of breakpoint data + // that can be used to readd them. mgorny wrote: > Long term, these functions

[Lldb-commits] [PATCH] D98822: [lldb] [Process/Linux] Watch for fork/vfork notifications

mgorny added inline comments. Comment at: lldb/include/lldb/Host/common/NativeProcessProtocol.h:145 + // Remove all software breakpoints and return a vector of breakpoint data + // that can be used to readd them. Long term, these functions are probably