Author: Raphael Isemann
Date: 2021-05-18T09:41:20+02:00
New Revision: bbea361039c11dc2e6e281c80fa8aa569f1c7c2d
URL:
https://github.com/llvm/llvm-project/commit/bbea361039c11dc2e6e281c80fa8aa569f1c7c2d
DIFF:
https://github.com/llvm/llvm-project/commit/bbea361039c11dc2e6e281c80fa8aa569f1c7c2d.dif
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGbbea361039c1: [lldb][NFC] Remove all uses of
StringRef::withNullAsEmpty in LLDB (authored by teemperor).
Herald added a subscriber: lldb-commits.
Ch
DavidSpickett added inline comments.
Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:126
+Address brk_address;
+if (!target.ResolveLoadAddress(fixed_bad_address, brk_address))
+ return false;
vsk wrote:
> DavidSpickett wrote
Author: Raphael Isemann
Date: 2021-05-18T10:49:11+02:00
New Revision: d017d12f126ee9045f58f9300078d805e3bcc763
URL:
https://github.com/llvm/llvm-project/commit/d017d12f126ee9045f58f9300078d805e3bcc763
DIFF:
https://github.com/llvm/llvm-project/commit/d017d12f126ee9045f58f9300078d805e3bcc763.dif
Author: James Henderson
Date: 2021-05-18T10:43:33+01:00
New Revision: a1e6565855784988aa6302d6672705baf2a84ff2
URL:
https://github.com/llvm/llvm-project/commit/a1e6565855784988aa6302d6672705baf2a84ff2
DIFF:
https://github.com/llvm/llvm-project/commit/a1e6565855784988aa6302d6672705baf2a84ff2.dif
werat created this revision.
werat added a reviewer: teemperor.
werat requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
`bool` is considered to be unsigned according to
`std::is_unsigned::value` (and `Type::GetTypeInfo`). Encoding it as
sig
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
Herald added a subscriber: JDevlieghere.
Nice, and it's not even my birthday. Just some nits that don't need another
round of review.
Comment at: lldb/test/API/lang/cp
werat updated this revision to Diff 346161.
werat added a comment.
Keep @skipIfWindows for now
Add mroe checks in tests
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102685/new/
https://reviews.llvm.org/D102685
Files:
lldb/source/Plugins/TypeSys
werat marked 2 inline comments as done.
werat added a comment.
Thanks for a quick review!
Comment at: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py:21
-# (http://llvm.org/pr21800)
-@skipIfWindows
def test_and_run_command(self):
teemperor wro
If you are doing further clean-up here, it almost looks like those two
reference members could actually be owned by IRForTarget i.e.
m_execution_unit
m_error_stream
Which would be cleaner.
> On May 18, 2021, at 1:49 AM, Raphael Isemann via lldb-commits
> wrote:
>
>
> Author: Raphael Is
wallace added inline comments.
Comment at: lldb/tools/lldb-vscode/ProgressEvent.h:32
+ ProgressEvent(uint64_t progress_id, llvm::StringRef message,
+llvm::Optional percentage);
clayborg wrote:
> Why is there an optional percentage for a start e
wallace updated this revision to Diff 346335.
wallace added a comment.
Simplified the constructors
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D101128/new/
https://reviews.llvm.org/D101128
Files:
lldb/tools/lldb-vscode/ProgressEvent.cpp
lldb/
12 matches
Mail list logo