[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

JDevlieghere added a comment. In D102811#2769686 , @teemperor wrote: > First and foremost: Cool new username. +1 from me. +2 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102811/new/ https://reviews.llvm.

Re: [Lldb-commits] [lldb] 4b074b4 - [lldb] Fix UB in half2float and add some more tests.

*sigh*I wish we had std::bit_cast instead of using union based type punning, we do have __builtin_bit_cast but it is different enough that replacing it later on w/ std::bit_cast wouldn’t just be search/replace. > On May 19, 2021, at 12:37 PM, Raphael Isemann via lldb-commits > wrote: > > > A

[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

teemperor added a comment. Herald added a subscriber: JDevlieghere. First and foremost: Cool new username. +1 from me. Otherwise I think Shafik's comment in D79752 still applies here. Could you make a short utility function for that chunk of code and put in Cla

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

bulbazord added a comment. In D79752#2769664 , @teemperor wrote: > Replaced by D102811 and Alex has > apparently a new account, so closing this. Yes, thank you for doing that. Forgot about this one. :) Repository: r

[Lldb-commits] [PATCH] D79752: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables

teemperor commandeered this revision. teemperor edited reviewers, added: xiaobai; removed: teemperor. teemperor added a comment. Replaced by D102811 and Alex has apparently a new account, so closing this. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D102811: [lldb] Move ClangModulesDeclVendor ownership to ClangPersistentVariables from Target

bulbazord created this revision. bulbazord added reviewers: teemperor, shafik, labath. Herald added subscribers: yaxunl, mgorny. bulbazord requested review of this revision. Herald added a project: LLDB. More decoupling of plugins and non-plugins. Target doesn't need to manage ClangModulesDeclVend

[Lldb-commits] [lldb] 30a5dda - Revert "[lldb] Fix UB in half2float and add some more tests."

Author: Raphael Isemann Date: 2021-05-19T22:06:53+02:00 New Revision: 30a5ddaef3e88912e10a6b1c8173b00819c722d3 URL: https://github.com/llvm/llvm-project/commit/30a5ddaef3e88912e10a6b1c8173b00819c722d3 DIFF: https://github.com/llvm/llvm-project/commit/30a5ddaef3e88912e10a6b1c8173b00819c722d3.dif

[Lldb-commits] [lldb] 4b074b4 - [lldb] Fix UB in half2float and add some more tests.

Author: Raphael Isemann Date: 2021-05-19T21:37:10+02:00 New Revision: 4b074b49be206306330076b9fa40632ef1960823 URL: https://github.com/llvm/llvm-project/commit/4b074b49be206306330076b9fa40632ef1960823 DIFF: https://github.com/llvm/llvm-project/commit/4b074b49be206306330076b9fa40632ef1960823.dif

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6c83d4a60b7d: [lldb] Enable TestCppBitfields on Windows (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] 6c83d4a - [lldb] Enable TestCppBitfields on Windows

Author: Andy Yankovsky Date: 2021-05-19T17:04:19+02:00 New Revision: 6c83d4a60b7d243f0674f4381ec72b7c8ec4f2be URL: https://github.com/llvm/llvm-project/commit/6c83d4a60b7d243f0674f4381ec72b7c8ec4f2be DIFF: https://github.com/llvm/llvm-project/commit/6c83d4a60b7d243f0674f4381ec72b7c8ec4f2be.diff

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

jankratochvil added a comment. In D98289#2764829 , @clayborg wrote: > No objections from me. Anyone else? So I have checked it in, thanks for checking it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D98289

[Lldb-commits] [lldb] 9dd861a - [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

Author: Jan Kratochvil Date: 2021-05-19T15:57:40+02:00 New Revision: 9dd861a4f53968c732531de5d4488ace20d6d075 URL: https://github.com/llvm/llvm-project/commit/9dd861a4f53968c732531de5d4488ace20d6d075 DIFF: https://github.com/llvm/llvm-project/commit/9dd861a4f53968c732531de5d4488ace20d6d075.diff

[Lldb-commits] [PATCH] D99653: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. jankratochvil marked an inline comment as done. Closed by commit rG9dd861a4f539: [nfc] [lldb] 1/2: Fix DW_AT_ranges DW_FORM_sec_offset not using… (authored by jankratoc

[Lldb-commits] [PATCH] D98289: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd1310817194a: [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not

[Lldb-commits] [lldb] d131081 - [lldb] 2/2: Fix DW_AT_ranges DW_FORM_sec_offset not using DW_AT_rnglists_base (used by GCC)

Author: Jan Kratochvil Date: 2021-05-19T15:57:40+02:00 New Revision: d1310817194aad488c86f4fb627c33090600a4a9 URL: https://github.com/llvm/llvm-project/commit/d1310817194aad488c86f4fb627c33090600a4a9 DIFF: https://github.com/llvm/llvm-project/commit/d1310817194aad488c86f4fb627c33090600a4a9.diff

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

werat added a comment. Accidentally included only two out of three lines in the commit :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102769/new/ https://reviews.llvm.org/D102769 ___ lldb-commits maili

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

werat updated this revision to Diff 346438. werat added a comment. remove the @skip Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102769/new/ https://reviews.llvm.org/D102769 Files: lldb/test/API/lang/cpp/bitfields/TestCppBitfields.py Index: l

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. Sorry, I meant you can just commit this without review :) (also you probably want to actually remove the skipIf) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D102769: [lldb] Enable TestCppBitfields on Windows

werat created this revision. werat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The tests works correctly on Windows, the linked bug has been resolved. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D102769 Files: l

[Lldb-commits] [PATCH] D102685: [lldb] Encode `bool` as unsigned int

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. werat marked an inline comment as done. Closed by commit rG0bab7b26f4d9: [lldb] Encode `bool` as unsigned int (authored by werat). Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] 0bab7b2 - [lldb] Encode `bool` as unsigned int

Author: Andy Yankovsky Date: 2021-05-19T15:32:17+02:00 New Revision: 0bab7b26f4d9dc4cb8f6c2877ad4a2c388c41c65 URL: https://github.com/llvm/llvm-project/commit/0bab7b26f4d9dc4cb8f6c2877ad4a2c388c41c65 DIFF: https://github.com/llvm/llvm-project/commit/0bab7b26f4d9dc4cb8f6c2877ad4a2c388c41c65.diff

[Lldb-commits] [lldb] ff95486 - [lldb][NFC] Remove sample test boilerplate from TestBreakOnCPP11Initializers

Author: Raphael Isemann Date: 2021-05-19T15:22:11+02:00 New Revision: ff954865137cdd11165340e2c9537cfd1b3f805d URL: https://github.com/llvm/llvm-project/commit/ff954865137cdd11165340e2c9537cfd1b3f805d DIFF: https://github.com/llvm/llvm-project/commit/ff954865137cdd11165340e2c9537cfd1b3f805d.dif

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added reviewers: omjavaid, labath, jasonmolenda, vsk. DavidSpickett added subscribers: vsk, jasonmolenda. DavidSpickett added a comment. One of the main reasons the MTE commands need to handle addresses is to lookup memory regions, this generalises the handling of that. I'm not sure

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett created this revision. Herald added a subscriber: kristof.beyls. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is based on https://reviews.llvm.org/D99944. On AArch64 we have various things using the non

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

DavidSpickett requested changes to this revision. DavidSpickett added a comment. This revision now requires changes to proceed. Realised that you've got an empty program file and no core file. I compiled main.c with: $ aarch64-unknown-linux-gnu-gcc -g -march=armv8.3-a -mbranch-protection=pac-