This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG8dd106028b15: [debugserver] Add platform cache support to
improve performance. (authored by kuperxu, committed by JDevlieghere).
Repository:
rG LL
Author: kuperxu
Date: 2021-05-20T19:10:46-07:00
New Revision: 8dd106028b1533f0de03a1ffb4ea0dce40b5a2ff
URL:
https://github.com/llvm/llvm-project/commit/8dd106028b1533f0de03a1ffb4ea0dce40b5a2ff
DIFF:
https://github.com/llvm/llvm-project/commit/8dd106028b1533f0de03a1ffb4ea0dce40b5a2ff.diff
LOG:
wallace added a comment.
Btw, lldb-server for a few months hasn't been supporting the functionalities
required by the old plugin, and as no one has complained, I imagine it's been
not actively used.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D10
kuperxu added a comment.
I don't have permission to commit, please land this code.
Thank you @JDevlieghere
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102833/new/
https://reviews.llvm.org/D102833
___
l
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102889/new/
https://reviews.llvm.org/D102889
___
drodriguez created this revision.
drodriguez added reviewers: JDevlieghere, labath, xiaobai.
Herald added a subscriber: mgorny.
drodriguez requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Other LLVM projects use the suffix `-depends` for the
wallace added a comment.
I'll contact them again. Last time I did they didn't reply. And btw, this
feature was broken for years and last year i revived this plugin, so I imagine
no one was using it. And in terms of features, the new implementation supports
the same features
Repository:
rG L
raj.khem updated this revision to Diff 346855.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102872/new/
https://reviews.llvm.org/D102872
Files:
lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp
Index: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux.cpp
==
clayborg added a comment.
I would be ok with this. Can you track down the original author and add them to
the review of this to be sure they aren't using it anymore, and if they need
tracing that they have everything they need with your new functionality?
Repository:
rG LLVM Github Monorepo
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
LGTM. Soon LLDB will be as nicely layered (and maybe as tasty) as some good
Schichttorte
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102
raj.khem created this revision.
raj.khem added a project: LLDB.
Herald added subscribers: JDevlieghere, atanasyan, arichardson, sdardis.
raj.khem requested review of this revision.
Herald added a subscriber: lldb-commits.
This helps fixing lldb-server build regression
> /mnt/b/yoe/master/build/tm
bulbazord updated this revision to Diff 346841.
bulbazord added a comment.
Add helper in ClangASTSource
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102811/new/
https://reviews.llvm.org/D102811
Files:
lldb/include/lldb/Target/Target.h
lldb/so
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6d19c84cd903: [lldb] Improve invalid DWARF DW_AT_ranges
error reporting (authored by jankratochvil).
Repository:
rG LLVM Github Monorepo
CHANGES
Author: Jan Kratochvil
Date: 2021-05-20T21:37:01+02:00
New Revision: 6d19c84cd90369de5cda37f9a7a721e1cd9d0cb8
URL:
https://github.com/llvm/llvm-project/commit/6d19c84cd90369de5cda37f9a7a721e1cd9d0cb8
DIFF:
https://github.com/llvm/llvm-project/commit/6d19c84cd90369de5cda37f9a7a721e1cd9d0cb8.diff
kastiglione added a comment.
@thakis thanks for pointing that out. I had tried `-Wall` using the clang
included with the latest version of Xcode, and that does not enable
`-Wmisleading-indentation`. I see from the compiler explorer that recent clang
versions do include misleading indentation di
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Yeah, looks pretty good!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102851/new/
https://reviews.llvm.org/D102851
___
jankratochvil updated this revision to Diff 346807.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102851/new/
https://reviews.llvm.org/D102851
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
lldb/source/Plugins/SymbolFile/DWA
jankratochvil requested review of this revision.
jankratochvil added a comment.
Is the message format OK now?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102851/new/
https://reviews.llvm.org/D102851
__
jankratochvil updated this revision to Diff 346801.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102851/new/
https://reviews.llvm.org/D102851
Files:
lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp
lldb/source/Plugins/SymbolFile/DWA
dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.
Looks good to me - at least includes more values from the file to point to the
problem. Though phrasing might be better (I guess some other code prints the
"DW_AT_ranges(0x0) attribute" pa
jasonmolenda accepted this revision.
jasonmolenda added a comment.
LGTM, thanks for doing this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102833/new/
https://reviews.llvm.org/D102833
___
lldb-commits
JDevlieghere added a comment.
Please let me know if you want me to land this for you.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102833/new/
https://reviews.llvm.org/D102833
___
lldb-commits mailing l
JDevlieghere accepted this revision.
JDevlieghere added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102833/new/
https://reviews.llvm.org/D102833
___
jankratochvil marked an inline comment as done.
jankratochvil added inline comments.
Comment at: lldb/test/Shell/SymbolFile/DWARF/DW_AT_range-DW_FORM_sec_offset.s:32
+# RNGLISTBASE-LABEL: image lookup -v -s lookup_rnglists
+# RNGLISTBASE: error: DW_AT_range-DW_FORM_sec_offset.s.t
jankratochvil created this revision.
jankratochvil added a reviewer: dblaikie.
jankratochvil added a project: LLDB.
Herald added a subscriber: JDevlieghere.
jankratochvil requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.
In D98289#inline-9391
Author: Raphael Isemann
Date: 2021-05-20T18:00:02+02:00
New Revision: 8ebaa195015dfd56f8413c43aa8f6d78ea7e6b30
URL:
https://github.com/llvm/llvm-project/commit/8ebaa195015dfd56f8413c43aa8f6d78ea7e6b30
DIFF:
https://github.com/llvm/llvm-project/commit/8ebaa195015dfd56f8413c43aa8f6d78ea7e6b30.dif
Author: Raphael Isemann
Date: 2021-05-20T17:07:23+02:00
New Revision: 48780527dd6820698f3537f5ebf76499030ee349
URL:
https://github.com/llvm/llvm-project/commit/48780527dd6820698f3537f5ebf76499030ee349
DIFF:
https://github.com/llvm/llvm-project/commit/48780527dd6820698f3537f5ebf76499030ee349.dif
kuperxu added a comment.
Currently the main time consuming performance is when loading the executable.
In the MachProcess::GetMachOInformationFromMemory function if the executable
has 100 load_command, then the function _dyld_process_info_create will be
executed 100 times
Repository:
rG LLV
kuperxu added a reviewer: aprantl.
kuperxu added a comment.
The main reason for the problem is that dyld has modified the
_dyld_process_info_create function implementation, which has increased the
function's time consumption significantly and caused a huge delay in attaching
the program.
Repo
kuperxu updated this revision to Diff 346671.
kuperxu added a comment.
[debugserver]Recalculate the platform cache each time the port is cleared.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D102833/new/
https://reviews.llvm.org/D102833
Files:
l
kuperxu created this revision.
kuperxu requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Repository:
rG LLVM Github Monorepo
https://reviews.llvm.org/D102833
Files:
lldb/tools/debugserver/source/MacOSX/MachProcess.h
lldb/tools/debugse
I think what you're looking for is llvm::bit_cast (in ADT/bit.h) :) But that
code was written before that, so that's why it's still using unions
> On 19 May 2021, at 23:27, Shafik Yaghmour wrote:
>
> *sigh*I wish we had std::bit_cast instead of using union based type punning,
> we do have __bu
32 matches
Mail list logo
