[Lldb-commits] [lldb] 8b656b8 - [lldb] Re-eanble and rewrite TestCPPStaticMembers

2021-05-25 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-25T11:52:28+02:00 New Revision: 8b656b88462f51396c8c4772e0012549f76f204f URL: https://github.com/llvm/llvm-project/commit/8b656b88462f51396c8c4772e0012549f76f204f DIFF: https://github.com/llvm/llvm-project/commit/8b656b88462f51396c8c4772e0012549f76f204f.dif

[Lldb-commits] [lldb] 3bf96b0 - [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

2021-05-25 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-25T12:08:50+02:00 New Revision: 3bf96b0329be554c67282b0d7d8da6a864b9e38f URL: https://github.com/llvm/llvm-project/commit/3bf96b0329be554c67282b0d7d8da6a864b9e38f DIFF: https://github.com/llvm/llvm-project/commit/3bf96b0329be554c67282b0d7d8da6a864b9e38f.dif

[Lldb-commits] [PATCH] D102993: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls

2021-05-25 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3bf96b0329be: [lldb] Disable minimal import mode for RecordDecls that back FieldDecls (authored by teemperor). Herald added a subscriber: lldb-commit

[Lldb-commits] [lldb] a3a9528 - [lldb] X-FAIL TestCPPStaticMembers on Windows

2021-05-25 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-25T13:10:19+02:00 New Revision: a3a95286a73fddc4027de930fac29728cd4259fc URL: https://github.com/llvm/llvm-project/commit/a3a95286a73fddc4027de930fac29728cd4259fc DIFF: https://github.com/llvm/llvm-project/commit/a3a95286a73fddc4027de930fac29728cd4259fc.dif

[Lldb-commits] [lldb] 1dee479 - [lldb][NFC] Remove misleading ModulePass base class for IRForTarget

2021-05-25 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-25T13:27:07+02:00 New Revision: 1dee479ff632ef841ca7b28485779d898dd15e84 URL: https://github.com/llvm/llvm-project/commit/1dee479ff632ef841ca7b28485779d898dd15e84 DIFF: https://github.com/llvm/llvm-project/commit/1dee479ff632ef841ca7b28485779d898dd15e84.dif

[Lldb-commits] [PATCH] D102677: [lldb][NFC] Remove misleading ModulePass base class for IRForTarget

2021-05-25 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1dee479ff632: [lldb][NFC] Remove misleading ModulePass base class for IRForTarget (authored by teemperor). Herald added a subscriber: lldb-commits.

[Lldb-commits] [PATCH] D102845: [lldb] Fix that LLDB doesn't print NaN's sign on Darwin

2021-05-25 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGae58cf5f45a9: [lldb] Fix that LLDB doesn't print NaN's sign on Darwin (authored by teemperor). Herald added a subscriber: lldb-commits. Changed prio

[Lldb-commits] [lldb] ae58cf5 - [lldb] Fix that LLDB doesn't print NaN's sign on Darwin

2021-05-25 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-05-25T13:33:28+02:00 New Revision: ae58cf5f45a9c159afbf86e93c0c257a22c4ee02 URL: https://github.com/llvm/llvm-project/commit/ae58cf5f45a9c159afbf86e93c0c257a22c4ee02 DIFF: https://github.com/llvm/llvm-project/commit/ae58cf5f45a9c159afbf86e93c0c257a22c4ee02.dif

Re: [Lldb-commits] [lldb] a3a9528 - [lldb] X-FAIL TestCPPStaticMembers on Windows

2021-05-25 Thread David Blaikie via lldb-commits
Might be worth a bug report and CC'ing some Windows-LLDB type folks on that for notice. On Tue, May 25, 2021 at 4:11 AM Raphael Isemann via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Raphael Isemann > Date: 2021-05-25T13:10:19+02:00 > New Revision: a3a95286a73fddc4027de930fac2

[Lldb-commits] [PATCH] D102428: [StopInfoMachException] Summarize arm64e BLRAx/LDRAx auth failures

2021-05-25 Thread Vedant Kumar via Phabricator via lldb-commits
vsk added a comment. Friendly ping. Comment at: lldb/source/Plugins/Process/Utility/StopInfoMachException.cpp:126 +Address brk_address; +if (!target.ResolveLoadAddress(fixed_bad_address, brk_address)) + return false; DavidSpickett wrote: > vsk wrot

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

2021-05-25 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor created this revision. teemperor added a reviewer: LLDB. teemperor added a project: LLDB. Herald added a subscriber: JDevlieghere. teemperor requested review of this revision. This function has a single-value caching based on function local static variables. This causes two problems:

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

2021-05-25 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added inline comments. Comment at: lldb/source/Core/Mangled.cpp:38 -static ConstString -get_demangled_name_without_arguments(ConstString mangled, - ConstString demangled) { - // This pair is - static std::pair - g_most_rece

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

2021-05-25 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision as: JDevlieghere. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103107/new/ https://reviews.llvm.org/D103107 ___ lldb-comm

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

2021-05-25 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik accepted this revision. shafik added a comment. was there a bug that inspired this? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103107/new/ https://reviews.llvm.org/D103107 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D103107: [lldb] Remove cache in get_demangled_name_without_arguments

2021-05-25 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor added a comment. In D103107#2780769 , @shafik wrote: > was there a bug that inspired this? Nope, the code just looked bogus when I scrolled over it while looking for something else. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D10310

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

2021-05-25 Thread Richard Howell via Phabricator via lldb-commits
rmaz created this revision. Herald added a subscriber: mgorny. rmaz requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add an option to skip generating a dSYM when installing the LLDB framework on Darwin. Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D103127: lldb: Don't check for CMAKE_SYSTEM_NAME==Android.

2021-05-25 Thread Peter Collingbourne via Phabricator via lldb-commits
pcc created this revision. pcc added reviewers: JDevlieghere, labath. Herald added subscribers: danielkiss, krytarowski, mgorny. pcc requested review of this revision. Herald added a project: LLDB. CMAKE_SYSTEM_NAME seems to be unreliable for detecting whether the target is Android. At least on my

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

2021-05-25 Thread Peter Collingbourne via Phabricator via lldb-commits
pcc added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:633 + + if (SendPacketAndWaitForResponse(packet.GetString(), response) != + PacketResult::Success || Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

2021-05-25 Thread Peter Collingbourne via Phabricator via lldb-commits
pcc added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeRegisterContextLinux_arm64.cpp:15 #include "lldb/Host/common/NativeProcessProtocol.h" #include "lldb/Utility/DataBufferHeap.h" Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [lldb] bbcb343 - [lldb] Avoid format string in LLDB_SCOPED_TIMER

2021-05-25 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-05-25T17:14:08-07:00 New Revision: bbcb3433d4e8f5fa385b14e74d4314bd5409022d URL: https://github.com/llvm/llvm-project/commit/bbcb3433d4e8f5fa385b14e74d4314bd5409022d DIFF: https://github.com/llvm/llvm-project/commit/bbcb3433d4e8f5fa385b14e74d4314bd5409022d.d

[Lldb-commits] [lldb] 564eb20 - Revert "[lldb] Avoid format string in LLDB_SCOPED_TIMER"

2021-05-25 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-05-25T17:22:51-07:00 New Revision: 564eb20e0deecd173a7b990dcfd0e57fb045c522 URL: https://github.com/llvm/llvm-project/commit/564eb20e0deecd173a7b990dcfd0e57fb045c522 DIFF: https://github.com/llvm/llvm-project/commit/564eb20e0deecd173a7b990dcfd0e57fb045c522.d

[Lldb-commits] [PATCH] D103124: [lldb] add LLDB_SKIP_DSYM option

2021-05-25 Thread Shoaib Meenai via Phabricator via lldb-commits
smeenai accepted this revision. smeenai added a subscriber: sgraenitz. smeenai added a comment. This revision is now accepted and ready to land. Swift's LLDB fork has a TODO for this :) CC @sgraenitz, who added that TODO. LGTM. Do you need this to be committed for you? Repository: rG LLVM Git

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

2021-05-25 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid updated this revision to Diff 347847. omjavaid added a comment. This add skipped linux-aarch64-pac.out file. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D99944/new/ https://reviews.llvm.org/D99944 Files: lldb/source/Plugins/ABI/AArch64/ABISysV_arm64.cpp lldb/source/Plugin

[Lldb-commits] [PATCH] D99944: [LLDB] AArch64 Linux and elf-core PAC stack unwinder support

2021-05-25 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid updated this revision to Diff 347848. omjavaid added a comment. Herald added a project: LLDB. Uploading linux-aarch64-pac.out using arc differential was not uploading binary file properly using arc to do the same. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https