[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:367 + /// We use 1 as a default stop id for post portem processes. + uint32_t m_stop_id = 1; clayborg wrote: > We really shouldn't have to set this manually. Probably best to start

[Lldb-commits] [PATCH] D104578: Clarify the "env" launch configuration setting.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104578/new/ https://reviews.llvm.org/D104578

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 353135. wallace marked 3 inline comments as done. wallace added a comment. per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104422/new/ https://reviews.llvm.org/D104422 Files:

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just a few nits! Comment at: lldb/include/lldb/Target/Trace.h:292-293 + /// \return + /// The stop ID of the live process being traced, or \b 1 if this

[Lldb-commits] [PATCH] D104578: Clarify the "env" launch configuration setting.

clayborg created this revision. clayborg added reviewers: labath, aprantl, JDevlieghere, wallace. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. A few users recently were trying to set environment values when using lldb-vscode

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg updated this revision to Diff 353120. clayborg added a comment. Fixed a case where the accessor was being used twice in the same function and fixed a typo in a comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace updated this revision to Diff 353117. wallace marked an inline comment as done. wallace added a comment. address comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104422/new/ https://reviews.llvm.org/D104422 Files:

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

wallace marked 2 inline comments as done. wallace added inline comments. Comment at: lldb/include/lldb/Target/Trace.h:292 + /// \return + /// The stop ID of the live process being traced, or \b 0 if this is a + /// post-mortem trace session. clayborg

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. In D104395#2828065 , @OmarEmaraDev wrote: > @clayborg I tried implementing scrolling mechanisms as suggested. My first > trial essentially defined a "visible area" rectangle which gets updated with > every time the selection

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. @clayborg I tried implementing scrolling mechanisms as suggested. My first trial essentially defined a "visible area" rectangle which gets updated with every time the selection changes, then when it comes to drawing, each field checks if it is completely contained

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 353087. OmarEmaraDev added a comment. - Add form pages. - Handle review. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104395/new/ https://reviews.llvm.org/D104395 Files:

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

clayborg added a comment. Yes, good to go! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Lets try the diamond character for the boolean stuff unless anyone has any objections. Maybe handle a few more keys for the boolean field as suggested in the comments. This will

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. Just one issue regarding the stop ID for post mortem. Once this is resolved, we will be good to go! Comment at: lldb/include/lldb/Target/Trace.h:292 + ///

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

asm added a comment. @teemperor @clayborg Is this good to go? :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104054/new/ https://reviews.llvm.org/D104054 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

dblaikie added a comment. In D104380#2826465 , @DavidSpickett wrote: > This change would have been part of https://reviews.llvm.org/D103701 if I had > realised that this was in fact how it worked. I separated it from the follow > ons because of that

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Sounds good, if this already passes all tests/etc (ie: there actually aren't any callers passing empty strings/non-failed errors/etc) Comment at:

[Lldb-commits] [lldb] f2c009d - [lldb-vscode] attempt to fix flakiness

Author: Walter Erquinigo Date: 2021-06-18T10:12:46-07:00 New Revision: f2c009dbcfd11fd1e8941513dcf49fffe43565a1 URL: https://github.com/llvm/llvm-project/commit/f2c009dbcfd11fd1e8941513dcf49fffe43565a1 DIFF:

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett created this revision. Herald added a subscriber: inglorion. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The intention is now that AppendError/SetError/AppendRawError only be called with some message to

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat updated this revision to Diff 352966. PatriosTheGreat added a comment. Thanks for the review feedback. Looks like moving frame recognizer call to StackFrameList::GetFramesUpTo also fixes infinity recursion issue. Regarding the zeroth frame issue: I'm actually using the

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett marked an inline comment as done. DavidSpickett added inline comments. Comment at: lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py:23 +def test_mte_regions(self): +if not self.isAArch64PAuth(): +

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

DavidSpickett updated this revision to Diff 352964. DavidSpickett added a comment. - Add missing include - Rename test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103626/new/ https://reviews.llvm.org/D103626 Files:

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. Do you think this needs a test with a core file as well? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 ___ lldb-commits

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 352959. DavidSpickett added a comment. - Move DoGetMemoryRegionInfo into protected section, GetMemoryRegionInfo is the public part. - Fix a comment typo. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 352954. DavidSpickett added a comment. Remove TODO. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 Files: lldb/include/lldb/Target/Process.h

[Lldb-commits] [PATCH] D104380: [lldb] Set return object failed status even if error string is empty

DavidSpickett added a comment. This change would have been part of https://reviews.llvm.org/D103701 if I had realised that this was in fact how it worked. I separated it from the follow ons because of that and to not bury 3 lines of change that apply to all callers of these functions, in 300