[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

nealsid added a comment. Thanks to both of you for this! I’m traveling for a few days but will be able to take a look towards the end of the week. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104437/new/ https://reviews.llvm.org/D104437

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg marked 3 inline comments as done. clayborg added inline comments. Comment at: lldb/source/Symbol/Symbol.cpp:573-582 +// Synthetic symbol names don't mean anything, but they do uniquely +// identify individual symbols so we give them a unique name. The name +/

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg updated this revision to Diff 353550. clayborg added a comment. Fix comments from review: - Add in-line C-style comment for parameter to symbol creation. - Fixed the entry point address to encode the offset correctly for the ELF e_entry address - Add header doc for the new Symtab functi

[Lldb-commits] [lldb] bff2b9a - Retry of [lldb-vscode] only report long running progress events

Author: Walter Erquinigo Date: 2021-06-21T20:33:09-07:00 New Revision: bff2b9adbc8de23aeaa654c5957624078ddf8fe9 URL: https://github.com/llvm/llvm-project/commit/bff2b9adbc8de23aeaa654c5957624078ddf8fe9 DIFF: https://github.com/llvm/llvm-project/commit/bff2b9adbc8de23aeaa654c5957624078ddf8fe9.di

[Lldb-commits] [lldb] f84615a - Revert "[lldb-vscode] only report long running progress events"

Author: Walter Erquinigo Date: 2021-06-21T19:42:34-07:00 New Revision: f84615a5a5cb05aacdb0e9e7ab13f3b95ce11ece URL: https://github.com/llvm/llvm-project/commit/f84615a5a5cb05aacdb0e9e7ab13f3b95ce11ece DIFF: https://github.com/llvm/llvm-project/commit/f84615a5a5cb05aacdb0e9e7ab13f3b95ce11ece.di

[Lldb-commits] [lldb] 2e11f4e - [lldb-vscode] Add simple DAP logs dump to investigate flakiness in tests

Author: Walter Erquinigo Date: 2021-06-21T19:35:05-07:00 New Revision: 2e11f4e06804e53cee95e63fdc9e5152f8444abb URL: https://github.com/llvm/llvm-project/commit/2e11f4e06804e53cee95e63fdc9e5152f8444abb DIFF: https://github.com/llvm/llvm-project/commit/2e11f4e06804e53cee95e63fdc9e5152f8444abb.di

[Lldb-commits] [lldb] 610d474 - [lldb-vscode] only report long running progress events

Author: Walter Erquinigo Date: 2021-06-21T19:35:05-07:00 New Revision: 610d474cfd82f11dc4702e2cf1b2485584d7c243 URL: https://github.com/llvm/llvm-project/commit/610d474cfd82f11dc4702e2cf1b2485584d7c243 DIFF: https://github.com/llvm/llvm-project/commit/610d474cfd82f11dc4702e2cf1b2485584d7c243.di

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

jingham added a comment. In D104488#2831818 , @clayborg wrote: > In D104488#2830992 , @jingham wrote: > >> Are the Symbol ID's for unnamed symbols the same each time you read in a >> symbol file? While the unnam

[Lldb-commits] [PATCH] D104578: Clarify the "env" launch configuration setting.

This revision was automatically updated to reflect the committed changes. Closed by commit rG4181bfe6888f: Clarify the "env" launch configuration setting. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104578/new/ https://revi

[Lldb-commits] [lldb] 4181bfe - Clarify the "env" launch configuration setting.

Author: Greg Clayton Date: 2021-06-21T16:11:16-07:00 New Revision: 4181bfe6888fdc6f24dc42d4ebb295920826de2b URL: https://github.com/llvm/llvm-project/commit/4181bfe6888fdc6f24dc42d4ebb295920826de2b DIFF: https://github.com/llvm/llvm-project/commit/4181bfe6888fdc6f24dc42d4ebb295920826de2b.diff

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

shafik added inline comments. Comment at: lldb/source/API/SBDebugger.cpp:392 + + if (result.Fail()) { +return result; What case is this catching? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ http

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

bulbazord updated this revision to Diff 353484. bulbazord added a comment. Addressed comments! :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104067/new/ https://reviews.llvm.org/D104067 Files: lldb/include/lldb/Target/Language.h lldb/source

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young added inline comments. Comment at: lldb/docs/conf.py:32-33 # set by CMake. -sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE")) +if os.getenv("LLDB_SWIG_MODULE") is not None: +sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE")) JDev

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

JDevlieghere added a comment. I'm a little suspicious about the changes to `conf.py`. Can you explain why they're necessary and what they're fixing? Comment at: lldb/docs/conf.py:32-33 # set by CMake. -sys.path.insert(0, os.getenv("LLDB_SWIG_MODULE")) +if os.geten

[Lldb-commits] [PATCH] D104281: [lldb][docs] Add reference docs for Lua scripting

siger-young updated this revision to Diff 353434. siger-young added a comment. Reference page for Python and Lua is ready. A new sphinx extension "sphinx-tabs" is added to enable users switching the language. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. In D101128#2831098 , @wallace wrote: > I'm reverting it asap Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101128/new/ https://reviews.llvm.org/D101128 _

[Lldb-commits] [lldb] 28d9fd0 - Revert "[lldb-vscode] attempt to fix flakiness"

Author: Walter Erquinigo Date: 2021-06-21T10:53:49-07:00 New Revision: 28d9fd00d4b5711fb029e3e642e2d81eaf9fd510 URL: https://github.com/llvm/llvm-project/commit/28d9fd00d4b5711fb029e3e642e2d81eaf9fd510 DIFF: https://github.com/llvm/llvm-project/commit/28d9fd00d4b5711fb029e3e642e2d81eaf9fd510.di

Re: [Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

I'm reverting it asap Il giorno lun 21 giu 2021 alle ore 10:48 Stella Stamenova via Phabricator < revi...@reviews.llvm.org> ha scritto: > stella.stamenova added a comment. > > @wallace : Your most recent change to comment out > ProgressEventThreadFunction is causing warnings to be generated when

[Lldb-commits] [PATCH] D101128: [lldb-vscode] only report long running progress events

stella.stamenova added a comment. @wallace : Your most recent change to comment out ProgressEventThreadFunction is causing warnings to be generated when building with clang. Please have a look: /usr/bin/clang++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -

[Lldb-commits] [PATCH] D104627: [lldb] Add support for escaping zsh arguments

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc197cddb16b3: [lldb] Add support for escaping zsh arguments (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM

[Lldb-commits] [lldb] c197cdd - [lldb] Add support for escaping zsh arguments

Author: Raphael Isemann Date: 2021-06-21T19:46:55+02:00 New Revision: c197cddb16b3ed0de98f80566f8fc47f78aee64c URL: https://github.com/llvm/llvm-project/commit/c197cddb16b3ed0de98f80566f8fc47f78aee64c DIFF: https://github.com/llvm/llvm-project/commit/c197cddb16b3ed0de98f80566f8fc47f78aee64c.dif

[Lldb-commits] [lldb] 1265f05 - [lldb] Skip TestLimitDebugInfo for Clang<7

Author: Raphael Isemann Date: 2021-06-21T19:46:29+02:00 New Revision: 1265f05c268f09c74a2ecaa3e2b3cea83ec10627 URL: https://github.com/llvm/llvm-project/commit/1265f05c268f09c74a2ecaa3e2b3cea83ec10627 DIFF: https://github.com/llvm/llvm-project/commit/1265f05c268f09c74a2ecaa3e2b3cea83ec10627.dif

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

jingham added a comment. Are the Symbol ID's for unnamed symbols the same each time you read in a symbol file? While the unnamed_symbol symbol names are not significant, it would be good if you were crashing in __lldb_unnamed_symbol111 on one lldb run, you would also crash in the same named sy

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

teemperor added a comment. In D104437#2825559 , @nealsid wrote: > Ah, my grep/find skills clearly failed me :) > > Yeah, those tests are exactly the same scenarios. However, if I understand > correctly, don't they use the API? I wanted to add some cover

[Lldb-commits] [PATCH] D104437: Add test for functions with extended characters.

jingham added a comment. It's quite common to use the lldbtest.TestBase.runCmd or lldbtest.TestBase.expect to test command line commands in the API tests. The latter has expect-like results checking which makes writing these checks easy. Even if you are testing a command-line command, drivin

[Lldb-commits] [PATCH] D104054: [lldb] Enable Rust v0 symbol demangling

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG0a2d4f3f24a3: [lldb] Enable Rust v0 symbol demangling (authored by Alexander Mols , committed by teemperor). Repository: rG LLVM Gith

[Lldb-commits] [lldb] 0a2d4f3 - [lldb] Enable Rust v0 symbol demangling

Author: Alexander Mols Date: 2021-06-21T18:20:15+02:00 New Revision: 0a2d4f3f24a377dc7d3cbed16d30603dc27554a8 URL: https://github.com/llvm/llvm-project/commit/0a2d4f3f24a377dc7d3cbed16d30603dc27554a8 DIFF: https://github.com/llvm/llvm-project/commit/0a2d4f3f24a377dc7d3cbed16d30603dc27554a8.diff

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. In D97281#2824678 , @DavidSpickett wrote: > @omjavaid As it stands, RemoveNonAddressBits here removes the top byte > unconditionally. > > You aske

[Lldb-commits] [PATCH] D104221: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

This revision was automatically updated to reflect the committed changes. Closed by commit rG7f20e6ae3229: [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses (authored by teemperor). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [lldb] 7f20e6a - [lldb][NFC] Remove redundant deleted constructors in HostInfoBase subclasses

Author: Raphael Isemann Date: 2021-06-21T13:33:40+02:00 New Revision: 7f20e6ae3229664f866149a4e0739a426b6fa463 URL: https://github.com/llvm/llvm-project/commit/7f20e6ae3229664f866149a4e0739a426b6fa463 DIFF: https://github.com/llvm/llvm-project/commit/7f20e6ae3229664f866149a4e0739a426b6fa463.dif

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In D104067#2825199 , @bulbazord wrote: > ping! Sorry, feel free to me directly sooner :) I ran some benchmarks and this changed the

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Could you move this function into the `Debugger` class and just make `SBDebugger` forward to that function? We usually keep the `SB*` classes as thin wrappers that only contain

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

teemperor added a comment. In D104525#2830025 , @DavidSpickett wrote: > Yeah good point, I can do that. I'm gonna go over the remaining SetStatus > calls first, then I'll look at it. Thank you, really appreciated! Repository: rG LLVM Github Monorep

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett added a comment. Yeah good point, I can do that. I'm gonna go over the remaining SetStatus calls first, then I'll look at it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104525/new/ https://reviews.llvm.org/D104525 ___

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

teemperor added a comment. LGTM, thanks for cleaning this up. If we're anyway signing up @DavidSpickett for refactoring duty: `CommandReturnObject::SetError(llvm::StringRef error_str)` is clearly the same method as `CommandReturnObject::AppendError`, so one of those probably should go the way

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12ae3cb7ba53: [lldb] Assert that CommandResultObject error messages are not empty (authored by DavidSpickett). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 12ae3cb - [lldb] Assert that CommandResultObject error messages are not empty

Author: David Spickett Date: 2021-06-21T09:44:47Z New Revision: 12ae3cb7ba5399b99c02e8a73c681192259e188f URL: https://github.com/llvm/llvm-project/commit/12ae3cb7ba5399b99c02e8a73c681192259e188f DIFF: https://github.com/llvm/llvm-project/commit/12ae3cb7ba5399b99c02e8a73c681192259e188f.diff LOG

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett updated this revision to Diff 353310. DavidSpickett added a comment. Use !empty instead of size. All tests passing on X86 and AArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104525/new/ https://reviews.llvm.org/D104525 Files: