[Lldb-commits] [lldb] f0d0612 - [NFC][trace] remove dead function

Author: Walter Erquinigo Date: 2021-06-23T23:18:53-07:00 New Revision: f0d06124769f477a26f8fa2589f0ace85419c120 URL: https://github.com/llvm/llvm-project/commit/f0d06124769f477a26f8fa2589f0ace85419c120 DIFF: https://github.com/llvm/llvm-project/commit/f0d06124769f477a26f8fa2589f0ace85419c120.di

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG2aa1dd1c66dc: [trace] Add a TraceCursor class (authored by Walter Erquinigo ). Changed prior to commit: https://reviews.llvm.org/D

[Lldb-commits] [lldb] 2aa1dd1 - [trace] Add a TraceCursor class

Author: Walter Erquinigo Date: 2021-06-23T22:28:01-07:00 New Revision: 2aa1dd1c66dc3b1f6253eec9fc68c081a945b74d URL: https://github.com/llvm/llvm-project/commit/2aa1dd1c66dc3b1f6253eec9fc68c081a945b74d DIFF: https://github.com/llvm/llvm-project/commit/2aa1dd1c66dc3b1f6253eec9fc68c081a945b74d.di

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

wallace added a comment. good to go Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg added a comment. Sounds good, can someone accept the patch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

jingham added a comment. I'm fine with the change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Just need to initialize the m_stop_id in the cursor to the invalid value and this is good to go. Comment at: lldb/include/lldb/Target/TraceCursor.h:132 + /// The stop I

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg added a comment. Anyone have any objections now? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104488/new/ https://reviews.llvm.org/D104488 ___ lldb-commits mailing list lldb-commits@lists.llvm.

[Lldb-commits] [PATCH] D104067: [lldb] Decouple ObjCLanguage from Symtab

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5bebc0b177d0: [lldb] Decouple ObjCLanguage from Symtab (authored by bulbazord). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] 5bebc0b - [lldb] Decouple ObjCLanguage from Symtab

Author: Alex Langford Date: 2021-06-23T13:49:46-07:00 New Revision: 5bebc0b177d0f02af3d8d2b02d182c04763ee468 URL: https://github.com/llvm/llvm-project/commit/5bebc0b177d0f02af3d8d2b02d182c04763ee468 DIFF: https://github.com/llvm/llvm-project/commit/5bebc0b177d0f02af3d8d2b02d182c04763ee468.diff

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

clayborg added a comment. In D104395#2836661 , @OmarEmaraDev wrote: > Since we are still working on this diff. I will add the other form > functionality I have been working on here as well if you don't mind. Sure thing! Comment at:

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev added a comment. Since we are still working on this diff. I will add the other form functionality I have been working on here as well if you don't mind. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1396-1405 + // ___

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGfe63db25bcc0: [lldb] Remove asserts in CommandReturnObject SetError and AppendError (authored by DavidSpickett). Repository: rG LLVM Github Monore

[Lldb-commits] [lldb] fe63db2 - [lldb] Remove asserts in CommandReturnObject SetError and AppendError

Author: David Spickett Date: 2021-06-23T13:11:14Z New Revision: fe63db25bcc0dd31fc471f60591a0f24ee8dbf57 URL: https://github.com/llvm/llvm-project/commit/fe63db25bcc0dd31fc471f60591a0f24ee8dbf57 DIFF: https://github.com/llvm/llvm-project/commit/fe63db25bcc0dd31fc471f60591a0f24ee8dbf57.diff LOG

[Lldb-commits] [lldb] 8a5165b - [lldb][NFC] Remove some redundant semicolons on HostInfoMacOSX

Author: Raphael Isemann Date: 2021-06-23T15:06:12+02:00 New Revision: 8a5165b3b9f20017ad28e28d7bc519f1855f0bfa URL: https://github.com/llvm/llvm-project/commit/8a5165b3b9f20017ad28e28d7bc519f1855f0bfa DIFF: https://github.com/llvm/llvm-project/commit/8a5165b3b9f20017ad28e28d7bc519f1855f0bfa.dif

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

teemperor added a comment. In D104778#2835701 , @DavidSpickett wrote: >> LGTM, I'll add them in my patch. Thanks for the quick turnaround! > > To clarify, is there still a regression with the API? No regression anymore from what I can see. My point was

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

DavidSpickett added a comment. > LGTM, I'll add them in my patch. Thanks for the quick turnaround! To clarify, is there still a regression with the API? - This removes the asserts so you won't crash - No functions are changed in `lldb/include/lldb/API/SBCommandReturnObject.h` The one thing that

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

DavidSpickett added a comment. As noted, the assert in AppendRawError remains. It has two internal callers and no API definition. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104778/new/ https://reviews.llvm.org/D104778 _

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, I'll add them in my patch. Thanks for the quick turnaround! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104778/new/ https://review

[Lldb-commits] [PATCH] D104778: [lldb] Remove asserts in CommandReturnObject SetError and AppendError

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. I added asserts to these in https://reviews.llvm.org/D104525. They are available (directly or otherwise) via the API so we should not assert.

[Lldb-commits] [lldb] 1b1c8e4 - [lldb] Remove CommandReturnObject's SetError(StringRef)

Author: David Spickett Date: 2021-06-23T11:25:10Z New Revision: 1b1c8e4a984c07a3c985408d3d80c8e24e60d3d1 URL: https://github.com/llvm/llvm-project/commit/1b1c8e4a984c07a3c985408d3d80c8e24e60d3d1 DIFF: https://github.com/llvm/llvm-project/commit/1b1c8e4a984c07a3c985408d3d80c8e24e60d3d1.diff LOG

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1b1c8e4a984c: [lldb] Remove CommandReturnObject's SetError(StringRef) (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SI

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104768/new/ https://reviews.llvm.org/D104768

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett updated this revision to Diff 353919. DavidSpickett added a comment. Don't change the API, just have SetError call underlying AppendError. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104768/new/ https://reviews.llvm.org/D104768 Fil

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett added a comment. I was going to say we only would need to remove the assert for this one: void CommandReturnObject::SetError(const Status &error, const char *fallback_error_cstr) { Since SetError checks that the char * is not null in the API l

[Lldb-commits] [PATCH] D104525: [lldb] Assert that CommandResultObject error messages are not empty

DavidSpickett added a comment. I was going to say we only would need to remove the assert for this one: void CommandReturnObject::SetError(const Status &error, const char *fallback_error_cstr) { Since SetError checks that the `char *` is not null in the API

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. We should never assert unless we have to within SB API calls as that takes down the whole debugging session and all this is directly available to users via the script interpret

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett added a comment. Herald added a subscriber: JDevlieghere. I'm not totally sure about adding AppendError to the API. Should we (and where should I) document that AppendError expects a non empty message? On the other hand if you're using a release build the assert to check that isn'

[Lldb-commits] [PATCH] D104768: [lldb] Remove CommandReturnObject's SetError(StringRef)

DavidSpickett created this revision. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Replacing existing uses with AppendError. SetError is also part of the SBI API. Instead of removing it outright, deprecate it and have it ca

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat updated this revision to Diff 353875. PatriosTheGreat added a comment. Hi everyone. Thanks for review. In order to move new method code to Debugger class I also had to move there SetInputFile(lldb::FileSP file) method. After I did that -- the reproducer tests started to fail. If