[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

clayborg added a comment. Should we leave the old one there in case this extension is loaded in an older IDE? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104882/new/ https://reviews.llvm.org/D104882

[Lldb-commits] [PATCH] D104893: Add data formatter support for a missing NSDictionary variant

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104893/new/ https://reviews.llvm.org/D104893

[Lldb-commits] [PATCH] D104893: Add data formatter support for a missing NSDictionary variant

jingham updated this revision to Diff 354418. jingham added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104893/new/ https://reviews.llvm.org/D104893

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

clayborg added a comment. In D104422#2839895 , @vsk wrote: > FTR, I'm quite happy with the new direction. Thanks! Thanks for your input. It helped us come up with something we thought made sense given all the input! Repository: rG LLVM Github

[Lldb-commits] [PATCH] D104422: [trace] Add a TraceCursor class

vsk added a comment. FTR, I'm quite happy with the new direction. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104422/new/ https://reviews.llvm.org/D104422 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

chrisbond updated this revision to Diff 354392. chrisbond added a comment. Herald added a subscriber: JDevlieghere. minimize diff content CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104882/new/ https://reviews.llvm.org/D104882 Files: lldb/tools/lldb-vscode/package.json Index:

[Lldb-commits] [PATCH] D104882: makes extension contribute breakpoints using new package.json schema:https://code.visualstudio.com/updates/v1_42#_implement-a-debug-adapter-inside-an-extension

chrisbond created this revision. chrisbond requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D104882 Files: lldb/tools/lldb-vscode/package.json Index:

[Lldb-commits] [lldb] 975af86 - Disable TestAArch64UnwindPAC.py for non PAC targets

Author: Muhammad Omair Javaid Date: 2021-06-24T22:50:36Z New Revision: 975af861f38fe2f11f98aeb990e9b6ee9dfee9ea URL: https://github.com/llvm/llvm-project/commit/975af861f38fe2f11f98aeb990e9b6ee9dfee9ea DIFF:

[Lldb-commits] [lldb] 473a3a7 - Disable check_qmemtags unit tests

Author: Muhammad Omair Javaid Date: 2021-06-24T22:36:31Z New Revision: 473a3a773ea565612e836ae6c2093178c5a9eb72 URL: https://github.com/llvm/llvm-project/commit/473a3a773ea565612e836ae6c2093178c5a9eb72 DIFF:

[Lldb-commits] [lldb] 3b4aad1 - Fix typo in TestMemoryTag.py

Author: Muhammad Omair Javaid Date: 2021-06-24T22:19:51Z New Revision: 3b4aad1186e8e8e6f6c7887cb5e8d9bfd7d3ce2f URL: https://github.com/llvm/llvm-project/commit/3b4aad1186e8e8e6f6c7887cb5e8d9bfd7d3ce2f DIFF:

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev planned changes to this revision. OmarEmaraDev added a comment. Not available in this patch yet: - Global error messages. - Contextual scrolling. - Action bar. - Auto completion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] f1e2d58 - [OptTable] Rename PrintHelp to printHelp

Author: Fangrui Song Date: 2021-06-24T14:47:03-07:00 New Revision: f1e2d5851bf869685971d5acb894b39a89ea2d49 URL: https://github.com/llvm/llvm-project/commit/f1e2d5851bf869685971d5acb894b39a89ea2d49 DIFF: https://github.com/llvm/llvm-project/commit/f1e2d5851bf869685971d5acb894b39a89ea2d49.diff

[Lldb-commits] [PATCH] D104395: [LLDB][GUI] Add initial forms support

OmarEmaraDev updated this revision to Diff 354364. OmarEmaraDev added a comment. - Add Surface type. - Add Pad and SubPad types. - Implement dynamic scrolling. - Implement per-field validation and error messages. - Implement File field. - Implement Directory field. - Implement List field. -

[Lldb-commits] [lldb] 9ca0171 - [LLDB] Fix broken LLDB build due MemoryTagManager.h

Author: Muhammad Omair Javaid Date: 2021-06-25T02:37:55+05:00 New Revision: 9ca0171a9ffdef5fdb1511d197a3fd72490362de URL: https://github.com/llvm/llvm-project/commit/9ca0171a9ffdef5fdb1511d197a3fd72490362de DIFF:

[Lldb-commits] [lldb] e50f9c4 - [lldb] Rename StringRef _lower() method calls to _insensitive()

Author: Martin Storsjö Date: 2021-06-25T00:22:01+03:00 New Revision: e50f9c419a84d1e58c38aa660c445395ad8056e6 URL: https://github.com/llvm/llvm-project/commit/e50f9c419a84d1e58c38aa660c445395ad8056e6 DIFF:

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

fhahn added a comment. In D95602#2839421 , @teemperor wrote: > In D95602#2839419 , @fhahn wrote: > >> > > I think that's the correct public CI that shows the failure: >

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

teemperor added a comment. In D95602#2839419 , @fhahn wrote: > It looks like this is breaking building LLDB on Green Dragon: > https://smooshbase.apple.com/ci/job/am_github_build_tester/63476/console > > please take a look and consider reverting if it

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

fhahn added a comment. It looks like this is breaking building LLDB on Green Dragon: https://smooshbase.apple.com/ci/job/am_github_build_tester/63476/console please take a look and consider reverting if it takes longer to fix the issue Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2839256 , @jankratochvil wrote: > On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built: > -rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver > It uses

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. On OSX with `-DLLDB_USE_SYSTEM_DEBUGSERVER=OFF` I have built: -rwxr-xr-x 1 macbook staff 689200 Jun 24 19:10 bin/debugserver It uses `lldb/tools/debugserver/source/RNBSocket.cpp` (if I mess up the source file it does not build). The build does not need this

Re: [Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

I wonder if instead of doing: // Use our target to get a shared pointer to ourselves... if (m_finalize_called && !PrivateStateThreadIsValid()) BroadcastEvent(event_sp); else m_private_state_broadcaster.BroadcastEvent(event_sp); ->

[Lldb-commits] [PATCH] D97285: [lldb][AArch64] Add "memory tag read" command

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG31f9960c3852: [lldb][AArch64] Add memory tag read command (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 31f9960 - [lldb][AArch64] Add "memory tag read" command

Author: David Spickett Date: 2021-06-24T17:35:45+01:00 New Revision: 31f9960c38529ce805edf9764535eb0ce188cadf URL: https://github.com/llvm/llvm-project/commit/31f9960c38529ce805edf9764535eb0ce188cadf DIFF:

[Lldb-commits] [PATCH] D95602: [lldb][AArch64] Add MTE memory tag reading to lldb

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5d3436200147: [lldb][AArch64] Add MTE memory tag reading to lldb (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [lldb] 5d34362 - [lldb][AArch64] Add MTE memory tag reading to lldb

Author: David Spickett Date: 2021-06-24T17:17:10+01:00 New Revision: 5d3436200147a999670f754288a03c4ac5a15aeb URL: https://github.com/llvm/llvm-project/commit/5d3436200147a999670f754288a03c4ac5a15aeb DIFF:

[Lldb-commits] [PATCH] D95601: [lldb][AArch64] Add memory tag reading to lldb-server

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGda2e614f56b1: [lldb][AArch64] Add memory tag reading to lldb-server (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] da2e614 - [lldb][AArch64] Add memory tag reading to lldb-server

Author: David Spickett Date: 2021-06-24T17:02:55+01:00 New Revision: da2e614f56b196b37175e2babfac8ed7b43ab624 URL: https://github.com/llvm/llvm-project/commit/da2e614f56b196b37175e2babfac8ed7b43ab624 DIFF:

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added inline comments. Comment at: lldb/tools/debugserver/source/RNBSocket.cpp:44 } else if (strcmp(hostname, "*") == 0) { addr = htonl(INADDR_ANY); return true; Here it should use `AI_PASSIVE` instead. Repository: rG LLVM Github

[Lldb-commits] [lldb] cc05418 - [lldb][AArch64] Fix unpack tags test case

Author: David Spickett Date: 2021-06-24T15:53:23+01:00 New Revision: cc05418d98f3d232cc66f9065262200eaa4a14db URL: https://github.com/llvm/llvm-project/commit/cc05418d98f3d232cc66f9065262200eaa4a14db DIFF:

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2838600 , @jankratochvil wrote: > In D104856#2838571 , @teemperor > wrote: > >> The file is part of `debugserver` which is Darwin exclusive and is also only >>

[Lldb-commits] [PATCH] D97282: [lldb][AArch64] Add memory-tagging qSupported feature

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d58fbd09efb: [lldb][AArch64] Add memory-tagging qSupported feature (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES

[Lldb-commits] [lldb] 8d58fbd - [lldb][AArch64] Add memory-tagging qSupported feature

Author: David Spickett Date: 2021-06-24T15:43:20+01:00 New Revision: 8d58fbd09efb443d92842a0d101348cda06d7253 URL: https://github.com/llvm/llvm-project/commit/8d58fbd09efb443d92842a0d101348cda06d7253 DIFF:

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838571 , @teemperor wrote: > The file is part of `debugserver` which is Darwin exclusive and is also only > compiled/used when you're on Darwin. It's also kind of its own thing: it > isn't using LLVM libraries

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor added a comment. In D104856#2838526 , @jankratochvil wrote: > In D104856#2838515 , @teemperor > wrote: > >> (Nit: this is from the Linux manpage but this code is only compiled on >> Darwin). > > Why

[Lldb-commits] [lldb] e0f2744 - [lldb][AArch64] Add class for managing memory tags

Author: David Spickett Date: 2021-06-24T15:10:01+01:00 New Revision: e0f2744a115c41e8d295b93dd74b39535c852390 URL: https://github.com/llvm/llvm-project/commit/e0f2744a115c41e8d295b93dd74b39535c852390 DIFF:

[Lldb-commits] [PATCH] D97281: [lldb][AArch64] Add class for managing memory tags

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe0f2744a115c: [lldb][AArch64] Add class for managing memory tags (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

jankratochvil added a comment. In D104856#2838515 , @teemperor wrote: > (Nit: this is from the Linux manpage but this code is only compiled on > Darwin). Why do you think so? I haven't tried to build it on OSX but according to GIT the last use of this

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

teemperor edited reviewers, added: jasonmolenda; removed: k8stone, beanz. teemperor added a comment. (Nit: this is from the Linux manpage but this code is only compiled on Darwin). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104856/new/

[Lldb-commits] [PATCH] D93479: [lldb] Simplify the is_finalized logic in process and make it thread safe.

aharries-upmem added a comment. Hi all, Apologies for being the bearer of bad news, but I believe that this patch breaks our[1] (downstream) lldb, by introducing a deadlock when a process is killed by a parent debugging process. Specifically, I believe that this patch causes a process to fail

[Lldb-commits] [PATCH] D104856: [lldb] replace gethostbyname call by getaddrinfo

serge-sans-paille created this revision. serge-sans-paille requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. According to the manpage The gethostbyname*() and gethostbyaddr*() functions are obsolete. Applications should use

[Lldb-commits] [lldb] f0d0612 - [NFC][trace] remove dead function

Author: Walter Erquinigo Date: 2021-06-23T23:18:53-07:00 New Revision: f0d06124769f477a26f8fa2589f0ace85419c120 URL: https://github.com/llvm/llvm-project/commit/f0d06124769f477a26f8fa2589f0ace85419c120 DIFF: