[Lldb-commits] [lldb] 42c05ed - Fix failing tests after https://reviews.llvm.org/D104488.

Author: Greg Clayton Date: 2021-06-28T19:59:24-07:00 New Revision: 42c05ed8beb264ccae0b471ca67ad3d7a6aeaa0c URL: https://github.com/llvm/llvm-project/commit/42c05ed8beb264ccae0b471ca67ad3d7a6aeaa0c DIFF: https://github.com/llvm/llvm-project/commit/42c05ed8beb264ccae0b471ca67ad3d7a6aeaa0c.diff

[Lldb-commits] [lldb] 323bcbd - Fix buildbot failure after https://reviews.llvm.org/D104488.

Author: Greg Clayton Date: 2021-06-28T18:12:05-07:00 New Revision: 323bcbdba0e6ffa206a4575ce90e5056e8e77c09 URL: https://github.com/llvm/llvm-project/commit/323bcbdba0e6ffa206a4575ce90e5056e8e77c09 DIFF: https://github.com/llvm/llvm-project/commit/323bcbdba0e6ffa206a4575ce90e5056e8e77c09.diff

[Lldb-commits] [lldb] d77ccfd - Create synthetic symbol names on demand to improve memory consumption and startup times.

Author: Greg Clayton Date: 2021-06-28T18:04:51-07:00 New Revision: d77ccfdc72182cf7ca1bbf6b8b47e062766a9f1f URL: https://github.com/llvm/llvm-project/commit/d77ccfdc72182cf7ca1bbf6b8b47e062766a9f1f DIFF: https://github.com/llvm/llvm-project/commit/d77ccfdc72182cf7ca1bbf6b8b47e062766a9f1f.diff

[Lldb-commits] [PATCH] D104488: Create synthetic symbol names on demand to improve memory consumption and startup times.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd77ccfdc7218: Create synthetic symbol names on demand to improve memory consumption and… (authored by clayborg). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

omjavaid added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:3477 + + if (raw_type == std::numeric_limits::max() || + // Make sure the cast below would be valid First condition looks redundant give

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

omjavaid added a comment. In D102757#2826611 , @DavidSpickett wrote: > Do you think this needs a test with a core file as well? I guess it wont be needed. Included test is fine to check whether we remove non-address bits or not. Rest functionality does

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/linux/aarch64/tagged_memory_read/TestAArch64LinuxTaggedMemoryRead.py:23 +def test_mte_regions(self): +if not self.isAArch64PAut

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. Excellent Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038

[Lldb-commits] [PATCH] D105060: [LLDB] dotest.py set selected_platform on remote connection

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG1fa702358569: [LLDB] dotest.py set selected_platform on remote connection (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLV

[Lldb-commits] [lldb] 1fa7023 - [LLDB] dotest.py set selected_platform on remote connection

Author: Muhammad Omair Javaid Date: 2021-06-28T21:37:12Z New Revision: 1fa70235856962fae723d97cb39b47da6eb9666e URL: https://github.com/llvm/llvm-project/commit/1fa70235856962fae723d97cb39b47da6eb9666e DIFF: https://github.com/llvm/llvm-project/commit/1fa70235856962fae723d97cb39b47da6eb9666e.di

[Lldb-commits] [PATCH] D105060: [LLDB] dotest.py set selected_platform on remote connection

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Thanks! LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105060/new/ https://reviews.llvm.org/D105060 ___ lldb-commits maili

[Lldb-commits] [PATCH] D105060: [LLDB] dotest.py set selected_platform on remote connection

omjavaid created this revision. omjavaid added a reviewer: JDevlieghere. omjavaid requested review of this revision. This patch fixes a bug in dotest.py where lldb.selected_platform was being set to host platform even after a successful connection to a remote platform via platform url. This patch

[Lldb-commits] [PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

mibintc reopened this revision. mibintc added a comment. This revision is now accepted and ready to land. Herald added a subscriber: JDevlieghere. More buildbot failures Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104729/new/ https://reviews.llvm

[Lldb-commits] [lldb] 1d85d08 - Revert "[clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options"

Author: Melanie Blower Date: 2021-06-28T15:47:21-04:00 New Revision: 1d85d0879a75b9556b10f55739437af8233c0b64 URL: https://github.com/llvm/llvm-project/commit/1d85d0879a75b9556b10f55739437af8233c0b64 DIFF: https://github.com/llvm/llvm-project/commit/1d85d0879a75b9556b10f55739437af8233c0b64.diff

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

mib updated this revision to Diff 354988. mib added a comment. Address @jingham comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038 Files: lldb/source/Commands/CommandObjectQuit.cpp lldb/source/C

[Lldb-commits] [PATCH] D104729: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

This revision was automatically updated to reflect the committed changes. Closed by commit rG2dbe1c675fe9: [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to… (authored by mibintc). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Changed prior to c

[Lldb-commits] [lldb] 2dbe1c6 - [clang][PATCH][nfc] Refactor TargetInfo::adjust to pass DiagnosticsEngine to allow diagnostics on target-unsupported options

Author: Melanie Blower Date: 2021-06-28T15:09:53-04:00 New Revision: 2dbe1c675fe94eeb7973dcc25b049d25f4ca4fa0 URL: https://github.com/llvm/llvm-project/commit/2dbe1c675fe94eeb7973dcc25b049d25f4ca4fa0 DIFF: https://github.com/llvm/llvm-project/commit/2dbe1c675fe94eeb7973dcc25b049d25f4ca4fa0.diff

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. Shouldn't have also said accepted yet... Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. One nit about the handling of colors. Comment at: lldb/source/Core/Debugger.cpp:611 + if (cmd_interpreter.GetSaveSessionOnQuit()) { +CommandReturnObject result(/*color

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

mib updated this revision to Diff 354962. mib marked 2 inline comments as done. mib added a comment. Address @jingham, @JDevlieghere & @shafik comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038 Fil

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

shafik added inline comments. Comment at: lldb/source/Core/Debugger.cpp:611 + if (cmd_interpreter.GetSaveSessionOnQuit()) { +CommandReturnObject result(/*colors*/ true); +cmd_interpreter.SaveTranscript(result); `/*colors=*/true` Repository: rG LLVM G

[Lldb-commits] [PATCH] D104653: [lldb] Avoid using any shell when calling xcrun.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG355541a1b7a5: [lldb] Avoid using any shell when calling xcrun. (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LL

[Lldb-commits] [lldb] 355541a - [lldb] Avoid using any shell when calling xcrun.

Author: Raphael Isemann Date: 2021-06-28T19:53:52+02:00 New Revision: 355541a1b7a5011f8f4ebadc3e23b25c734f9d27 URL: https://github.com/llvm/llvm-project/commit/355541a1b7a5011f8f4ebadc3e23b25c734f9d27 DIFF: https://github.com/llvm/llvm-project/commit/355541a1b7a5011f8f4ebadc3e23b25c734f9d27.dif

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

mib added a comment. In D105030#2844708 , @vsk wrote: > I love the save-session feature. Just checking, has it already been > release-noted on llvm.org (and for that matter Xcode)? Glad you like it @vsk ! I don't think it was on the release note (at lea

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

mib updated this revision to Diff 354950. mib marked 3 inline comments as done. mib added a comment. Rephrase setting description Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105030/new/ https://reviews.llvm.org/D105030 Files: lldb/include/lldb

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere added inline comments. Comment at: lldb/lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# RUN: %build %p/Inputs/dummy-target.c -o %t.out +# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' JDevlieghe

[Lldb-commits] [lldb] a4aa705 - [lldb] Remove spurious lldb/lldb subdirectory

Author: Jonas Devlieghere Date: 2021-06-28T10:41:03-07:00 New Revision: a4aa705d52e818cf526f5e41cce8e719befd97a6 URL: https://github.com/llvm/llvm-project/commit/a4aa705d52e818cf526f5e41cce8e719befd97a6 DIFF: https://github.com/llvm/llvm-project/commit/a4aa705d52e818cf526f5e41cce8e719befd97a6.d

[Lldb-commits] [PATCH] D103349: [lldb] Don't print script output twice in HandleCommand

JDevlieghere added inline comments. Comment at: lldb/lldb/test/Shell/Breakpoint/breakpoint-command.test:1 +# RUN: %build %p/Inputs/dummy-target.c -o %t.out +# RUN: %lldb %t.out -o 'b main' -o 'break command add 1 -o "script print(95000 + 126)"' -o 'r' thakis wro

[Lldb-commits] [PATCH] D104405: Change PathMappingList::FindFile to return an optional result (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. LGTM modulo formatting CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104405/new/ https://reviews.llvm.org/D104405 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM too CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104406/new/ https://reviews.llvm.org/D104406 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

vsk added a comment. I love the save-session feature. Just checking, has it already been release-noted on llvm.org (and for that matter Xcode)? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105030/new/ https://reviews.llvm.org/D105030 ___

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2977 + result.SetStatus(eReturnStatusSuccessContinuingResult); result.AppendMessageWithFormat("Session's transcripts saved to %s\n", Why `eReturnStatusSuccessCont

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

jingham added a comment. Maybe a test? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105038/new/ https://reviews.llvm.org/D105038 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [PATCH] D105038: [lldb/Interpreter] Fix session-save-on-quit when using ^D

mib created this revision. mib added reviewers: JDevlieghere, teemperor. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. Previously, when `interpreter.save-session-on-quit` was enabled, lldb would save the session transcript only when runn

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

mib updated this revision to Diff 354916. mib added a comment. Address @JDevlieghere comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105030/new/ https://reviews.llvm.org/D105030 Files: lldb/include/lldb/Interpreter/CommandInterpreter.h l

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

mib added inline comments. Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts.">; def StopCmdSourceOnError: Property<"stop-command-source-on-error", "Boolean">,

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/InterpreterProperties.td:18 +DefaultStringValue<"">, +Desc<"A path where LLDB will save the session's transcripts.">; def StopCmdSourceOnError: Property<"stop-command-source-on-error", "Boolean">,

[Lldb-commits] [PATCH] D105034: [lldb/lua] Add scripted watchpoints for Lua

siger-young created this revision. siger-young added reviewers: tammela, JDevlieghere. siger-young added a project: LLDB. siger-young requested review of this revision. Herald added a subscriber: lldb-commits. Add support for Lua scripted watchpoints, with basic tests. Repository: rG LLVM Gith

[Lldb-commits] [PATCH] D105030: [lldb/Interpreter] Add setting to set session transcript save directory

mib created this revision. mib added reviewers: teemperor, JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new interpreter setting `interpreter.save-session-directory` so the user can specify a directo