[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

pcc added a comment. > Programs must enable the tagged address ABI to > receive these signals and are also opting into the > presence of these tag bits. This is actually independent of the tagged address ABI. For siginfo data structures read via `ptrace(PTRACE_GETSIGINFO)` we will always have

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace dump ctf -f ` command

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/include/lldb/Target/TraceHTR.h:1-2 +//===-- TraceHTR.h -*- C++ +//-*-===// +//

[Lldb-commits] [lldb] 379f24f - Revert "Revert "Reset the wakeup timeout when we re-enter the continue wait.""

Author: Jim Ingham Date: 2021-07-12T14:20:49-07:00 New Revision: 379f24ffde03d1730f1e8332574865277a5478fe URL: https://github.com/llvm/llvm-project/commit/379f24ffde03d1730f1e8332574865277a5478fe DIFF: https://github.com/llvm/llvm-project/commit/379f24ffde03d1730f1e8332574865277a5478fe.diff

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

clayborg requested changes to this revision. clayborg added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:1305 + + // If a function has an auto return type we need to find the defintion since + // that will have the deduced return

[Lldb-commits] [lldb] 8ea1a63 - [vscode] fix ubsan problem in the progress event reporter

Author: Walter Erquinigo Date: 2021-07-12T13:22:25-07:00 New Revision: 8ea1a630d66f4d70a7177c6eb522a3efff21b1be URL: https://github.com/llvm/llvm-project/commit/8ea1a630d66f4d70a7177c6eb522a3efff21b1be DIFF:

[Lldb-commits] [PATCH] D105832: [vscode] fix ubsan problem in the progress event reporter

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8ea1a630d66f: [vscode] fix ubsan problem in the progress event reporter (authored by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil marked an inline comment as done. jankratochvil added inline comments. Comment at: lldb/tools/driver/Driver.cpp:871 int main(int argc, char const *argv[]) { + ::setlocale(LC_ALL, ""); + ::setlocale(LC_CTYPE, ""); teemperor wrote: > Can you make

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

jankratochvil updated this revision to Diff 358047. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105779/new/ https://reviews.llvm.org/D105779 Files: lldb/source/Core/IOHandlerCursesGUI.cpp lldb/tools/driver/Driver.cpp Index:

[Lldb-commits] [PATCH] D105832: [vscode] fix ubsan problem in the progress event reporter

wallace created this revision. wallace added a reviewer: clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The error UndefinedBehaviorSanitizer: undefined-behavior

[Lldb-commits] [PATCH] D105564: Fix for DWARF parsing to better handle auto return type for member functions

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. I think this looks good, thanks for fixing this! I believe there should be a few more tests for all the corner cases we can run into here (those tests can all be just Python

[Lldb-commits] [PATCH] D105655: [LLDB][GUI] Add Process Attach form

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1921 protected: std::vector m_fields; std::vector m_actions; Do these actually

[Lldb-commits] [lldb] 11b47c1 - Reland "[clang-repl] Implement partial translation units and error recovery."

Author: Vassil Vassilev Date: 2021-07-12T15:21:22Z New Revision: 11b47c103a36371576711cae1f7527c26f78efb5 URL: https://github.com/llvm/llvm-project/commit/11b47c103a36371576711cae1f7527c26f78efb5 DIFF: https://github.com/llvm/llvm-project/commit/11b47c103a36371576711cae1f7527c26f78efb5.diff

[Lldb-commits] [lldb] 7177c59 - [lldb][NFC] Use ArrayRef in TypeSystemClang::SetFunctionParameters

Author: Raphael Isemann Date: 2021-07-12T15:38:51+02:00 New Revision: 7177c5951ab4fefcd8986a7808d895ffeeace037 URL: https://github.com/llvm/llvm-project/commit/7177c5951ab4fefcd8986a7808d895ffeeace037 DIFF:

[Lldb-commits] [PATCH] D105698: [lldb/Target] Fix event handling during process launch

mib closed this revision. mib added a comment. Landed in 8266b7ea7dac95b60843a1fdde31b42475687fe5 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105698/new/

[Lldb-commits] [lldb] 8266b7e - [lldb/Target] Fix event handling during process launch

Author: Med Ismail Bennani Date: 2021-07-12T12:34:26+01:00 New Revision: 8266b7ea7dac95b60843a1fdde31b42475687fe5 URL: https://github.com/llvm/llvm-project/commit/8266b7ea7dac95b60843a1fdde31b42475687fe5 DIFF:

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

DavidSpickett added a comment. > Is this final version or you are still doing refactoring. Also can you kindly > order its child and parent revs in current tag-write patch series. I'm currently rebasing all the active patches onto this one, I don't expect to change this but I might have to

[Lldb-commits] [PATCH] D105779: RFC: [lldb] Fix editline unicode on Linux

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. In retrospective that's a rather obvious fix. Thanks! This LGTM, but I think this deserves a comment about why we are setting this. Usually LLVM avoids the locale-dependent

[Lldb-commits] [PATCH] D105630: [lldb][AArch64] Refactor memory tag range handling

omjavaid added a comment. Is this final version or you are still doing refactoring. Also can you kindly order its child and parent revs in current tag-write patch series. Comment at: lldb/source/Commands/CommandObjectMemoryTag.cpp:70 Process *process =

[Lldb-commits] [PATCH] D105178: [lldb][AArch64] Annotate synchronous tag faults

omjavaid accepted this revision. omjavaid added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/API/linux/aarch64/mte_tag_faults/main.c:29 + + if (prctl(PR_SET_TAGGED_ADDR_CTRL, prctl_arg2, 0, 0, 0)) +return 1; Can we

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

This revision was automatically updated to reflect the committed changes. Closed by commit rG10f5e08a7124: [LLDB] Testsuite: Add helper to check for AArch64 target (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 10f5e08 - [LLDB] Testsuite: Add helper to check for AArch64 target

Author: Muhammad Omair Javaid Date: 2021-07-12T14:21:45+05:00 New Revision: 10f5e08a7124d2efb5b3a58a041363dbe291fefd URL: https://github.com/llvm/llvm-project/commit/10f5e08a7124d2efb5b3a58a041363dbe291fefd DIFF:

[Lldb-commits] [PATCH] D104914: [lldb] Correct format of qMemTags type field

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. I am trying to run test_qmemtags_packets but the test hangs while waiting for lldb-server to terminate. My test compiler is

[Lldb-commits] [PATCH] D105483: [LLDB] Testsuite: Add helper to check for AArch64 target

DavidSpickett added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105483/new/ https://reviews.llvm.org/D105483 ___ lldb-commits mailing list lldb-commits@lists.llvm.org