[Lldb-commits] [PATCH] D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again

jasonmolenda updated this revision to Diff 360717. jasonmolenda added a comment. Update patch to address Jonas' suggestion of not duplicating the code to write the LC_NOTE load command & payloads (I was annoyed by this too but didn't deal with it in my first pass). Also add a test, although it

[Lldb-commits] [PATCH] D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again

jasonmolenda updated this revision to Diff 360722. jasonmolenda added a comment. One more bit I meant to do -- added output to "process status --verbose" to show the addressing masks in effect. There's no other way to check what lldb is currently using for ptrauth masks currently, to debug/conf

[Lldb-commits] [lldb] cdc6f8d - Read and write a LC_NOTE "addrable bits" for addressing mask

Author: Jason Molenda Date: 2021-07-22T01:06:44-07:00 New Revision: cdc6f8d728208d2f06c1c632a41d930e172b4fb5 URL: https://github.com/llvm/llvm-project/commit/cdc6f8d728208d2f06c1c632a41d930e172b4fb5 DIFF: https://github.com/llvm/llvm-project/commit/cdc6f8d728208d2f06c1c632a41d930e172b4fb5.diff

[Lldb-commits] [PATCH] D106348: Write the # of addressable bits into Mach-O corefiles, read it back out again

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcdc6f8d72820: Read and write a LC_NOTE "addrable bits" for address

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

teemperor added a comment. Quick note to prevent some confusion: I saw this patch and realized that the LLDB change was only necessary because some Clang code got copy pasted into LLDB. I removed that copy in https://reviews.llvm.org/D106537 so if you see merge conflicts while merging this, you

[Lldb-commits] [lldb] 67c588c - [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

Author: Raphael Isemann Date: 2021-07-22T13:30:48+02:00 New Revision: 67c588c481bb2fb9f72459fbc205c3e1ee8c4b3b URL: https://github.com/llvm/llvm-project/commit/67c588c481bb2fb9f72459fbc205c3e1ee8c4b3b DIFF: https://github.com/llvm/llvm-project/commit/67c588c481bb2fb9f72459fbc205c3e1ee8c4b3b.dif

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG67c588c481bb: [lldb] Generalize empty record size computation to avoid giving empty C++… (authored by teemperor). Herald added a subscriber: lldb-com

[Lldb-commits] [PATCH] D106266: [C++4OpenCL] Add run line standard aliases clc++1.0 and CLC++1.0

Topotuna added a comment. That is good to know. Thank you for sorting it out CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106266/new/ https://reviews.llvm.org/D106266 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [lldb] 12a89e1 - [lldb][NFCI] Remove redundant accessibility heuristic in the DWARF parser

Author: Raphael Isemann Date: 2021-07-22T13:36:23+02:00 New Revision: 12a89e14b83ac3db9e44f535a43bb11e7b6c3601 URL: https://github.com/llvm/llvm-project/commit/12a89e14b83ac3db9e44f535a43bb11e7b6c3601 DIFF: https://github.com/llvm/llvm-project/commit/12a89e14b83ac3db9e44f535a43bb11e7b6c3601.dif

[Lldb-commits] [PATCH] D105463: [lldb][NFC] Remove redundant accessibility heuristic in the DWARF parser

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG12a89e14b83a: [lldb][NFCI] Remove redundant accessibility heuristic in the DWARF parser (authored by teemperor). Herald added a subscriber: lldb-comm

[Lldb-commits] [PATCH] D106483: [LLDB][GUI] Add Platform Plugin Field

OmarEmaraDev updated this revision to Diff 360767. OmarEmaraDev added a comment. - Rebase on main and fix conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106483/new/ https://reviews.llvm.org/D106483 Files: lldb/source/Core/IOHandlerCurs

[Lldb-commits] [lldb] 0780034 - [lldb] Fix that `process signal` completion always returns all signals

Author: Raphael Isemann Date: 2021-07-22T13:51:21+02:00 New Revision: 078003482e90ff5c7ba047a3d3152f0b0c392b31 URL: https://github.com/llvm/llvm-project/commit/078003482e90ff5c7ba047a3d3152f0b0c392b31 DIFF: https://github.com/llvm/llvm-project/commit/078003482e90ff5c7ba047a3d3152f0b0c392b31.dif

[Lldb-commits] [PATCH] D105028: [lldb] Fix that `process signal` completion always returns all signals

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG078003482e90: [lldb] Fix that `process signal` completion always returns all signals (authored by teemperor). Herald added a subscriber: lldb-commits

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

kimanh added a comment. Thanks for having a look at the CL! In D106355#2893959 , @jankratochvil wrote: > Is it really just a microoptimization or can you measure any improvement? > That `ManualDWARFIndex::Index` will be called is expected. But there sh

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. This is going to be excellent for linux targets and similar, In D106084#2882970 , @probinson wrote: > + @jmorse who is better placed than I am to say whether this is what Sony > would prefer. Slightly trickier -- our debugger wo

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added a reviewer: jmorse. probinson added a subscriber: jmorse. probinson added a comment. + @jmorse who is better placed than I am to say whether this is what Sony would prefer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2886659 , @jmorse wrote: > This is going to be excellent for linux targets and similar, > > In D106084#2882970 , @probinson > wrote: > >> + @jmorse who is better placed than I

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

ldionne requested changes to this revision. ldionne added a comment. This revision now requires changes to proceed. What's the benefit of having docx documentation? We generate HTML documentation, which ends up in the website, and that seems strictly superior to generating docx. What do you need

[Lldb-commits] [PATCH] D106339: Add support to generate Sphinx DOCX documentation

t-tye created this revision. t-tye added a reviewer: scott.linder. Herald added subscribers: libcxx-commits, mgorny. Herald added a reviewer: bollu. Herald added a reviewer: MaskRay. Herald added a reviewer: sscalpone. Herald added a project: libunwind. Herald added a reviewer: libunwind. t-tye req

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added a comment. > Wouldn't the current "limited" behavior have problems for this shared > libraries situation too? Sounds like in that case -fstandalone-debug should > be used. @jmorse am I remembering correctly, that we require dllimport-style annotations, so "limited" actually inc

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

JDevlieghere accepted this revision. JDevlieghere added a comment. Adrian said "Let's do it!" on the mailing list so LGTM for Darin. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 ___

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse accepted this revision. jmorse added a comment. In D106084#2887702 , @dblaikie wrote: > It'd be preferable not to split these two cases (current "limited" versus > "ctor" homing) - because they rely on the same assumption, that the whole > progra

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

jmorse added a comment. In D106084#2890541 , @probinson wrote: > @jmorse am I remembering correctly, that we require dllimport-style > annotations, so "limited" actually includes these types even if they aren't > constructed locally? I am vague on the

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

probinson added a comment. > (hence the renaming of "limited" a long time ago to "standalone-debug" to > create a policy/philosophy around what goes in each category). Sorry, what? I thought -fstandalone-debug meant FullDebugInfo, and AFAICT that's still how the driver handles it? Repository

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie added a comment. In D106084#2890469 , @probinson wrote: >> (hence the renaming of "limited" a long time ago to "standalone-debug" to >> create a policy/philosophy around what goes in each category). > > Sorry, what? I thought -fstandalone-debug

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

dblaikie accepted this revision. dblaikie added subscribers: probinson, aprantl. dblaikie added a comment. This revision is now accepted and ready to land. Please wait for sign-off from @aprantl (or another appropriate Apple representative) & @probinson (or another appropriate Sony representative

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 360646. Ericson2314 added a comment. Rebase, fixing conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt lib

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 updated this revision to Diff 360647. Ericson2314 added a comment. rebase, fixing conflicts Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 Files: clang/tools/scan-build/CMakeLists.txt lib

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang updated this revision to Diff 360621. akhuang added a comment. Herald added a subscriber: dang. Add an opt out flag: fno-use-ctor-homing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106084/new/ https://reviews.llvm.org/D106084 Files: cl

[Lldb-commits] [PATCH] D100810: Use `GNUInstallDirs` to support custom installation dirs. -- LLVM

Ericson2314 added a subscriber: phosek. Ericson2314 added a comment. @phosek would you mind reviewing this one next? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100810/new/ https://reviews.llvm.org/D100810 ___

[Lldb-commits] [PATCH] D106084: [DebugInfo] Switch to using constructor homing (-debug-info-kind=constructor) by default when debug info is enabled

akhuang added a comment. Realized it's probably a good idea to add an opt out flag (counterpart to fuse-ctor-homing). Also, maybe in a separate patch, maybe should make these clang flags instead of cc1 flags- Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.ll

[Lldb-commits] [PATCH] D106459: [LLDB][GUI] Check fields validity in actions

OmarEmaraDev updated this revision to Diff 360778. OmarEmaraDev added a comment. - Merge main and fix conflicts. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106459/new/ https://reviews.llvm.org/D106459 Files: lldb/source/Core/IOHandlerCursesGU

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

mib updated this revision to Diff 360779. mib added a comment. Fix `ScriptedProcess::IsAlive` crash during process destruction Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D100384/new/ https://reviews.llvm.org/D100384 Files: lldb/examples/python

[Lldb-commits] [lldb] 312b43d - [lldb/Plugins] Add ScriptedProcess Process Plugin

Author: Med Ismail Bennani Date: 2021-07-22T14:47:33+02:00 New Revision: 312b43da05002bbe4a06de925e34b216252bc412 URL: https://github.com/llvm/llvm-project/commit/312b43da05002bbe4a06de925e34b216252bc412 DIFF: https://github.com/llvm/llvm-project/commit/312b43da05002bbe4a06de925e34b216252bc412.

[Lldb-commits] [PATCH] D100384: [lldb/Plugins] Update ScriptedProcess Process Plugin

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG312b43da0500: [lldb/Plugins] Add ScriptedProcess Process Plugin (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 77440d6 - [lldb][NFC] Allow range-based for loops over DWARFDIE's children

Author: Raphael Isemann Date: 2021-07-22T15:03:30+02:00 New Revision: 77440d644b3ba26443c1d14d04a4046fab07d731 URL: https://github.com/llvm/llvm-project/commit/77440d644b3ba26443c1d14d04a4046fab07d731 DIFF: https://github.com/llvm/llvm-project/commit/77440d644b3ba26443c1d14d04a4046fab07d731.dif

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG77440d644b3b: [lldb][NFC] Allow range-based for loops over DWARFDIE's children (authored by teemperor). Herald added a subscriber: lldb-commits. Rep

[Lldb-commits] [lldb] eb61ffb - [lldb] Fix TestCompletion by using SIGPIPE instead of SIGINT as test signal

Author: Raphael Isemann Date: 2021-07-22T15:35:28+02:00 New Revision: eb61ffbcb277cfaeb459d6d38b34ba908d247f96 URL: https://github.com/llvm/llvm-project/commit/eb61ffbcb277cfaeb459d6d38b34ba908d247f96 DIFF: https://github.com/llvm/llvm-project/commit/eb61ffbcb277cfaeb459d6d38b34ba908d247f96.dif

[Lldb-commits] [lldb] 3d9a9fa - [lldb] Remove a wrong assert in TestStructTypes that checks that empty structs in C always have size 0

Author: Raphael Isemann Date: 2021-07-22T16:56:50+02:00 New Revision: 3d9a9fa6911a5228ce799a7c639e94d322678934 URL: https://github.com/llvm/llvm-project/commit/3d9a9fa6911a5228ce799a7c639e94d322678934 DIFF: https://github.com/llvm/llvm-project/commit/3d9a9fa6911a5228ce799a7c639e94d322678934.dif

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch resolves the paths in the file/directory fields before

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

stella.stamenova added a comment. I think this change broke the Windows LLDB bot. More specifically the TestStructTypes test: https://lab.llvm.org/buildbot/#/builders/83/builds/8528 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105471/new/ https:

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

stella.stamenova added a comment. In D105471#2896533 , @stella.stamenova wrote: > I think this change broke the Windows LLDB bot. More specifically the > TestStructTypes test: > > https://lab.llvm.org/buildbot/#/builders/83/builds/8528 Looks like you f

[Lldb-commits] [PATCH] D105471: [lldb] Generalize empty record size computation to avoid giving empty C++ structs a size of 0

teemperor added a comment. In D105471#2896544 , @stella.stamenova wrote: > In D105471#2896533 , > @stella.stamenova wrote: > >> I think this change broke the Windows LLDB bot. More specifically the >> TestStruc

[Lldb-commits] [PATCH] D106564: [LLDB][GUI] Add Arch Field

OmarEmaraDev created this revision. OmarEmaraDev added a reviewer: clayborg. Herald added a reviewer: teemperor. OmarEmaraDev requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This patch adds an Arch field that inputs and validates an arch sp

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

mib updated this revision to Diff 360857. mib edited the summary of this revision. mib added a reviewer: teemperor. mib added a project: LLDB. mib added a comment. Herald added a subscriber: JDevlieghere. Conform `ScriptedProcessPythonInterface` to SWIG python types Repository: rG LLVM Github

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Some nits but otherwise this seems like the right direction. Thanks! Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.

[Lldb-commits] [PATCH] D103172: [lldb][NFC] Allow range-based for loops over DWARFDIE's children

dblaikie added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDIE.h:97-105 + template + llvm::iterator_range children() const { +return llvm::make_range(T(*this), T()); + } +}; + +class DWARFDIE::child_iterator rather than a temepl

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInterface.cpp:66 bool ScriptedProcessPythonInterface::ShouldStop() { - return GetGenericInteger("shuold_stop"); + return static_cast(

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

mib updated this revision to Diff 360925. mib marked 3 inline comments as done. mib added a comment. Address @teemperor comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105788/new/ https://reviews.llvm.org/D105788 Files: lldb/source/Plug

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 created this revision. augusto2112 added reviewers: jasonmolenda, aprantl. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. On mach-O, if an object file is eligible to be in the shared cache, it cannot have data read

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. I think this is the last round of review so I'll just accept this modulo a few nits. Comment at: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcessPythonInt

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

mib updated this revision to Diff 360958. mib added a comment. Address last comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105788/new/ https://reviews.llvm.org/D105788 Files: lldb/source/Plugins/ScriptInterpreter/Python/ScriptedProcess

[Lldb-commits] [lldb] 3d4cadf - [lldb/Interpreter] Conform ScriptedProcessPythonInterface to SWIG python types

Author: Med Ismail Bennani Date: 2021-07-22T22:48:15+02:00 New Revision: 3d4cadfb26437bd686ca8177f5454a366fed59eb URL: https://github.com/llvm/llvm-project/commit/3d4cadfb26437bd686ca8177f5454a366fed59eb DIFF: https://github.com/llvm/llvm-project/commit/3d4cadfb26437bd686ca8177f5454a366fed59eb.

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3d4cadfb2643: [lldb/Interpreter] Conform ScriptedProcessPythonInterface to SWIG python types (authored by mib). Repository: rG LLVM Github Monorep

[Lldb-commits] [lldb] 254c4d1 - [lldb] Fix build failure introduced by 3d4cadfb26437bd686ca8177f5454a366fed59eb

Author: Med Ismail Bennani Date: 2021-07-22T20:54:27Z New Revision: 254c4d174ea3bd3601818b003fc169cdedf24fb9 URL: https://github.com/llvm/llvm-project/commit/254c4d174ea3bd3601818b003fc169cdedf24fb9 DIFF: https://github.com/llvm/llvm-project/commit/254c4d174ea3bd3601818b003fc169cdedf24fb9.diff

[Lldb-commits] [PATCH] D105788: [LLDB] Silence warnings from ScriptedProcessPythonInterface.cpp

mib added a comment. Hi @omjavaid , please let me know if you're still seeing the warnings. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105788/new/ https://reviews.llvm.org/D105788 ___ lldb-com

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 39 inline comments as done. jj10306 added inline comments. Comment at: lldb/source/Target/TraceHTR.cpp:53-57 +std::vector const &TraceHTR::GetBlockLayers() const { + return m_block_layers; +} + +HTRInstructionLayer const &TraceHTR::GetInstructionLayer() const { --

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 updated this revision to Diff 360965. jj10306 marked 2 inline comments as done. jj10306 added a comment. Address comments: - use unique_ptr to prevent unnecessary copying - add support for trace decoding errors CHANGES SINCE LAST ACTION https://reviews.llvm.org/D105741/new/ https://r

[Lldb-commits] [lldb] bcce8e0 - Fix the logic so stop-hooks get run after a breakpoint that ran an expression

Author: Jim Ingham Date: 2021-07-22T15:06:41-07:00 New Revision: bcce8e0fccc1d6c2f18ade0ffa7039fb705bade2 URL: https://github.com/llvm/llvm-project/commit/bcce8e0fccc1d6c2f18ade0ffa7039fb705bade2 DIFF: https://github.com/llvm/llvm-project/commit/bcce8e0fccc1d6c2f18ade0ffa7039fb705bade2.diff LO

[Lldb-commits] [PATCH] D106514: Fix the logic so stop-hooks get run after a breakpoint that ran an expression

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbcce8e0fccc1: Fix the logic so stop-hooks get run after a breakpoint that ran an expression (authored by jingham). Herald added a project: LLDB. Hera

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. Hm there's no phab action which says "reject approach" :) the perf impact of forcing all reads to be out of memory would be dramatically bad for a remote system debug session, this can't be done. If there is a specific caller that must use live memory even for a s

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. I should add — I also don’t think this will fix the bug you’re working on. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 ___ lld

[Lldb-commits] [PATCH] D106355: [DWARF5] Only fallback to manual index if no entry was found

jankratochvil added a comment. In D106355#2896117 , @kimanh wrote: > In our case we have some third-party libraries that were not built by us, and > therefore they don't have any name index. Our main focus, is however, not to > debug those third party l

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

jasonmolenda added a comment. I do like the debug-lldb check that the file cache read matches the live memory part. :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106584/new/ https://reviews.llvm.org/D106584 ___

[Lldb-commits] [PATCH] D106501: [trace] Add the definition of a TraceExporter plugin

wallace updated this revision to Diff 361013. wallace added a comment. Herald added a subscriber: dang. I've added a basic implementation of a CTF exporter plugin that can be used by https://reviews.llvm.org/D105741 (lldb) help thread trace export ctf Export a given thread's trace to Chrome

[Lldb-commits] [PATCH] D106623: Fix a logic error in "break delete --disabled" when no "protected" breakpoints are specified.

jingham created this revision. jingham added a reviewer: JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Fix "break delete --disabled" with no arguments. The code that figured out which breakpoints to delete w