[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

yinghuitan added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2812 +g_vsc.variables.IsPermanentVariableReference(variablesReference); +g_vsc.variables.InserExpandableVariable(variable, is_permanent); } clayborg

[Lldb-commits] [PATCH] D106553: [LLDB][GUI] Resolve paths in file/directory fields

clayborg requested changes to this revision. clayborg added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Core/IOHandlerCursesGUI.cpp:1308 } if (FileSystem::Instance().IsDirectory(file)) { SetError("Not a file!");

[Lldb-commits] [PATCH] D106459: [LLDB][GUI] Check fields validity in actions

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG80ac12b70b16: [LLDB][GUI] Check fields validity in actions (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 80ac12b - [LLDB][GUI] Check fields validity in actions

Author: Omar Emara Date: 2021-07-23T18:02:48-07:00 New Revision: 80ac12b70b16a51fac9918c4b25e3bdfad05eee5 URL: https://github.com/llvm/llvm-project/commit/80ac12b70b16a51fac9918c4b25e3bdfad05eee5 DIFF: https://github.com/llvm/llvm-project/commit/80ac12b70b16a51fac9918c4b25e3bdfad05eee5.diff

[Lldb-commits] [lldb] e160b39 - [LLDB][GUI] Add Platform Plugin Field

Author: Omar Emara Date: 2021-07-23T18:00:10-07:00 New Revision: e160b3987e734ba834cbd985315765ea7f468680 URL: https://github.com/llvm/llvm-project/commit/e160b3987e734ba834cbd985315765ea7f468680 DIFF: https://github.com/llvm/llvm-project/commit/e160b3987e734ba834cbd985315765ea7f468680.diff

[Lldb-commits] [PATCH] D106483: [LLDB][GUI] Add Platform Plugin Field

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe160b3987e73: [LLDB][GUI] Add Platform Plugin Field (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D106723: [source maps] fix source mapping when there are multiple matching rules

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGef8c6849a235: [source maps] fix source mapping when there are multiple matching rules (authored by Walter Erquinigo wall...@fb.com). Repository:

[Lldb-commits] [lldb] ef8c684 - [source maps] fix source mapping when there are multiple matching rules

Author: Walter Erquinigo Date: 2021-07-23T17:53:12-07:00 New Revision: ef8c6849a235e97b8b981e0f998d430fdbd7bc2a URL: https://github.com/llvm/llvm-project/commit/ef8c6849a235e97b8b981e0f998d430fdbd7bc2a DIFF:

[Lldb-commits] [PATCH] D106723: [source maps] fix source mapping when there are multiple matching rules

wallace updated this revision to Diff 361390. wallace added a comment. last nit Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106723/new/ https://reviews.llvm.org/D106723 Files: lldb/include/lldb/Target/PathMappingList.h

[Lldb-commits] [PATCH] D106723: [source maps] fix source mapping when there are multiple matching rules

wallace updated this revision to Diff 361389. wallace added a comment. improve the variable name Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106723/new/ https://reviews.llvm.org/D106723 Files: lldb/include/lldb/Target/PathMappingList.h

[Lldb-commits] [PATCH] D104406: Express PathMappingList::FindFile() in terms of PathMappingList.h::RemapPath() (NFC)

wallace added a comment. Btw, this broke source maps with multiple rules as explained here D106723 :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104406/new/ https://reviews.llvm.org/D104406

[Lldb-commits] [PATCH] D106723: [source maps] fix source mapping when there are multiple matching rules

wallace added a comment. As a note, the test is an lldb-vscode test, because I already have a set up for source maps in this kind of scenario, from breakpoints to frames, so it was easy. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106723/new/

[Lldb-commits] [PATCH] D106723: [source maps] fix source mapping when there are multiple matching rules

clayborg added inline comments. Comment at: lldb/include/lldb/Target/PathMappingList.h:75 /// + /// \param[in] check_filesystem + /// If \b true, besides matching \p path with the remapping rules, this tries "only_if_exists" be a better name for

[Lldb-commits] [PATCH] D106723: [source maps] fix source mapping when there are multiple matching rules

wallace updated this revision to Diff 361388. wallace edited the summary of this revision. wallace added a comment. Fixed another bug and added tests Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D106723/new/ https://reviews.llvm.org/D106723

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

clayborg added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2784 if (curr_variable.MightHaveChildren()) - newVariablesReference = i; + newVariablesReference = g_vsc.variables.GetNewVariableRefence(true); break;

[Lldb-commits] [PATCH] D106723: [source maps] fix source mapping when there are multiple matching rules

wallace created this revision. wallace added a reviewer: clayborg. wallace requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This error was introduced in D104406 . If there are multiple matchings rules for

[Lldb-commits] [PATCH] D105166: Fix expression evaluation result expansion in lldb-vscode

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. So there are issues with the setVariable and the variable reference it is returning. See inlined comments. Comment at: lldb/tools/lldb-vscode/VSCode.cpp:540 +

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

wallace added inline comments. Comment at: lldb/source/Target/TraceHTR.cpp:160 + current_instruction_load_address); + valid_cursor = cursor.Next(); + if (current_instruction_type & jj10306 wrote: > wallace wrote: > > valid_cursor is not a nice

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

vsk added a comment. Hey Augusto, thanks for tackling this, I'm just now slowly paging things in. Is this a correct statement of the problem: LLDB is failing to disable its file cache optimization when reading writable segments (say, __DATA) from a MachO sourced from the shared cache? If

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 29 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:272 + /// The map of block IDs to \a HTRBlock. + std::unordered_map const () const; + jj10306 wrote: > wallace wrote: > > jj10306

[Lldb-commits] [PATCH] D106712: Remember to check whether the current thread is stopped for a no-stop signal

jingham created this revision. jingham added reviewers: clayborg, JDevlieghere. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. When calculating the "currently selected thread" in Process::HandleStateChangedEvent, we check whether

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked an inline comment as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:272 + /// The map of block IDs to \a HTRBlock. + std::unordered_map const () const; + wallace wrote: > jj10306 wrote: > > wallace

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

wallace added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:272 + /// The map of block IDs to \a HTRBlock. + std::unordered_map const () const; + jj10306 wrote: > wallace wrote: > > As this is const, the only way to use this

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

jj10306 marked 2 inline comments as done. jj10306 added inline comments. Comment at: lldb/include/lldb/Target/TraceHTR.h:272 + /// The map of block IDs to \a HTRBlock. + std::unordered_map const () const; + wallace wrote: > As this is const, the only way

[Lldb-commits] [PATCH] D106584: [lldb] Improve checking of file cache read eligibility for mach-O

augusto2112 added a comment. Hi Jason, I could place this check on the caller, but I think here is the right place for it, maybe I can convince you. > the perf impact of forcing all reads to be out of memory would be > dramatically bad for a remote system debug session, this can't be done.

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

DavidSpickett added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) omjavaid

[Lldb-commits] [PATCH] D105182: [lldb] Add "memory tag write" command

omjavaid accepted this revision. omjavaid added a comment. This revision is now accepted and ready to land. LGTM after addressing comment above. Comment at: lldb/test/API/linux/aarch64/mte_tag_access/main.c:10 +char *checked_mmap(size_t page_size, int prot) { + char *ptr =

[Lldb-commits] [PATCH] D105180: [lldb][AArch64] Add memory tag writing to lldb-server

omjavaid added inline comments. Comment at: lldb/test/API/tools/lldb-server/memory-tagging/TestGdbRemoteMemoryTagging.py:56 # Run the packet stream context = self.expect_gdbremote_sequence() self.assertIsNotNone(context) omjavaid

[Lldb-commits] [PATCH] D105741: [trace] Add `thread trace export` command for Intel PT trace visualization

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. So much better. There's an optimization that you can make when merging maps, and besides that you need a more comprehensive test. Comment at: