[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

bulbazord added a comment. In D108229#2966405 , @aprantl wrote: > FYI (you may have have already noticed) this causes some merge conflicts in > swift-lldb. It would be great if we could work together to figure out how to > best resolve them. Yes, I

[Lldb-commits] [PATCH] D108229: [lldb] Refactor Module::LookupInfo constructor

aprantl added a comment. FYI (you may have have already noticed) this causes some merge conflicts in swift-lldb. It would be great if we could work together to figure out how to best resolve them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

clayborg added a comment. Very nice! Structure is good now. I found a few other issue we should fix as well. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:225 +m.SizeOfImage = static_cast( +mod->GetObjectFile()->GetByteSize()); +

[Lldb-commits] [PATCH] D108739: [LLDB] AArch64 SVE restore SVE registers after expression

omjavaid created this revision. omjavaid added reviewers: DavidSpickett, rankov. omjavaid added a project: LLDB. Herald added subscribers: ctetreau, JDevlieghere, kristof.beyls, tschuett. omjavaid requested review of this revision. This patch fixes register save/restore on expression call to also

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK updated this revision to Diff 368765. Aj0SK added a comment. Change ObjectFileMinidump plugin to inherit from PluginInterface Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108233/new/ https://reviews.llvm.org/D108233 Files:

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

MaskRay added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:293 + // ld.so saves empty file name for the executable file in the link map. + // When executable is run using ld.so, we need to be update executable path. + if

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

MaskRay added inline comments. Comment at: lldb/test/API/functionalities/dyld-launch-linux/TestDyldLaunchLinux.py:16 +exe = "/lib64/ld-linux-x86-64.so.2" +if(os.path.exists(exe)): +target = self.dbg.CreateTarget(exe)

[Lldb-commits] [PATCH] D108061: [lldb] Add support for shared library load when executable called through ld.

MaskRay added inline comments. Comment at: lldb/test/API/functionalities/dyld-launch-linux/Makefile:1 +CXX_SOURCES := main.cpp +LD_EXTRAS := -Wl,-rpath "-Wl,$(shell pwd)" ``` CXX_SOURCES := main.cpp DYLIB_NAME := signal_file DYLIB_CXX_SOURCES := signal_file.cpp

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

shafik added a comment. In D108717#2965815 , @teemperor wrote: > Thanks for the patch! > > So IIUC correctly this fixes a crash when calling `Dereference` on an SBValue > that is of type `SomeTypedef` with `typedef int& SomeTypedef`? If yes, then I >

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6508 + if (parent_type_class == clang::Type::LValueReference) +pointee_clang_type = GetLValueReferenceType(type).GetPointeeType(); + else

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

shafik added inline comments. Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6505 if (idx_is_valid) { - const clang::ReferenceType *reference_type = - llvm::cast(GetQualType(type).getTypePtr()); - CompilerType pointee_clang_type = -

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

clayborg added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/ObjectFileMinidump.cpp:31 + /*create_memory_callback=*/nullptr, + /*get_module_specifications=*/nullptr, SaveCore); +} It should be fine to not inherit from ObjectFile

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3c11e5722c30: [LLDB][GUI] Add initial searcher support (authored by OmarEmaraDev, committed by clayborg). Repository: rG LLVM Github Monorepo

[Lldb-commits] [lldb] 3c11e57 - [LLDB][GUI] Add initial searcher support

Author: Omar Emara Date: 2021-08-25T13:55:11-07:00 New Revision: 3c11e5722c302a9dcf01b97ace868e156e376bc6 URL: https://github.com/llvm/llvm-project/commit/3c11e5722c302a9dcf01b97ace868e156e376bc6 DIFF: https://github.com/llvm/llvm-project/commit/3c11e5722c302a9dcf01b97ace868e156e376bc6.diff

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Ok, sounds like you have thought this through. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108545/new/ https://reviews.llvm.org/D108545

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Thanks for the patch! So IIUC correctly this fixes a crash when calling `Dereference` on an SBValue that is of type `SomeTypedef` with `typedef int& SomeTypedef`? If yes, then

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

aprantl added inline comments. Comment at: lldb/test/API/lang/cpp/null_references/TestNullReferences.py:14 + +self.runCmd("continue") Why is the `continue` necessary and what is it actually that's triggering the crash? CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. That looks obviously correct, thanks! Comment at: lldb/source/Plugins/TypeSystem/Clang/TypeSystemClang.cpp:6506 + CompilerType pointee_clang_type; + + if

[Lldb-commits] [PATCH] D107521: [lldb/Plugins] Introduce Scripted Interface Factory

mib updated this revision to Diff 368704. mib marked 7 inline comments as done. mib edited the summary of this revision. mib added a reviewer: jingham. mib added a comment. Address @JDevlieghere and implement the generic `ScriptedPythonInterface::Dispatch` method that @jingham suggested. This

[Lldb-commits] [PATCH] D108717: Fix Reference case for TypeSystemClang::GetChildCompilerTypeAtIndex(...) to avoid possible invalid cast

shafik created this revision. shafik added reviewers: aprantl, teemperor, werat. Herald added a subscriber: arphaman. shafik requested review of this revision. D103532 modified this case to preserve type sugar but we can end up with cases where the cast is not

[Lldb-commits] [PATCH] D108257: Add type to the output for FieldDecl when logging in ClangASTSource::layoutRecordType

shafik added a comment. In D108257#2950994 , @aprantl wrote: > If getType() doesn't trigger type completion then this LGTM! AFAICT the call to `getType` end up in `ValueDecl`: QualType getType() const { return DeclType; } and this is just returning

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108510/new/ https://reviews.llvm.org/D108510 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

Aj0SK marked 9 inline comments as done. Aj0SK added a comment. Thanks for the review! Some requested changes need to be clarified for me. I have a problem mainly with successfully registering the Plugin when it inherits only from PluginInterface. Comment at:

[Lldb-commits] [PATCH] D108545: [LLDB][GUI] Add initial searcher support

OmarEmaraDev added a comment. @clayborg I see a number of issues with using forms directly: - The user will have to bother with form navigation. If we have a text field and a choice field, the user will have to switch between them using Tab and Shift+Tab in order to explore, rectify, and

[Lldb-commits] [PATCH] D108510: [lldb] Allow to register frame recognizers applied beyond the first instruction

malor updated this revision to Diff 368565. malor added a comment. Updated the description of the flag to incorporate Jim's feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108510/new/ https://reviews.llvm.org/D108510 Files: lldb/source/Commands/CommandObjectFrame.cpp

[Lldb-commits] [PATCH] D107079: [lldb] Add an option for emitting LLDB logs as JSON

teemperor added a comment. Friendly ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107079/new/ https://reviews.llvm.org/D107079 ___ lldb-commits mailing list lldb-commits@lists.llvm.org