[Lldb-commits] [PATCH] D109738: [lldb] Fix bug 38317 - Address breakpoints don't work if set before the process launches

2021-09-13 Thread Vadim Chugunov via Phabricator via lldb-commits
vadimcn created this revision. vadimcn added a reviewer: jingham. vadimcn added a project: LLDB. Herald added a subscriber: JDevlieghere. vadimcn requested review of this revision. Herald added a subscriber: lldb-commits. Setting an address breakpoint unconditionally creates a location, however

[Lldb-commits] [PATCH] D109339: Fix compilation error with older libstdc++

2021-09-13 Thread Vadim Chugunov via Phabricator via lldb-commits
vadimcn updated this revision to Diff 372391. vadimcn added a comment. Re-formatted CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109339/new/ https://reviews.llvm.org/D109339 Files: lldb/include/lldb/Target/ThreadPlanStack.h Index: lldb/include/lldb/Target/ThreadPlanStack.h

[Lldb-commits] [PATCH] D108233: WIP: Add minidump save-core functionality to ELF object files

2021-09-13 Thread Fangrui Song via Phabricator via lldb-commits
MaskRay added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Minidump/MinidumpFileBuilder.cpp:120 + if (error.Fail()) { +error.SetErrorString("Unable to convert the csd string to UTF16."); +return error;

[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

2021-09-13 Thread walter erquinigo via Phabricator via lldb-commits
wallace accepted this revision. wallace added a comment. nice! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109633/new/ https://reviews.llvm.org/D109633 ___ lldb-commits mailing list

[Lldb-commits] [lldb] e69d359 - [lldb] Actually fix format specifier after D108233

2021-09-13 Thread Fangrui Song via lldb-commits
Author: Fangrui Song Date: 2021-09-13T13:40:37-07:00 New Revision: e69d359841b6358f1d17569212ef8cf91244ca11 URL: https://github.com/llvm/llvm-project/commit/e69d359841b6358f1d17569212ef8cf91244ca11 DIFF: https://github.com/llvm/llvm-project/commit/e69d359841b6358f1d17569212ef8cf91244ca11.diff

[Lldb-commits] [PATCH] D109633: [lldb-vscode] Fix focus thread when previous thread exits

2021-09-13 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109633/new/ https://reviews.llvm.org/D109633

[Lldb-commits] [lldb] c4fa2c8 - [lldb] Fix warning in MinidumpFileBuilder.cpp

2021-09-13 Thread Alex Langford via lldb-commits
Author: Alex Langford Date: 2021-09-13T10:37:45-07:00 New Revision: c4fa2c8aa493e4c786446739ba3eb0eb4918d579 URL: https://github.com/llvm/llvm-project/commit/c4fa2c8aa493e4c786446739ba3eb0eb4918d579 DIFF: https://github.com/llvm/llvm-project/commit/c4fa2c8aa493e4c786446739ba3eb0eb4918d579.diff

[Lldb-commits] [PATCH] D109281: [lldb] [gdb-remote] Extend x86 pseudo-regs to i386

2021-09-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 372263. mgorny added a comment. Rebase. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109281/new/ https://reviews.llvm.org/D109281 Files: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext.cpp

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

2021-09-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 372261. mgorny added a comment. Rename the file to `_x86.cpp` to future-proof it. Replace`assert()s` with explicit skipping, we don't really want to crash on unexpected data in `target.xml`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D108831/new/

[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Add x31 AArch64 register for gdbserver

2021-09-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, emaste, krytarowski. Herald added subscribers: omjavaid, kristof.beyls. mgorny requested review of this revision. Create an x31 register that is aliased to sp if the latter is present and the former is not. This is needed to bring

[Lldb-commits] [PATCH] D109691: [lldb] [ABI/AArch64] Recognize special regs by their xN names too

2021-09-13 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: kristof.beyls. mgorny requested review of this revision. Recognize lr/sp/fp by their numeric register names in the ABI plugin. This is necessary to mark them appropriately when

[Lldb-commits] [lldb] dd58083 - [lldb] [test] Remove parent output checks from follow-child tests

2021-09-13 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-13T15:50:00+02:00 New Revision: dd5808330484ad3b82ba92ae1a249127b0e0bbb4 URL: https://github.com/llvm/llvm-project/commit/dd5808330484ad3b82ba92ae1a249127b0e0bbb4 DIFF: https://github.com/llvm/llvm-project/commit/dd5808330484ad3b82ba92ae1a249127b0e0bbb4.diff

[Lldb-commits] [lldb] c82dbc2 - [lldb] Skip TestGuiBasicDebug due to pr51833

2021-09-13 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-09-13T15:11:28+02:00 New Revision: c82dbc2924bd37fc497cdfe581a21810aace608d URL: https://github.com/llvm/llvm-project/commit/c82dbc2924bd37fc497cdfe581a21810aace608d DIFF: https://github.com/llvm/llvm-project/commit/c82dbc2924bd37fc497cdfe581a21810aace608d.diff

[Lldb-commits] [PATCH] D109626: [lldb] Remove redundant register alt_names

2021-09-13 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe3d878bdd82e: [lldb] Remove redundant register alt_names (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

2021-09-13 Thread Michał Górny via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8567f4d4b9a7: [lldb] Support querying registers via generic names without alt_names (authored by mgorny). Herald added a project: LLDB. Changed

[Lldb-commits] [lldb] e3d878b - [lldb] Remove redundant register alt_names

2021-09-13 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-13T13:05:06+02:00 New Revision: e3d878bdd82e10658e7b31dc6adec4a582ba1891 URL: https://github.com/llvm/llvm-project/commit/e3d878bdd82e10658e7b31dc6adec4a582ba1891 DIFF: https://github.com/llvm/llvm-project/commit/e3d878bdd82e10658e7b31dc6adec4a582ba1891.diff

[Lldb-commits] [lldb] 8567f4d - [lldb] Support querying registers via generic names without alt_names

2021-09-13 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-09-13T13:05:06+02:00 New Revision: 8567f4d4b9a79f041406026011fb8151b24b8c99 URL: https://github.com/llvm/llvm-project/commit/8567f4d4b9a79f041406026011fb8151b24b8c99 DIFF: https://github.com/llvm/llvm-project/commit/8567f4d4b9a79f041406026011fb8151b24b8c99.diff

[Lldb-commits] [PATCH] D109600: [lldb] Remove PluginInterface::GetPluginVersion

2021-09-13 Thread Pavel Labath via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGb03126768a84: [lldb] Remove PluginInterface::GetPluginVersion (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D108554: [lldb] Support querying registers via generic names without alt_names

2021-09-13 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/API/SBFrame.cpp:636-638 +if (const RegisterInfo *reg_info = +reg_ctx->GetRegisterInfoByName(name)) { +

[Lldb-commits] [lldb] 4b2e38d - [lldb][NFC] Cleanup EditlineHistory

2021-09-13 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-09-13T09:30:31+02:00 New Revision: 4b2e38d940673e6ec01c4653eacf620e7e53ae6d URL: https://github.com/llvm/llvm-project/commit/4b2e38d940673e6ec01c4653eacf620e7e53ae6d DIFF: