[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

clayborg added a comment. We should make a test for this. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationClient.cpp:2909-2917 + if (!pid_tid) { +// if ids is empty, this is an error +if (ids.size() == 0) +

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted created this revision. ted added a reviewer: clayborg. ted requested review of this revision. Herald added a project: LLDB. If the remote gdbserver's qfThreadInfo reply has a trailing comma, GDBRemoteCommunicationClient::GetCurrentProcessAndThreadIDs will return an empty vector of thread ids.

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

bulbazord added a comment. In D109928#3005085 , @clayborg wrote: > Looks fine to me. I am assuming the full test suite passes with this change > in place? It didn't introduce any new test failures on any of my machines. Comment at: l

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

clayborg added a comment. Looks fine to me. I am assuming the full test suite passes with this change in place? Comment at: lldb/source/Expression/IRExecutionUnit.cpp:717 + if (ConstString best_alternate_mangled_name = + FindBestAlternateMangledName(d

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

amccarth added a comment. I'm trying to understand why I've never seen the problem that this patch is trying to address. I wasn't aware of `LLVM_ENABLE_DIA_SDK` so I've never turned it off. But I've run `check lldb` exclusively with `LLDB_USE_NATIVE_PDB_READER=TRUE` for a long time, so I'm su

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

bulbazord created this revision. bulbazord added a reviewer: clayborg. bulbazord requested review of this revision. Herald added a project: LLDB. The work that IRExecutionUnit::CollectFallbackNames is basically the work that `CPlusPlusLanguage::GetDemangledFunctionNameWithoutArguments` does alread

[Lldb-commits] [PATCH] D109832: [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash

amccarth added a comment. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109832/new/ https://reviews.llvm.org/D109832 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [lldb] 8fb8601 - Revert "[lldb] Skip TestAppleSimulatorOSType if json parsing fails"

Author: Augusto Noronha Date: 2021-09-16T17:49:59-03:00 New Revision: 8fb86011026c56204e54a2806d598249c6297d08 URL: https://github.com/llvm/llvm-project/commit/8fb86011026c56204e54a2806d598249c6297d08 DIFF: https://github.com/llvm/llvm-project/commit/8fb86011026c56204e54a2806d598249c6297d08.dif

[Lldb-commits] [lldb] 79e48f3 - Revert "[MachCore] Report arm64 thread exception state"

Author: Vedant Kumar Date: 2021-09-16T13:43:35-07:00 New Revision: 79e48f3c7c8ca205048f584b7658ef001a677c6d URL: https://github.com/llvm/llvm-project/commit/79e48f3c7c8ca205048f584b7658ef001a677c6d DIFF: https://github.com/llvm/llvm-project/commit/79e48f3c7c8ca205048f584b7658ef001a677c6d.diff

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG7eb67748f9d7: [MachCore] Report arm64 thread exception state (authored by vsk). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [lldb] 7eb6774 - [MachCore] Report arm64 thread exception state

Author: Vedant Kumar Date: 2021-09-16T13:35:06-07:00 New Revision: 7eb67748f9d7186419d678e807c01fc2a3811a80 URL: https://github.com/llvm/llvm-project/commit/7eb67748f9d7186419d678e807c01fc2a3811a80 DIFF: https://github.com/llvm/llvm-project/commit/7eb67748f9d7186419d678e807c01fc2a3811a80.diff

[Lldb-commits] [PATCH] D109785: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGa65f6aafe2d3: [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings (authored by bulbazord). Changed prior to commit: https

[Lldb-commits] [lldb] a65f6aa - [lldb] Refactor and rename CPlusPlusLanguage::FindAlternateFunctionManglings

Author: Alex Langford Date: 2021-09-16T13:13:07-07:00 New Revision: a65f6aafe2d357cd83de62832a2bdae49a2d6749 URL: https://github.com/llvm/llvm-project/commit/a65f6aafe2d357cd83de62832a2bdae49a2d6749 DIFF: https://github.com/llvm/llvm-project/commit/a65f6aafe2d357cd83de62832a2bdae49a2d6749.diff

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

teemperor requested changes to this revision. teemperor added a comment. This revision now requires changes to proceed. Herald added a subscriber: JDevlieghere. Could you add a test for that? The usual test fixit in Clang is `.`/`->` mixup, e.g. (lldb) expr struct Foo { int i; }; Foo *f; f.i ;

[Lldb-commits] [PATCH] D109336: [lldb] Skip TestAppleSimulatorOSType if json parsing fails

This revision was automatically updated to reflect the committed changes. Closed by commit rG47dd1f642846: [lldb] Skip TestAppleSimulatorOSType if json parsing fails (authored by augusto2112). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109336/new/

[Lldb-commits] [lldb] 47dd1f6 - [lldb] Skip TestAppleSimulatorOSType if json parsing fails

Author: Augusto Noronha Date: 2021-09-16T16:38:20-03:00 New Revision: 47dd1f642846d476e3d789f4aa941699dc0ed3fe URL: https://github.com/llvm/llvm-project/commit/47dd1f642846d476e3d789f4aa941699dc0ed3fe DIFF: https://github.com/llvm/llvm-project/commit/47dd1f642846d476e3d789f4aa941699dc0ed3fe.dif

[Lldb-commits] [PATCH] D109908: [lldb] Show fix-it applied even if expression didn't evaluate succesfully

augusto2112 created this revision. augusto2112 added reviewers: aprantl, labath. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. If we applied a fix-it before evaluating an expression and that expression didn't evaluate correctl

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add pseudo-regs if missing [WIP]

mgorny updated this revision to Diff 373024. mgorny retitled this revision from "[lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]" to "[lldb] [ABI/AArch64] Add pseudo-regs if missing [WIP]". mgorny edited the summary of this revision. mgorny added a comment. Cover FPU registers. CHA

[Lldb-commits] [PATCH] D109906: [lldb] [test] Add unittest for DynamicRegisterInfo::Finalize()

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. https://reviews.llvm.org/D109906 Files: lldb/unittests/Process/Utility/CMakeLists.txt lldb/unittests/Process/Utility/DynamicRegisterInfoTest.cpp Index: lldb/unittests/

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

vsk updated this revision to Diff 373016. vsk added a comment. - Add missing skipIf(arch=no_match(['arm64', 'arm64e'])) change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109795/new/ https://reviews.llvm.org/D109795 Files: lldb/include/lldb/T

[Lldb-commits] [PATCH] D109795: [MachCore] Report arm64 thread exception state

vsk updated this revision to Diff 373014. vsk added a comment. - Limit testing to arm64/arm64e only. - Set a stop reason for crashing threads only (and not for threads waiting on a syscall to finish). - Use @jasonmolenda's multi-threaded test case; make sure we only select the crashing thread.

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs

mgorny abandoned this revision. mgorny added a comment. Ok, I see now that I was wrong. `DynamicRegisterInfo::Finalize()` already does that. I've finally managed to figure out what this scary code does ;-). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109879/new/ https://reviews.llvm.

[Lldb-commits] [lldb] c96d457 - [lldb] Remove SBExecutionContext::reset (NFC)

Author: Jonas Devlieghere Date: 2021-09-16T11:00:12-07:00 New Revision: c96d45700f6d3cb2b8d1972bb8de03522b3ff8d7 URL: https://github.com/llvm/llvm-project/commit/c96d45700f6d3cb2b8d1972bb8de03522b3ff8d7 DIFF: https://github.com/llvm/llvm-project/commit/c96d45700f6d3cb2b8d1972bb8de03522b3ff8d7.d

[Lldb-commits] [PATCH] D109899: [lldb] [gdb-remote] Recognize aarch64v type from gdbserver

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: kristof.beyls. mgorny requested review of this revision. https://reviews.llvm.org/D109899 Files: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp lldb/test/API/functionalit

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. In D109797#3003265 , @labath wrote: > Since the meaning of `m_initial_modules_added` is basically "should I do a > full scan through the linked list" and LoadAllCurrentModules (called from > DidAttach) does a full scan, it

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 372982. emrekultursay added a comment. Added m_initial_modules_added=true into LoadAllCurrentModules. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files: l

[Lldb-commits] [lldb] a2c319f - [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

Author: Alfonso Gregory Date: 2021-09-16T18:29:57+02:00 New Revision: a2c319fdc6b35ae6d8578459f07c89042775e5ec URL: https://github.com/llvm/llvm-project/commit/a2c319fdc6b35ae6d8578459f07c89042775e5ec DIFF: https://github.com/llvm/llvm-project/commit/a2c319fdc6b35ae6d8578459f07c89042775e5ec.dif

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]

mgorny added a comment. Ok, I definitely need some 'process plugin' IDs to handle invalidate_regs between pseudo-registers. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 ___ lldb-commits mailing l

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs

mgorny updated this revision to Diff 372919. mgorny added a comment. Now with a trivial unit test. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109879/new/ https://reviews.llvm.org/D109879 Files: lldb/source/Plugins/Process/Utility/DynamicRegisterInfo.cpp lldb/unittests/Process/Ut

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]

mgorny added a comment. In D109876#3003630 , @labath wrote: > In the mean time (and maybe before that), I'd like to understand why do you > need to mess with the process plugin register numbers in this class. It > doesn't seem like a good idea for that

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]

labath added a comment. I think we could move the DynamicRegisterInfo class into non-plugin code, but I need to give it more thought. In the mean time (and maybe before that), I'd like to understand why do you need to mess with the process plugin register numbers in this class. It doesn't seem

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs

labath added a comment. So, does this fix like an existing test or something? Maybe you could write a unit test for it? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109879/new/ https://reviews.llvm.org/D109879 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs

mgorny added a comment. Now, a fun fact: ProcessGDBRemote has already been passing temporaries. We probably didn't notice it's broken simply because lldb-server didn't send value_regs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109879/new/ https://reviews.llvm.org/D109879

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

labath added a comment. Hmm... is the (non native) SymbolFilePDB plugin actually capable of doing anything without the DIA SDK. If it can't set breakpoints, then I would guess the answer is: not much. Maybe we could automatically select the "Native" plugin in this case, just like we do on non-w

[Lldb-commits] [PATCH] D109879: [lldb] [DynamicRegisterInfo] Update RegisterInfo with copy of value_regs/invalidate_regs

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Update the value_regs and invalidate_regs pointers in RegisterInfo to use the copy made by DynamicRegisterInfo. This permits passing temporaries as value_regs and invalidat

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]

mgorny updated this revision to Diff 372907. mgorny added a comment. Use public API to determine next regnums. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 Files: lldb/include/lldb/Target/ABI.h lldb/source/Plugins/ABI/AArch64/ABIAArch64

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]

mgorny added a comment. @labath, I think the biggest problem here is that `DynamicRegisterInfo` is defined only inside source tree. I'm not sure if I should continue with a forward declaration like this or aim to move `DynamicRegisterInfo` into public headers. if the former, should I move it in

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]

mgorny added a comment. (so far with ugly hacks, to get some initial ideas on how to proceed with this) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109876/new/ https://reviews.llvm.org/D109876 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D109876: [lldb] [ABI/AArch64] Add 32-bit pseudo-regs if missing [WIP]

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: kristof.beyls. mgorny requested review of this revision. Create 32-bit wN pseudo-registers if xN registers are present but wN registers are missing. This is the case when interacting with

[Lldb-commits] [PATCH] D109832: [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash

This revision was automatically updated to reflect the committed changes. Closed by commit rG99ece01a0f57: [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] 99ece01 - [lldb/win] Fix TestIRMemoryMapWindows.test when running tests in git bash

Author: Nico Weber Date: 2021-09-16T07:40:54-04:00 New Revision: 99ece01a0f571f0df129a55bf679f7fbd0b01b75 URL: https://github.com/llvm/llvm-project/commit/99ece01a0f571f0df129a55bf679f7fbd0b01b75 DIFF: https://github.com/llvm/llvm-project/commit/99ece01a0f571f0df129a55bf679f7fbd0b01b75.diff LO

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis added a comment. In D109834#3003250 , @labath wrote: > I fear this is going to be an endless whack-a-mole. There's no way every > contributor will remember to (correctly) add this feature. I think that's ok. 10/250 shell tests need it and there i

[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Alias sp to x31 on AArch64 for gdbserver

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47d57547f43c: [lldb] [Process/gdb-remote] Alias sp to x31 on AArch64 for gdbserver (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] 47d5754 - [lldb] [Process/gdb-remote] Alias sp to x31 on AArch64 for gdbserver

Author: Michał Górny Date: 2021-09-16T13:13:47+02:00 New Revision: 47d57547f43c6cf9404268b8a4c2f75c402615c2 URL: https://github.com/llvm/llvm-project/commit/47d57547f43c6cf9404268b8a4c2f75c402615c2 DIFF: https://github.com/llvm/llvm-project/commit/47d57547f43c6cf9404268b8a4c2f75c402615c2.diff

[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Alias sp to x31 on AArch64 for gdbserver

mgorny updated this revision to Diff 372889. mgorny added a comment. Rebased — we no longer need the alt_name dance. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109695/new/ https://reviews.llvm.org/D109695 Files: lldb/source/Plugins/ABI/AArch64/ABIAArch64.cpp lldb/source/Plugins/

[Lldb-commits] [PATCH] D109872: [lldb] [DynamicRegisterInfo] Pass name/alt_name via RegisterInfo

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG86a58f10284d: [lldb] [DynamicRegisterInfo] Pass name/alt_name via RegisterInfo (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] 86a58f1 - [lldb] [DynamicRegisterInfo] Pass name/alt_name via RegisterInfo

Author: Michał Górny Date: 2021-09-16T12:00:20+02:00 New Revision: 86a58f10284dea118703ecde0ef5b9a4f6e4d8be URL: https://github.com/llvm/llvm-project/commit/86a58f10284dea118703ecde0ef5b9a4f6e4d8be DIFF: https://github.com/llvm/llvm-project/commit/86a58f10284dea118703ecde0ef5b9a4f6e4d8be.diff

[Lldb-commits] [PATCH] D109872: [lldb] [DynamicRegisterInfo] Pass name/alt_name via RegisterInfo

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. mgorny requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Remove the name and alt_name parameters from AddRegister() and instead pass them via RegisterInfo.na

[Lldb-commits] [lldb] bd590a5 - [lldb] Make Platform::DebugProcess take a Target reference

Author: Pavel Labath Date: 2021-09-16T11:33:47+02:00 New Revision: bd590a5f895f50ceb7669de1b4a69bbcc8adb38b URL: https://github.com/llvm/llvm-project/commit/bd590a5f895f50ceb7669de1b4a69bbcc8adb38b DIFF: https://github.com/llvm/llvm-project/commit/bd590a5f895f50ceb7669de1b4a69bbcc8adb38b.diff

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

mstorsjo added a comment. In D109777#3003312 , @DavidSpickett wrote: > One thing that I forgot to ask, are there already tests that cover the > scenario the bug reported? No idea - this fixes a sequence of `b `, `run`, `step`, i.e. fairly trivial/basi

[Lldb-commits] [PATCH] D109695: [lldb] [Process/gdb-remote] Alias sp to x31 on AArch64 for gdbserver

mgorny updated this revision to Diff 372883. mgorny retitled this revision from "[lldb] [Process/gdb-remote] Add x31 AArch64 register for gdbserver" to "[lldb] [Process/gdb-remote] Alias sp to x31 on AArch64 for gdbserver". mgorny edited the summary of this revision. Herald added a subscriber: je

[Lldb-commits] [lldb] ceded41 - Don't set executable file in ObjectFileMachO::LoadCoreFileImages

Author: Jason Molenda Date: 2021-09-16T01:38:48-07:00 New Revision: ceded4153245322c45d28068860fb3d8d0a4884d URL: https://github.com/llvm/llvm-project/commit/ceded4153245322c45d28068860fb3d8d0a4884d DIFF: https://github.com/llvm/llvm-project/commit/ceded4153245322c45d28068860fb3d8d0a4884d.diff

[Lldb-commits] [PATCH] D109691: [lldb] [ABI/AArch64] Recognize special regs by their xN names too

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGc208deb90082: [lldb] [ABI/AArch64] Recognize special regs by their xN names too (authored by mgorny). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [PATCH] D109272: [lldb] [gdb-remote] Try using for remote arch unconditionally

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG66249323d25f: [lldb] [gdb-remote] Try using for remote arch unconditionally (authored by mgorny). Herald added a project: LLDB. Chan

[Lldb-commits] [lldb] 6624932 - [lldb] [gdb-remote] Try using for remote arch unconditionally

Author: Michał Górny Date: 2021-09-16T10:23:31+02:00 New Revision: 66249323d25f6db1dc76bd9fb3b9eebe436519a6 URL: https://github.com/llvm/llvm-project/commit/66249323d25f6db1dc76bd9fb3b9eebe436519a6 DIFF: https://github.com/llvm/llvm-project/commit/66249323d25f6db1dc76bd9fb3b9eebe436519a6.diff

[Lldb-commits] [lldb] c208deb - [lldb] [ABI/AArch64] Recognize special regs by their xN names too

Author: Michał Górny Date: 2021-09-16T10:23:31+02:00 New Revision: c208deb9008260d3effc00c98493434a65af4b8d URL: https://github.com/llvm/llvm-project/commit/c208deb9008260d3effc00c98493434a65af4b8d DIFF: https://github.com/llvm/llvm-project/commit/c208deb9008260d3effc00c98493434a65af4b8d.diff

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

DavidSpickett added a comment. One thing that I forgot to ask, are there already tests that cover the scenario the bug reported? Good chance there are but they only run on x86 due to the available bots. We (Linaro) are working to get more tests running on WoA bots so this would be covered even

[Lldb-commits] [PATCH] D108831: [lldb] [gdb-remote] Add x86_64 pseudo-registers when using gdbserver

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteRegisterContext_x86.cpp:37-54 +static std::array partial_gpr_regs = {{ +{"rax", {{"eax"}, {"ax"}, {"ah"}, {"al"}}}, +{"rbx", {{"ebx"}, {"bx"}, {"bh"}, {"bl"}}}, +{"rcx", {{"ecx"

[Lldb-commits] [PATCH] D109272: [lldb] [gdb-remote] Try using for remote arch unconditionally

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Sounds like a good idea. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109272/new/ https://reviews.llvm.org/D109272 ___ lldb-commits maili

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

labath added a comment. The real issue here is that there are two implementations in the first place. The lldb-server method is supposed to be the new thing, and the old should go away as soon as the new one is good enough. Therefore I wouldn't spend too much time trying to unify these. Rather,

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

labath added a comment. Since the meaning of `m_initial_modules_added` is basically "should I do a full scan through the linked list" and LoadAllCurrentModules (called from DidAttach) does a full scan, it seems to me the real bug is that this function does not set `m_initial_modules_added = tru