[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

jasonmolenda added a comment. In D110013#3013733 , @aprantl wrote: > Without having dug into this deeper, do you think not specifying the arch > could cause any problems with universal binaries? I guess not, because we > still have the UUID, and the

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

bulbazord added a comment. In D109928#3013627 , @shafik wrote: > I think this looks fine, just verify that this in a C++ case an expression > with an `extern "C"` function call works fine e.g. > > extern "C" { > int g() { return 10;} > } > >

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

vsk added a comment. In D110013#3013733 , @aprantl wrote: > Without having dug into this deeper, do you think not specifying the arch > could cause any problems with universal binaries? I guess not, because we > still have the UUID, and the UUID is per

[Lldb-commits] [PATCH] D109937: [lldb] Handle malformed qfThreadInfo reply

ted updated this revision to Diff 374049. ted added a comment. [lldb] Handle malformed qfThreadInfo reply Add requested test. Refine handling of malformed reply with no valid threads. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109937/new/

[Lldb-commits] [PATCH] D110013: [lldb][crashlog] Avoid specifying arch for image when a UUID is present

aprantl added a comment. Without having dug into this deeper, do you think not specifying the arch could cause any problems with universal binaries? I guess not, because we still have the UUID, and the UUID is per arch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D109928: [lldb] Remove IRExecutionUnit::CollectFallbackNames

shafik added a comment. I think this looks fine, just verify that this in a C++ case an expression with an `extern "C"` function call works fine e.g. extern "C" { int g() { return 10;} } int main() { return g(); // break here and run expr g() } I discovered the other day

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay added a comment. plabath/mgorny: This change is ready for another round of review. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 ___

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374027. emrekultursay added a comment. Minor fix in test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files:

[Lldb-commits] [PATCH] D109797: Fix rendezvous for rebase_exec=true case

emrekultursay updated this revision to Diff 374026. emrekultursay added a comment. Update test to pass on MacOS Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109797/new/ https://reviews.llvm.org/D109797 Files:

[Lldb-commits] [lldb] 40e971a - nullptr printing - update for a change to clang type printing that now uses "std::nullptr_t"

Author: David Blaikie Date: 2021-09-21T11:50:24-07:00 New Revision: 40e971a21052a8638933037615e3c681e193f3fc URL: https://github.com/llvm/llvm-project/commit/40e971a21052a8638933037615e3c681e193f3fc DIFF: https://github.com/llvm/llvm-project/commit/40e971a21052a8638933037615e3c681e193f3fc.diff

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

This revision was automatically updated to reflect the committed changes. Closed by commit rG908c11544212: [lldb/win] Default to native PDB reader when LLVM_ENABLE_DIA_SDK=NO (authored by thakis). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 908c115 - [lldb/win] Default to native PDB reader when LLVM_ENABLE_DIA_SDK=NO

Author: Nico Weber Date: 2021-09-21T13:02:52-04:00 New Revision: 908c1154421287c6ffa0ef06ef5225a8fd0b06a7 URL: https://github.com/llvm/llvm-project/commit/908c1154421287c6ffa0ef06ef5225a8fd0b06a7 DIFF: https://github.com/llvm/llvm-project/commit/908c1154421287c6ffa0ef06ef5225a8fd0b06a7.diff

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

amccarth accepted this revision. amccarth added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110172/new/ https://reviews.llvm.org/D110172 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dexonsmith added a comment. In D109345#3008426 , @dblaikie wrote: > Thanks for the suggestions/details, @dexonsmith - I've posted to llvm-dev > here: https://groups.google.com/g/llvm-dev/c/m9UVRhzJvh4/m/qdd_SyPuCQAJ and > will wait for some follow-up

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit updated this revision to Diff 372770. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt

[Lldb-commits] [PATCH] D109345: MemoryBuffer: Migrate to Expected/llvm::Error from ErrorOr/std::error_code

dblaikie added a comment. Thanks for the suggestions/details, @dexonsmith - I've posted to llvm-dev here: https://groups.google.com/g/llvm-dev/c/m9UVRhzJvh4/m/qdd_SyPuCQAJ and will wait for some follow-up (or dead silence) before starting along probably your latter suggestion. Repository:

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

This revision was automatically updated to reflect the committed changes. Closed by commit rGa2c319fdc6b3: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR… (authored by gAlfonso-bit, committed by Mordante). Herald added a project: LLDB. Herald added a reviewer:

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @Mordante Alfonso Gregory gfunni...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

gAlfonso-bit added a comment. @ldionne can you please please merge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

thakis updated this revision to Diff 373910. thakis added a comment. slightly nicer preprocessor goop in more correct CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110172/new/ https://reviews.llvm.org/D110172 Files: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Index:

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

thakis updated this revision to Diff 373909. thakis added a comment. slightly simpler preprocessor goop CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110172/new/ https://reviews.llvm.org/D110172 Files: lldb/source/Plugins/SymbolFile/PDB/SymbolFilePDB.cpp Index:

[Lldb-commits] [PATCH] D109834: [lldb/win] Improve check-lldb-shell with LLVM_ENABLE_DIA_SDK=NO

thakis added a comment. Well, it's a start, so let's land that part (D110172 ). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109834/new/ https://reviews.llvm.org/D109834 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D110172: [lldb/win] Default to native PDB reader when building with LLVM_ENABLE_DIA_SDK=NO

thakis created this revision. thakis added reviewers: labath, amccarth. thakis added a project: LLDB. Herald added a subscriber: JDevlieghere. thakis requested review of this revision. Trying to use the DIA SDK reader only to fail with "DIA SDK wasn't enabled" isn't very useful. The native PDB

[Lldb-commits] [PATCH] D109777: [lldb] [Windows] Fix continuing from breakpoints and singlestepping on ARM/AArch64

mstorsjo added a comment. @labath Does this seem ok to you now, and/or do you have any refactoring suggestion regarding getting the breakpoint opcode size in ProcessWindows.cpp? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D109777/new/

[Lldb-commits] [PATCH] D110027: [lldb] [gdb-remote] Use local regnos for value_regs/invalidate_regs

mgorny updated this revision to Diff 373814. mgorny marked 2 inline comments as done. mgorny added a comment. Both requests implemented. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110027/new/ https://reviews.llvm.org/D110027 Files:

[Lldb-commits] [PATCH] D110027: [lldb] [gdb-remote] Use local regnos for value_regs/invalidate_regs

labath added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4619 +for (uint32_t : remote_reg_info.value_regs) { + std::map::iterator x_lldb = + remote_to_local_map.find(x); auto :)

[Lldb-commits] [lldb] 791b6eb - [lldb] Speculative fix to TestGuiExpandThreadsTree

Author: Pavel Labath Date: 2021-09-21T10:01:00+02:00 New Revision: 791b6ebc86680168d634103b67a92a354c075cc4 URL: https://github.com/llvm/llvm-project/commit/791b6ebc86680168d634103b67a92a354c075cc4 DIFF: https://github.com/llvm/llvm-project/commit/791b6ebc86680168d634103b67a92a354c075cc4.diff