kimanh added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFUnit.cpp:522
+entry->getContribution(llvm::DW_SECT_RNGLISTS)) {
+ Offset = contribution->Offset;
return DWARFDataExtractor(data, contribution->Offset,
MaskRay accepted this revision.
MaskRay added a comment.
This revision is now accepted and ready to land.
Looks great!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109975/new/
https://reviews.llvm.org/D109975
This revision was automatically updated to reflect the committed changes.
Closed by commit rG953ddded1aa2: [lldb] Handle malformed qfThreadInfo reply
(authored by ted).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109937/new/
Author: Ted Woodward
Date: 2021-09-23T17:03:47-05:00
New Revision: 953ddded1aa2b459a939e0f1649691c9086ba416
URL:
https://github.com/llvm/llvm-project/commit/953ddded1aa2b459a939e0f1649691c9086ba416
DIFF:
https://github.com/llvm/llvm-project/commit/953ddded1aa2b459a939e0f1649691c9086ba416.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGfbaf36721783: [lldb] Show fix-it applied even if expression
didnt evaluate succesfully (authored by augusto2112).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Author: Augusto Noronha
Date: 2021-09-23T16:45:04-03:00
New Revision: fbaf36721783c3bcbd45f81294e6980eaef165e4
URL:
https://github.com/llvm/llvm-project/commit/fbaf36721783c3bcbd45f81294e6980eaef165e4
DIFF:
bulbazord updated this revision to Diff 374639.
bulbazord added a comment.
Rebasing
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110115/new/
https://reviews.llvm.org/D110115
Files:
lldb/include/lldb/Target/Language.h
Author: Michał Górny
Date: 2021-09-23T20:02:01+02:00
New Revision: cc3c788ad23636d16f1db2ae859315628783b0e8
URL:
https://github.com/llvm/llvm-project/commit/cc3c788ad23636d16f1db2ae859315628783b0e8
DIFF:
https://github.com/llvm/llvm-project/commit/cc3c788ad23636d16f1db2ae859315628783b0e8.diff
Author: Michał Górny
Date: 2021-09-23T20:02:00+02:00
New Revision: fa456505b80b0cf83647a1b26713e4d3b38eccc2
URL:
https://github.com/llvm/llvm-project/commit/fa456505b80b0cf83647a1b26713e4d3b38eccc2
DIFF:
https://github.com/llvm/llvm-project/commit/fa456505b80b0cf83647a1b26713e4d3b38eccc2.diff
This revision was automatically updated to reflect the committed changes.
Closed by commit rGc22329972f02: [lldb] Add a C language REPL to test
LLDBs REPL infrastructure (authored by teemperor).
Herald added a subscriber: lldb-commits.
Changed prior to commit:
Author: Raphael Isemann
Date: 2021-09-23T19:31:02+02:00
New Revision: c22329972f02f9d51e2f9ea54d9075a4a808ffde
URL:
https://github.com/llvm/llvm-project/commit/c22329972f02f9d51e2f9ea54d9075a4a808ffde
DIFF:
I will! Thanks!
Il Gio 23 Set 2021, 12:35 PM Pavel Labath via Phabricator <
revi...@reviews.llvm.org> ha scritto:
> labath added a comment.
>
> I'm pretty sure Caleb does not have commit access. Walter, would you do
> the honors?
>
>
> Repository:
> rG LLVM Github Monorepo
>
> CHANGES SINCE
teemperor accepted this revision.
teemperor added a comment.
This revision is now accepted and ready to land.
My bad, I thought you wanted to print the fix-its if the 'fixed' expression
failed to *parse* again, but this is about non-parsing errors. Ignore my other
points, they were suggestions
Author: Michał Górny
Date: 2021-09-23T18:17:09+02:00
New Revision: bcb6b97cde84b6acd67d5551302683234c09337c
URL:
https://github.com/llvm/llvm-project/commit/bcb6b97cde84b6acd67d5551302683234c09337c
DIFF:
https://github.com/llvm/llvm-project/commit/bcb6b97cde84b6acd67d5551302683234c09337c.diff
Author: Michał Górny
Date: 2021-09-23T18:17:09+02:00
New Revision: 12504f50729a338fb37c1c1863e7125b607e11d7
URL:
https://github.com/llvm/llvm-project/commit/12504f50729a338fb37c1c1863e7125b607e11d7
DIFF:
https://github.com/llvm/llvm-project/commit/12504f50729a338fb37c1c1863e7125b607e11d7.diff
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rG6fbed33d4a7d: [lldb] [gdb-remote] Use local regnos for
value_regs/invalidate_regs (authored by mgorny).
Herald added a project: LLDB.
Changed prior
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
mgorny marked 2 inline comments as done.
Closed by commit rGb03e701c1453: [lldb] [gdb-remote] Refactor getting remote
regs to use local vector (authored by mgorny).
Author: Michał Górny
Date: 2021-09-23T17:21:56+02:00
New Revision: 6fbed33d4a7de2229c40e6318f223092d3a23848
URL:
https://github.com/llvm/llvm-project/commit/6fbed33d4a7de2229c40e6318f223092d3a23848
DIFF:
https://github.com/llvm/llvm-project/commit/6fbed33d4a7de2229c40e6318f223092d3a23848.diff
Author: Michał Górny
Date: 2021-09-23T17:21:55+02:00
New Revision: b03e701c145365ba339657ead54a2e0cc5c02776
URL:
https://github.com/llvm/llvm-project/commit/b03e701c145365ba339657ead54a2e0cc5c02776
DIFF:
https://github.com/llvm/llvm-project/commit/b03e701c145365ba339657ead54a2e0cc5c02776.diff
emrekultursay added a comment.
Done. Can you also submit it please?
Comment at: lldb/test/API/functionalities/dlopen/main.cpp:26
+ // dlopen the 'liblib_b.so' shared library.
+ void* h = dlopen(solib, RTLD_LAZY);
+ assert(h && "dlopen failed?");
labath
emrekultursay updated this revision to Diff 374536.
emrekultursay marked 4 inline comments as done.
emrekultursay added a comment.
Renamed test to load_after_attach.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109797/new/
mgorny marked 3 inline comments as done.
mgorny added inline comments.
Comment at:
lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4461-4464
+if (!reg_info.value_regs.empty())
+ reg_info.value_regs.push_back(LLDB_INVALID_REGNUM);
+if
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Looks good, just be careful about sentinels.
Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:571-578
-if (!value_regs.empty()) {
-
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
cool
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110027/new/
https://reviews.llvm.org/D110027
___
lldb-commits mailing list
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
lgtm, modulo comments.
Comment at: lldb/test/API/functionalities/dlopen/TestDlopen.py:1
+import lldb
+from lldbsuite.test.decorators import *
I'd put this
labath added a comment.
I'm pretty sure Caleb does not have commit access. Walter, would you do the
honors?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D110269/new/
https://reviews.llvm.org/D110269
Author: Pavel Labath
Date: 2021-09-23T12:30:18+02:00
New Revision: 5685eb950da7c6901c8b264a3c93e8ea63b34d3d
URL:
https://github.com/llvm/llvm-project/commit/5685eb950da7c6901c8b264a3c93e8ea63b34d3d
DIFF:
https://github.com/llvm/llvm-project/commit/5685eb950da7c6901c8b264a3c93e8ea63b34d3d.diff
27 matches
Mail list logo
