[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D111964#3071292 , @mgorny wrote: >>> This is not fully functional yet, as lldb-server >>> crashes when attempting to send long packets (e.g. target.xml contents). >> >> I am guessing you'll also want to disable QStartNoAckMode f

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny added a comment. In D111964#3072088 , @labath wrote: > I think we could introduce something like `Connection::IsReliable` and key > that behavior off of that. > > Although I can't say I actually understand how the "ack" mode is supposed to > work

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. In D111964#3071292 , @mgorny wrote: > In D111964#3069414 , @labath wrote: > >> What's the test strategy for this? > > Still thinking about it. I'm mostly PoC-ing this while other changes ar

[Lldb-commits] [PATCH] D111964: [lldb] [lldb-server] Allow any protocol supported by lldb

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/tools/lldb-server/lldb-gdbserver.cpp:237-249 + if (!is_url) { +// Ensure we have a port number for the connection. +// Note: use rfind, because the host/port may look like "[::1]:12345". +uint32_t connect

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Looks good. Thanks for your patience. Comment at: lldb/source/Plugins/ABI/X86/ABIX86.cpp:36-52 +enum RegKind { + GPR32, GPR16, GPR8h, GPR8, + MM, + YMM_YMMh,

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/include/lldb/Host/Terminal.h:21 public: + struct Data; + mgorny wrote: > labath wrote: > > Move this into the protected section > If I do that, I can't use it from `TerminalState`. I see. I was expecting that Termi

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

2021-10-19 Thread Raphael Isemann via Phabricator via lldb-commits
teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111989/new/ https://reviews.llvm.org/D111989

[Lldb-commits] [PATCH] D108937: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5352ea4a721e: [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm* (authored by mgorny). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D108937?vs=380453&id=

[Lldb-commits] [lldb] 5352ea4 - [lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T10:31:07+02:00 New Revision: 5352ea4a721ef252129994111b83dc350ecc71da URL: https://github.com/llvm/llvm-project/commit/5352ea4a721ef252129994111b83dc350ecc71da DIFF: https://github.com/llvm/llvm-project/commit/5352ea4a721ef252129994111b83dc350ecc71da.diff

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 380609. mgorny marked 2 inline comments as done. mgorny added a comment. Make `Terminal::Data` private and befriend `TerminalState`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111890/new/ https://reviews.llvm.org/D111890 Files: lldb/include/lld

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: clayborg, aadsm. labath requested review of this revision. Herald added a project: LLDB. specifically, ignore addresses that point before the first code section. This resurrects D87172 with several notable ch

[Lldb-commits] [lldb] cfaa5c3 - [lldb] Filter duplicates in Target::GetScratchTypeSystems

2021-10-19 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-10-19T11:49:47+02:00 New Revision: cfaa5c344d5bc73aae0ec39d57d98acf7463fccf URL: https://github.com/llvm/llvm-project/commit/cfaa5c344d5bc73aae0ec39d57d98acf7463fccf DIFF: https://github.com/llvm/llvm-project/commit/cfaa5c344d5bc73aae0ec39d57d98acf7463fccf.dif

[Lldb-commits] [PATCH] D111931: [lldb] Filter duplicates in Target::GetScratchTypeSystems

2021-10-19 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGcfaa5c344d5b: [lldb] Filter duplicates in Target::GetScratchTypeSystems (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D111715: [WIP] [lldb] change name demangling to be consistent between windows and linx

2021-10-19 Thread Andy Yankovsky via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG134e1817f62c: [lldb] change name demangling to be consistent between windows and linx (authored by lassefolger, committed by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION http

[Lldb-commits] [lldb] 134e181 - [lldb] change name demangling to be consistent between windows and linx

2021-10-19 Thread Andy Yankovsky via lldb-commits
Author: Lasse Folger Date: 2021-10-19T12:04:37+02:00 New Revision: 134e1817f62c08cde1ed1f7e94e51425536085ac URL: https://github.com/llvm/llvm-project/commit/134e1817f62c08cde1ed1f7e94e51425536085ac DIFF: https://github.com/llvm/llvm-project/commit/134e1817f62c08cde1ed1f7e94e51425536085ac.diff

[Lldb-commits] [lldb] 9a57d1e - [lldb] Allow dumping the state of all scratch TypeSystems

2021-10-19 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-10-19T12:05:14+02:00 New Revision: 9a57d1e52680ac05c29d6d0d2cfbaf3b05a5cbce URL: https://github.com/llvm/llvm-project/commit/9a57d1e52680ac05c29d6d0d2cfbaf3b05a5cbce DIFF: https://github.com/llvm/llvm-project/commit/9a57d1e52680ac05c29d6d0d2cfbaf3b05a5cbce.dif

[Lldb-commits] [PATCH] D111936: [lldb] Allow dumping the state of all scratch TypeSystems

2021-10-19 Thread Raphael Isemann via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG9a57d1e52680: [lldb] Allow dumping the state of all scratch TypeSystems (authored by teemperor). Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 8bac18b - [lldb] Reduce code duplication around inferior building

2021-10-19 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2021-10-19T12:09:41+02:00 New Revision: 8bac18be0e45adc7b096375bf4f65635fb994df0 URL: https://github.com/llvm/llvm-project/commit/8bac18be0e45adc7b096375bf4f65635fb994df0 DIFF: https://github.com/llvm/llvm-project/commit/8bac18be0e45adc7b096375bf4f65635fb994df0.diff

[Lldb-commits] [PATCH] D111989: [lldb] Reduce code duplication around inferior building

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8bac18be0e45: [lldb] Reduce code duplication around inferior building (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111989/new/ https:

[Lldb-commits] [lldb] ee11612 - Revert "[lldb] [ABI/X86] Support combining xmm* and ymm*h regs into ymm*"

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T12:31:25+02:00 New Revision: ee11612ee10edd0d1f219c302f1a0abe0b46ddb3 URL: https://github.com/llvm/llvm-project/commit/ee11612ee10edd0d1f219c302f1a0abe0b46ddb3 DIFF: https://github.com/llvm/llvm-project/commit/ee11612ee10edd0d1f219c302f1a0abe0b46ddb3.diff

[Lldb-commits] [PATCH] D112061: [lldb] Remove ConstString from GetPluginNameStatic of some plugins

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath created this revision. labath added reviewers: teemperor, JDevlieghere. Herald added subscribers: sbc100, emaste. labath requested review of this revision. Herald added subscribers: MaskRay, aheejin. Herald added a project: LLDB. This patch deals with ObjectFile, ObjectContainer and Operati

[Lldb-commits] [lldb] 7dfb139 - [lldb] Adjust udt-layout.test after MS mangling change

2021-10-19 Thread Raphael Isemann via lldb-commits
Author: Raphael Isemann Date: 2021-10-19T12:43:24+02:00 New Revision: 7dfb1395549c34f4b607055c01f8c510ead6b0db URL: https://github.com/llvm/llvm-project/commit/7dfb1395549c34f4b607055c01f8c510ead6b0db DIFF: https://github.com/llvm/llvm-project/commit/7dfb1395549c34f4b607055c01f8c510ead6b0db.dif

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG39f2b059633e: [lldb] [Host] Make Terminal methods return llvm::Error (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [lldb] 39f2b05 - [lldb] [Host] Make Terminal methods return llvm::Error

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T13:31:03+02:00 New Revision: 39f2b059633ec1dc51b10b3fb48b616d87c273e3 URL: https://github.com/llvm/llvm-project/commit/39f2b059633ec1dc51b10b3fb48b616d87c273e3 DIFF: https://github.com/llvm/llvm-project/commit/39f2b059633ec1dc51b10b3fb48b616d87c273e3.diff

[Lldb-commits] [lldb] c6d7f24 - [lldb] [ABI/X86] Refactor ABIX86::AugmentRegisterInfo()

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T13:36:38+02:00 New Revision: c6d7f248bda3439a06c630c35360d40dbfc06abe URL: https://github.com/llvm/llvm-project/commit/c6d7f248bda3439a06c630c35360d40dbfc06abe DIFF: https://github.com/llvm/llvm-project/commit/c6d7f248bda3439a06c630c35360d40dbfc06abe.diff

[Lldb-commits] [PATCH] D112066: [lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. Herald added a subscriber: kristof.beyls. mgorny requested review of this revision. Fix incorrect values for value_regs, and incomplete values for invalidate_regs in RegisterInfos_arm. The value_regs ent

[Lldb-commits] [PATCH] D112066: [lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added a reviewer: omjavaid. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. rG7a8ba4ffbee fixed a similar problem on aarch64. CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [lldb] 1c2c67b - [lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T14:47:46+02:00 New Revision: 1c2c67b46b55a2a81ebc988c829e2eee13a4fec6 URL: https://github.com/llvm/llvm-project/commit/1c2c67b46b55a2a81ebc988c829e2eee13a4fec6 DIFF: https://github.com/llvm/llvm-project/commit/1c2c67b46b55a2a81ebc988c829e2eee13a4fec6.diff

[Lldb-commits] [PATCH] D112066: [lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1c2c67b46b55: [lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https:/

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

2021-10-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 380664. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files: lldb/examples/python/scripted_process/main.stack-dump lldb/examples/python/scripted_process/my_scripted_p

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

2021-10-19 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett created this revision. Herald added subscribers: kristof.beyls, mgorny. DavidSpickett requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This adds a specific unwind plan for AArch64 Linux sigreturn frames. Previously we assumed t

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

2021-10-19 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added a reviewer: omjavaid. DavidSpickett added inline comments. Herald added a subscriber: JDevlieghere. Comment at: lldb/source/Symbol/AArch64UnwindInfo.cpp:40 + // [1] + // https://github.com/torvalds/linux/blob/master/arch/arm64/kernel/signal.c + int32_t offs

[Lldb-commits] [lldb] 7df912c - Revert "[lldb] [Process/Utility] Fix value_regs/invalidate_regs for ARM"

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T15:33:39+02:00 New Revision: 7df912c65d1963c5403f1d645329b20f7e2d60ea URL: https://github.com/llvm/llvm-project/commit/7df912c65d1963c5403f1d645329b20f7e2d60ea DIFF: https://github.com/llvm/llvm-project/commit/7df912c65d1963c5403f1d645329b20f7e2d60ea.diff

[Lldb-commits] [lldb] 5cd28f7 - [lldb] [Process/Utility] clang-format RegisterInfos_arm.h

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T15:51:47+02:00 New Revision: 5cd28f71b1d96a4d4ed61e06751f52257da4df71 URL: https://github.com/llvm/llvm-project/commit/5cd28f71b1d96a4d4ed61e06751f52257da4df71 DIFF: https://github.com/llvm/llvm-project/commit/5cd28f71b1d96a4d4ed61e06751f52257da4df71.diff

[Lldb-commits] [lldb] 28e0c34 - [lldb] [Process/Utility] Define sN regs on ARM via helper macro

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T15:51:47+02:00 New Revision: 28e0c34216530087f62da66f3f19ce57211d8eed URL: https://github.com/llvm/llvm-project/commit/28e0c34216530087f62da66f3f19ce57211d8eed DIFF: https://github.com/llvm/llvm-project/commit/28e0c34216530087f62da66f3f19ce57211d8eed.diff

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

2021-10-19 Thread Pavel Kosov via Phabricator via lldb-commits
kpdev42 added a comment. In D110827#3059120 , @clayborg wrote: > In D110827#3042820 , @kpdev42 wrote: > >> In D110827#3034767 , @clayborg >> wrote: >> >>> LLDB also tests

[Lldb-commits] [lldb] b492b0b - [lldb] [Process/Utility] Define dN regs on ARM via helper macro

2021-10-19 Thread Michał Górny via lldb-commits
Author: Michał Górny Date: 2021-10-19T17:06:03+02:00 New Revision: b492b0be95d9134bfb092eb2c73cf6996c4518f7 URL: https://github.com/llvm/llvm-project/commit/b492b0be95d9134bfb092eb2c73cf6996c4518f7 DIFF: https://github.com/llvm/llvm-project/commit/b492b0be95d9134bfb092eb2c73cf6996c4518f7.diff

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

2021-10-19 Thread Shafik Yaghmour via Phabricator via lldb-commits
shafik added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:472 + InitializeFirstCodeAddress(*m_objfile_sp->GetModule()->GetSectionList()); + if (m_first_code_address == LLDB_INVALID_ADDRESS) +m_first_code_address = 0;

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

2021-10-19 Thread Nikolay Chokoev via Phabricator via lldb-commits
georgiev updated this revision to Diff 380714. georgiev added a comment. A new lldbutil function to test the breakpoint - check_breakpoint. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899 Files: lldb/packages/Python/lldbsuite/test/lldbutil.p

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:646 +bpno, +expected_locations = -1, +expected_hit_count = -1, `None` would be more pythonic Comment at: lldb/packages

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath updated this revision to Diff 380715. labath added a comment. Move the recursion into a helper function Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112058/new/ https://reviews.llvm.org/D112058 Files: lldb/source/Plugins/SymbolFile/DWARF

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

2021-10-19 Thread Pavel Labath via Phabricator via lldb-commits
labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:472 + InitializeFirstCodeAddress(*m_objfile_sp->GetModule()->GetSectionList()); + if (m_first_code_address == LLDB_INVALID_ADDRESS) +m_first_code_address = 0;

[Lldb-commits] [lldb] 1529738 - [debugserver] Fix BUILDING_FOR_ARM64_OSX

2021-10-19 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2021-10-19T09:55:53-07:00 New Revision: 1529738b6619cdf817feb31771b57a893accf63b URL: https://github.com/llvm/llvm-project/commit/1529738b6619cdf817feb31771b57a893accf63b DIFF: https://github.com/llvm/llvm-project/commit/1529738b6619cdf817feb31771b57a893accf63b.d

[Lldb-commits] [lldb] a66798c - Remove unneeded variable num_found.

2021-10-19 Thread Jim Ingham via lldb-commits
Author: Jim Ingham Date: 2021-10-19T09:57:07-07:00 New Revision: a66798cd67fedc35efbb8986deef417631bbc88a URL: https://github.com/llvm/llvm-project/commit/a66798cd67fedc35efbb8986deef417631bbc88a DIFF: https://github.com/llvm/llvm-project/commit/a66798cd67fedc35efbb8986deef417631bbc88a.diff LO

[Lldb-commits] [PATCH] D111030: [lldb] [Host] Add setters for common teletype properties to Terminal

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 380726. mgorny added a comment. Rebased to use `llvm::Error` return type. Moved `Parity` into `Terminal` class. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111030/new/ https://reviews.llvm.org/D111030 Files: lldb/include/lldb/Host/Terminal.h l

[Lldb-commits] [PATCH] D111355: [lldb] Add serial:// protocol for connecting to serial port

2021-10-19 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 380731. mgorny retitled this revision from "[lldb] Add serial:// protocol for connecting to serial port [WIP/PoC]" to "[lldb] Add serial:// protocol for connecting to serial port". mgorny added a comment. Move `serial://` URL parsing to `SerialPort` class. Im

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

2021-10-19 Thread Jim Ingham via Phabricator via lldb-commits
jingham added a comment. It looks like you missed one conversion. I agree with Pavel that None is not only more pythonic but also more lldbutils-y. Other than those nits, LGTM. Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:648 +expected_hit_count =

[Lldb-commits] [PATCH] D112058: [lldb/DWARF] Ignore debug info pointing to the low addresses

2021-10-19 Thread Greg Clayton via Phabricator via lldb-commits
clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Looks good. Do we need a follow up patch to avoid creating functions that should have been stripped? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llv

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

2021-10-19 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111965/new/ https://reviews.llvm.org/D111965 ___

[Lldb-commits] [lldb] 8ac5a66 - [lldb] improve the help strings for gdb-remote and kdp-remote

2021-10-19 Thread Lawrence D'Anna via lldb-commits
Author: Lawrence D'Anna Date: 2021-10-19T13:08:21-07:00 New Revision: 8ac5a6641fa4d742fb4599b485c40700e773f01f URL: https://github.com/llvm/llvm-project/commit/8ac5a6641fa4d742fb4599b485c40700e773f01f DIFF: https://github.com/llvm/llvm-project/commit/8ac5a6641fa4d742fb4599b485c40700e773f01f.dif

[Lldb-commits] [PATCH] D111965: [lldb] improve the help strings for gdb-remote and kdp-remote

2021-10-19 Thread Lawrence D'Anna via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG8ac5a6641fa4: [lldb] improve the help strings for gdb-remote and kdp-remote (authored by lawrence_danna). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11196

[Lldb-commits] [lldb] 5e004b0 - [lldb/test] Update test/API/functionalities/load_lazy to macOS 12

2021-10-19 Thread Vedant Kumar via lldb-commits
Author: Vedant Kumar Date: 2021-10-19T13:25:14-07:00 New Revision: 5e004b03f72a17f916b93792eb778dfa9e7a09cc URL: https://github.com/llvm/llvm-project/commit/5e004b03f72a17f916b93792eb778dfa9e7a09cc DIFF: https://github.com/llvm/llvm-project/commit/5e004b03f72a17f916b93792eb778dfa9e7a09cc.diff

[Lldb-commits] [PATCH] D112034: [lldb/test] Update test/API/functionalities/load_lazy to macOS 12

2021-10-19 Thread Vedant Kumar via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG5e004b03f72a: [lldb/test] Update test/API/functionalities/load_lazy to macOS 12 (authored by vsk). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D112107: [lldb/Plugins] Make `ScriptedInterface::CreatePluginObject` more generic

2021-10-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch refactors the `ScriptedInterface::CreatePluginObject` method and all its virtual implementations to use a `Structured

[Lldb-commits] [PATCH] D112109: [lldb/Plugins] Serialize ProcessLaunchInfo ScriptedProcess Dictionary

2021-10-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch replaces the type of the ProcessLaunchInfo ScriptedProcess Dictionary from a StructuredData pointer to be serialized

[Lldb-commits] [PATCH] D112046: [lldb/bindings] Change ScriptedThread initializer parameters

2021-10-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 380818. mib added a comment. Update after rebase. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112046/new/ https://reviews.llvm.org/D112046 Files: lldb/bindings/python/python-wrapper.swig lldb/examples/python

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

2021-10-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 380819. mib added a comment. Fix test. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files: lldb/examples/python/scripted_process/main.stack-dump lldb/examples/pyth

[Lldb-commits] [PATCH] D112045: [lldb/API] Fix SBLaunchInfo::SetScriptedProcessDictionary

2021-10-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib abandoned this revision. mib added a comment. I'm abandoning this revision in favor of D112109 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112045/new/ https://reviews.llvm.org/D112045

[Lldb-commits] [PATCH] D112047: [lldb/test] Update TestScriptedProcess to use skinny corefiles

2021-10-19 Thread Med Ismail Bennani via Phabricator via lldb-commits
mib updated this revision to Diff 380825. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112047/new/ https://reviews.llvm.org/D112047 Files: lldb/examples/python/scripted_process/main.stack-dump lldb/examples/python/scripted_process/my_scripted_process.py lldb/examples/python/script

[Lldb-commits] [lldb] 320f65e - [LLDB][NFC] Remove parameter names from forward declarations from hand written expressions used in heap.py part 2

2021-10-19 Thread Shafik Yaghmour via lldb-commits
Author: Shafik Yaghmour Date: 2021-10-19T16:52:36-07:00 New Revision: 320f65ee65f40fadbd2016036e538e28ae28614c URL: https://github.com/llvm/llvm-project/commit/320f65ee65f40fadbd2016036e538e28ae28614c DIFF: https://github.com/llvm/llvm-project/commit/320f65ee65f40fadbd2016036e538e28ae28614c.dif