[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

labath added a comment. Thanks for doing this. Just a couple of small remarks. Comment at: lldb/source/Plugins/Language/CPlusPlus/CxxStringTypes.cpp:35 -bool lldb_private::formatters::Char8StringSummaryProvider( -ValueObject &valobj, Stream &stream, const TypeSummaryOptio

[Lldb-commits] [PATCH] D112629: [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Host/common/Socket.cpp:198-199 } else { // If this was unsuccessful, then check if it's simply a signed 32-bit // integer, representi

[Lldb-commits] [PATCH] D112691: Include target settings in "statistics dump" output.

clayborg created this revision. clayborg added reviewers: wallace, aadsm, jingham, JDevlieghere. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Many target settings can be set that can affect how breakpoints are found during a de

[Lldb-commits] [PATCH] D112683: Add unix signal hit counts to the target statistics.

This revision was automatically updated to reflect the committed changes. Closed by commit rG130055647922: Add unix signal hit counts to the target statistics. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112683/new/ https:/

[Lldb-commits] [lldb] 1300556 - Add unix signal hit counts to the target statistics.

Author: Greg Clayton Date: 2021-10-27T22:31:14-07:00 New Revision: 130055647922ffa9dd9abd5a838727773f73c48a URL: https://github.com/llvm/llvm-project/commit/130055647922ffa9dd9abd5a838727773f73c48a DIFF: https://github.com/llvm/llvm-project/commit/130055647922ffa9dd9abd5a838727773f73c48a.diff

[Lldb-commits] [PATCH] D112683: Add unix signal hit counts to the target statistics.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. great! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112683/new/ https://reviews.llvm.org/D112683 ___

[Lldb-commits] [PATCH] D112683: Add unix signal hit counts to the target statistics.

clayborg created this revision. clayborg added reviewers: JDevlieghere, jingham, wallace, aadsm. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Android and other platforms make wide use of signals when running applications and th

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

jingham added a comment. In D112587#3092125 , @clayborg wrote: > In D112587#3092120 , @jingham wrote: > >> Note, the breakpoint serialization for breakpoints only serializes the >> filter/resolver and the breakpo

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg added a comment. In D112587#3092120 , @jingham wrote: > Note, the breakpoint serialization for breakpoints only serializes the > filter/resolver and the breakpoint specific options. It doesn't do anything > with locations or their options. Af

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

jingham added a comment. Note, the breakpoint serialization for breakpoints only serializes the filter/resolver and the breakpoint specific options. It doesn't do anything with locations or their options. After all, you when you go to reset a breakpoint in another session (which is what this

[Lldb-commits] [PATCH] D105470: [lldb] Clear children of ValueObject on value update

jingham added a comment. In D105470#2868858 , @werat wrote: > Thanks for the explanation! But at this point I feel I'm a bit confused about > how it all _supposed_ to work in the current design :) Apparently I lost track of this review... > If I unders

[Lldb-commits] [PATCH] D112677: Remove unused ValueObjectDynamicValue::SetOwningSP & backing ivar

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. I am sure you have checked the Swift codebase as well for any uses. If so LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112677/new/ ht

[Lldb-commits] [PATCH] D112677: Remove unused ValueObjectDynamicValue::SetOwningSP & backing ivar

jingham created this revision. jingham added reviewers: JDevlieghere, mib. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This owning_sp has no uses and the ValueObjectDynamicValue already tracks its ownership through the parent it

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

This revision was automatically updated to reflect the committed changes. Closed by commit rGfb2549683260: Add breakpoint resolving stats to each target. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://revie

[Lldb-commits] [lldb] fb25496 - Add breakpoint resolving stats to each target.

Author: Greg Clayton Date: 2021-10-27T16:50:11-07:00 New Revision: fb2549683260b137f1bd62a5145ddff6d2403e64 URL: https://github.com/llvm/llvm-project/commit/fb2549683260b137f1bd62a5145ddff6d2403e64 DIFF: https://github.com/llvm/llvm-project/commit/fb2549683260b137f1bd62a5145ddff6d2403e64.diff

[Lldb-commits] [PATCH] D112676: [lldb] The os and version are not separate components in the triple

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rG2c350730ca8b: [lldb] The os and version are not separate components in the triple (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG

[Lldb-commits] [lldb] 2c35073 - [lldb] The os and version are not separate components in the triple

Author: Jonas Devlieghere Date: 2021-10-27T16:40:20-07:00 New Revision: 2c350730ca8b75727188139f033a7bd60d9383c7 URL: https://github.com/llvm/llvm-project/commit/2c350730ca8b75727188139f033a7bd60d9383c7 DIFF: https://github.com/llvm/llvm-project/commit/2c350730ca8b75727188139f033a7bd60d9383c7.d

[Lldb-commits] [PATCH] D112676: [lldb] The os and version are not separate components in the triple

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:62 +component = [arch, vendor, os + version] +if env: +components.append(env) aprantl wrote: > So

[Lldb-commits] [PATCH] D112676: [lldb] The os and version are not separate components in the triple

aprantl added a comment. thanks! Comment at: lldb/packages/Python/lldbsuite/test/builders/darwin.py:62 +component = [arch, vendor, os + version] +if env: +components.append(env) So this tests for the empty string? CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. sounds good to me! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112587/new/ https://reviews.llvm.org/D112587 ___

[Lldb-commits] [PATCH] D112676: [lldb] The os and version are not separate components in the triple

JDevlieghere updated this revision to Diff 382851. JDevlieghere added a comment. Skip the environment if it's empty and avoid a TypeError when concatenating 'NoneType' and 'str'. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112676/new/ https://reviews.llvm.org/D112676 Files: lldb/p

[Lldb-commits] [PATCH] D112676: [lldb] The os and version are not separate components in the triple

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. Yup that's wrong. Personally I would only append env to the list if non-empty. Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112676/new/ https://reviews.llvm.org/D112676 _

[Lldb-commits] [PATCH] D112676: [lldb] The os and version are not separate components in the triple

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. JDevlieghere requested review of this revision. Create a valid triple in the Darwin builder. Currently it was incorrectly treating the os and version as two separate components in the triple. https://reviews.llvm.org/D11

[Lldb-commits] [lldb] a0c1e75 - [lldb] Skip TestCCallingConventions.test_ms_abi on arm64

Author: Jonas Devlieghere Date: 2021-10-27T16:08:14-07:00 New Revision: a0c1e7571fe4f61d0f976bff3cdc50d1c2a578a6 URL: https://github.com/llvm/llvm-project/commit/a0c1e7571fe4f61d0f976bff3cdc50d1c2a578a6 DIFF: https://github.com/llvm/llvm-project/commit/a0c1e7571fe4f61d0f976bff3cdc50d1c2a578a6.d

[Lldb-commits] [PATCH] D112495: [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

mib added a comment. Build run #37166 (https://green.lab.llvm.org/green/job/lldb-cmake/37166/) confirms that this patch caused the failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112495/new/ https://reviews.llvm.org/D112495 ___

[Lldb-commits] [PATCH] D112495: [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

mib added a comment. Looking at the test backtrace, it seems that we couldn't connect to debugserver: File "/Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/lldb/test/API/commands/platform/sdk/TestPlatformSDK.py", line 113, in test_macos_sdk self.assertTrue(connected, "could no

[Lldb-commits] [lldb] 8dbbe33 - Revert "[lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse"

Author: Med Ismail Bennani Date: 2021-10-27T23:57:33+02:00 New Revision: 8dbbe3356b0bda56c7d21e5a3b07d7bfe601bc22 URL: https://github.com/llvm/llvm-project/commit/8dbbe3356b0bda56c7d21e5a3b07d7bfe601bc22 DIFF: https://github.com/llvm/llvm-project/commit/8dbbe3356b0bda56c7d21e5a3b07d7bfe601bc22.

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

clayborg added a comment. Looks good to me, but the expression parser isn't my main area of expertise. I would like to see someone with more knowledge in the expression parser to make the final ok. Raphael? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg added inline comments. Comment at: lldb/source/Breakpoint/Breakpoint.cpp:1120 +else + llvm::consumeError(expected_value.takeError()); + } wallace wrote: > err, i'm not a fan of this. Why don't you just make this return an expected > and make t

[Lldb-commits] [lldb] 8bac9e3 - [lldb] Fixup code addresses in the Objective-C language runtime

Author: Jonas Devlieghere Date: 2021-10-27T14:48:03-07:00 New Revision: 8bac9e3686e05916db88dab29b3c7fee70090d81 URL: https://github.com/llvm/llvm-project/commit/8bac9e3686e05916db88dab29b3c7fee70090d81 DIFF: https://github.com/llvm/llvm-project/commit/8bac9e3686e05916db88dab29b3c7fee70090d81.d

[Lldb-commits] [PATCH] D112662: [lldb] Fixup code addresses in the Objective-C language runtime

This revision was automatically updated to reflect the committed changes. Closed by commit rG8bac9e3686e0: [lldb] Fixup code addresses in the Objective-C language runtime (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D112587: Add breakpoint resolving stats to each target.

clayborg updated this revision to Diff 382803. clayborg added a comment. Changes in this version: - If we fail to get "details" from the structured data, we put the error string into the "details" dictionary with the error string. - Added "numLocations" (int64_t) and "numResolvedLocations" (int6

[Lldb-commits] [PATCH] D112662: [lldb] Fixup code addresses in the Objective-C language runtime

JDevlieghere updated this revision to Diff 382795. JDevlieghere marked an inline comment as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112662/new/ https://reviews.llvm.org/D112662 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCClassDescriptorV2.cpp

[Lldb-commits] [PATCH] D112662: [lldb] Fixup code addresses in the Objective-C language runtime

aprantl accepted this revision. aprantl added a comment. This revision is now accepted and ready to land. This is all good of course, but I wonder if we should lift this into the type system and have functions returned a UnstrippedAddress type that you can only turn into an addr_t by calling Fix

[Lldb-commits] [PATCH] D112662: [lldb] Fixup code addresses in the Objective-C language runtime

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jasonmolenda. JDevlieghere requested review of this revision. Upstream the calls to ABI::FixCodeAddress in the Objective-C language runtime. https://reviews.llvm.org/D112662 Files: lldb/source/Plugins/LanguageRuntime/

[Lldb-commits] [PATCH] D112658: [lldb] Refactor C/C++ string and char summary providers

ljmf00 created this revision. ljmf00 added projects: LLDB, LLVM. Herald added a subscriber: JDevlieghere. ljmf00 requested review of this revision. Herald added a subscriber: lldb-commits. Signed-off-by: Luís Ferreira This patch refactors C/C++ formatters to avoid repetitive code. Repository

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG3eb9e6536a6a: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs (authored by danilashtefan, committed by Walter Erquinig

[Lldb-commits] [lldb] 3eb9e65 - [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

Author: Danil Stefaniuc Date: 2021-10-27T11:55:11-07:00 New Revision: 3eb9e6536a6a40f116655240b264292efabdc928 URL: https://github.com/llvm/llvm-project/commit/3eb9e6536a6a40f116655240b264292efabdc928 DIFF: https://github.com/llvm/llvm-project/commit/3eb9e6536a6a40f116655240b264292efabdc928.dif

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382734. danilashtefan added a comment. Last thing corrected :) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [PATCH] D112564: [lldb] Add support for custom char8_t types with different name

ljmf00 added a comment. In D112564#3089399 , @labath wrote: > What exactly do you need the test to do? Is printing a global variable > (`char8_t_ish foo[] = "my string"`) sufficient? > If so, you can take a look at the tests in `test/Shell/SymbolFile/DWA

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace accepted this revision. wallace added a comment. This revision is now accepted and ready to land. Just fix that last thing and I'll land your patch :) Thanks Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:318 -class StdMapSynthProvider: +class StdSetOrMapSynthPr

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382729. danilashtefan added a comment. Refactoring Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/sour

[Lldb-commits] [PATCH] D112495: [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

mib added a comment. Herald added a subscriber: JDevlieghere. This patch broke `TestPlatformSDK.py` on GreenDragon (https://green.lab.llvm.org/green/job/lldb-cmake/37156/) Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112495/new/ https://reviews.l

[Lldb-commits] [PATCH] D112632: [lldb] [Host/Terminal] Add llvm_unreachable() to appease Windows

mgorny created this revision. mgorny added reviewers: labath, emaste, teemperor, krytarowski, thakis. mgorny requested review of this revision. https://reviews.llvm.org/D112632 Files: lldb/source/Host/common/Terminal.cpp Index: lldb/source/Host/common/Terminal.cpp

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py:45 "[3] = 3", "[6] = 6"]) danilashtefan wrote: > wallace wrote: > > can you

[Lldb-commits] [PATCH] D112629: [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct

mgorny updated this revision to Diff 382698. mgorny added a comment. Fix missing return in `operator<<`. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112629/new/ https://reviews.llvm.org/D112629 Files: lldb/include/lldb/Host/Socket.h lldb/source/Host/common/Socket.cpp lldb/sourc

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

mgorny added a comment. In D111890#3090632 , @thakis wrote: > This causes lots of warnings on Windows, where TERMIOS is false: > http://45.33.8.238/win/47744/step_4.txt (look for "Terminal.cpp"). Could you > take a look? It looks like return statements

[Lldb-commits] [PATCH] D111890: [lldb] [Host] Make Terminal methods return llvm::Error

thakis added a comment. Herald added a subscriber: JDevlieghere. This causes lots of warnings on Windows, where TERMIOS is false: http://45.33.8.238/win/47744/step_4.txt (look for "Terminal.cpp"). Could you take a look? It looks like return statements are genuinely missing there. Repository:

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. pretty good! Just some cosmetic changes needed and that's it Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:318 -class StdMapSynthProvider: +class StdSetO

[Lldb-commits] [PATCH] D112629: [lldb] [Host/Socket] Make DecodeHostAndPort() return a dedicated struct

mgorny created this revision. mgorny added reviewers: labath, teemperor, krytarowski, emaste. mgorny requested review of this revision. https://reviews.llvm.org/D112629 Files: lldb/include/lldb/Host/Socket.h lldb/source/Host/common/Socket.cpp lldb/source/Host/common/TCPSocket.cpp lldb/sou

[Lldb-commits] [lldb] 9d7006c - [lldb][NFC] Move a declaration in DWARFASTParserClang to its first use.

Author: Raphael Isemann Date: 2021-10-27T17:46:50+02:00 New Revision: 9d7006c4aee693a4c09f18cecd244da919ebe13b URL: https://github.com/llvm/llvm-project/commit/9d7006c4aee693a4c09f18cecd244da919ebe13b DIFF: https://github.com/llvm/llvm-project/commit/9d7006c4aee693a4c09f18cecd244da919ebe13b.dif

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382668. danilashtefan added a comment. Small formatting Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/data-formatter-stl/generic/set/TestDataFormatterGenericSet.py:45 "[3] = 3", "[6] = 6"]) wallace wrote: > can you add additional asse

[Lldb-commits] [PATCH] D112537: [formatters] Add a libstdcpp formatter for set and unify tests across stdlibs

danilashtefan updated this revision to Diff 382665. danilashtefan edited the summary of this revision. danilashtefan added a comment. Update Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112537/new/ https://reviews.llvm.org/D112537 Files: lldb/e

[Lldb-commits] [lldb] 99f5f0a - fix comment typos to cycle bots

Author: Nico Weber Date: 2021-10-27T09:43:42-04:00 New Revision: 99f5f0a2b72bfaf0bfb527466fdd50748583559f URL: https://github.com/llvm/llvm-project/commit/99f5f0a2b72bfaf0bfb527466fdd50748583559f DIFF: https://github.com/llvm/llvm-project/commit/99f5f0a2b72bfaf0bfb527466fdd50748583559f.diff LO

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 added a comment. Ping Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110827/new/ https://reviews.llvm.org/D110827 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/c

[Lldb-commits] [PATCH] D112612: [lldb] [docs] Remove obsolete recommonmark use

This revision was automatically updated to reflect the committed changes. Closed by commit rGd03b04f211e7: [lldb] [docs] Remove obsolete recommonmark use (authored by mgorny). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [lldb] d03b04f - [lldb] [docs] Remove obsolete recommonmark use

Author: Michał Górny Date: 2021-10-27T13:45:05+02:00 New Revision: d03b04f211e73c2f59ba5dc6a6a8c777de001ad6 URL: https://github.com/llvm/llvm-project/commit/d03b04f211e73c2f59ba5dc6a6a8c777de001ad6 DIFF: https://github.com/llvm/llvm-project/commit/d03b04f211e73c2f59ba5dc6a6a8c777de001ad6.diff

[Lldb-commits] [PATCH] D112612: [lldb] [docs] Remove obsolete recommonmark use

mgorny created this revision. mgorny added reviewers: labath, teemperor. mgorny requested review of this revision. The recommonmark package is no longer required since all the documents have been converted to .rst. Remove the related support code from docs/conf.py. https://reviews.llvm.org/D112

[Lldb-commits] [lldb] 560221a - [lldb] Modernize TestVLA.py

Author: Pavel Labath Date: 2021-10-27T12:47:56+02:00 New Revision: 560221ac7f5ca3d5dcae405587db066f4c4c8a7c URL: https://github.com/llvm/llvm-project/commit/560221ac7f5ca3d5dcae405587db066f4c4c8a7c DIFF: https://github.com/llvm/llvm-project/commit/560221ac7f5ca3d5dcae405587db066f4c4c8a7c.diff

[Lldb-commits] [PATCH] D112495: [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGe1acadb61dfc: [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse (authored by mgorny). Herald added a project: LLDB. Repository:

[Lldb-commits] [lldb] e1acadb - [lldb] [Host/ConnectionFileDescriptor] Refactor to improve code reuse

Author: Michał Górny Date: 2021-10-27T12:45:52+02:00 New Revision: e1acadb61dfc0810656219c6314019d5132f2c61 URL: https://github.com/llvm/llvm-project/commit/e1acadb61dfc0810656219c6314019d5132f2c61 DIFF: https://github.com/llvm/llvm-project/commit/e1acadb61dfc0810656219c6314019d5132f2c61.diff

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. > One way to demonstrate (and test) this would be to have a bit of inline asm, > which sets all registers to known values, and then raises a signal (SIGILL is > probably the easiest to raise from asm). I will give that a go, probably as a separate test case. Rep

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382591. DavidSpickett added a comment. Update comment. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069 Files: lldb/include/lldb/Target/Platform.h lldb/sourc

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382590. DavidSpickett added a comment. Use generic register names and don't set type to DWARF. Pass triple instead of machine and use isAArch64. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

labath added a comment. Since the signal context contains a copy of all registers, maybe you should be setting all of them. The other registers will not be used for unwinding, but they will enable to user to inspect the registers in the stack frames above the signal handler. One way to demonstr

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett added a comment. > Thanks for doing this. Just a couple of comments inline. Will respond to these shortly. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112069/new/ https://reviews.llvm.org/D112069 __

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

DavidSpickett updated this revision to Diff 382575. DavidSpickett added a comment. Turns out comparing thread.get_thread_frames() doesn't work because you end up getting references to the same frames. Instead save the info we want to compare. One obvious reason this tactic should have failed is t

[Lldb-commits] [lldb] f5158ca - Modernize Platform::GetOSKernelDescription

Author: Pavel Labath Date: 2021-10-27T10:46:47+02:00 New Revision: f5158ca48c260dd29136ab19ba8573226f087fb3 URL: https://github.com/llvm/llvm-project/commit/f5158ca48c260dd29136ab19ba8573226f087fb3 DIFF: https://github.com/llvm/llvm-project/commit/f5158ca48c260dd29136ab19ba8573226f087fb3.diff

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

labath added inline comments. Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:295 + unwind_plan_sp->SetUnwindPlanForSignalTrap(eLazyBoolYes); + unwind_plan_sp->SetRegisterKind(eRegisterKindDWARF); + Ah now I see that it worked because of this.

[Lldb-commits] [PATCH] D112069: [lldb][AArch64] Add UnwindPlan for Linux sigreturn

labath added a comment. Thanks for doing this. Just a couple of comments inline. Comment at: lldb/source/Plugins/Platform/Linux/PlatformLinux.cpp:288 + + unwind_plan_sp = std::make_shared(eRegisterKindGeneric); + unwind_plan_sp->AppendRow(row); I have a feeli