[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGdfd499a61c45: [lldb][NFC] avoid unnecessary roundtrips between different string types (authored by xujuntwt95329, committed by Walter Erquinigo

[Lldb-commits] [lldb] dfd499a - [lldb][NFC] avoid unnecessary roundtrips between different string types

Author: Xu Jun Date: 2021-11-01T22:15:01-07:00 New Revision: dfd499a61c45778b7f01458d50ccc384343f53d5 URL: https://github.com/llvm/llvm-project/commit/dfd499a61c45778b7f01458d50ccc384343f53d5 DIFF: https://github.com/llvm/llvm-project/commit/dfd499a61c45778b7f01458d50ccc384343f53d5.diff LOG:

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 added a comment. @wallace rebased But I guess you should apply this patch firstly? https://reviews.llvm.org/D112439 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

This revision was automatically updated to reflect the committed changes. Closed by commit rGfe19ae352ce2: normalize file path when searching the source map (authored by xujuntwt95329, committed by Walter Erquinigo wall...@fb.com). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] fe19ae3 - normalize file path when searching the source map

Author: Xu Jun Date: 2021-11-01T22:13:55-07:00 New Revision: fe19ae352ce201e7bab8baac4587cc4334e742e4 URL: https://github.com/llvm/llvm-project/commit/fe19ae352ce201e7bab8baac4587cc4334e742e4 DIFF: https://github.com/llvm/llvm-project/commit/fe19ae352ce201e7bab8baac4587cc4334e742e4.diff LOG:

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

xujuntwt95329 updated this revision to Diff 383965. xujuntwt95329 added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 Files: lldb/include/lldb/Target/PathMappingList.h

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

wallace added a comment. could you rebase this on top of the main branch? I tried to 'arc patch' it locally and there are a few merge issues. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna added a comment. In D112973#3101602 , @JDevlieghere wrote: > FWIW `crashlog.py` has a good example of how to import LLDB. It's complicated > slightly by us having to honor the `LLDB_DEFAULT_PYTHON_VERSION`, but > otherwise it's pretty

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

jingham added a comment. But I do agree with Jonas that we should find a less python-specific way to implement this. I don't think you need to actually fill in the Lua parts, but whoever does that shouldn't have to copy everything that was done for python, a lot of this should be shareable.

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

jingham added a comment. In D112973#3101602 , @JDevlieghere wrote: > I feel like this puts too much Python specific logic in the driver compared > to the convenience it brings. Even though we already leak python details > (like `--python-path`), LLDB

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

jingham added a comment. Since you do need to match the lldb module to the python it was built against, this seems a useful addition. The original --python-path was a bit unfortunate, we're supposed to be able to support multiple scripting interpreters (currently python & lua) and it would be

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

JDevlieghere added a comment. I feel like this puts too much Python specific logic in the driver compared to the convenience it brings. Even though we already leak python details (like `--python-path`), LLDB has always been designed to support several scripting languages. I'm not convinced

[Lldb-commits] [PATCH] D112973: [lldb] make it easier to find LLDB's python

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added subscribers: dang, mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. It is surprisingly difficult to write a simple python script that can

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna created this revision. lawrence_danna added reviewers: jasonmolenda, JDevlieghere, jingham. Herald added a subscriber: mgorny. lawrence_danna requested review of this revision. Herald added a project: LLDB. LLDB doesn't use only the python stable ABI, which means loading it into an

[Lldb-commits] [PATCH] D112439: normalize file path when searching the source map

aprantl accepted this revision. aprantl added a comment. In D112439#3098307 , @xujuntwt95329 wrote: > Hi, @aprantl > > I've submitted a NFC patch here: > https://reviews.llvm.org/D112863 > > Seems that patch can't build by CI because it is based on this

[Lldb-commits] [PATCH] D112863: [lldb][NFC] avoid unnecessary roundtrips between different string types

aprantl accepted this revision. aprantl added a comment. Thank you! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112863/new/ https://reviews.llvm.org/D112863 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; clayborg wrote: > are we guaranteed to get some debug info with line zero

[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

aprantl added inline comments. Comment at: lldb/test/Shell/ObjC/tagged_pointer_info.test:3 + +RUN: %clang_host -g -framework Foundation -o %t.out %S/Inputs/test.m + personal opinion without through reasoning behind it: This feels more like an API test to me.

[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

aprantl added a comment. This is great, thanks! (one question inline) Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:1008 } - result.SetStatus(lldb::eReturnStatusSuccessFinishResult); - return true; + success

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

clayborg added inline comments. Comment at: lldb/test/Shell/Commands/command-disassemble-mixed.c:11-18 +int main(int argc, char **argv) +{ + int i; + + for (i=0; i < 10; ++i) ; + + return 0; are we guaranteed to get some debug info with line zero in it with

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

clayborg added a comment. LGTM. This is in Jason's function so I will let him give the final ok. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112931/new/ https://reviews.llvm.org/D112931 ___

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

dblaikie added a comment. In D112165#3100608 , @teemperor wrote: > Small note: gmodules test are never run on Linux, so you actually have to run > them on macOS (or I think FreeBSD) to know whether the tests work. Yeah, I'll admit I didn't test this,

[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

JDevlieghere updated this revision to Diff 383851. JDevlieghere added a comment. Add test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112945/new/ https://reviews.llvm.org/D112945 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [PATCH] D112945: [lldb] Improve error reporting in `lang objc tagged-pointer info`

JDevlieghere created this revision. JDevlieghere added a reviewer: aprantl. JDevlieghere requested review of this revision. Improve error handling for the `lang objc tagged-pointer info`. Rather than failing silently, report an error if we couldn't convert an argument to an address or resolve

[Lldb-commits] [lldb] ac7c880 - [lldb][gmodules] Fix TestDataFormatterCpp with gmodules on macOS

Author: Raphael Isemann Date: 2021-11-01T18:44:32+01:00 New Revision: ac7c8808ba89fb6188d5b1bb83bdd08e5c39d71e URL: https://github.com/llvm/llvm-project/commit/ac7c8808ba89fb6188d5b1bb83bdd08e5c39d71e DIFF:

[Lldb-commits] [lldb] 68bb4e1 - [lldb][NFC] Inclusive Language: Replace master with main

Author: Quinn Pham Date: 2021-11-01T12:25:41-05:00 New Revision: 68bb4e16482b765148993cbb912f5be1b01d5b57 URL: https://github.com/llvm/llvm-project/commit/68bb4e16482b765148993cbb912f5be1b01d5b57 DIFF: https://github.com/llvm/llvm-project/commit/68bb4e16482b765148993cbb912f5be1b01d5b57.diff

[Lldb-commits] [PATCH] D112165: Cleanup a few more PR36048 skips

teemperor added a comment. Small note: gmodules test are never run on Linux, so you actually have to run them on macOS (or I think FreeBSD) to know whether the tests work. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112165/new/

[Lldb-commits] [PATCH] D112856: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message.

This revision was automatically updated to reflect the committed changes. Closed by commit rG64cc073abd59: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message. (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 64cc073 - [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message.

Author: Jonas Devlieghere Date: 2021-11-01T09:39:24-07:00 New Revision: 64cc073abd59d7ac2359d258f407254de6c79c84 URL: https://github.com/llvm/llvm-project/commit/64cc073abd59d7ac2359d258f407254de6c79c84 DIFF:

[Lldb-commits] [PATCH] D112834: [lldb-vscode] Fix coredump load source mapping for first file

This revision was automatically updated to reflect the committed changes. Closed by commit rG1c05c52de217: [lldb-vscode] Fix coredump load source mapping for first file (authored by ted). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112834/new/

[Lldb-commits] [lldb] 1c05c52 - [lldb-vscode] Fix coredump load source mapping for first file

Author: Ted Woodward Date: 2021-11-01T10:47:42-05:00 New Revision: 1c05c52de2177a328b7d2d07b697af67eb9f8122 URL: https://github.com/llvm/llvm-project/commit/1c05c52de2177a328b7d2d07b697af67eb9f8122 DIFF: https://github.com/llvm/llvm-project/commit/1c05c52de2177a328b7d2d07b697af67eb9f8122.diff

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted updated this revision to Diff 383810. ted added a comment. Fix test to exit lldb Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112931/new/ https://reviews.llvm.org/D112931 Files: lldb/source/Core/Disassembler.cpp

[Lldb-commits] [PATCH] D112931: Fix mixed disassembly showing source lines for "line 0"

ted created this revision. ted requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. "line 0" in a DWARF linetable means something that doesn't have associated source. The code for mixed disassembly has a comment indicating that "line 0" should

[Lldb-commits] [lldb] 9e0a39f - [lldb] Add a test for class loading via member typedefs

Author: Raphael Isemann Date: 2021-11-01T15:58:45+01:00 New Revision: 9e0a39f3787ac055631891be9062dcd561cf4501 URL: https://github.com/llvm/llvm-project/commit/9e0a39f3787ac055631891be9062dcd561cf4501 DIFF:

[Lldb-commits] [PATCH] D112856: [lldb] Only specify LLVM_ENABLE_RUNTIMES in the libcxx error message.

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112856/new/ https://reviews.llvm.org/D112856 ___ lldb-commits mailing list