[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

labath added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:558 +struct CompatibleArchs { + const char **archs = nullptr; Is this any different from an `ArrayRef`? Comment at: lldb/source/Plugins/Platform

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Nice cleanup of this table that's been growing over the years. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113155/new/ https://reviews.llvm.org/D113155

[Lldb-commits] [PATCH] D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

jasonmolenda accepted this revision. jasonmolenda added a comment. This revision is now accepted and ready to land. Yep, looks good, we can't hardcode the OS in this triple, we might be getting iOS or macOS binaries and should accept any OS these days. CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [lldb] 553a872 - [LLDB] Adjust DumpDataExtractorTest.Formats for Windows

Author: Muhammad Omair Javaid Date: 2021-11-04T08:48:26+05:00 New Revision: 553a87246510632b60d8d87913d8e4d5ddc86529 URL: https://github.com/llvm/llvm-project/commit/553a87246510632b60d8d87913d8e4d5ddc86529 DIFF: https://github.com/llvm/llvm-project/commit/553a87246510632b60d8d87913d8e4d5ddc865

[Lldb-commits] [PATCH] D113165: [LIT] Add win32 PLATFORM env var to test config

omjavaid created this revision. omjavaid added reviewers: zturner, mstorsjo. Herald added subscribers: pengfei, delcypher, kristof.beyls. omjavaid requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. LIT skips various system environment variable

[Lldb-commits] [PATCH] D113163: [LLDB][Breakpad] Create a function for each compilation unit.

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. Since every FUNC record (in breakpad) is a compilation unit, creating t

[Lldb-commits] [PATCH] D113159: [lldb] Don't set the OS for ARMGetSupportedArchitectureAtIndex

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jasonmolenda. Herald added subscribers: arphaman, kristof.beyls. JDevlieghere requested review of this revision. Don't set the OS when computing supported architectures in PlatformDarwin::ARMGetSupportedArchitectureAtIndex.

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.cpp:573 +static const char *g_arm64_compatible_archs[] = { +"arm64","armv7","armv7f", "armv7k", "armv7s", "armv7m", +"armv7em", "armv6m", "armv6

[Lldb-commits] [PATCH] D113155: [lldb] Remove nested switches from ARMGetSupportedArchitectureAtIndex (NFC)

JDevlieghere created this revision. JDevlieghere added reviewers: friss, jasonmolenda. Herald added subscribers: arphaman, kristof.beyls. JDevlieghere requested review of this revision. Remove the nested switches from the ARMGetSupportedArchitectureAtIndex implementation. I considered a few alter

[Lldb-commits] [lldb] f9e6be5 - [lldb] Update tagged pointer command output and test.

Author: Jonas Devlieghere Date: 2021-11-03T15:04:36-07:00 New Revision: f9e6be5cc1a2cfe5294d4d55336b23266fcfc26f URL: https://github.com/llvm/llvm-project/commit/f9e6be5cc1a2cfe5294d4d55336b23266fcfc26f DIFF: https://github.com/llvm/llvm-project/commit/f9e6be5cc1a2cfe5294d4d55336b23266fcfc26f.d

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

lawrence_danna added a comment. In D113047#3106732 , @stella.stamenova wrote: > The Windows buildbot is still broken after this change: > > https://lab.llvm.org/buildbot/#/builders/83/builds/11630 sorry again :/ I will fix. It's takaing me a alittle

[Lldb-commits] [PATCH] D113047: [lldb] update TestEchoCommands

stella.stamenova added a comment. The Windows buildbot is still broken after this change: https://lab.llvm.org/buildbot/#/builders/83/builds/11630 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113047/new/ https://reviews.llvm.org/D113047

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jingham added a comment. So probably the only safe thing to do is to ensure if the command doesn't specify a target in the execution context, we pick the currently selected one. IIUC, that's the proposal here, so I think this is all good. But we want to be careful not to allow implicit behavi

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jingham added a comment. This needs some more design, I think. The obvious solution to Ted's problem is that `target create` should make the new target the currently selected one. Then the second HandleCommand would have a selected target, and the second command would work. But that doesn't

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

jingham added a comment. I think we should make simple cases like this work for sure. But OTOH, if you are writing a script that you might use anywhere non-trivial, SBCommandInterpreter.HandleCommand(char *, SBError) is NOT a safe thing to call. You could be in an lldb session with more than

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

labath added a comment. In D113098#3105906 , @ljmf00 wrote: > In D113098#3105809 , @labath wrote: > >> bug reported in PR45856. > > Thanks for your time fixing this. So, for better understanding, does the > infra

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett added a comment. > Looks like this breaks the build on Windows Should be fixed now. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 ___ lldb-comm

[Lldb-commits] [PATCH] D111209: Don't push null ExecutionContext on CommandInterpreter exectx stack

ted added a comment. @jasonmolenda I discovered the same issue in another way - create a python command and load it with "command script import". Here is test.py: def __lldb_init_module(debugger, dict): debugger.HandleCommand( 'command script add -f test.test test') prin

[Lldb-commits] [lldb] fac3f20 - Reland "[lldb] Remove non address bits when looking up memory regions"

Author: David Spickett Date: 2021-11-03T13:56:51Z New Revision: fac3f20de55769d028bd92220e74f22fa57dd4b2 URL: https://github.com/llvm/llvm-project/commit/fac3f20de55769d028bd92220e74f22fa57dd4b2 DIFF: https://github.com/llvm/llvm-project/commit/fac3f20de55769d028bd92220e74f22fa57dd4b2.diff LOG

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

ljmf00 added a comment. In D113098#3105809 , @labath wrote: > bug reported in PR45856. Thanks for your time fixing this. So, for better understanding, does the infrastructure behind LLDB, Target and Process have similar APIs but Process is just for the

[Lldb-commits] [lldb] 5fbcf67 - Revert "[lldb] Remove non address bits when looking up memory regions"

Author: David Spickett Date: 2021-11-03T13:27:41Z New Revision: 5fbcf677347e38718461496d9e9e184a7a30c3fb URL: https://github.com/llvm/llvm-project/commit/5fbcf677347e38718461496d9e9e184a7a30c3fb DIFF: https://github.com/llvm/llvm-project/commit/5fbcf677347e38718461496d9e9e184a7a30c3fb.diff LOG

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

labath added a comment. Herald added a subscriber: JDevlieghere. bug reported in PR45856. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113098/new/ https://reviews.llvm.org/D113098 ___ lldb-commits maili

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

labath created this revision. labath added reviewers: teemperor, vsk. labath requested review of this revision. Herald added a project: LLDB. The StringPrinter class was using a Process instance to read memory. This automatically prevented it from working before starting the program. This patch c

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

thakis added a comment. Looks like this breaks the build on Windows: http://45.33.8.238/win/48210/step_4.txt Please take a look. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 _

[Lldb-commits] [lldb] 30f9227 - [lldb] Remove ConstString from plugin names in PluginManager innards

Author: Pavel Labath Date: 2021-11-03T13:14:21+01:00 New Revision: 30f922741a4fec8e6fa222321c3f57735862b0d3 URL: https://github.com/llvm/llvm-project/commit/30f922741a4fec8e6fa222321c3f57735862b0d3 DIFF: https://github.com/llvm/llvm-project/commit/30f922741a4fec8e6fa222321c3f57735862b0d3.diff

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

This revision was automatically updated to reflect the committed changes. Closed by commit rG6f5ce43b4337: [lldb] Remove non address bits when looking up memory regions (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757

[Lldb-commits] [lldb] 6f5ce43 - [lldb] Remove non address bits when looking up memory regions

Author: David Spickett Date: 2021-11-03T11:10:42Z New Revision: 6f5ce43b433706c3ae5c37022d6c0964b6bfadf8 URL: https://github.com/llvm/llvm-project/commit/6f5ce43b433706c3ae5c37022d6c0964b6bfadf8 DIFF: https://github.com/llvm/llvm-project/commit/6f5ce43b433706c3ae5c37022d6c0964b6bfadf8.diff LOG

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 384393. DavidSpickett added a comment. Change ProcessDebugger to DoGetMemoryRegionInfo also, to reduce confusion. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 384389. DavidSpickett added a comment. Update comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D102757/new/ https://reviews.llvm.org/D102757 Files: lldb/include/lldb/Target/Process.h lldb/sourc

[Lldb-commits] [PATCH] D102757: [lldb] Remove non address bits when looking up memory regions

DavidSpickett updated this revision to Diff 384385. DavidSpickett added a comment. Rebase onto latest main. Remove pointer auth from the test. This means we can run it on current buildbots more easily. There are other tests that look at pauth specifically, here we just care that the ABI plugin wa