[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. There are two things that could be added. One is already mentioned in the comments, which is logging error messages in a way that we can track bugs in an automated fashion, as righ

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna updated this revision to Diff 386996. lawrence_danna added a comment. rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 Files: lldb/CMakeLists.txt lldb/bindings/python/CMakeLists.t

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386995. lawrence_danna added a comment. cmake fix Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt lldb/bindings/python/get-pytho

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

zequanwu added a comment. > The ast thing could be tested by running "image dump ast" on an appropriate > piece of debug info. I didn't observe any difference before and after this patch with `image dump ast` tested on https://github.com/llvm/llvm-project/blob/main/lldb/test/Shell/SymbolFile/N

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a reviewer: jdoerfert. Herald added subscribers: lldb-commits, sstefan1. Herald added a project: LLDB. `image lookup -a ` doesn't work because the compilands list is always e

[Lldb-commits] [PATCH] D113810: Add the stop count to "statistics dump" in each target's dictionary.

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. The stop id includes all the user expression stops. So the same "drive through code" could produce very different stop counts if you ran a bunch of `p`-s in one session but not the other.

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg marked 4 inline comments as done. clayborg added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:713 + /// is unknown or can't be determined. + lldb::addr_t m_length; + /// The data for this object file so things can be parsed lazily. --

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg updated this revision to Diff 386972. clayborg added a comment. Added more comments to the encoding functions to detail how things are encoded. Fixed error typos. Added version to symbol table cache file so we can improve the format as time goes on and avoid loading out of data caches.

[Lldb-commits] [PATCH] D112972: [lldb] use EXT_SUFFIX for python extension

lawrence_danna updated this revision to Diff 386970. lawrence_danna added a comment. rebased, and include win32 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112972/new/ https://reviews.llvm.org/D112972 Files: lldb/CMakeLists.txt lldb/bindings

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386968. lawrence_danna added a comment. revert change that disabled the test Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt lld

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. In D113650#3128674 , @stella.stamenova wrote: > Can you please disable the test on Windows or back your change out until > there's a fix? There are already other failures that are getting missed > because the bot is red.

[Lldb-commits] [lldb] 19cd6f3 - [lldb] temporarily disable TestPaths.test_interpreter_info on windows

Author: Lawrence D'Anna Date: 2021-11-12T15:41:39-08:00 New Revision: 19cd6f31d83ec9cf4712e76668b2076a4c9741e4 URL: https://github.com/llvm/llvm-project/commit/19cd6f31d83ec9cf4712e76668b2076a4c9741e4 DIFF: https://github.com/llvm/llvm-project/commit/19cd6f31d83ec9cf4712e76668b2076a4c9741e4.dif

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

stella.stamenova added a comment. This broke the build on Windows. The buildbot was, sadly, already red because of another test failure: https://lab.llvm.org/buildbot/#/builders/83/builds/11931 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104886/

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

stella.stamenova added a comment. Can you please disable the test on Windows or back your change out until there's a fix? There are already other failures that are getting missed because the bot is red. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386967. lawrence_danna added a comment. cleanup cmake usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 Files: lldb/CMakeLists.txt lldb/bindings/python

[Lldb-commits] [PATCH] D113810: Add the stop count to "statistics dump" in each target's dictionary.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. It is great to know how many times the target has stopped over its lifetime as

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

bulbazord added a comment. This patch effectively introduces a file format to cache lldb internal state. While the tests and the code do give some information for what it looks like, some documentation about this format would be nice. I like this idea a lot! My comments were kind of surface lev

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg created this revision. clayborg added reviewers: jingham, labath, JDevlieghere, wallace, aadsm. Herald added subscribers: mgorny, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay. Herald added a project: LLDB. Added the ability to cache t

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna updated this revision to Diff 386878. lawrence_danna edited the summary of this revision. lawrence_danna added a comment. fix cmake error message condition for cross-compile Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ h

[Lldb-commits] [lldb] 84c5702 - [lldb][NFC] Inclusive language: rename m_master in ASTImporterDelegate

Author: Quinn Pham Date: 2021-11-12T12:04:14-06:00 New Revision: 84c5702b76497e6f3e3f2abc15fb59e947663b38 URL: https://github.com/llvm/llvm-project/commit/84c5702b76497e6f3e3f2abc15fb59e947663b38 DIFF: https://github.com/llvm/llvm-project/commit/84c5702b76497e6f3e3f2abc15fb59e947663b38.diff LO

[Lldb-commits] [PATCH] D113720: [lldb][NFC] Inclusive language: rename m_master in ASTImporterDelegate

This revision was automatically updated to reflect the committed changes. Closed by commit rG84c5702b7649: [lldb][NFC] Inclusive language: rename m_master in ASTImporterDelegate (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1137

[Lldb-commits] [PATCH] D113521: Allow lldb to launch a remote executable when there isn't a local copy

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. In D113521#3125429 , @clayborg wrote: > I'm good with this to get things started. Pavel? I think I mostly understand where's Jim's coming from, though

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. When you do your tests, don't care too much about std::string yet, as it has its own issues, but instead create a non-standard size type like struct Foo { int a; int b;

[Lldb-commits] [lldb] 52a3ed5 - [lldb][NFC] Inclusive language: replace master/slave names for ptys

Author: Quinn Pham Date: 2021-11-12T10:54:18-06:00 New Revision: 52a3ed5b93ca9aba042d87e2bb697bf0dda2e43c URL: https://github.com/llvm/llvm-project/commit/52a3ed5b93ca9aba042d87e2bb697bf0dda2e43c DIFF: https://github.com/llvm/llvm-project/commit/52a3ed5b93ca9aba042d87e2bb697bf0dda2e43c.diff LO

[Lldb-commits] [PATCH] D113687: [lldb][NFC] Inclusive language: replace master/slave names for ptys

This revision was automatically updated to reflect the committed changes. Closed by commit rG52a3ed5b93ca: [lldb][NFC] Inclusive language: replace master/slave names for ptys (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113687/

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

teemperor added a subscriber: labath. teemperor added a comment. @labath raised some concerns in IRC about the setup code being run in a potential multithreaded env (which makes sense). Feel free to revert (not sure when/if I'll get around to address the issues) Repository: rG LLVM Github Mo

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

danilashtefan added inline comments. Comment at: lldb/examples/synthetic/gnu_libstdcpp.py:77 +key = self.get_child_key(index) +return current.CreateChildAtOffset('[' + str(key.GetValue()) + ']', self.next.GetType().GetByteSize() + self.data_size, self.dat

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

danilashtefan added a comment. Hi Walter :) This is the Draft PR for the unordered_map/set data formatter. Currently it works well in case both key and values are of the same primitive data types (except string). Unfortunately, the following problems are encountered: 1. When key and value are

[Lldb-commits] [PATCH] D113760: [formatters] Draft diff for unordered_map libstdcpp formatter

danilashtefan updated this revision to Diff 386824. danilashtefan added a comment. Small cosmetic change Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113760/new/ https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py

[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGcef1e07cc6d0: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT (authored by teemperor). Herald added a subscriber: lldb-commits

[Lldb-commits] [lldb] cef1e07 - [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

Author: Raphael Isemann Date: 2021-11-12T14:19:15+01:00 New Revision: cef1e07cc6d00b5b429d77133201e1f404a8023c URL: https://github.com/llvm/llvm-project/commit/cef1e07cc6d00b5b429d77133201e1f404a8023c DIFF: https://github.com/llvm/llvm-project/commit/cef1e07cc6d00b5b429d77133201e1f404a8023c.dif

[Lldb-commits] [PATCH] D113760: next

danilashtefan created this revision. danilashtefan requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D113760 Files: lldb/examples/synthetic/gnu_libstdcpp.py lldb/source/Plug

[Lldb-commits] [lldb] c30c37c - Revert "[lldb] fix test expectation broken by clang fix at D110216"

Author: Adrian Kuegel Date: 2021-11-12T13:21:30+01:00 New Revision: c30c37c00a501e21f36f13109795dd5f95e1d937 URL: https://github.com/llvm/llvm-project/commit/c30c37c00a501e21f36f13109795dd5f95e1d937 DIFF: https://github.com/llvm/llvm-project/commit/c30c37c00a501e21f36f13109795dd5f95e1d937.diff