[Lldb-commits] [PATCH] D104886: [lldb] Fix that the embedded Python REPL crashes if it receives SIGINT

labath added a comment. In D104886#3127411 , @teemperor wrote: > @labath raised some concerns in IRC about the setup code being run in a > potential multithreaded env (which makes sense). Feel free to revert (not > sure when/if I'll get around to addres

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

labath added a comment. In D113724#3128929 , @zequanwu wrote: >> The ast thing could be tested by running "image dump ast" on an appropriate >> piece of debug info. > > I didn't observe any difference before and after this patch with `image dump > ast`

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

labath added a comment. Maybe it's good for starting a discussion, but I am surprised that we would need to cache symtab information. This is a fairly simple format that needs to be read at application runtime as well, so I am surprised that reading it from the cache is substantially faster tha

[Lldb-commits] [lldb] 5e20cd6 - [lldb/test] Fix std-module vector tests to work with both kinds of vector layouts

Author: Pavel Labath Date: 2021-11-15T11:12:05+01:00 New Revision: 5e20cd6568564025367b6a67424436c5d06fe3bc URL: https://github.com/llvm/llvm-project/commit/5e20cd6568564025367b6a67424436c5d06fe3bc DIFF: https://github.com/llvm/llvm-project/commit/5e20cd6568564025367b6a67424436c5d06fe3bc.diff

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

werat updated this revision to Diff 387213. werat added a comment. Update commit message, rename test variable Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113673/new/ https://reviews.llvm.org/D113673 Files: lldb/source/Plugins/TypeSystem/Clang

[Lldb-commits] [lldb] 95102b7 - [lldb] Unwrap the type when dereferencing the value

Author: Andy Yankovsky Date: 2021-11-15T14:48:19+01:00 New Revision: 95102b7dc3c1b5b3f1b688221d9aa28cb1e17974 URL: https://github.com/llvm/llvm-project/commit/95102b7dc3c1b5b3f1b688221d9aa28cb1e17974 DIFF: https://github.com/llvm/llvm-project/commit/95102b7dc3c1b5b3f1b688221d9aa28cb1e17974.diff

[Lldb-commits] [PATCH] D113673: [lldb] Unwrap the type when dereferencing the value

This revision was automatically updated to reflect the committed changes. Closed by commit rG95102b7dc3c1: [lldb] Unwrap the type when dereferencing the value (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113673/new/ https://rev

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat marked 4 inline comments as done. werat added a comment. In D113498#3124525 , @teemperor wrote: > I really like the solution, but I think by fixing the `CanInterpret` you also > made the test case no longer reach the actual changed interpreting log

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat updated this revision to Diff 387236. werat added a comment. Address review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 Files: lldb/source/Expression/IRInterpreter.cpp lldb/test/API

[Lldb-commits] [PATCH] D113893: [lldb/test] Move gdb client utils into the packages tree

labath created this revision. labath added reviewers: JDevlieghere, mgorny. Herald added subscribers: kbarton, sbc100, nemanjai. labath requested review of this revision. Herald added a subscriber: aheejin. Herald added a project: LLDB. This infrastructure has proven proven its worth, so give it a

[Lldb-commits] [PATCH] D113893: [lldb/test] Move gdb client utils into the packages tree

mgorny added a comment. Are there any changes to the code you've moved that we should look at? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113893/new/ https://reviews.llvm.org/D113893 ___ lldb-commits

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

labath added a reviewer: jingham. labath added a comment. Jim, could you take look at this? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113098/new/ https://reviews.llvm.org/D113098 ___ lldb-commits mai

[Lldb-commits] [PATCH] D113893: [lldb/test] Move gdb client utils into the packages tree

labath added a comment. Nope. In fact, if you look closely, you'll see that phabricator highlights the entire `lldbgdbclient.py` file as being moved from the original file. :) I will need to make some changes to this code, but I'll do that as a separate patch. Repository: rG LLVM Github Mon

[Lldb-commits] [PATCH] D113893: [lldb/test] Move gdb client utils into the packages tree

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM then. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113893/new/ https://reviews.llvm.org/D113893 _

[Lldb-commits] [PATCH] D113810: Add the stop count to "statistics dump" in each target's dictionary.

clayborg added a comment. In D113810#3128741 , @jingham wrote: > The stop id includes all the user expression stops. So the same "drive > through code" could produce very different stop counts if you ran a bunch of > `p`-s in one session but not the ot

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

zequanwu updated this revision to Diff 387348. zequanwu marked an inline comment as done. zequanwu added a comment. Use `/base:0x40` in test case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113821/new/ https://reviews.llvm.org/D113821 Files

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/test/Shell/SymbolFile/NativePDB/lookup-by-address.cpp:12 +// ADDRESS: image lookup -a 0x401000 +// ADDRESS: Address: lookup-by-address.cpp.tmp.exe[0x{{[0

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu created this revision. zequanwu added a reviewer: labath. zequanwu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is a split of D113724 . Calling `TypeSystemClang::AddMethodToCXXRecordType`

[Lldb-commits] [PATCH] D113724: [LLDB][NativePDB] Fix missing symbol info when backtrace minidump

zequanwu abandoned this revision. zequanwu added a comment. Splitted into D113821 and D113930 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113724/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D113533: [LLDB] Remove access check of decl in TypeSystemClang.cpp

zequanwu abandoned this revision. zequanwu added a comment. D113930 is the correct fix for that. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113533/new/ https://reviews.llvm.org/D113533

[Lldb-commits] [lldb] f17404a - [LLDB][NativePDB] Fix image lookup by address

Author: Zequan Wu Date: 2021-11-15T12:30:23-08:00 New Revision: f17404a733c18f0aa8ff98255dbae0f59298 URL: https://github.com/llvm/llvm-project/commit/f17404a733c18f0aa8ff98255dbae0f59298 DIFF: https://github.com/llvm/llvm-project/commit/f17404a733c18f0aa8ff98255dbae0f59298.diff LOG

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

This revision was automatically updated to reflect the committed changes. Closed by commit rGf17404a733c1: [LLDB][NativePDB] Fix image lookup by address (authored by zequanwu). Changed prior to commit: https://reviews.llvm.org/D113821?vs=387348&id=387355#toc Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg added a comment. In D113789#3130741 , @labath wrote: > Maybe it's good for starting a discussion, but I am surprised that we would > need to cache symtab information. This is a fairly simple format that needs > to be read at application runtime

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg added a comment. Thinking about this a bit more after Pavel's comment on if performance was improved due to mangling: we don't currently get any perf improvement from mangling/demangling. We might be able to get better performance out of this as well if we _do_ cache the "mangled/deman

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

stella.stamenova added a comment. I think this broke the windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/12036 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113821/new/ https://reviews.llvm.org/D113821

[Lldb-commits] [lldb] b6d3535 - [LLDB][NativePDB] Fix local-variables.cpp failure on windows bots

Author: Zequan Wu Date: 2021-11-15T16:14:55-08:00 New Revision: b6d35352304601925bc1c055106949d2e27b3975 URL: https://github.com/llvm/llvm-project/commit/b6d35352304601925bc1c055106949d2e27b3975 DIFF: https://github.com/llvm/llvm-project/commit/b6d35352304601925bc1c055106949d2e27b3975.diff LOG

[Lldb-commits] [PATCH] D113821: [LLDB][NativePDB] Fix image lookup by address

zequanwu added a comment. In D113821#3133324 , @stella.stamenova wrote: > I think this broke the windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/12036 Thanks, hopefully this will fix it: rGb6d35352304601925bc1c055106949d2e27b3975

[Lldb-commits] [PATCH] D113789: Add the ability to cache information for a module between debugger instances.

clayborg added a comment. Some perf numbers that involve loading a large iOS Application and all of its shared libraries without caching first and then with caching are found below. The "lldb-perf.py" command will start a timer, run any LLDB commands and then stop the timer and print out. Befor

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

jingham requested changes to this revision. jingham added a comment. This revision now requires changes to proceed. It makes sense for the string formatters to try reading from the target if there's no process. So the general idea is fine. But one of the other major differences between the Targ

[Lldb-commits] [lldb] dbd36e1 - Add the stop count to "statistics dump" in each target's dictionary.

Author: Greg Clayton Date: 2021-11-15T18:59:09-08:00 New Revision: dbd36e1e9f16059f1be1d15f8549a6e538906679 URL: https://github.com/llvm/llvm-project/commit/dbd36e1e9f16059f1be1d15f8549a6e538906679 DIFF: https://github.com/llvm/llvm-project/commit/dbd36e1e9f16059f1be1d15f8549a6e538906679.diff

[Lldb-commits] [PATCH] D113810: Add the stop count to "statistics dump" in each target's dictionary.

This revision was automatically updated to reflect the committed changes. Closed by commit rGdbd36e1e9f16: Add the stop count to "statistics dump" in each target's dictionary. (authored by clayborg). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1138

[Lldb-commits] [PATCH] D113810: Add the stop count to "statistics dump" in each target's dictionary.

jingham added a comment. In D113810#3132418 , @clayborg wrote: > In D113810#3128741 , @jingham wrote: > >> The stop id includes all the user expression stops. So the same "drive >> through code" could produce ve

[Lldb-commits] [PATCH] D113810: Add the stop count to "statistics dump" in each target's dictionary.

clayborg added a comment. In D113810#3133655 , @jingham wrote: > In D113810#3132418 , @clayborg > wrote: > >> In D113810#3128741 , @jingham >> wrote: >> >>> The stop id

[Lldb-commits] [PATCH] D113965: [NFC] Refactor symbol table parsing.

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, aadsm, wallace. Herald added subscribers: sbc100, emaste. clayborg requested review of this revision. Herald added subscribers: lldb-commits, MaskRay, aheejin. Herald added a project: LLDB. Symbol table parsin

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

labath added a reviewer: shafik. labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Tagging Shafik in case he wants to look at the AST usage, but overall, this seems to be in line with the discussions on the other patch. Repository: rG LLVM