[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

clayborg added a comment. Never mind, it seems to be fixed. Although the problem I mentioned is still true where some test cases might set "self.target = debugger.CreateTarget(...)" and if those test cases try to use the check_breakpoint function. See suggested code edit for a potential fix.

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

clayborg added a comment. In D111899#3140422 , @aprantl wrote: > FYI, this broke all the TestObjCNewSyntax* tests. I *think* I've fixed them. I synced to top of tree, still having issues. What was the commit for your fix? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

clayborg added a comment. The right fix IMHO is to rename the function in lldbtest.py from "def target(self):" to "def selected_target(self):" and then find all call sites and fix them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

clayborg added a comment. This change causes many test suite errors due to inline comment. Please fix ASAP Comment at: lldb/packages/Python/lldbsuite/test/lldbutil.py:759 + +bkpt = test.target().FindBreakpointByID(bpno) +test.assertTrue(bkpt.IsValid(), "Breakpoint

[Lldb-commits] [lldb] d9f56fe - Remove unused variable.

Author: Jim Ingham Date: 2021-11-18T15:58:20-08:00 New Revision: d9f56feda84ad9d9edfff32c64a70af73c5f9b6a URL: https://github.com/llvm/llvm-project/commit/d9f56feda84ad9d9edfff32c64a70af73c5f9b6a DIFF: https://github.com/llvm/llvm-project/commit/d9f56feda84ad9d9edfff32c64a70af73c5f9b6a.diff

[Lldb-commits] [PATCH] D114178: [lldb] Fix formatted log statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c4464a5bd35: [lldb] Fix formatted log statement (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114178/new/

[Lldb-commits] [lldb] 0c4464a - [lldb] Fix formatted log statement

Author: Keith Smiley Date: 2021-11-18T15:09:38-08:00 New Revision: 0c4464a5bd35dd865f568ed68171208e44df16c7 URL: https://github.com/llvm/llvm-project/commit/0c4464a5bd35dd865f568ed68171208e44df16c7 DIFF: https://github.com/llvm/llvm-project/commit/0c4464a5bd35dd865f568ed68171208e44df16c7.diff

[Lldb-commits] [lldb] cbb8b20 - Revert "Increase gdbremote timeout."

Author: Adrian Prantl Date: 2021-11-18T15:07:30-08:00 New Revision: cbb8b200a6566943d898e51b80769a648a47a04c URL: https://github.com/llvm/llvm-project/commit/cbb8b200a6566943d898e51b80769a648a47a04c DIFF: https://github.com/llvm/llvm-project/commit/cbb8b200a6566943d898e51b80769a648a47a04c.diff

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

jingham added a comment. In D11#3141355 , @puremourning wrote: > Sorry, but is anything further required from me on this patch ? You addressed an issue Shafik asked you to, so then he should make sure he's happy with the change and mark the patch

[Lldb-commits] [PATCH] D112222: [LLDB] libcxx summary formatters for std::string_view

puremourning added a comment. Sorry, but is anything further required from me on this patch ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11/new/ https://reviews.llvm.org/D11 ___ lldb-commits

[Lldb-commits] [lldb] 721bb73 - make testcase more robust

Author: Adrian Prantl Date: 2021-11-18T14:00:53-08:00 New Revision: 721bb736764787bd03727196b734f74a6c8745e0 URL: https://github.com/llvm/llvm-project/commit/721bb736764787bd03727196b734f74a6c8745e0 DIFF: https://github.com/llvm/llvm-project/commit/721bb736764787bd03727196b734f74a6c8745e0.diff

[Lldb-commits] [PATCH] D114111: Remove a useless temporary of a base class type.

srhines accepted this revision. srhines added a comment. Per https://developer.android.com/guide/topics/renderscript/migrate, we are starting to turn things down as part of the deprecation. I reached out internally to the folks helping with that to make sure that we don't cause problems by

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114156/new/ https://reviews.llvm.org/D114156

[Lldb-commits] [lldb] 5cf23ec - fix syntax error

Author: Adrian Prantl Date: 2021-11-18T10:49:51-08:00 New Revision: 5cf23ecc23afa0e04e5b5e2b3ca8e9e3c988d9ec URL: https://github.com/llvm/llvm-project/commit/5cf23ecc23afa0e04e5b5e2b3ca8e9e3c988d9ec DIFF: https://github.com/llvm/llvm-project/commit/5cf23ecc23afa0e04e5b5e2b3ca8e9e3c988d9ec.diff

[Lldb-commits] [PATCH] D114178: [lldb] Fix formatted log statement

keith created this revision. keith added reviewers: kastiglione, aprantl. keith requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously this would output literally without replacements Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

labath updated this revision to Diff 388263. labath added a comment. use a class sentinel Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114156/new/ https://reviews.llvm.org/D114156 Files: lldb/packages/Python/lldbsuite/test/gdbclientutils.py

[Lldb-commits] [lldb] 95af9d8 - [NFC][lldb] Inclusive language: remove instances of master from comments in lldb

Author: Quinn Pham Date: 2021-11-18T12:34:13-06:00 New Revision: 95af9d888b086ecfecdb54c74910467d95128734 URL: https://github.com/llvm/llvm-project/commit/95af9d888b086ecfecdb54c74910467d95128734 DIFF: https://github.com/llvm/llvm-project/commit/95af9d888b086ecfecdb54c74910467d95128734.diff

[Lldb-commits] [PATCH] D114123: [NFC][lldb] Inclusive language: remove instances of master from comments in lldb

This revision was automatically updated to reflect the committed changes. Closed by commit rG95af9d888b08: [NFC][lldb] Inclusive language: remove instances of master from comments in lldb (authored by quinnp). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D114150: [lldb] Deobfuscate python-swigsafecast.swig

This revision was automatically updated to reflect the committed changes. Closed by commit rGf1127914d3dc: [lldb] Deobfuscate python-swigsafecast.swig (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114150/new/

[Lldb-commits] [lldb] f112791 - [lldb] Deobfuscate python-swigsafecast.swig

Author: Pavel Labath Date: 2021-11-18T19:27:09+01:00 New Revision: f1127914d3dcbfbe3bbd943ab84bea3805164295 URL: https://github.com/llvm/llvm-project/commit/f1127914d3dcbfbe3bbd943ab84bea3805164295 DIFF: https://github.com/llvm/llvm-project/commit/f1127914d3dcbfbe3bbd943ab84bea3805164295.diff

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:89 packetLog = None +RESPONSE_DISCONNECT = object() labath wrote: > mgorny wrote: > > How about making it a class instead? It should make debugging easier,

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

labath updated this revision to Diff 388248. labath added a comment. Don't try to raise classes Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114156/new/ https://reviews.llvm.org/D114156 Files:

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:89 packetLog = None +RESPONSE_DISCONNECT = object() mgorny wrote: > How about making it a class instead? It should make debugging easier, if it > ever

[Lldb-commits] [PATCH] D111899: LLDB tests modification for hardware breakpoints

aprantl added a comment. FYI, this broke all the TestObjCNewSyntax* tests. I *think* I've fixed them. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D111899/new/ https://reviews.llvm.org/D111899 ___

[Lldb-commits] [lldb] 08c0a45 - Unbreak test after D111899

Author: Adrian Prantl Date: 2021-11-18T08:51:50-08:00 New Revision: 08c0a45ab89c64195d8302d3cde20719cbd81d30 URL: https://github.com/llvm/llvm-project/commit/08c0a45ab89c64195d8302d3cde20719cbd81d30 DIFF: https://github.com/llvm/llvm-project/commit/08c0a45ab89c64195d8302d3cde20719cbd81d30.diff

[Lldb-commits] [PATCH] D114150: [lldb] Deobfuscate python-swigsafecast.swig

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114150/new/ https://reviews.llvm.org/D114150

[Lldb-commits] [PATCH] D114157: [lldb/test] Make it possible to run the mock gdb server on a single thread

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. I think I may have delayed constructing socket until `start()` for some reason but maybe it was just originally like that and didn't want to change semantics. If it doesn't break tests, wfm.

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:89 packetLog = None +RESPONSE_DISCONNECT = object() How about making it a class instead? It should make debugging easier, if it ever comes to that. ```

[Lldb-commits] [PATCH] D113098: [lldb] (Partially) enable formatting of utf strings before the program is started

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rG4c56f734b35d: [lldb] (Partially) enable formatting of utf strings before the program is… (authored by labath).

[Lldb-commits] [lldb] 4c56f73 - [lldb] (Partially) enable formatting of utf strings before the program is started

Author: Pavel Labath Date: 2021-11-18T14:45:17+01:00 New Revision: 4c56f734b35dd3e16b75da46c023cd4b92f83f8c URL: https://github.com/llvm/llvm-project/commit/4c56f734b35dd3e16b75da46c023cd4b92f83f8c DIFF: https://github.com/llvm/llvm-project/commit/4c56f734b35dd3e16b75da46c023cd4b92f83f8c.diff

[Lldb-commits] [PATCH] D114157: [lldb/test] Make it possible to run the mock gdb server on a single thread

labath created this revision. labath added a reviewer: mgorny. labath requested review of this revision. Herald added a project: LLDB. This is a preparatory commit to enable mocking of qemu startup. That will involve running the mock server in a separate process, so there's no need for

[Lldb-commits] [PATCH] D114156: [lldb/test] Add ability to terminate connection from a gdb-client handler

labath created this revision. labath added a reviewer: mgorny. labath requested review of this revision. Herald added a project: LLDB. We were using the client socket close as a way to terminate the handler thread. But this kind of concurrent access to the same socket is not safe. It also

[Lldb-commits] [lldb] 3a56f56 - [lldb] Convert internal platform usages GetSupportedArchitectures

Author: Pavel Labath Date: 2021-11-18T13:31:09+01:00 New Revision: 3a56f5622f392660a3af52d85368661b812f5978 URL: https://github.com/llvm/llvm-project/commit/3a56f5622f392660a3af52d85368661b812f5978 DIFF: https://github.com/llvm/llvm-project/commit/3a56f5622f392660a3af52d85368661b812f5978.diff

[Lldb-commits] [PATCH] D114150: [lldb] Deobfuscate python-swigsafecast.swig

labath created this revision. labath added reviewers: JDevlieghere, jingham. labath requested review of this revision. Herald added a project: LLDB. This file was way more complicated than it needed to be. This patch removes the automagic reference-to-pointer delegation and replaces the template

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3139112 , @shafik wrote: > On the other hand this is a well-formed constant expression: > > static const int x =0; > constexpr const int* ip1 = + 1; > > Does that get you the test case you need? This expression

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

kpdev42 updated this revision to Diff 388118. kpdev42 added a comment. Addressed review comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110827/new/ https://reviews.llvm.org/D110827 Files: