[Lldb-commits] [lldb] c0e3bb4 - [lldb] Fix TestFileHandle.py

Author: Pavel Labath Date: 2021-11-25T08:56:45+01:00 New Revision: c0e3bb4d4ba3064c42fb8e1ee9f001235d9af04c URL: https://github.com/llvm/llvm-project/commit/c0e3bb4d4ba3064c42fb8e1ee9f001235d9af04c DIFF: https://github.com/llvm/llvm-project/commit/c0e3bb4d4ba3064c42fb8e1ee9f001235d9af04c.diff

[Lldb-commits] [PATCH] D110827: [LLDB] Provide target specific directories to libclang

teemperor accepted this revision. teemperor added a comment. This revision is now accepted and ready to land. LGTM, thanks for fixing this! Comment at: lldb/source/Plugins/ExpressionParser/Clang/CppModuleConfiguration.cpp:86 - // Check for /usr/include. On Linux this might

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3149188 , @labath wrote: > I don't believe this solution is correct. > > How did this work before? Is it because `ObjectFileELF::GetSymtab` contained > the same (incorrect) unique_ptr pattern? It did, but because eac

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

danilashtefan updated this revision to Diff 389597. danilashtefan added a comment. Unified tests added Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new/ https://reviews.llvm.org/D114008 Files: lldb/examples/synthetic/gnu_libstdcpp.py l

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: DavidSpickett, JDevlieghere, shafik. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My recent change (https://reviews.llvm.org/D104413) broke the lldb

[Lldb-commits] [PATCH] D114544: [lldb] Fix 'memory write' to not allow specifying values when writing file contents

RamNalamothu created this revision. RamNalamothu added reviewers: JDevlieghere, DavidSpickett, zturner, teemperor. RamNalamothu requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently the 'memory write' command allows specifying the value

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf23b829a2635: Fixed use of -o and -k in LLDB under Windows when statically compiled with… (authored by PatriosTheGreat, committed by DavidSpickett).

[Lldb-commits] [lldb] f23b829 - Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

Author: Levon Ter-Grigoryan Date: 2021-11-24T16:17:08Z New Revision: f23b829a2635a6d833bdc81a12d6217b52ae9e45 URL: https://github.com/llvm/llvm-project/commit/f23b829a2635a6d833bdc81a12d6217b52ae9e45 DIFF: https://github.com/llvm/llvm-project/commit/f23b829a2635a6d833bdc81a12d6217b52ae9e45.diff

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added a comment. > some things in this patch are called "Qemu" (the plugin folder, for instance) I wouldn't pay much attention to the `qemu-system` idea, it was just a hypothetical from me. Unless it's something that you would call a public API. Like the platform's name for exampl

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:505 except: +traceback.print_exc() return Is this something that happens every so often during testing and can be mostly igno

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

DavidSpickett added a comment. > qemu also does not support macOS Do you mean qemu-user here? I agree being able to run the tests there is nice. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 _

[Lldb-commits] [lldb] 96beb30 - [lldb] Move GetSupportedArchitectureAtIndex to PlatformDarwin

Author: Pavel Labath Date: 2021-11-24T15:48:23+01:00 New Revision: 96beb30fbbcea87a3da7e984ba34951b0fa6deb5 URL: https://github.com/llvm/llvm-project/commit/96beb30fbbcea87a3da7e984ba34951b0fa6deb5 DIFF: https://github.com/llvm/llvm-project/commit/96beb30fbbcea87a3da7e984ba34951b0fa6deb5.diff

[Lldb-commits] [PATCH] D114529: [lldb/gdb-remote] Remove initial pipe-draining workaround

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. Makes sense to me. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114529/new/ https://reviews.llvm.org/D114529 _

[Lldb-commits] [PATCH] D114529: [lldb/gdb-remote] Remove initial pipe-draining workaround

labath added a comment. Ed, I don't suppose you by any chance remember more details about that patch? I couldn't find a way to reproduce this with a modern-day qemu, but I also couldn't find any evidence that this ever was an issue, so it is possible (though not very likely, I hope) that I am m

[Lldb-commits] [PATCH] D114529: [lldb/gdb-remote] Remove initial pipe-draining workaround

labath created this revision. labath added reviewers: emaste, mgorny, jasonmolenda. labath requested review of this revision. Herald added a project: LLDB. This code, added in rL197579 (Dec 2013) is supposed to work around what was presumably a qemu bug, where

[Lldb-commits] [PATCH] D114520: [lldb/gdb-remote] Ignore spurious ACK packets

labath added inline comments. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp:56 {{"$foobar#79"}, {"foobar"}}, - {{"$}}#fa"}, {"]"}}, - {{"$x*%#c7"}, {"x"}}, mgorny wrote: > I don't get how this is relevant to

[Lldb-commits] [lldb] c52ff0c - [LLDB/test] lldbutil check_breakpoint() - check target instance

Author: SYNOPSYS\georgiev Date: 2021-11-24T11:13:17Z New Revision: c52ff0cfcbf46b81d3df868a259d94910cd15c9a URL: https://github.com/llvm/llvm-project/commit/c52ff0cfcbf46b81d3df868a259d94910cd15c9a DIFF: https://github.com/llvm/llvm-project/commit/c52ff0cfcbf46b81d3df868a259d94910cd15c9a.diff

[Lldb-commits] [PATCH] D114520: [lldb/gdb-remote] Ignore spurious ACK packets

mgorny accepted this revision. mgorny added inline comments. This revision is now accepted and ready to land. Comment at: lldb/unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp:56 {{"$foobar#79"}, {"foobar"}}, - {{"$}}#fa"}, {"]"}}, - {{"$x*%#c7"}, {"xx

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

mgorny accepted this revision. mgorny added a comment. This revision is now accepted and ready to land. That said, I wonder if we should use some formatter (e.g. `black`) for Python files. While I can't really say I like black's coding style, it's quite popular and using some formatter would be

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath updated this revision to Diff 389443. labath marked 4 inline comments as done. labath added a comment. Address Michał's feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114509/new/ https://reviews.llvm.org/D114509 Files: lldb/packa

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath marked 4 inline comments as done. labath added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:403 return self._connection.sendall(data) +class TCPServerSocket(ServerSocket): mgorny wrote: > It's customary (rea

[Lldb-commits] [PATCH] D114520: [lldb/gdb-remote] Ignore spurious ACK packets

labath created this revision. labath added reviewers: mgorny, jasonmolenda. labath requested review of this revision. Herald added a project: LLDB. Although I cannot find any mention of this in the specification, both gdb and lldb agree on sending an initial + packet after establishing the connect

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

mgorny added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/gdbclientutils.py:403 return self._connection.sendall(data) +class TCPServerSocket(ServerSocket): It's customary (read: PEP8) to use two empty lines between global-scope stuf

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

DavidSpickett added a comment. Not sure if you're a regular contributor and already know this but in case not, I tend to use https://clang.llvm.org/docs/ClangFormat.html#script-for-patch-reformatting for doing clang-format stuff. It'll format only the lines you've changed. Repository: rG LL

[Lldb-commits] [PATCH] D114448: [Bug 49018][lldb] Fix incorrect help text for 'memory write' command

DavidSpickett added a comment. Thanks for looking at this bug! I admit I don't know the option parsing very well which is why I shied away from fixing it myself. Some good finds elsewhere too, but better as their own changes I think. (feel free to add me on review there too)

[Lldb-commits] [lldb] 6f82264 - [lldb/gdb-remote] Remove more non-stop mode remnants

Author: Pavel Labath Date: 2021-11-24T10:00:43+01:00 New Revision: 6f82264dbb02028d4ec4940aeb6d716dded6e879 URL: https://github.com/llvm/llvm-project/commit/6f82264dbb02028d4ec4940aeb6d716dded6e879 DIFF: https://github.com/llvm/llvm-project/commit/6f82264dbb02028d4ec4940aeb6d716dded6e879.diff

Re: [Lldb-commits] [lldb] 91f78eb - Revert "[lldb] Load the fblldb module automatically"

We actually came across a need to do something similar recently. I was planning to propose the introduction of a "site" lldbinit file. I haven't figured out the details, but I guess it would be located at some path relative to the lldb installation, and sourced before the user-specific and cwd

[Lldb-commits] [PATCH] D114509: [lldb] Introduce PlatformQemuUser

labath created this revision. labath added reviewers: JDevlieghere, DavidSpickett, mgorny. labath requested review of this revision. Herald added a project: LLDB. This adds a new platform class, whose job is to enable running (debugging) executables under qemu. (For general information about qemu