DavidSpickett updated this revision to Diff 390076.
DavidSpickett added a comment.
Rebase after changes to previous patches.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D107140/new/
https://reviews.llvm.org/D107140
Files:
lldb/include/lldb/Core
DavidSpickett updated this revision to Diff 390073.
DavidSpickett added a comment.
- Move to Target/
- Doxygen style comments at top of class
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D112825/new/
https://reviews.llvm.org/D112825
Files:
lldb/
Author: David Spickett
Date: 2021-11-26T15:35:02Z
New Revision: 0df522969a7a0128052bd79182c8d58e00556e2f
URL:
https://github.com/llvm/llvm-project/commit/0df522969a7a0128052bd79182c8d58e00556e2f
DIFF:
https://github.com/llvm/llvm-project/commit/0df522969a7a0128052bd79182c8d58e00556e2f.diff
LOG
labath added a comment.
You need to construct issue appropriately nested ValueCheck objects. Something
like this:
children.insert(0,ValueCheck(children=[ValueCheck(value=i),
ValueCheck(value=i+1), ValueCheck(i + 2)])
If that doesn't work then that's probably a bug in the ValueCheck matching
This revision was automatically updated to reflect the committed changes.
Closed by commit rG7f05ff8be481: [Bug 49018][lldb] Fix incorrect help text for
'memory write' command (authored by ramana-nvr, committed by
RamNalamothu).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
Author: Venkata Ramanaiah Nalamothu
Date: 2021-11-26T19:14:26+05:30
New Revision: 7f05ff8be481f6db23615c028280fd92c2080f5f
URL:
https://github.com/llvm/llvm-project/commit/7f05ff8be481f6db23615c028280fd92c2080f5f
DIFF:
https://github.com/llvm/llvm-project/commit/7f05ff8be481f6db23615c028280fd92
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114448/new/
https://reviews.llvm.org/D114448
_
RamNalamothu updated this revision to Diff 390022.
RamNalamothu added a comment.
Re-use the existing constexpr option table.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114448/new/
https://reviews.llvm.org/D114448
Files:
lldb/include/lldb/Inte
RamNalamothu added inline comments.
Comment at: lldb/source/Interpreter/OptionGroupFormat.cpp:66
+ 0,
+ eArgTypeCount,
+ "The number of total items to display."},
DavidSpickett wrote:
> RamNalamothu wrote:
> > DavidSpickett wrote:
>
werat added inline comments.
Comment at: lldb/source/Plugins/SymbolFile/DWARF/SymbolFileDWARF.cpp:2464
+const char *qn = die.GetQualifiedName(s);
+if (strncmp(sc, qn, strlen(sc)))
Can `GetQualifiedName` return `NULL` string?
Comment a
lassefolger updated this revision to Diff 390001.
lassefolger added a comment.
rebased on nfc
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114627/new/
https://reviews.llvm.org/D114627
Files:
lldb/include/lldb/Symbol/SymbolFile.h
lldb/source/P
lassefolger created this revision.
lassefolger added reviewers: werat, teemperor.
lassefolger requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
Searching for fully qualified types in a SymbolFile can be inefficient
if it contains many types w
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:160
+ // we must use an untagged address.
+ MemoryRegionInfo::RangeType range(RemoveNonAddressBits(addr), len);
+ range = ExpandToGranule(range);
--
DavidSpickett marked 2 inline comments as done.
DavidSpickett added inline comments.
Comment at:
lldb/source/Plugins/Process/Utility/MemoryTagManagerAArch64MTE.cpp:148
+ // For the logic to work regions must be in ascending order.
+ // We're going to assume that there are no o
mgorny added a comment.
I don't think I really want to work on this right now. Even if it still works
reliably, I'm not sure if the gain is really worth the added complexity (and
risks).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D89335/new/
https://reviews.llvm.org/D89335
DavidSpickett updated this revision to Diff 389988.
DavidSpickett added a comment.
- Range based for loop over memory regions
- Reduce number of ->GetRange calls
- Check for overlapping regions up front and error if founda
- Added test that the range invesion check removes ignores tags
- Added the
danilashtefan added a comment.
Hi @labath, Thank you so much for your comment and correction. The initial
version of the test was the following, with array of ValueCheck objects:
`def check(self, var_name, size):
var = self.findVariable(var_name)
self.assertEqual(var.GetNumChildren(), size)
labath requested changes to this revision.
labath added a comment.
This revision now requires changes to proceed.
I guess this slipped off my radar What's the state of this? Are you still
interested in the patch? If yes, we can try again after rebasing.
CHANGES SINCE LAST ACTION
https://r
labath accepted this revision.
labath added a comment.
This revision is now accepted and ready to land.
Getting this off my queue. I think the change is fine, but I can also live with
the original comment.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D90876/new/
https://reviews.llvm.or
This revision was automatically updated to reflect the committed changes.
Closed by commit rG94038c570fbc: [lldb] Fix 'memory write' to not
allow specifying values when writing file… (authored by ramana-nvr).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.
Author: Venkata Ramanaiah Nalamothu
Date: 2021-11-26T15:50:36+05:30
New Revision: 94038c570fbc991c03fe68793c576314c231d4ee
URL:
https://github.com/llvm/llvm-project/commit/94038c570fbc991c03fe68793c576314c231d4ee
DIFF:
https://github.com/llvm/llvm-project/commit/94038c570fbc991c03fe68793c576314
labath added a comment.
Thanks for the review. I'm going to wait until the US folks get back before
submitting this.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D114509/new/
https://reviews.llvm.org/D114509
__
DavidSpickett added a comment.
Thanks for splitting the patches.
Comment at: lldb/source/Interpreter/OptionGroupFormat.cpp:30
+ m_option_definition[2] = default_opt_defs[2];
+ m_option_definition[3] = default_opt_defs[3];
You could use a std::copy for this
DavidSpickett accepted this revision.
DavidSpickett added a comment.
This revision is now accepted and ready to land.
> All the comments etc came from that.
Yeah it's a bit of a judgement call so it's a safe bet to add them and see what
review thinks. I know for sure there are plenty of tests wi
24 matches
Mail list logo
