[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

lawrence_danna marked an inline comment as done. lawrence_danna added a comment. fixed whitespace and commited Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114973/new/ https://reviews.llvm.org/D114973 _

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

This revision was automatically updated to reflect the committed changes. Closed by commit rG27ca9458012c: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH (authored by lawrence_danna). Changed prior to commit: https://reviews.llvm.org/D114973?vs=391384&id=391541#toc Repository: rG LLVM Git

[Lldb-commits] [lldb] 27ca945 - [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

Author: Lawrence D'Anna Date: 2021-12-02T21:13:35-08:00 New Revision: 27ca9458012caf8b556ce31fc7aaac571af878d2 URL: https://github.com/llvm/llvm-project/commit/27ca9458012caf8b556ce31fc7aaac571af878d2 DIFF: https://github.com/llvm/llvm-project/commit/27ca9458012caf8b556ce31fc7aaac571af878d2.dif

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

clayborg added a comment. In D113650#3168812 , @lawrence_danna wrote: > @clayborg > > Does this fix it for you? > > https://reviews.llvm.org/D114973 Yes it does! Thanks Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

clayborg added inline comments. Comment at: lldb/bindings/python/get-python-config.py:71 main() \ No newline at end of file Add newline Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114973/new/ https://revie

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

clayborg accepted this revision. clayborg added a comment. Yep, fixes it for me! Thanks!! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114973/new/ https://reviews.llvm.org/D114973 ___ lldb-commits maili

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

lawrence_danna added a comment. @clayborg Does this fix it for you? https://reviews.llvm.org/D114973 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___ lldb-

[Lldb-commits] [PATCH] D115001: Simplify logic to identify dyld_sim in Simulator debugging on macos

This revision was automatically updated to reflect the committed changes. Closed by commit rGfddafa110d86: Simplify logic to identify dyld_sim in Simulator debugging on macos (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D1

[Lldb-commits] [lldb] fddafa1 - Simplify logic to identify dyld_sim in Simulator debugging on macos

Author: Jason Molenda Date: 2021-12-02T18:14:13-08:00 New Revision: fddafa110d8628851a48939fe956864b318e8e53 URL: https://github.com/llvm/llvm-project/commit/fddafa110d8628851a48939fe956864b318e8e53 DIFF: https://github.com/llvm/llvm-project/commit/fddafa110d8628851a48939fe956864b318e8e53.diff

[Lldb-commits] [PATCH] D115017: Fix error reporting for "process load" and add a test for it.

jingham created this revision. jingham added a reviewer: JDevlieghere. Herald added a subscriber: emaste. jingham requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We weren't reporting errors (like file not found) from "process load", because

[Lldb-commits] [PATCH] D114008: Draft PR for the deque, stack, queue lldb data formatters

wallace updated this revision to Diff 391513. wallace added a comment. Fix the few issues in Danil's implementation Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114008/new/ https://reviews.llvm.org/D114008 Files: lldb/examples/synthetic/gnu_lib

[Lldb-commits] [PATCH] D115001: Simplify logic to identify dyld_sim in Simulator debugging on macos

jingham accepted this revision. jingham added a comment. This revision is now accepted and ready to land. We will have gotten the full triple from debugserver by the time we get here, so we'll know the Simulator bit, and we get the os_type for dyld_sim from the mach-o header, which has to be rig

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

clayborg added a comment. I am not cross compiling in this case. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113650/new/ https://reviews.llvm.org/D113650 ___ lldb-commits mailing list lldb-commits@list

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

clayborg added a comment. if I try to manually set the python3 executable with: -DPYTHON_EXECUTABLE=/Applications/Xcode.app/Contents/Developer/usr/bin/python3 I get the following error: [cmake] CMake Error at /Users/gclayton/Documents/src/lldb/clean/llvm-project/lldb/CMakeLists.txt:53 (me

[Lldb-commits] [PATCH] D113650: [lldb] fix -print-script-interpreter-info on windows

clayborg added a comment. I can't build on macOS now. I checked out the source code and tried to do: cmake -G Ninja -DCMAKE_BUILD_TYPE:STRING=Debug -DLLVM_ENABLE_ASSERTIONS:BOOL=TRUE -DLLVM_ENABLE_PROJECTS='clang;libcxx;libcxxabi;lldb' -DLLDB_BUILD_FRAMEWORK:BOOL=TRUE -DLLDB_USE_SYSTEM_DEBUG

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

JDevlieghere added a comment. Can we add a small test for the error messages? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114923/new/ https://reviews.llvm.org/D114923 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

clayborg added a comment. In D114288#3165212 , @clayborg wrote: > In D114288#3163808 , @omjavaid > wrote: > >> Hi @clayborg >> This breaks LLDB Arm/Linux buildbot. >> https://lab.llvm.org/buildbot/#/builders/17

[Lldb-commits] [lldb] 266a66c - Include extra input contents on this test so we can see why lldb-arm-ubuntu buildbot is failing.

Author: Greg Clayton Date: 2021-12-02T15:47:15-08:00 New Revision: 266a66c915cbbc36b1a3887963eb97f32306c7e4 URL: https://github.com/llvm/llvm-project/commit/266a66c915cbbc36b1a3887963eb97f32306c7e4 DIFF: https://github.com/llvm/llvm-project/commit/266a66c915cbbc36b1a3887963eb97f32306c7e4.diff

[Lldb-commits] [PATCH] D115001: Simplify logic to identify dyld_sim in Simulator debugging on macos

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: kristof.beyls. jasonmolenda requested review of this revision. The DynamicLoader plugin for macOS needs to identify which binary is the dynamic loader (dyld,

[Lldb-commits] [PATCH] D113930: [LLDB][NativePDB] Fix function decl creation for class methods

zequanwu updated this revision to Diff 391454. zequanwu added a comment. Add test with `lldb-test symbols --dump-ast` though it printed the methods twice. It is considered a separate bug that could be fixed later. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114973/new/ https://reviews.llvm.org/D114973 ___

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

mib marked 2 inline comments as done. mib added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:359 +] return self.register_info DavidSpickett wrote: > Is it worth putting an `else: raise Unkno

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

mib updated this revision to Diff 391389. mib edited the summary of this revision. mib added a comment. Address @DavidSpickett feedbacks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114923/new/ https://reviews.llvm.org/D114923 Files: lldb/exam

[Lldb-commits] [PATCH] D114973: [lldb] add fallback for LLDB_PYTHON_RELATIVE_PATH

lawrence_danna created this revision. lawrence_danna added reviewers: labath, jingham, JDevlieghere. lawrence_danna requested review of this revision. Herald added a project: LLDB. Some pythons are configured to set platlib somewhere outside of their sys.prefix. It's important that we at least u

[Lldb-commits] [PATCH] D114907: [lldb] Skip two lldb tests on Windows because they are flaky

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was automatically updated to reflect the committed changes. Closed by commit rGc24860118a7e: [lldb] Skip two lldb tests on Windows because they are flaky (authored by stella.stamenova). Repository:

[Lldb-commits] [lldb] c248601 - [lldb] Skip two lldb tests on Windows because they are flaky

Author: Stella Stamenova Date: 2021-12-02T09:53:28-08:00 New Revision: c24860118a7e4fe0611a9463498181a4a01b9459 URL: https://github.com/llvm/llvm-project/commit/c24860118a7e4fe0611a9463498181a4a01b9459 DIFF: https://github.com/llvm/llvm-project/commit/c24860118a7e4fe0611a9463498181a4a01b9459.di

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. mgorny requested review of this revision. Recognize FreeBSD vmcores (kernel core dumps) through OS ABI = 0xFF + ELF version = 0, and do not process them via the elf-core plugi

[Lldb-commits] [PATCH] D114923: [lldb/plugins] Add arm64(e) support to ScriptedProcess

DavidSpickett added a reviewer: DavidSpickett. DavidSpickett added inline comments. Comment at: lldb/examples/python/scripted_process/scripted_process.py:357 +{'name': 'pc', 'bitsize': 64, 'offset': 256, 'encoding': 'uint', 'format': 'hex', 'set': 0, 'g

[Lldb-commits] [PATCH] D114861: Don't consider frames with different PCs as a loop

DavidSpickett added a comment. Looking at `GetOneMoreFrame` I agree the logic matches up but don't understand the logic enough overall to approve. I'll leave that to others. Comment at: lldb/source/Target/RegisterContextUnwind.cpp:697 + // theory we can have arbitrary number

Re: [Lldb-commits] [PATCH] D114288: [NFC] Refactor symbol table parsing.

On Thu, 2 Dec 2021 at 01:37, Greg Clayton via Phabricator < revi...@reviews.llvm.org> wrote: > clayborg added a comment. > > In D114288#3163808 , @omjavaid > wrote: > > > Hi @clayborg > > This breaks LLDB Arm/Linux buildbot. > https://lab.llvm.org/buildbot