[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

thakis added inline comments. Comment at: lldb/source/Plugins/Platform/Windows/PlatformWindows.cpp:397 + +error.SetErrorStringWithFormat("LoadLibrary Error: %lu", error_code); +return LLDB_INVALID_IMAGE_TOKEN; ``` ../../lldb/source/Plugins/Platform/Window

[Lldb-commits] [lldb] ee4b462 - [lldb] Fix a warning

Author: Kazu Hirata Date: 2021-12-04T18:34:29-08:00 New Revision: ee4b462693b1ffeccfe1b8fcf0a0c12896ac6e6a URL: https://github.com/llvm/llvm-project/commit/ee4b462693b1ffeccfe1b8fcf0a0c12896ac6e6a DIFF: https://github.com/llvm/llvm-project/commit/ee4b462693b1ffeccfe1b8fcf0a0c12896ac6e6a.diff L

[Lldb-commits] [PATCH] D115074: [lldb/lua] Suppress warnings about C-linkage in generated wrapper

dim added a comment. In D115074#3170635 , @JDevlieghere wrote: > We should move this from the wrapper to the header block, similar to what > Pavel did for Python: > https://reviews.llvm.org/rG9a14adeae00015798843ff5cad987e5fdbdddb34 I agree, but I'm n

[Lldb-commits] [PATCH] D115104: [lldb] Fix guessing of windows path style

jarin created this revision. jarin added a reviewer: labath. jarin requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Currently, only paths with length>3 are guessed as Windows paths. This prevents root paths (such as C:\) to be recognized as

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 updated this revision to Diff 391867. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 Files: lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp:1 +#include "DWARFASTParser.h" +#include "DWARFAttribute.h" ljmf00 wrote: > bulbazord wrote: > > This file will need a license header. > Yes, my bad. Thanks for noti

[Lldb-commits] [PATCH] D114668: [lldb][NFC] Move generic DWARFASTParser code out of Clang-specific code

ljmf00 updated this revision to Diff 391856. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114668/new/ https://reviews.llvm.org/D114668 Files: lldb/source/Plugins/SymbolFile/DWARF/CMakeLists.txt lldb/source/Plugins/SymbolFile/DWARF/DWARFASTParser.cpp lldb/source/Plugins/SymbolFile/

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

This revision was automatically updated to reflect the committed changes. compnerd marked an inline comment as done. Closed by commit rGf1585a4b47cc: Windows: support `DoLoadImage` (authored by compnerd). Changed prior to commit: https://reviews.llvm.org/D77287?vs=390249&id=391847#toc Reposito

[Lldb-commits] [lldb] f1585a4 - Windows: support `DoLoadImage`

Author: Saleem Abdulrasool Date: 2021-12-04T11:11:47-08:00 New Revision: f1585a4b47cc9c08c9a4c10058597f4b7468c227 URL: https://github.com/llvm/llvm-project/commit/f1585a4b47cc9c08c9a4c10058597f4b7468c227 DIFF: https://github.com/llvm/llvm-project/commit/f1585a4b47cc9c08c9a4c10058597f4b7468c227.

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 391834. mgorny edited the summary of this revision. mgorny added a comment. Herald added a subscriber: kristof.beyls. Also i386. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https://reviews.llvm.org/D114911 Files: lldb/source/Plugins/

[Lldb-commits] [PATCH] D114911: [lldb] Introduce a FreeBSDKernel plugin for vmcores

mgorny updated this revision to Diff 391827. mgorny added a comment. Add arm64 support, simplify logic in ThreadFreeBSDKernel, handle unsupported architectures gracefully (instead of crashing). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114911/new/ https://reviews.llvm.org/D114911

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

mgorny updated this revision to Diff 391826. mgorny added a comment. Sorry, accidentally uploaded the patch to the wrong revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114967/new/ https://reviews.llvm.org/D114967 Files: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

mgorny updated this revision to Diff 391822. mgorny added a comment. Add arm64 support, simplify logic in ThreadFreeBSDKernel, handle unsupported architectures gracefully (instead of crashing). CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114967/new/ https://reviews.llvm.org/D114967