[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg marked 6 inline comments as done. clayborg added inline comments. Comment at: lldb/source/Utility/DataFileCache.cpp:58 + else +consumeError(cache_or_err.takeError()); +} wallace wrote: > could you create a new lldb log channel where this

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg updated this revision to Diff 394141. clayborg added a comment. Address all review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115324/new/ https://reviews.llvm.org/D115324 Files: lldb/include/lldb/Core/Mangled.h

[Lldb-commits] [PATCH] D115698: [lldb] Check if language is supported before creating a REPL instance

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, teemperor. JDevlieghere requested review of this revision. Currently, we'll try to instantiate a ClangREPL for every known language. The plugin manager already knows what languages are supported, so rely on that to only

[Lldb-commits] [PATCH] D115570: [lldb] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 394118. Ericson2314 added a comment. 1. Updating D115570 : [lldb] Use `GNUInstallDirs` to support custom installation dirs. # 2. Enter a brief description of the changes included in this update. 3. The first line is

[Lldb-commits] [PATCH] D115570: [lldb] Use `GNUInstallDirs` to support custom installation dirs.

Ericson2314 updated this revision to Diff 394117. Ericson2314 added a comment. simplify Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115570/new/ https://reviews.llvm.org/D115570 Files: lldb/CMakeLists.txt lldb/cmake/modules/AddLLDB.cmake

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

shafik accepted this revision. shafik added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115662/new/ https://reviews.llvm.org/D115662

Re: [Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

This is NFC On Mon, Dec 13, 2021 at 5:00 PM David Blaikie wrote: > Any chance of test coverage? > > On Mon, Dec 13, 2021 at 4:58 PM Jonas Devlieghere via lldb-commits < > lldb-commits@lists.llvm.org> wrote: > >> >> Author: Jonas Devlieghere >> Date: 2021-12-13T16:58:39-08:00 >> New Revision:

Re: [Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

Any chance of test coverage? On Mon, Dec 13, 2021 at 4:58 PM Jonas Devlieghere via lldb-commits < lldb-commits@lists.llvm.org> wrote: > > Author: Jonas Devlieghere > Date: 2021-12-13T16:58:39-08:00 > New Revision: 58473d84e0c7796de5dcfd3153e5d5cc8ad034b3 > > URL: >

[Lldb-commits] [lldb] 58473d8 - [lldb] Use LLDB_VERSION_STRING instead of CLANG_VERSION_STRING

Author: Jonas Devlieghere Date: 2021-12-13T16:58:39-08:00 New Revision: 58473d84e0c7796de5dcfd3153e5d5cc8ad034b3 URL: https://github.com/llvm/llvm-project/commit/58473d84e0c7796de5dcfd3153e5d5cc8ad034b3 DIFF:

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. much nicer than the first version. I'm just asking a few minor things. Comment at: lldb/include/lldb/Host/FileSystem.h:147 + /// + /// The path must specify a

[Lldb-commits] [PATCH] D94997: [lldb][lldb-vscode] Updated implementation of 'launch' and 'attach' requests to not create auxiliary target in case "launchCommands" and "attachCommands" are provided.

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Revert the whitespace only changes to the .py file and good to go as long as all vscode tests are passing. Comment at:

[Lldb-commits] [PATCH] D77287: Windows: support `DoLoadImage`

compnerd added a comment. Thanks @thakis - 906e60b9f923464cba0f71a9205846550752162f should have addressed that from a few days ago (sorry about not mentioning that here) Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

dblaikie accepted this revision. dblaikie added a comment. This revision is now accepted and ready to land. Looks alright CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D115324: Added the ability to cache the finalized symbol tables subsequent debug sessions to start faster.

clayborg updated this revision to Diff 394041. clayborg added a comment. Added string tables to the cache files. This allowed me to add the symbol table name indexes to the same symbol table cache file and share any strings from the normal symbol table. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

This revision was automatically updated to reflect the committed changes. Closed by commit rGf2120328e818: Add support for a load binary LC_NOTE in mach-o corefiles (authored by jasonmolenda). Changed prior to commit: https://reviews.llvm.org/D115494?vs=393668=394031#toc Repository: rG LLVM

[Lldb-commits] [lldb] f212032 - Add support for a "load binary" LC_NOTE in mach-o corefiles

Author: Jason Molenda Date: 2021-12-13T13:21:56-08:00 New Revision: f2120328e81879bf14d2a5c381749a11577fa304 URL: https://github.com/llvm/llvm-project/commit/f2120328e81879bf14d2a5c381749a11577fa304 DIFF: https://github.com/llvm/llvm-project/commit/f2120328e81879bf14d2a5c381749a11577fa304.diff

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

nealsid added a comment. Thanks, Pavel. Some comments responded to, will take another look at the buffered/unbuffered I/O issue and address the remaining comments. Comment at: lldb/include/lldb/Host/Editline.h:392-393 + + friend class

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 created this revision. Herald added a reviewer: shafik. ljmf00 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This assignment is already being done via UpdateSymbolContextScopeForType routine at the end of the type parsing

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

ljmf00 added a comment. Sorry for the delay. Can you re-review this @dblaikie ? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D113604: [lldb][NFC] Format lldb/include/lldb/Symbol/Type.h

ljmf00 updated this revision to Diff 394001. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113604/new/ https://reviews.llvm.org/D113604 Files: lldb/include/lldb/Symbol/Type.h lldb/source/Symbol/Type.cpp Index: lldb/source/Symbol/Type.cpp

[Lldb-commits] [PATCH] D114791: [lldb] Clarify StructuredDataImpl ownership

This revision was automatically updated to reflect the committed changes. labath marked an inline comment as done. Closed by commit rG82de8df26f15: [lldb] Clarify StructuredDataImpl ownership (authored by labath). Changed prior to commit: https://reviews.llvm.org/D114791?vs=390672=393996#toc

[Lldb-commits] [lldb] 82de8df - [lldb] Clarify StructuredDataImpl ownership

Author: Pavel Labath Date: 2021-12-13T21:04:51+01:00 New Revision: 82de8df26f15778793dc6b1526e14779f435f2e1 URL: https://github.com/llvm/llvm-project/commit/82de8df26f15778793dc6b1526e14779f435f2e1 DIFF: https://github.com/llvm/llvm-project/commit/82de8df26f15778793dc6b1526e14779f435f2e1.diff

[Lldb-commits] [PATCH] D114791: [lldb] Clarify StructuredDataImpl ownership

labath marked an inline comment as done. labath added inline comments. Comment at: lldb/bindings/lua/lua-wrapper.swig:31 lldb::BreakpointLocationSP bp_loc_sp, StructuredDataImpl *extra_args_impl ) mib wrote: > May be we should keep consistency with the

[Lldb-commits] [lldb] 82d6a96 - disable test on older compilers

Author: Adrian Prantl Date: 2021-12-13T11:59:05-08:00 New Revision: 82d6a96e129e959f78173a4ad5d165380f98d3f5 URL: https://github.com/llvm/llvm-project/commit/82d6a96e129e959f78173a4ad5d165380f98d3f5 DIFF: https://github.com/llvm/llvm-project/commit/82d6a96e129e959f78173a4ad5d165380f98d3f5.diff

[Lldb-commits] [PATCH] D115654: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory

This revision was automatically updated to reflect the committed changes. Closed by commit rGef74c8002ae8: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D115652: [lldb/API] Add SetDataWithOwnership method to SBData

This revision was automatically updated to reflect the committed changes. Closed by commit rG72e25978f93f: [lldb/API] Add SetDataWithOwnership method to SBData (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115652/new/

[Lldb-commits] [lldb] ef74c80 - [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory

Author: Med Ismail Bennani Date: 2021-12-13T11:05:07-08:00 New Revision: ef74c8002ae86d95fd9d1927233102aac52d769c URL: https://github.com/llvm/llvm-project/commit/ef74c8002ae86d95fd9d1927233102aac52d769c DIFF:

[Lldb-commits] [lldb] 72e2597 - [lldb/API] Add SetDataWithOwnership method to SBData

Author: Med Ismail Bennani Date: 2021-12-13T11:05:06-08:00 New Revision: 72e25978f93f0bf7577593aba9591c727526423c URL: https://github.com/llvm/llvm-project/commit/72e25978f93f0bf7577593aba9591c727526423c DIFF:

[Lldb-commits] [PATCH] D115654: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115654/new/ https://reviews.llvm.org/D115654

[Lldb-commits] [PATCH] D115652: [lldb/API] Add SetDataWithOwnership method to SBData

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115652/new/ https://reviews.llvm.org/D115652

[Lldb-commits] [PATCH] D115654: [lldb/plugin] Fix heap-use-after-free in ScriptedProcess::ReadMemory

mib created this revision. mib added reviewers: JDevlieghere, aprantl. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This commit should fix a heap-use-after-free bug that was caught by the sanitizer bot. The issue is that we were

[Lldb-commits] [PATCH] D115126: [LLDB] Add unit tests for Editline keyboard shortcuts

labath added inline comments. Comment at: lldb/include/lldb/Host/Editline.h:392-393 + + friend class EditlineKeyboardBindingTest_MultiLineEditlineKeybindings_Test; + friend class EditlineKeyboardBindingTest_SingleLineEditlineKeybindings_Test; }; This also

[Lldb-commits] [PATCH] D115652: [lldb/API] Add SetDataWithOwnership method to SBData

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: yaxunl. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new method to SBData: SetDataWithOwnership. Instead of referencing

[Lldb-commits] [PATCH] D115201: [lldb] Move UpdateSymbolContextScopeForType

ljmf00 added a comment. In D115201#3176955 , @shafik wrote: > Can you add a motivation for this to your summary, thank you! I added some description to it. I don't think it is worth mentioning my work on upstreaming the D lldb plugin, but I'm doing

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

jasonmolenda added inline comments. Comment at: lldb/test/API/macosx/function-starts/TestFunctionStarts.py:68 bkpt = target.BreakpointCreateByName("dont_strip_me", exe) +self.runCmd("b dont_strip_me") self.assertTrue(bkpt.GetNumLocations() > 0, "Didn't

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

labath added a comment. I don't know whether the types should be uniqued at this level (obviously, they should be uniqued somewhere), but these are the thoughts that spring to mind: - if this is a problem for lldb-test, then it would be preferable to come up with a solution that does not

[Lldb-commits] [PATCH] D115494: Add support to lldb for reading a "load binary" LC_NOTE with Mach-O corefiles

DavidSpickett accepted this revision. DavidSpickett added a comment. This revision is now accepted and ready to land. LGTM assuming the change in TestFunctionStarts.py wasn't meant to be included. Comment at: lldb/test/API/macosx/function-starts/TestFunctionStarts.py:68

[Lldb-commits] [lldb] 529e03e - [lldb] Remove named function arguments from TestQemuLaunch

Author: Pavel Labath Date: 2021-12-13T15:30:26+01:00 New Revision: 529e03ea650a8eb3327c697c9c930793ab54c0af URL: https://github.com/llvm/llvm-project/commit/529e03ea650a8eb3327c697c9c930793ab54c0af DIFF: https://github.com/llvm/llvm-project/commit/529e03ea650a8eb3327c697c9c930793ab54c0af.diff