[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu added a comment. In D115308#3189261 , @labath wrote: > I don't know whether the types should be uniqued at this level (obviously, > they should be uniqued somewhere), but these are the thoughts that spring to > mind: > > - if this is a problem

[Lldb-commits] [PATCH] D115308: [LLDB] Uniquify Type in type list.

zequanwu updated this revision to Diff 395543. zequanwu added a comment. Revert back to first diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115308/new/ https://reviews.llvm.org/D115308 Files:

[Lldb-commits] [PATCH] D116028: [lldb] Use GetSupportedArchitectures on darwin platforms

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. This was on my todo-list for this week but you beat me to it. Thanks for taking care of this! LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D116012: Fix "settings set -g" so it works again.

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116012/new/ https://reviews.llvm.org/D116012

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

mgorny added a comment. In D116005#3202721 , @labath wrote: > How about factoring the two implementations into subclasses. If the classes > are small, maybe you can just declare them in the cpp file... Yes, that's a nice idea. As an extra, we can

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

mgorny updated this revision to Diff 395471. mgorny added a comment. Split into FVC/KVM classes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116005/new/ https://reviews.llvm.org/D116005 Files: lldb/source/Plugins/Process/FreeBSDKernel/CMakeLists.txt

[Lldb-commits] [lldb] af27466 - Reland "[AST] Add UsingType: a sugar type for types found via UsingDecl"

Author: Sam McCall Date: 2021-12-20T18:03:15+01:00 New Revision: af27466c50398e3f04372850370eab8dc8abbb92 URL: https://github.com/llvm/llvm-project/commit/af27466c50398e3f04372850370eab8dc8abbb92 DIFF: https://github.com/llvm/llvm-project/commit/af27466c50398e3f04372850370eab8dc8abbb92.diff

[Lldb-commits] [lldb] cc56c66 - Revert "[AST] Add UsingType: a sugar type for types found via UsingDecl"

Author: Sam McCall Date: 2021-12-20T17:53:56+01:00 New Revision: cc56c66f27e131b914082d3bd21180646e842e9a URL: https://github.com/llvm/llvm-project/commit/cc56c66f27e131b914082d3bd21180646e842e9a DIFF: https://github.com/llvm/llvm-project/commit/cc56c66f27e131b914082d3bd21180646e842e9a.diff

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg updated this revision to Diff 395441. clayborg added a comment. Remove commented out code. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115951/new/ https://reviews.llvm.org/D115951 Files: lldb/include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

clayborg updated this revision to Diff 395440. clayborg added a comment. Address review comments. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115951/new/ https://reviews.llvm.org/D115951 Files: lldb/include/lldb/Symbol/SymbolFile.h

[Lldb-commits] [PATCH] D116005: [lldb] [Process/FreeBSDKernel] Introduce libkvm support

labath added a comment. How about factoring the two implementations into subclasses. If the classes are small, maybe you can just declare them in the cpp file... CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116005/new/ https://reviews.llvm.org/D116005

[Lldb-commits] [PATCH] D115951: Cache the manual DWARF index out to the LLDB cache directory when the LLDB index cache is enabled.

labath added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DIERef.h:59 +return m_dwo_num_valid == rhs.m_dwo_num_valid && + m_dwo_num == rhs.m_dwo_num && m_section == rhs.m_section && + m_die_offset == rhs.m_die_offset;

[Lldb-commits] [PATCH] D116028: [lldb] Use GetSupportedArchitectures on darwin platforms

labath created this revision. labath added a reviewer: JDevlieghere. labath requested review of this revision. Herald added a project: LLDB. This finishes the GetSupportedArchitectureAtIndex migration. There are opportunities to simplify this even further, but I am going to leave that to the

[Lldb-commits] [PATCH] D113174: [lldb] Summary provider for char flexible array members

This revision was automatically updated to reflect the committed changes. Closed by commit rG35870c442210: [lldb] Summary provider for char flexible array members (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113174/new/

[Lldb-commits] [lldb] 35870c4 - [lldb] Summary provider for char flexible array members

Author: Pavel Labath Date: 2021-12-20T12:30:34+01:00 New Revision: 35870c442210b885391926f6ae8546beba70906f URL: https://github.com/llvm/llvm-project/commit/35870c442210b885391926f6ae8546beba70906f DIFF: https://github.com/llvm/llvm-project/commit/35870c442210b885391926f6ae8546beba70906f.diff

[Lldb-commits] [lldb] f0a670e - [lldb/test] Remove some decorators from TestModuleCacheUniversal

Author: Pavel Labath Date: 2021-12-20T12:20:00+01:00 New Revision: f0a670e93b61928982e43afb2d57179ea18f0b8c URL: https://github.com/llvm/llvm-project/commit/f0a670e93b61928982e43afb2d57179ea18f0b8c DIFF: https://github.com/llvm/llvm-project/commit/f0a670e93b61928982e43afb2d57179ea18f0b8c.diff

[Lldb-commits] [lldb] 6c2bf01 - [lldb/python] Fix a compile error in 7406d236d8

Author: Pavel Labath Date: 2021-12-20T09:57:29+01:00 New Revision: 6c2bf01270a8a52b7986d5c49eaa7ad1c7083ec5 URL: https://github.com/llvm/llvm-project/commit/6c2bf01270a8a52b7986d5c49eaa7ad1c7083ec5 DIFF: https://github.com/llvm/llvm-project/commit/6c2bf01270a8a52b7986d5c49eaa7ad1c7083ec5.diff

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

This revision was automatically updated to reflect the committed changes. Closed by commit rG7406d236d873: [lldb/python] Fix (some) dangling pointers in our glue code (authored by labath). Changed prior to commit: https://reviews.llvm.org/D115925?vs=395072=395389#toc Repository: rG LLVM

[Lldb-commits] [lldb] 7406d23 - [lldb/python] Fix (some) dangling pointers in our glue code

Author: Pavel Labath Date: 2021-12-20T09:42:08+01:00 New Revision: 7406d236d873d74b01c3cef285e5d9012dcef151 URL: https://github.com/llvm/llvm-project/commit/7406d236d873d74b01c3cef285e5d9012dcef151 DIFF: https://github.com/llvm/llvm-project/commit/7406d236d873d74b01c3cef285e5d9012dcef151.diff

[Lldb-commits] [PATCH] D115925: [lldb/python] Fix (some) dangling pointers in our glue code

labath added a comment. Thanks. In case anyone's wondering, the reason for that stray command is because I originally wanted to test this via `use_debugger` command. However, that turned out to not work because the SBDebugger object for the `use_debugger`s own argument was created at the exact

[Lldb-commits] [PATCH] D116009: [lldb/gdb-remote] drop all junk bytes in incoming packet

labath added a comment. The find_first_of solution does look better. For the test, I /think/ it would be sufficient to add a new case to the test in `unittests/Process/gdb-remote/GDBRemoteCommunicationTest.cpp`. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION