[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

labath added a comment. How are you planning to make use of this functionality? I'm asking because I'm wondering if it wouldn't be better to do this kind of processing in the PDB code, and then hand this class a finished list of line entries. Inserting entries into the middle of a vector is exp

[Lldb-commits] [PATCH] D106837: Create synthetic symbol names on demand to improve memory consumption and startup times.

rZhBoYao added a comment. Hi all, I found this patch causing PR52702 in that the parent of this commit and LLDB 12 worked fine. When disassembling a hello world C program on Linux, LLDB used to show `callq 0x4010

[Lldb-commits] [PATCH] D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. jasonmolenda requested review of this revision. We have a gdb stub that can get the UUID and address/slide of the firmware running on a device, and I'm adding support for sending t

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

rZhBoYao created this revision. rZhBoYao added reviewers: clayborg, wallace, JDevlieghere. rZhBoYao added a project: LLDB. rZhBoYao requested review of this revision. Herald added a subscriber: lldb-commits. Mangled::operator! claimes to be true if the object has an empty mangled and unmangled na

[Lldb-commits] [PATCH] D116217: [lldb] Fix PR52702 by fixing Mangled::operator!

clayborg requested changes to this revision. clayborg added a comment. This revision now requires changes to proceed. We should add a unit test for this to verify this doesn't regress in lldb/unittests/Core/MangledTest.cpp for both the operator bool and the ! operator Comment

[Lldb-commits] [PATCH] D106837: Create synthetic symbol names on demand to improve memory consumption and startup times.

clayborg added a comment. In D106837#3207676 , @rZhBoYao wrote: > Hi all, I found this patch causing PR52702 in that > the parent of this commit > and LLDB 12 worked > fi

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 added a comment. In D115662#3192735 , @labath wrote: > In D115662#3192651 , @ljmf00 wrote: > >> In D115662#3192064 , @labath wrote: >> >>> I don't have any issues w

[Lldb-commits] [PATCH] D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:584 + + if (!module_sp.get()) { +// Force a an external lookup,

[Lldb-commits] [PATCH] D116195: [LLDB] Allows overwriting the existing line entry at given file address when inserting

zequanwu added a comment. In D116195#3207672 , @labath wrote: > How are you planning to make use of this functionality? > > I'm asking because I'm wondering if it wouldn't be better to do this kind of > processing in the PDB code, and then hand this clas

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny created this revision. mgorny added reviewers: labath, krytarowski, emaste. Herald added a subscriber: arichardson. mgorny requested review of this revision. Include the complete list of threads of all running processes in the FreeBSDKernel plugin. This makes it possible to inspect the sta

[Lldb-commits] [PATCH] D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it

jasonmolenda updated this revision to Diff 396111. jasonmolenda added a comment. Update patch to incorporate Jonas' feedback. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116211/new/ https://reviews.llvm.org/D116211 Files: lldb/docs/lldb-gdb-re

[Lldb-commits] [lldb] 8a26ba6 - Load binary by UUID from qProcessInfo packet fields

Author: Jason Molenda Date: 2021-12-23T15:20:50-08:00 New Revision: 8a26ba6a02f1319ddaca017bbda81c2b82fb4050 URL: https://github.com/llvm/llvm-project/commit/8a26ba6a02f1319ddaca017bbda81c2b82fb4050 DIFF: https://github.com/llvm/llvm-project/commit/8a26ba6a02f1319ddaca017bbda81c2b82fb4050.diff

[Lldb-commits] [PATCH] D116211: With firmware debug sess, if gdb stub knows the UUID/address of binary, try to load it

This revision was automatically updated to reflect the committed changes. Closed by commit rG8a26ba6a02f1: Load binary by UUID from qProcessInfo packet fields (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116211/new/ http

[Lldb-commits] [PATCH] D116162: [lldb/python] Fix dangling Event and CommandReturnObject references

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. This patch looks good to me, however, may be it would be good to have a `IsInitialized`/ `IsCleared` method for all SB-types to make sure the object hasn't been cleared after going out-of-scope ? I