[Lldb-commits] [PATCH] D116372: [lldb-server/linux] Fix waitpid for multithreaded forks

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1909 + wait_status); +tid_events.try_emplace(thread_up->GetID(), wait_status); + } mgorny wrote: > Hmm, I'm a bit confused here. Why would the key

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

labath added a comment. Can we make the number of threads smaller? Perhaps by patching the linked lists to skip the uninteresting ones? 600 threads is way too much, all we really need is one thread from each of the three categories. Then you can meaningfully assert the names and registers of th

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny added a comment. That would be a lot of work, and it would need to be repeated whenever the test data needs to be regenerated. How about leaving the threads as-is but just testing the few selected ones from the list? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116255/new/ htt

[Lldb-commits] [PATCH] D116372: [lldb-server/linux] Fix waitpid for multithreaded forks

mgorny added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1918 +} else { + // This can happen if one of the events is an main thread exit. + LLDB_LOG(log, "... but the thread has disappeared"); labath wrote:

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

labath added a comment. That would deal with the code coverage, but it still leaves us with a fairly large core file, and a lot of uninteresting tests obscuring the output. How do you generate these core files? Do you actually create a fresh core dump or you just recompute the "interesting" por

[Lldb-commits] [PATCH] D116372: [lldb-server/linux] Fix waitpid for multithreaded forks

labath added inline comments. Comment at: lldb/source/Plugins/Process/Linux/NativeProcessLinux.cpp:1918 +} else { + // This can happen if one of the events is an main thread exit. + LLDB_LOG(log, "... but the thread has disappeared"); mgorny wrote:

[Lldb-commits] [lldb] d7dbe2c - [lldb] Remove lldbtest.getBuildFlags

Author: Pavel Labath Date: 2021-12-30T12:19:24+01:00 New Revision: d7dbe2c4a00ba2abd998328ad6b8023637bc71d9 URL: https://github.com/llvm/llvm-project/commit/d7dbe2c4a00ba2abd998328ad6b8023637bc71d9 DIFF: https://github.com/llvm/llvm-project/commit/d7dbe2c4a00ba2abd998328ad6b8023637bc71d9.diff

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny added a comment. In D116255#3213612 , @labath wrote: > That would deal with the code coverage, but it still leaves us with a fairly > large core file, and a lot of uninteresting tests obscuring the output. > > How do you generate these core files?

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny added a comment. Ok, so limiting to 200-ish threads halves the data size: -rw-r--r-- 1 mgorny mgorny 76K 12-30 14:16 /tmp/vmcore.bz2 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116255/new/ https://reviews.llvm.org/D116255 ___ lldb

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

labath added a comment. In D116255#3213665 , @mgorny wrote: > In D116255#3213612 , @labath wrote: > >> That would deal with the code coverage, but it still leaves us with a fairly >> large core file, and a lot of

[Lldb-commits] [lldb] 9b8f9d3 - [lldb/qemu] More flexible emulator specification

Author: Pavel Labath Date: 2021-12-30T15:14:41+01:00 New Revision: 9b8f9d33dbbcd6525ab4d582cb9abb6f98e3601c URL: https://github.com/llvm/llvm-project/commit/9b8f9d33dbbcd6525ab4d582cb9abb6f98e3601c DIFF: https://github.com/llvm/llvm-project/commit/9b8f9d33dbbcd6525ab4d582cb9abb6f98e3601c.diff

[Lldb-commits] [PATCH] D116419: [lldb] Display MachO seg, sec of memory region

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, aprantl. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. `memory region` displays the top-level section name, which for MachO is the segment name. Th

[Lldb-commits] [PATCH] D115662: [lldb][DWARF] Remove duplicate DIE type assignment

ljmf00 planned changes to this revision. ljmf00 added a comment. In D115662#3211312 , @labath wrote: > I don't have any issues with this, if everything still works. I hoped there > would be more of a discussion on this (I was hoping I'd maybe learn somet