[Lldb-commits] [PATCH] D116682: [lldb] Add StringList::AppendString(const Twine&) (NFC)

This revision was automatically updated to reflect the committed changes. Closed by commit rG3a1a0d4957ec: [lldb] Add StringList::AppendString(const Twine) (NFC) (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116682/new/

[Lldb-commits] [lldb] 3a1a0d4 - [lldb] Add StringList::AppendString(const Twine&) (NFC)

Author: Dave Lee Date: 2022-01-05T18:49:15-08:00 New Revision: 3a1a0d4957ece964a88b9912f4a86f651f026392 URL: https://github.com/llvm/llvm-project/commit/3a1a0d4957ece964a88b9912f4a86f651f026392 DIFF: https://github.com/llvm/llvm-project/commit/3a1a0d4957ece964a88b9912f4a86f651f026392.diff

[Lldb-commits] [PATCH] D116708: [lldb] Break out long help for 'frame var'

This revision was automatically updated to reflect the committed changes. Closed by commit rGef6817f9329c: [lldb] Break out long help for frame var (authored by kastiglione). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116708/new/

[Lldb-commits] [lldb] ef6817f - [lldb] Break out long help for 'frame var'

Author: Dave Lee Date: 2022-01-05T18:47:52-08:00 New Revision: ef6817f9329ce16dae33e64e2534a52647f089b0 URL: https://github.com/llvm/llvm-project/commit/ef6817f9329ce16dae33e64e2534a52647f089b0 DIFF: https://github.com/llvm/llvm-project/commit/ef6817f9329ce16dae33e64e2534a52647f089b0.diff

[Lldb-commits] [PATCH] D116682: [lldb] Add StringList::AppendString(const Twine&) (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116682/new/ https://reviews.llvm.org/D116682

[Lldb-commits] [PATCH] D116708: [lldb] Break out long help for 'frame var'

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Neat. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116708/new/ https://reviews.llvm.org/D116708

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

JDevlieghere requested changes to this revision. JDevlieghere added a comment. This revision now requires changes to proceed. We shouldn't have to manage memory at this granularity. Why isn't `xmlFreeDoc` cleaning this up? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D116708: [lldb] Break out long help for 'frame var'

kastiglione created this revision. kastiglione added reviewers: augusto2112, JDevlieghere, jingham, rastogishubham. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current help for `frame variable` is somewhat long. Its

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

yuanzi created this revision. yuanzi added a reviewer: LLDB. yuanzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While running heap checker on a test that uses LLDB API, the following memory leak is found: RAW: HeapChecker started...

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

This revision was automatically updated to reflect the committed changes. JDevlieghere marked 2 inline comments as done. Closed by commit rG46a28a954e5e: [lldb] Create a property to store the REPL language (authored by JDevlieghere). Herald added a project: LLDB. Repository: rG LLVM Github

[Lldb-commits] [lldb] 46a28a9 - [lldb] Create a property to store the REPL language

Author: Jonas Devlieghere Date: 2022-01-05T15:03:46-08:00 New Revision: 46a28a954e5e813f64ff458891b2d0891963c7d8 URL: https://github.com/llvm/llvm-project/commit/46a28a954e5e813f64ff458891b2d0891963c7d8 DIFF:

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

JDevlieghere marked 2 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1777 if (auto single_lang = repl_languages.GetSingularLanguage()) { language = *single_lang; aprantl wrote: > As you said

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

aprantl added inline comments. Comment at: lldb/source/Core/Debugger.cpp:1777 if (auto single_lang = repl_languages.GetSingularLanguage()) { language = *single_lang; As you said in the description, this is effectively dead code. Is this to be

[Lldb-commits] [PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

thakis added a comment. Not sure what happened here but this change added back a whole bunch of old code. I reverted this in 085f078307bac264301b07f6e47e2a04e90a6f1d . Please carefully check `git diff origin/main` before

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

jhenderson added inline comments. Comment at: llvm/docs/CommandGuide/llvm-install-name-tool.rst:79 -To report bugs, please visit . +To report bugs, please visit . I believe

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added a comment. @asl hi, do you feel good with this revision? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

MaskRay reopened this revision. MaskRay added a subscriber: ldionne. MaskRay added a comment. (CC @ldionne @smeenai) The revert 859ebca744e634dcc89a2294ffa41574f947bd62 included many unintended changes. Repository: rG

[Lldb-commits] [PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG859ebca744e6: Revert D109159 [amdgpu] Enable selection of `s_cselect_b64`. (authored by david-salinas). Herald added subscribers: cfe-commits,

[Lldb-commits] [PATCH] D115960: Revert D109159 "[amdgpu] Enable selection of `s_cselect_b64`."

smeenai added a comment. Herald added a subscriber: JDevlieghere. I believe you landed the wrong commit. rG859ebca744e634dcc89a2294ffa41574f947bd62 looks like the previous versions of this diff, where lots of extraneous

[Lldb-commits] [PATCH] D116547: Revert "[amdgpu] Enable selection of `s_cselect_b64`."

david-salinas abandoned this revision. david-salinas added a comment. Abandoning. Will use D115960 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116547/new/ https://reviews.llvm.org/D116547

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

JDevlieghere added a comment. No test because this is NFC upstream where there's only one supported REPL language. This is tested downstream in the Swift fork. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116697/new/ https://reviews.llvm.org/D116697

[Lldb-commits] [PATCH] D116697: [lldb] Create a property to store the REPL language

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, teemperor, labath. JDevlieghere requested review of this revision. Until the introduction of the C++ REPL, there was always a single REPL language. The code relied on this assumption through

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a subscriber: aprantl. shafik added a comment. In D112709#3223098 , @shafik wrote: > Because `BOOL` is actually a `signed char` @aprantl corrected me, it can vary on some platforms it is `signed char` but on others it is `bool`.

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere accepted this revision. JDevlieghere added a comment. Thanks! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione updated this revision to Diff 397681. kastiglione added a comment. explicit std::string type Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/ https://reviews.llvm.org/D116491 Files:

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto _name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +

[Lldb-commits] [PATCH] D115974: [formatters] Improve documentation

wallace updated this revision to Diff 397667. wallace added a comment. per comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D115974/new/ https://reviews.llvm.org/D115974 Files: lldb/docs/use/variable.rst Index: lldb/docs/use/variable.rst

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

augusto2112 accepted this revision. augusto2112 added a comment. This revision is now accepted and ready to land. I liked the small cleanups in the code as well! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116491/new/

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto _name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a comment. Because `BOOL` is actually a `signed char` Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112709/new/ https://reviews.llvm.org/D112709 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

shafik added a comment. Pavel, I apologize no one let you know earlier but it looks like this change broke `TestFormattersBoolRefPtr.py` test. see: https://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/39449/ Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

kastiglione added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto _name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +

[Lldb-commits] [PATCH] D116682: [lldb] Add StringList::AppendString(const Twine&) (NFC)

kastiglione created this revision. kastiglione added a reviewer: JDevlieghere. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add a convenience for appending constructed string values. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

JDevlieghere added inline comments. Comment at: lldb/source/Interpreter/CommandInterpreter.cpp:2864 + for (const auto _name : subcommands_found) { +auto qualified_name = (command_name + " " + subcommand_name).str(); +

[Lldb-commits] [PATCH] D116625: [lldb] [debugserver] Simplify handling of arch specific files

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Sounds reasonable, with the ifdefs in place I can't think of any reason this would break. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] df4ad36 - [lldb/linux] Fix a race in handling of simultaneous thread exits

Author: Pavel Labath Date: 2022-01-05T13:21:35+01:00 New Revision: df4ad3625fad54d91b688564d5b2408aa943ebe4 URL: https://github.com/llvm/llvm-project/commit/df4ad3625fad54d91b688564d5b2408aa943ebe4 DIFF: https://github.com/llvm/llvm-project/commit/df4ad3625fad54d91b688564d5b2408aa943ebe4.diff