[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Usually, the only thing one can do if a close fails is to log an error message, so it's not completely surprising that this has gone by unnoticed. It might be nice to insert a close call to

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

labath added a comment. Yes, that's the API I had in mind, but check out the inline comments for some problems/improvements. Comment at: lldb/source/Host/common/XML.cpp:141 + attr_value = (const char *)value; + free(value); +} this should be

[Lldb-commits] [lldb] bd23dff - Revert "[lldb] Compute fully qualified command names in FindCommandsForApropos"

Author: Dave Lee Date: 2022-01-06T20:15:19-08:00 New Revision: bd23dffc2c38b7cffd3811716fd373cd2b588c27 URL: https://github.com/llvm/llvm-project/commit/bd23dffc2c38b7cffd3811716fd373cd2b588c27 DIFF: https://github.com/llvm/llvm-project/commit/bd23dffc2c38b7cffd3811716fd373cd2b588c27.diff

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added a subscriber: jingham. kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:560-563 } else if (num_matches == 0) { -result.GetErrorStream().Printf("error: no variables matched " -

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione added inline comments. Comment at: lldb/source/Commands/CommandObjectFrame.cpp:560-563 } else if (num_matches == 0) { -result.GetErrorStream().Printf("error: no variables matched " - "the

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione updated this revision to Diff 398040. kastiglione added a comment. s/warning/error Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116788/new/ https://reviews.llvm.org/D116788 Files: lldb/source/Commands/CommandObjectFrame.cpp

[Lldb-commits] [PATCH] D116788: [lldb] Set result error state in 'frame variable'

kastiglione created this revision. kastiglione added reviewers: JDevlieghere, clayborg. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Ensure that errors in `frame variable` are reflected in result object. The statistics for

[Lldb-commits] [PATCH] D116491: [lldb] Compute fully qualified command names in FindCommandsForApropos

This revision was automatically updated to reflect the committed changes. Closed by commit rGb3bfd595a548: [lldb] Compute fully qualified command names in FindCommandsForApropos (authored by kastiglione). Changed prior to commit: https://reviews.llvm.org/D116491?vs=397681=398034#toc

[Lldb-commits] [lldb] b3bfd59 - [lldb] Compute fully qualified command names in FindCommandsForApropos

Author: Dave Lee Date: 2022-01-06T19:26:57-08:00 New Revision: b3bfd595a548cd85b12e4e83729436cb73b26f29 URL: https://github.com/llvm/llvm-project/commit/b3bfd595a548cd85b12e4e83729436cb73b26f29 DIFF: https://github.com/llvm/llvm-project/commit/b3bfd595a548cd85b12e4e83729436cb73b26f29.diff

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

yuanzi updated this revision to Diff 398009. yuanzi edited the summary of this revision. yuanzi added a comment. Yeah since `xmlGetProp` calls `xmlGetPropNodeValueInternal`, which calls `xmlStrdup` rather than returning the content or value of the node directly, `xmlFreeDoc` could not clean it

[Lldb-commits] [PATCH] D116772: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

yuanzi created this revision. yuanzi requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. While running heap checker on a test that uses LLDB API, the following memory leak is found: RAW: HeapChecker started... RAW: Leak check _main_ detected

[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

shafik added a comment. AFAICT this fix is correct but I am not sure how to verify of test it. I ran the test suite and it passed but that does not mean this is being covered. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116768/new/ https://reviews.llvm.org/D116768

[Lldb-commits] [PATCH] D116768: Fix setting of success in Socket::Close()

shafik created this revision. shafik added reviewers: labath, jingham, JDevlieghere. shafik requested review of this revision. Both `close` and `closesocket` should return `0` on success so using `!!` looks incorrect. I replaced this will a more readable `== 0` check.

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. mgorny marked an inline comment as done. Closed by commit rG9b1d27b2fa72: [lldb] [Process/FreeBSDKernel] Support finding all processes (authored by mgorny). Herald

[Lldb-commits] [lldb] 9b1d27b - [lldb] [Process/FreeBSDKernel] Support finding all processes

Author: Michał Górny Date: 2022-01-06T21:53:28+01:00 New Revision: 9b1d27b2fa727a3a6f53a803d75beed50a1be999 URL: https://github.com/llvm/llvm-project/commit/9b1d27b2fa727a3a6f53a803d75beed50a1be999 DIFF: https://github.com/llvm/llvm-project/commit/9b1d27b2fa727a3a6f53a803d75beed50a1be999.diff

[Lldb-commits] [PATCH] D112709: [lldb] Fix matchers for char array formatters

labath added a comment. Thanks for the heads up. I've reverted the problematic parts in 31c7165a2b . I'll come with a proper fix soon-ish. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D116255: [lldb] [Process/FreeBSDKernel] Support finding all processes

mgorny marked an inline comment as done. mgorny added inline comments. Comment at: lldb/test/API/functionalities/postmortem/FreeBSDKernel/TestFreeBSDKernelVMCore.py:60-61 +self.assertEqual( +[thread.GetFrameAtIndex(i).addr.GetLoadAddress(target) +

[Lldb-commits] [lldb] 31c7165 - [lldb] Remove summary for signed char *

Author: Pavel Labath Date: 2022-01-06T19:52:24+01:00 New Revision: 31c7165a2bd69e07b916434a50826860132ba75f URL: https://github.com/llvm/llvm-project/commit/31c7165a2bd69e07b916434a50826860132ba75f DIFF: https://github.com/llvm/llvm-project/commit/31c7165a2bd69e07b916434a50826860132ba75f.diff

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

jhenderson accepted this revision. jhenderson added a comment. LGTM, from my point of view. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu added a comment. It looks like @asl isn't here and many experienced guys accepted this. So I think it might should be good to commit this one. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGbbce75e352be: Update Bug report URL to Github Issues (authored by

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

ChuanqiXu updated this revision to Diff 397763. ChuanqiXu added a comment. Address comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D116351/new/ https://reviews.llvm.org/D116351 Files: clang-tools-extra/docs/clang-doc.rst clang/docs/CommandGuide/clang.rst

[Lldb-commits] [PATCH] D116707: [lldb] fix memory leak in "GetGDBServerRegisterInfoXMLAndProcess"

labath added a comment. In D116707#3223998 , @JDevlieghere wrote: > We shouldn't have to manage memory at this granularity. Why isn't > `xmlFreeDoc` cleaning this up? Because xmlGetProp

[Lldb-commits] [PATCH] D116625: [lldb] [debugserver] Simplify handling of arch specific files

This revision was automatically updated to reflect the committed changes. Closed by commit rG1919720fdd34: [lldb] [debugserver] Simplify handling of arch specific files (authored by mstorsjo). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 1919720 - [lldb] [debugserver] Simplify handling of arch specific files

Author: Martin Storsjö Date: 2022-01-06T10:23:04+02:00 New Revision: 1919720fdd348ca568b235bf3f1357c198eccd15 URL: https://github.com/llvm/llvm-project/commit/1919720fdd348ca568b235bf3f1357c198eccd15 DIFF: