[Lldb-commits] [PATCH] D117462: [lldb/python] Use PythonObject in LLDBSwigPython functions

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM, thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117462/new/ https://reviews.llvm.org/D117462

[Lldb-commits] [PATCH] D117547: [lldb] Simplify RemoteAwarePlatform::ResolveExecutable

labath created this revision. labath added reviewers: jarin, PatriosTheGreat, EugeneBi, yuri. labath requested review of this revision. Herald added a project: LLDB. The function had three branches: - host - remote-but-not-connected - remote-and-connected All three branches overlap to varying de

[Lldb-commits] [PATCH] D117547: [lldb] Simplify RemoteAwarePlatform::ResolveExecutable

labath added a comment. Herald added a subscriber: JDevlieghere. I've added as reviewers everyone who has touched this function recently, in case you have some checks/use-cases you want to try, or can think of other reasons to not do this. Repository: rG LLVM Github Monorepo CHANGES SINCE L

[Lldb-commits] [lldb] c154f39 - [lldb/python] Use PythonObject in LLDBSwigPython functions

Author: Pavel Labath Date: 2022-01-18T10:28:58+01:00 New Revision: c154f397eeb86ea1a5b8fa46405104ace962cec3 URL: https://github.com/llvm/llvm-project/commit/c154f397eeb86ea1a5b8fa46405104ace962cec3 DIFF: https://github.com/llvm/llvm-project/commit/c154f397eeb86ea1a5b8fa46405104ace962cec3.diff

[Lldb-commits] [PATCH] D117462: [lldb/python] Use PythonObject in LLDBSwigPython functions

This revision was automatically updated to reflect the committed changes. Closed by commit rGc154f397eeb8: [lldb/python] Use PythonObject in LLDBSwigPython functions (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117462/new/ htt

[Lldb-commits] [lldb] 04f13da - [lldb] Fix compiler warning in CommunicationTest

Author: Pavel Labath Date: 2022-01-18T10:31:37+01:00 New Revision: 04f13da677d11f447e6332cf3171f5f1547d01a3 URL: https://github.com/llvm/llvm-project/commit/04f13da677d11f447e6332cf3171f5f1547d01a3 DIFF: https://github.com/llvm/llvm-project/commit/04f13da677d11f447e6332cf3171f5f1547d01a3.diff

[Lldb-commits] [lldb] afb196c - [lldb] s/dyn_cast/isa in TypeSystemClang

Author: Pavel Labath Date: 2022-01-18T10:33:40+01:00 New Revision: afb196c357f787c6e1e960aeca9531494102ad30 URL: https://github.com/llvm/llvm-project/commit/afb196c357f787c6e1e960aeca9531494102ad30 DIFF: https://github.com/llvm/llvm-project/commit/afb196c357f787c6e1e960aeca9531494102ad30.diff

[Lldb-commits] [PATCH] D117550: [lldb] Introduce SBPlatform::SetSDKRoot

labath created this revision. labath added reviewers: JDevlieghere, jingham. labath requested review of this revision. Herald added a project: LLDB. It complements the existing SBDebugger::SetCurrentPlatformSDKRoot and allows one to set the sysroot of a platform without making it current. Reposi

[Lldb-commits] [PATCH] D117068: [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface

mib updated this revision to Diff 400799. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117068/new/ https://reviews.llvm.org/D117068 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/include/lldb/Interpreter/ScriptedProcessInterface.h lldb/source/Plugins/Script

[Lldb-commits] [PATCH] D117068: [lldb/Plugins] Add ScriptedProcess::GetThreadsInfo interface

mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117068/new/ https://reviews.llvm.org/D117068 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D117070: [lldb/Plugins] Move ScriptedThreadInterface to ScriptedThread

mib updated this revision to Diff 400800. mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117070/new/ https://reviews.llvm.org/D117070 Files: lldb/include/lldb/Interpreter/ScriptedProcessInterface.h lldb/source/Plugins/Process/scripted/ScriptedThread.cpp

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib updated this revision to Diff 400801. mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117071/new/ https://reviews.llvm.org/D117071 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/include/lldb/Interpreter/ScriptedInterface.h lldb

[Lldb-commits] [PATCH] D117074: [lldb/Plugins] Enrich ScriptedThreads Stop Reasons with Exceptions

mib updated this revision to Diff 400802. mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117074/new/ https://reviews.llvm.org/D117074 Files: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process/scripted/ScriptedThread.cpp

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

mib updated this revision to Diff 400803. mib edited the summary of this revision. mib added a comment. Rebase and address @labath comments. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117076/new/ https://reviews.llvm.org/D117076 Files: lldb/include/lldb/Target/Thread.h lldb/sour

[Lldb-commits] [PATCH] D117374: [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC)

mib updated this revision to Diff 400804. mib added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117374/new/ https://reviews.llvm.org/D117374 Files: lldb/include/lldb/Interpreter/ScriptedInterface.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp Index

[Lldb-commits] [lldb] 7f4d66f - [lldb] Delete TestStopReplyContainsThreadPcs

Author: Pavel Labath Date: 2022-01-18T14:17:33+01:00 New Revision: 7f4d66f23e3e8a2a03e83a2df0ee3a56790e2b64 URL: https://github.com/llvm/llvm-project/commit/7f4d66f23e3e8a2a03e83a2df0ee3a56790e2b64 DIFF: https://github.com/llvm/llvm-project/commit/7f4d66f23e3e8a2a03e83a2df0ee3a56790e2b64.diff

[Lldb-commits] [PATCH] D117559: [lldb] Remove remote testing ability from lldb**-server** tests

labath created this revision. labath added reviewers: hhb, omjavaid, ted. labath requested review of this revision. Herald added a project: LLDB. It was only ever implemented for linux (and android), and even that implementation is fairly hacky and flaky (e.g. it is relying on launching the server

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp:340 +if (!thread_sp) + return GetInterface().ErrorWithMessage( + LLVM_PRETTY_FUNCTI

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. I think this is as good as we can make it. Thanks for your patience. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117071/new/ https://reviews.llvm.org/D117071 __

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

mib updated this revision to Diff 400838. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117076/new/ https://reviews.llvm.org/D117076 Files: lldb/include/lldb/Target/Thread.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process/scripted/ScriptedThread

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

labath created this revision. labath added reviewers: stella.stamenova, JDevlieghere. Herald added a subscriber: mgorny. labath requested review of this revision. Herald added a project: LLDB. This macro was being used to select the proper import/export annotations on SB classes. Non-windows clien

[Lldb-commits] [PATCH] D117076: [lldb/Plugins] Fix ScriptedThread IndexID reporting

mib updated this revision to Diff 400843. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117076/new/ https://reviews.llvm.org/D117076 Files: lldb/include/lldb/Target/Thread.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp lldb/source/Plugins/Process/scripted/ScriptedThread

[Lldb-commits] [PATCH] D117374: [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC)

mib updated this revision to Diff 400845. mib added a comment. Format CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117374/new/ https://reviews.llvm.org/D117374 Files: lldb/include/lldb/Interpreter/ScriptedInterface.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp Index

[Lldb-commits] [PATCH] D117374: [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC)

mib updated this revision to Diff 400847. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117374/new/ https://reviews.llvm.org/D117374 Files: lldb/include/lldb/Interpreter/ScriptedInterface.h lldb/source/Plugins/Process/scripted/ScriptedProcess.cpp Index: lldb/source/Plugins/Process/

[Lldb-commits] [PATCH] D117071: [lldb/Plugins] Add support of multiple ScriptedThreads in a ScriptedProcess

mib added a comment. In D117071#3251124 , @labath wrote: > I think this is as good as we can make it. Thanks for your patience. Thanks for your help :) ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117071/new/ https://reviews.llvm.org/D11707

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117564/new/ https://reviews.llvm.org/D117564 __

[Lldb-commits] [PATCH] D116972: [lldb] Run the test suite in verbose mode

stella.stamenova added a comment. Since @omjavaid is working on a related change in https://reviews.llvm.org/D117363, perhaps he can make the necessary changes there to support `-j` for the tests? Repository: rZORG LLVM Github Zorg CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11697

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova created this revision. stella.stamenova added reviewers: JDevlieghere, clayborg, labath. stella.stamenova requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The current default is to not use lldb-server on Windows, however, ll

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117581/new/ https://reviews.llvm.org/D117581

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

stella.stamenova added a comment. Herald added a subscriber: JDevlieghere. This does not build correctly with gcc 7.3.1 on CentOS: /usr/bin/g++ -DGTEST_HAS_RTTI=0 -DHAVE_ROUND -D_DEBUG -D_GNU_SOURCE -D__STDC_CONSTANT_MACROS -D__STDC_FORMAT_MACROS -D__STDC_LIMIT_MACROS -I/mnt/resource/1/b/llvm

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

labath added a comment. sounds like something that could be fixed by a couple of std::moves Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117113/new/ https://reviews.llvm.org/D117113 ___ lldb-commits mai

[Lldb-commits] [PATCH] D117374: [lldb/Interpreter] Make `ScriptedInterface::ErrorWithMessage` static (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117374/new/ https://reviews.llvm.org/D117374 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D117113: [lldb] [llgs] Implement qXfer:siginfo:read

mgorny added a comment. In D117113#3251838 , @stella.stamenova wrote: > This does not build correctly with gcc 7.3.1 on CentOS: Could you please try adding some `std::move()`s to the relevant returns? I don't have an access to such an ancient compiler.

[Lldb-commits] [PATCH] D117474: [lldb] Make StatsDuration thread-safe

clayborg accepted this revision. clayborg added a comment. This revision is now accepted and ready to land. Thanks for finding a solution. I tried originally doing a std::atomic but those are not supported. As long as you have verified that storing at a uint64_t reports the same kinds of duratio

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

JDevlieghere accepted this revision. JDevlieghere added a comment. Neat Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117564/new/ https://reviews.llvm.org/D117564 ___ lldb-commits mailing list lldb-commi

[Lldb-commits] [PATCH] D117550: [lldb] Introduce SBPlatform::SetSDKRoot

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117550/new/ https://reviews.llvm.org/D117550 ___

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere created this revision. JDevlieghere added reviewers: labath, mib. JDevlieghere requested review of this revision. We got a few crash reports that showed LLDB initializing Python on two separate threads. Make `g_initialized` atomic to prevent that from happening. https://reviews.llv

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

mib accepted this revision. mib added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117601/new/ https://reviews.llvm.org/D117601 ___ lldb-commits mailing list lldb-commits@lists

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, jingham. JDevlieghere requested review of this revision. Use libobjc.A.dylib as a sentinel to detect situations where we're reading libraries from memory instead of the shared cache. https://reviews.llvm.org/D117623 Fil

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2377-2378 +stream->Printf( +"warning: libobjc.A.dylib is being read from memory instead of the %s" +"shared cache. This will likel

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

stella.stamenova added a comment. So, sadly, I am going to have to backtrack here. When I set `LLDB_USE_LLDB_SERVER` in my environment and ran the tests, they did appear to be more stable (fewer failures across 10 test runs), but it was all a joke my machine was playing on me. Running the test

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere updated this revision to Diff 401034. JDevlieghere added a comment. Unbotch the patch CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117623/new/ https://reviews.llvm.org/D117623 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp lld

[Lldb-commits] [PATCH] D117490: [lldb] Log prototype

clayborg added a comment. I like the idea of the templates that would not allow bitfields from one log channel to be used on another log channel as there we a few incorrect ones in the GDB remote process plug-in. See inlined comments Comment at: lldb/include/lldb/Utility/Logg

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

aprantl added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2377 +stream->Printf( +"warning: libobjc.A.dylib is being read from memory instead of the %s" +"shared cache. This will likely reduce p

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere updated this revision to Diff 401036. JDevlieghere added a comment. Update warning message CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117623/new/ https://reviews.llvm.org/D117623 Files: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

aprantl added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2379 +stream->Printf("warning: libobjc.A.dylib is being read from process " + "memory. This indicates that we could not %s. This will

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

jingham added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2359 +void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() { +#ifdef __APPLE__ + if (!m_objc_module_sp) Why is this code #ifdef APPLE?

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2379 +stream->Printf("warning: libobjc.A.dylib is being read from process " + "memory. This indicates that we could not %s. This

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere marked an inline comment as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2359 +void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() { +#ifdef __APPLE__ + if (!m_objc_module_

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

jingham added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2359 +void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() { +#ifdef __APPLE__ + if (!m_objc_module_sp) JDevlieghere wrote: > jingham w

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

JDevlieghere marked 4 inline comments as done. JDevlieghere added inline comments. Comment at: lldb/source/Plugins/LanguageRuntime/ObjC/AppleObjCRuntime/AppleObjCRuntimeV2.cpp:2359 +void AppleObjCRuntimeV2::WarnIfNoExpandedSharedCache() { +#ifdef __APPLE__ + if (!m_objc_module_

[Lldb-commits] [lldb] d230848 - [lldb] Print an error message when we're reading libobjc.A.dylib from memory

Author: Jonas Devlieghere Date: 2022-01-18T17:23:38-08:00 New Revision: d230848a85a922260b7ad6984f2dd19222c125a6 URL: https://github.com/llvm/llvm-project/commit/d230848a85a922260b7ad6984f2dd19222c125a6 DIFF: https://github.com/llvm/llvm-project/commit/d230848a85a922260b7ad6984f2dd19222c125a6.d

[Lldb-commits] [PATCH] D117623: [lldb] Print an error message when we're reading libobjc.A.dylib from memory

This revision was automatically updated to reflect the committed changes. JDevlieghere marked an inline comment as done. Closed by commit rGd230848a85a9: [lldb] Print an error message when we're reading libobjc.A.dylib from memory (authored by JDevlieghere). Herald added a project: LLDB. Changed

[Lldb-commits] [PATCH] D117632: Instrument SBAPI with scoped timers

jingham added a comment. I was about to say this shouldn't matter, since most people don't run with timers enabled and the timers should be no-ops when timing is off. But LLDB_SCOPED_TIMER seems to do a bunch of work even when the timers are disabled. The work includes "look up the Category i

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

codemzs created this revision. codemzs added reviewers: mgorny, labath, emaste, krytarowski, stella.stamenova. codemzs requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Pursuant to discussion here https://reviews.llvm.org/D117113 Repository

[Lldb-commits] [PATCH] D117637: Fix build break on CentOS due to gcc 7.3.1

stella.stamenova accepted this revision. stella.stamenova added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117637/new/ https://reviews.llvm.org/D117637 ___

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

labath added a comment. I don't think that `atomic` is what you want here. In the case of a race, the "loser" will immediately continue to use python as if it was initialized, even though the winner has not finished the initialization. You most likely need `call_once` semantics, blocking all th

[Lldb-commits] [PATCH] D117601: [lldb] Make Python initialization atomic

JDevlieghere planned changes to this revision. JDevlieghere added a comment. In D117601#3253663 , @labath wrote: > I don't think that `atomic` is what you want here. In the case of a > race, the "loser" will immediately continue to use python as if it wa