[Lldb-commits] [lldb] cac164f - [lldb] Update the modulemap

2022-01-20 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-20T18:28:23-08:00 New Revision: cac164ff9cb671fae7a00d9a3adf1834ebca8bd9 URL: https://github.com/llvm/llvm-project/commit/cac164ff9cb671fae7a00d9a3adf1834ebca8bd9 DIFF:

[Lldb-commits] [PATCH] D117632: [lldb] Instrument SB API with signposts

2022-01-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG156b997251db: [lldb] Instrument SB API with signposts (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

2022-01-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG1755f5b1d7b7: [lldb] Decouple instrumentation from the reproducers (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit:

[Lldb-commits] [lldb] 156b997 - [lldb] Instrument SB API with signposts

2022-01-20 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-20T18:06:14-08:00 New Revision: 156b997251db6d87636fa300d7654989caa01dea URL: https://github.com/llvm/llvm-project/commit/156b997251db6d87636fa300d7654989caa01dea DIFF:

[Lldb-commits] [lldb] f811cb8 - [lldb] Revive lldb-instr

2022-01-20 Thread Jonas Devlieghere via lldb-commits
Author: Jonas Devlieghere Date: 2022-01-20T18:06:14-08:00 New Revision: f811cb82a6cd811dbb4730009d0f060503aa1c76 URL: https://github.com/llvm/llvm-project/commit/f811cb82a6cd811dbb4730009d0f060503aa1c76 DIFF:

[Lldb-commits] [PATCH] D117748: [lldb] Revive lldb-instr

2022-01-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rGf811cb82a6cd: [lldb] Revive lldb-instr (authored by JDevlieghere). Herald added a project: LLDB. Changed prior to commit: https://reviews.llvm.org/D117748?vs=401504=401831#toc Repository: rG LLVM

[Lldb-commits] [PATCH] D117299: [lldb] Ignore non-address bits in "memory find" arguments

2022-01-20 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added inline comments. Comment at: lldb/test/API/linux/aarch64/tagged_memory_access/TestAArch64LinuxTaggedMemoryAccess.py:70 +# 1. It tries to search a gigantic amount of memory. +#We're not going to to test for this because a failure +#

[Lldb-commits] [PATCH] D117837: [lldb] Fix timer logging inverted quiet condition

2022-01-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117837/new/ https://reviews.llvm.org/D117837

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

2022-01-20 Thread Muhammad Omair Javaid via Phabricator via lldb-commits
omjavaid added a comment. In D117676#3254662 , @labath wrote: > FWIW, I consider the build.py script a failed experiment. The idea itself was > not completely bad, but the lack of buy-in from sufficient amount of > developers meant that it never really

[Lldb-commits] [PATCH] D117837: [lldb] Fix timer logging inverted quiet condition

2022-01-20 Thread Dave Lee via Phabricator via lldb-commits
kastiglione created this revision. kastiglione added reviewers: JDevlieghere, labath. kastiglione requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The logic of `g_quiet` was inverted in D26243 . This

[Lldb-commits] [lldb] 36cb29c - Work around a module build failure on the bots.

2022-01-20 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2022-01-20T13:39:48-08:00 New Revision: 36cb29cbbe1b22dcd298ad65e1fabe899b7d7249 URL: https://github.com/llvm/llvm-project/commit/36cb29cbbe1b22dcd298ad65e1fabe899b7d7249 DIFF: https://github.com/llvm/llvm-project/commit/36cb29cbbe1b22dcd298ad65e1fabe899b7d7249.diff

[Lldb-commits] [PATCH] D117564: [lldb] Remove the requirement for windows clients to specify -DIMPORT_LIBLLDB

2022-01-20 Thread Pavel Labath via Phabricator via lldb-commits
labath added a comment. I've done that with rG57ebfea38c03e5cd2d0677eabd2abf761b336097 , if you're still interested in static builds. It took me a while to get to that, as I was fighting fires which also had to do with funky

[Lldb-commits] [lldb] 57ebfea - [lldb] Surround LLDB_API-defining code with #ifndef LLDB_API

2022-01-20 Thread Pavel Labath via lldb-commits
Author: Pavel Labath Date: 2022-01-20T20:50:35+01:00 New Revision: 57ebfea38c03e5cd2d0677eabd2abf761b336097 URL: https://github.com/llvm/llvm-project/commit/57ebfea38c03e5cd2d0677eabd2abf761b336097 DIFF: https://github.com/llvm/llvm-project/commit/57ebfea38c03e5cd2d0677eabd2abf761b336097.diff

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

2022-01-20 Thread Jonas Devlieghere via Phabricator via lldb-commits
JDevlieghere added a comment. Thanks, I'll address those things before landing the patch. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117712/new/ https://reviews.llvm.org/D117712 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D117712: [lldb] Disconnect instrumentation from the reproducers

2022-01-20 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Utility/Instrumentation.h:23 + +template ::value, int>::type = 0> I didn't notice this before, but I think this should

[Lldb-commits] [PATCH] D117748: [lldb] Revive lldb-instr

2022-01-20 Thread Pavel Labath via Phabricator via lldb-commits
labath accepted this revision. labath added a comment. This revision is now accepted and ready to land. Personally, I have never used the tool even when the macros were complex, but I don't see any harm in having it. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117748/new/

[Lldb-commits] [lldb] df31ff1 - [cmake] Make include(GNUInstallDirs) always below project(..)

2022-01-20 Thread John Ericson via lldb-commits
Author: John Ericson Date: 2022-01-20T18:59:17Z New Revision: df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4 URL: https://github.com/llvm/llvm-project/commit/df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4 DIFF: https://github.com/llvm/llvm-project/commit/df31ff1b29bc4c2308ec5df8a7ff0ec2ab0942d4.diff LOG:

[Lldb-commits] [PATCH] D117581: [lldb] Use lldb-server by default on Windows

2022-01-20 Thread Stella Stamenova via Phabricator via lldb-commits
stella.stamenova abandoned this revision. stella.stamenova added a comment. I spent a bit of time trying to investigate the failures, but I couldn't make much progress and I don't have time to dedicate to a more thorough investigation. It looks like there are a few tests that outright fail

[Lldb-commits] [lldb] c0957bd - Add missing include to fix modular build

2022-01-20 Thread Adrian Prantl via lldb-commits
Author: Adrian Prantl Date: 2022-01-20T08:35:33-08:00 New Revision: c0957bd61794cc37012e7a5f7d89f00fe02ff2ef URL: https://github.com/llvm/llvm-project/commit/c0957bd61794cc37012e7a5f7d89f00fe02ff2ef DIFF: https://github.com/llvm/llvm-project/commit/c0957bd61794cc37012e7a5f7d89f00fe02ff2ef.diff

[Lldb-commits] [PATCH] D107140: [lldb] Add option to show memory tags in memory read output

2022-01-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 401592. DavidSpickett added a comment. Update with changes to previous patches. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107140/new/ https://reviews.llvm.org/D107140 Files:

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

2022-01-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett added inline comments. Comment at: lldb/include/lldb/Target/MemoryTagMap.h:29 + /// Non-null pointer to a memory tag manager. + MemoryTagMap(const MemoryTagManager *manager); + DavidSpickett wrote: > JDevlieghere wrote: > > If the pointer

[Lldb-commits] [PATCH] D112825: [lldb] Add MemoryTagMap class

2022-01-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 401588. DavidSpickett added a comment. Change MemoryTagMap::empty() to Empty() to match lldb style. Attempted to use a const& for the tag manager and remembered why that won't work. Made the explanatory comment more clear. Repository: rG LLVM

[Lldb-commits] [PATCH] D117707: siginfo_t synthesis WIP

2022-01-20 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 401585. mgorny added a comment. Put the common test code into a common init function, add tests for armv7, arm64, i386, ppc64le. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files:

[Lldb-commits] [PATCH] D112824: [lldb][AArch64] Add MakeTaggedRanges to MemoryTagManager

2022-01-20 Thread David Spickett via Phabricator via lldb-commits
DavidSpickett updated this revision to Diff 401583. DavidSpickett added a comment. Rebase, update the name of RemoveTagBits. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D112824/new/ https://reviews.llvm.org/D112824 Files:

[Lldb-commits] [PATCH] D117707: siginfo_t synthesis WIP

2022-01-20 Thread Michał Górny via Phabricator via lldb-commits
mgorny updated this revision to Diff 401582. mgorny added a comment. Cover all fields with tests and add a test input generator. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117707/new/ https://reviews.llvm.org/D117707 Files: lldb/bindings/interface/SBPlatform.i

[Lldb-commits] [PATCH] D117672: [lldb] Remove non-address bits from addresses given to memory tag commands

2022-01-20 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG787f91b0bb34: [lldb] Remove non-address bits from addresses given to memory tag commands (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 787f91b - [lldb] Remove non-address bits from addresses given to memory tag commands

2022-01-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-20T10:48:14Z New Revision: 787f91b0bb34abeca86ad5c8a60ef044a7942996 URL: https://github.com/llvm/llvm-project/commit/787f91b0bb34abeca86ad5c8a60ef044a7942996 DIFF: https://github.com/llvm/llvm-project/commit/787f91b0bb34abeca86ad5c8a60ef044a7942996.diff

[Lldb-commits] [PATCH] D117671: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

2022-01-20 Thread David Spickett via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG585abe3ba506: [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits (authored by DavidSpickett). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 585abe3 - [lldb] Rename MemoryTagManager RemoveNonAddressBits to RemoveTagBits

2022-01-20 Thread David Spickett via lldb-commits
Author: David Spickett Date: 2022-01-20T10:47:05Z New Revision: 585abe3ba506e410b382f8130f72b9368573a781 URL: https://github.com/llvm/llvm-project/commit/585abe3ba506e410b382f8130f72b9368573a781 DIFF: https://github.com/llvm/llvm-project/commit/585abe3ba506e410b382f8130f72b9368573a781.diff