[Lldb-commits] [PATCH] D119400: Fix a double debug info size counting in top level stats for "statistics dump".

clayborg created this revision. clayborg added reviewers: labath, JDevlieghere, jingham, wallace. Herald added a subscriber: kristof.beyls. clayborg requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This mainly affects Darwin targets (macOS,

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

mib updated this revision to Diff 407370. mib added a comment. Reformat and update error messages. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119388/new/ https://reviews.llvm.org/D119388 Files: lldb/examples/python/scripted_process/scripted_process.py lldb/include/lldb/Target/St

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

mib updated this revision to Diff 407368. mib marked 2 inline comments as done. mib edited the summary of this revision. mib added a comment. Address @jingham's comments CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119388/new/ https://reviews.llvm.org/D119388 Files: lldb/examples/py

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

mib marked 4 inline comments as done. mib added inline comments. Comment at: lldb/source/Plugins/Process/scripted/ScriptedThread.cpp:151 +bool ScriptedThread::LoadArtificialStackFrames() { + StructuredData::ArraySP arr_sp = GetInterface()->GetStackFrames(); + ji

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

jingham added a comment. Some nits. Mostly I think the "idx" field in the frame list is redundant and only allows you to get the order wrong w/o adding useful functionality. I haven't studied Pavel's changes to the Python lifecycle management yet, so I can't comment on whether that part of the

[Lldb-commits] [PATCH] D119389: [lldb/crashlog] Add CrashLogScriptedProcess and resurrect_crashlog method

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. Herald added a subscriber: mgorny. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch introduces a new type of ScriptedProcess: CrashLogScriptedProcess. It takes advant

[Lldb-commits] [PATCH] D119388: [lldb/Plugin] Add artificial stackframe loading in ScriptedThread

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch adds the ability for ScriptedThread to load artificial stack frames. To do so, the interpreter instance can c

[Lldb-commits] [PATCH] D119386: [lldb/Plugins] Clean-up ScriptedProcess python script (NFC)

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch removes the `my_scripted_process.py` blueprint since it's not used anymore. The patch also updates the base Scripted

[Lldb-commits] [PATCH] D119168: [lldb/crashlog] Fix arm64 register parsing on crashlog.py

This revision was automatically updated to reflect the committed changes. Closed by commit rG9a9bf12c4a10: [lldb/crashlog] Fix arm64 register parsing on crashlog.py (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119168/new/ https:/

[Lldb-commits] [PATCH] D118513: [lldb/test] Split Scripted Process test in multiple tests (NFC)

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGd327108d175f: [lldb/test] Split Scripted Process test in multiple tests (NFC) (authored by mib). Changed prior to commit: https://reviews.llvm.org

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf5e5074c40be: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64 (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 9a9bf12 - [lldb/crashlog] Fix arm64 register parsing on crashlog.py

Author: Med Ismail Bennani Date: 2022-02-09T13:28:20-08:00 New Revision: 9a9bf12c4a10aa87f15463fbe0021f99012a88df URL: https://github.com/llvm/llvm-project/commit/9a9bf12c4a10aa87f15463fbe0021f99012a88df DIFF: https://github.com/llvm/llvm-project/commit/9a9bf12c4a10aa87f15463fbe0021f99012a88df.

[Lldb-commits] [lldb] d327108 - [lldb/test] Split Scripted Process test in multiple tests (NFC)

Author: Med Ismail Bennani Date: 2022-02-09T13:28:20-08:00 New Revision: d327108d175fc5d1d4f5c018d129e337d162810c URL: https://github.com/llvm/llvm-project/commit/d327108d175fc5d1d4f5c018d129e337d162810c DIFF: https://github.com/llvm/llvm-project/commit/d327108d175fc5d1d4f5c018d129e337d162810c.

[Lldb-commits] [lldb] f5e5074 - [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

Author: Med Ismail Bennani Date: 2022-02-09T13:28:20-08:00 New Revision: f5e5074c40be29d3a0c5d4ac616df8e61e4ddc63 URL: https://github.com/llvm/llvm-project/commit/f5e5074c40be29d3a0c5d4ac616df8e61e4ddc63 DIFF: https://github.com/llvm/llvm-project/commit/f5e5074c40be29d3a0c5d4ac616df8e61e4ddc63.

[Lldb-commits] [PATCH] D118513: [lldb/test] Split Scripted Process test in multiple tests (NFC)

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118513/new/ https://reviews.llvm.org/D118513 ___ lldb-commits mailing li

[Lldb-commits] [PATCH] D118513: [lldb/test] Split Scripted Process test in multiple tests (NFC)

mib updated this revision to Diff 407269. mib edited the summary of this revision. mib added a comment. Disable debug info testing. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D118513/new/ https://reviews.llvm.org/D118513 Files: lldb/test/API/functionalities/scripted_process/TestScr

[Lldb-commits] [lldb] 48d8890 - [LLDB][NativePDB] fix that FindSymbolScope never finds scope of a symbol if it doesn't open a scope

Author: Zequan Wu Date: 2022-02-09T13:20:45-08:00 New Revision: 48d889079a8a050bb41defd5688e0b213c1c5655 URL: https://github.com/llvm/llvm-project/commit/48d889079a8a050bb41defd5688e0b213c1c5655 DIFF: https://github.com/llvm/llvm-project/commit/48d889079a8a050bb41defd5688e0b213c1c5655.diff LOG

[Lldb-commits] [PATCH] D118484: [lldb/test] Fix TestScriptedProcess.py timeout on x86_64

mib updated this revision to Diff 407264. mib edited the summary of this revision. mib added a comment. Added a `is_stopped` member variable to StackCoreScriptedThread since I abandoned D118482 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D118482: [lldb/Plugins] Add lldb.ScriptedProcess.get_most_relevant_thread_index interpreter method

mib abandoned this revision. mib added a comment. @jingham I just got rid of all of this, and added a `is_stopped` variable to the `stack_core_scripted_process.StackCoreScriptedThread` class in D118484 . CHANGES SINCE LAST ACTION https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3308499 , @stella.stamenova wrote: > It looks like the new test is failing on the Windows bot: > > https://lab.llvm.org/buildbot/#/builders/83/builds/15049 Whoops, static lookup seem to be broken on Windows (other tests

[Lldb-commits] [lldb] e0f2375 - [lldb] Disable failing test on Windows

Author: Andy Yankovsky Date: 2022-02-09T20:40:50+01:00 New Revision: e0f2375b5262d0dd778ecaf0628f905d241da733 URL: https://github.com/llvm/llvm-project/commit/e0f2375b5262d0dd778ecaf0628f905d241da733 DIFF: https://github.com/llvm/llvm-project/commit/e0f2375b5262d0dd778ecaf0628f905d241da733.diff

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

clayborg added a comment. I am fine with this. Only suggestion is to use ConstString still for the m_instance_name since we might compare against this name if we are looking for one with a matching name (instead of std::string). Comment at: lldb/include/lldb/Target/Platform.h

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

stella.stamenova added a comment. It looks like the new test is failing on the Windows bot: https://lab.llvm.org/buildbot/#/builders/83/builds/15049 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://reviews.llvm.org/D113498 __

[Lldb-commits] [lldb] 1046b72 - [lldb] Account for extra threads in TestGdbRemoteThreadsInStopReply on windows

Author: Pavel Labath Date: 2022-02-09T17:42:54+01:00 New Revision: 1046b726ad4461d0ba0a8c9391836b679a719a60 URL: https://github.com/llvm/llvm-project/commit/1046b726ad4461d0ba0a8c9391836b679a719a60 DIFF: https://github.com/llvm/llvm-project/commit/1046b726ad4461d0ba0a8c9391836b679a719a60.diff

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

This revision was automatically updated to reflect the committed changes. Closed by commit rGafb446e8a61d: [lldb] Constant-resolve operands to `getelementptr` (authored by werat). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D113498/new/ https://rev

[Lldb-commits] [lldb] afb446e - [lldb] Constant-resolve operands to `getelementptr`

Author: Andy Yankovsky Date: 2022-02-09T17:38:38+01:00 New Revision: afb446e8a61de4a41504a71f61a4b1d93ce22716 URL: https://github.com/llvm/llvm-project/commit/afb446e8a61de4a41504a71f61a4b1d93ce22716 DIFF: https://github.com/llvm/llvm-project/commit/afb446e8a61de4a41504a71f61a4b1d93ce22716.diff

[Lldb-commits] [PATCH] D113498: [lldb] Constant-resolve operands to `getelementptr`

werat added a comment. In D113498#3305973 , @shafik wrote: > I believe this a program like this > > int main() { > int arr[2]{0}; > > return arr[1]; > } > > and an expression like this `expr arr[0]` will give us the constant > expression

[Lldb-commits] [lldb] 9611282 - [lldb] Stabilize threaded windows lldb-server tests

Author: Pavel Labath Date: 2022-02-09T16:18:27+01:00 New Revision: 9611282c64f4cec1d6d0d997202762fa38e99663 URL: https://github.com/llvm/llvm-project/commit/9611282c64f4cec1d6d0d997202762fa38e99663 DIFF: https://github.com/llvm/llvm-project/commit/9611282c64f4cec1d6d0d997202762fa38e99663.diff

[Lldb-commits] [lldb] 96000f5 - [lldb] Simplify SBCommandInterpreter::SourceInitFileInHomeDirectory

Author: Pavel Labath Date: 2022-02-09T16:18:27+01:00 New Revision: 96000f5c2bf99365bb45528898c864fcb1c7780b URL: https://github.com/llvm/llvm-project/commit/96000f5c2bf99365bb45528898c864fcb1c7780b DIFF: https://github.com/llvm/llvm-project/commit/96000f5c2bf99365bb45528898c864fcb1c7780b.diff

[Lldb-commits] [lldb] 73a961b - [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

Author: Muhammad Omair Javaid Date: 2022-02-09T17:40:39+05:00 New Revision: 73a961b9cca1ecaa16ca7d9a456961ab6510bd1c URL: https://github.com/llvm/llvm-project/commit/73a961b9cca1ecaa16ca7d9a456961ab6510bd1c DIFF: https://github.com/llvm/llvm-project/commit/73a961b9cca1ecaa16ca7d9a456961ab6510bd

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

This revision was automatically updated to reflect the committed changes. Closed by commit rG73a961b9cca1: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows (authored by omjavaid). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D117676: [LLDB] Port toolchain-msvc.test for Arm/AArch4 Windows

omjavaid added a comment. ping! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D117676/new/ https://reviews.llvm.org/D117676 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] 29caa85 - [lldb] Restore original meaning to test_qThreadStopInfo_only_reports_one_thread_stop_reason_during_interrupt

Author: Pavel Labath Date: 2022-02-09T12:34:55+01:00 New Revision: 29caa8583f60ed5aa668144491ce65be00986947 URL: https://github.com/llvm/llvm-project/commit/29caa8583f60ed5aa668144491ce65be00986947 DIFF: https://github.com/llvm/llvm-project/commit/29caa8583f60ed5aa668144491ce65be00986947.diff

[Lldb-commits] [lldb] 9e69959 - [lldb] Adjust windows xfails for D119167

Author: Pavel Labath Date: 2022-02-09T12:04:13+01:00 New Revision: 9e6995957ac2df6978d7ff1b9ae97d937d6ac85a URL: https://github.com/llvm/llvm-project/commit/9e6995957ac2df6978d7ff1b9ae97d937d6ac85a DIFF: https://github.com/llvm/llvm-project/commit/9e6995957ac2df6978d7ff1b9ae97d937d6ac85a.diff

[Lldb-commits] [PATCH] D119167: [lldb/test] Remove sleeps from some lldb-server tests

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a4fe166d13b: [lldb/test] Remove sleeps from some lldb-server tests (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119167/new/ https://

[Lldb-commits] [lldb] 5a4fe16 - [lldb/test] Remove sleeps from some lldb-server tests

Author: Pavel Labath Date: 2022-02-09T11:05:02+01:00 New Revision: 5a4fe166d13bf89e6bc387bd96232e8c0f706d27 URL: https://github.com/llvm/llvm-project/commit/5a4fe166d13bf89e6bc387bd96232e8c0f706d27 DIFF: https://github.com/llvm/llvm-project/commit/5a4fe166d13bf89e6bc387bd96232e8c0f706d27.diff

[Lldb-commits] [PATCH] D118494: [lldb] Observe SG_READ_ONLY flag in MachO binaries

labath added inline comments. Comment at: lldb/source/Plugins/ObjectFile/Mach-O/ObjectFileMachO.cpp:1436 result |= ePermissionsReadable; - if (seg_cmd.initprot & VM_PROT_WRITE) + if ((seg_cmd.initprot & VM_PROT_WRITE) && !(seg_cmd.flags & SG_READ_ONLY)) result |= ePer