[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

JDevlieghere added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); andcarminati wrote: > JDevlieghere wrote: > >

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

andcarminati added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); JDevlieghere wrote: > labath wrote: > >

[Lldb-commits] [PATCH] D120517: PlatformMacOSX should be activated for lldb built to run on an iOS etc device

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120517/new/ https://reviews.llvm.org/D120517

[Lldb-commits] [PATCH] D120517: PlatformMacOSX should be activated for lldb built to run on an iOS etc device

jasonmolenda created this revision. jasonmolenda added a reviewer: JDevlieghere. jasonmolenda added a project: LLDB. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. In the changes Jonas made in https://reviews.llvm.org/D117340 , a small oversight was that

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

jingham added a comment. Could you use `help --scripting` (`help -s`) or maybe `help --api`? Then you could also do `apropos -s` if you ended up adding an apropos feature in the script interface, which would be consistent and fairly discoverable. Then for folks that used it all the time they

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu added inline comments. Comment at: lldb/source/Core/Address.cpp:739 - s->PutCString(", location = "); - var_sp->DumpLocationForAddress(s, *this); - s->PutCString(", decl = "); labath wrote: > This place was the

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 411203. zequanwu marked an inline comment as done. zequanwu added a comment. Update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.org/D119963 Files:

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

kastiglione added a comment. It's too bad `script` doesn't have subcommands, because that might have been a natural place for such a command. Are there any commands you think this could be added? Or would this have to be a new top level command? A new top-level command seems unfortunate.

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

JDevlieghere added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); labath wrote: > JDevlieghere wrote: > > I see an

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

emaste added a comment. We need to make sure a test covers this as well, perhaps just enabling lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

JDevlieghere added a comment. This is really great, this is going to save me a lot of time. I wonder if we should take this even further and make it a first class command in lldb, similar to `apropos`. (I wouldn't make it part of apropos, because it can already be overwhelming.) By making it

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

emaste added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:128 + +#ifdef NT_ARM_ADDR_MASK + if (m_addr_mask_is_valid) This `#define` is coming from our headers? We need to provide this constant within

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

andrew created this revision. andrew added a reviewer: mgorny. Herald added subscribers: kristof.beyls, krytarowski, arichardson. andrew requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Read the mask using ptrace with PT_GETREGSET with

[Lldb-commits] [PATCH] D110569: [lldb] [Process/FreeBSD] Rework arm64 register access

andrew updated this revision to Diff 48. andrew added a comment. Rebase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110569/new/ https://reviews.llvm.org/D110569 Files: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD.h

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

labath added inline comments. Comment at: lldb/source/Core/Address.cpp:739 - s->PutCString(", location = "); - var_sp->DumpLocationForAddress(s, *this); - s->PutCString(", decl = "); This place was the only caller of

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

ilya-nozhkin added a comment. In D120319#3342657 , @labath wrote: > Another possibility is to use the gdb-client test infrastructure to simulate > a server which refuses to write to a register It would be the most proper way, I agree, but I think that

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

ilya-nozhkin updated this revision to Diff 411065. ilya-nozhkin added a comment. Replaced redundant check in the test with assert. Also, I've removed type annotations to be consistent with the code around. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120319/new/

[Lldb-commits] [lldb] a85d3b6 - [lldb] Fix macos build for D120425

Author: Pavel Labath Date: 2022-02-24T12:47:43+01:00 New Revision: a85d3b66cb968a8bdbdfedb67dda0475c81c1c93 URL: https://github.com/llvm/llvm-project/commit/a85d3b66cb968a8bdbdfedb67dda0475c81c1c93 DIFF: https://github.com/llvm/llvm-project/commit/a85d3b66cb968a8bdbdfedb67dda0475c81c1c93.diff

[Lldb-commits] [PATCH] D120425: [lldb/host] Remove monitor_signals argument from process monitoring functions

thakis added a comment. Breaks Mac build: http://45.33.8.238/macm1/28811/step_4.txt Ptal. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120425/new/ https://reviews.llvm.org/D120425 ___ lldb-commits

[Lldb-commits] [PATCH] D120319: Set error message if ValueObjectRegister fails to write back to register

labath added a comment. So, it seems we were all correct. The mach-o core file implementation does permit writing registers, while the elf one doesn't. I guess we never got that feature request for elf. I don't think that's a blocker for writing this test though. If we decide to support

[Lldb-commits] [lldb] b5eeb88 - [lldb] One more fix for the MonitorChildProcess patch (D120425)

Author: Pavel Labath Date: 2022-02-24T12:06:42+01:00 New Revision: b5eeb8873af93029221e97ad4d89febb22f62fd3 URL: https://github.com/llvm/llvm-project/commit/b5eeb8873af93029221e97ad4d89febb22f62fd3 DIFF: https://github.com/llvm/llvm-project/commit/b5eeb8873af93029221e97ad4d89febb22f62fd3.diff

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

labath added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); JDevlieghere wrote: > I see an opportunity for a little

[Lldb-commits] [lldb] c64dbb6 - [lldb] Fix windows build for D120425

Author: Pavel Labath Date: 2022-02-24T11:50:54+01:00 New Revision: c64dbb66d98d78bfca80ef23959747fe76911a4a URL: https://github.com/llvm/llvm-project/commit/c64dbb66d98d78bfca80ef23959747fe76911a4a DIFF: https://github.com/llvm/llvm-project/commit/c64dbb66d98d78bfca80ef23959747fe76911a4a.diff

[Lldb-commits] [PATCH] D120425: [lldb/host] Remove monitor_signals argument from process monitoring functions

This revision was automatically updated to reflect the committed changes. Closed by commit rG12c9c4a88537: [lldb/host] Remove monitor_signals argument from process monitoring functions (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] 12c9c4a - [lldb/host] Remove monitor_signals argument from process monitoring functions

Author: Pavel Labath Date: 2022-02-24T11:12:59+01:00 New Revision: 12c9c4a8853740c41b183495f4d9931e7eee5268 URL: https://github.com/llvm/llvm-project/commit/12c9c4a8853740c41b183495f4d9931e7eee5268 DIFF: https://github.com/llvm/llvm-project/commit/12c9c4a8853740c41b183495f4d9931e7eee5268.diff