[Lldb-commits] [PATCH] D120607: [lldb/test] Re-enable TestEvents.py on Darwin and fix crashes

mib created this revision. mib added a reviewer: JDevlieghere. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch re-enables TestEvents.py on Darwin and fixes some crashes that were happening due to an undefined method. I ran it

[Lldb-commits] [lldb] 2dc6e90 - [lldb/Host] Fix crash in FileSystem::IsLocal

Author: Med Ismail Bennani Date: 2022-02-25T18:33:31-08:00 New Revision: 2dc6e906b09deb092c15a726c06d0ecbeec1eb18 URL: https://github.com/llvm/llvm-project/commit/2dc6e906b09deb092c15a726c06d0ecbeec1eb18 DIFF:

[Lldb-commits] [PATCH] D120599: Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

This revision was automatically updated to reflect the committed changes. Closed by commit rG425880ed35ee: Reland [lldb/test] Fix TestProgressReporting.py race issue with the event… (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120598: [lldb/crashlog] Fix scripted_crashlog_json.test failure

This revision was automatically updated to reflect the committed changes. Closed by commit rGbadb6e2730a9: [lldb/crashlog] Fix scripted_crashlog_json.test failure (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120598/new/

[Lldb-commits] [lldb] 425880e - Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

Author: Med Ismail Bennani Date: 2022-02-25T17:20:39-08:00 New Revision: 425880ed35ee399d8f1af0aac60100e4901f289f URL: https://github.com/llvm/llvm-project/commit/425880ed35ee399d8f1af0aac60100e4901f289f DIFF:

[Lldb-commits] [lldb] badb6e2 - [lldb/crashlog] Fix scripted_crashlog_json.test failure

Author: Med Ismail Bennani Date: 2022-02-25T17:20:35-08:00 New Revision: badb6e2730a970b5ee94f0adb77c2de741ebbf68 URL: https://github.com/llvm/llvm-project/commit/badb6e2730a970b5ee94f0adb77c2de741ebbf68 DIFF:

[Lldb-commits] [PATCH] D120598: [lldb/crashlog] Fix scripted_crashlog_json.test failure

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120598/new/ https://reviews.llvm.org/D120598

[Lldb-commits] [PATCH] D120599: Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. Ship it Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120599/new/ https://reviews.llvm.org/D120599

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace requested changes to this revision. wallace added a comment. This revision now requires changes to proceed. you got the flow correct. I left comments regarding specific details, but good job overall!! Comment at: lldb/docs/lldb-gdb-remote.txt:454-479 +//}], +//

[Lldb-commits] [PATCH] D120599: Reland "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

mib created this revision. mib added reviewers: labath, JDevlieghere, MForster. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch relands commit 3e3e79a9e4c378b59f5f393f556e6a84edcd8898

[Lldb-commits] [PATCH] D120598: [lldb/crashlog] Fix scripted_crashlog_json.test failure

mib created this revision. mib added reviewers: JDevlieghere, jingham. mib added a project: LLDB. mib requested review of this revision. Herald added a subscriber: lldb-commits. This patch should fix the test failure on scripted_crashlog_json.test. The failure is caused because crash reporter

[Lldb-commits] [PATCH] D120595: [trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

jj10306 added inline comments. Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:51 + int64_t m_time_shift; + int64_t m_time_zero; +}; What is the suggested way to serialize a u64 into JSON? I thought of two approaches: 1. Store two

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda added a comment. In D120594#3346730 , @jasonmolenda wrote: > In D120594#3346722 , @JDevlieghere > wrote: > >> Nit: can we use a colon instead of dash? We have a bunch of places already >> where

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda added a comment. In D120594#3346722 , @JDevlieghere wrote: > Nit: can we use a colon instead of dash? We have a bunch of places already > where we're "concatenating" errors with a colon so I'd like to keep that > consistent. Using a dash

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

JDevlieghere added a comment. Nit: can we use a colon instead of dash? We have a bunch of places already where we're "concatenating" errors with a colon so I'd like to keep that consistent. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D120595: [trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

jj10306 created this revision. jj10306 added reviewers: wallace, davidca. jj10306 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Begin implementing Tsc to timestamp conversion for IntelPT traces: - Add TscConverter and stub out first

[Lldb-commits] [PATCH] D120594: Improve error messages for command that need a stopped process

jasonmolenda created this revision. jasonmolenda added a reviewer: jingham. jasonmolenda added a project: LLDB. Herald added a subscriber: JDevlieghere. jasonmolenda requested review of this revision. Herald added a subscriber: lldb-commits. I don't think lldb's error messaging is great when

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

JDevlieghere added a comment. Yup, that works too Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

JDevlieghere updated this revision to Diff 411533. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120593/new/ https://reviews.llvm.org/D120593 Files: lldb/tools/driver/Driver.cpp llvm/include/llvm/Support/WithColor.h llvm/lib/Support/WithColor.cpp Index:

[Lldb-commits] [PATCH] D120593: [Support] Allow the ability to change WithColor's auto detection function

JDevlieghere created this revision. JDevlieghere added reviewers: aprantl, RKSimon, jdenny. Herald added subscribers: dexonsmith, hiraditya. JDevlieghere requested review of this revision. Herald added a project: LLVM. `WithColor` has an "auto detection mode" which looks whether the corresponding

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

andcarminati added inline comments. Comment at: lldb/source/Symbol/ObjectFile.cpp:559 + lldb::offset_t section_offset) const { + offset_t offset = section->GetOffset() + section_offset; + return m_data.GetCStr(); Wouldn't it be

[Lldb-commits] [lldb] 2ce6bc6 - [lldb] Fix check for TARGET_OS_IPHONE

Author: Jonas Devlieghere Date: 2022-02-25T13:24:39-08:00 New Revision: 2ce6bc61e876f4e7918952a565488d737ce647f6 URL: https://github.com/llvm/llvm-project/commit/2ce6bc61e876f4e7918952a565488d737ce647f6 DIFF:

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

labath added a comment. I don't think this implementation is sound. If you look at the implementation of `ReadSectionData` you'll see that there is a lot more involved in reading data from a section than just incrementing a pointer. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

augusto2112 added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:677 + const char *GetCStrFromSection(Section *section, + lldb::offset_t section_offset) const; + aprantl wrote: > Should we call it

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

aprantl added inline comments. Comment at: lldb/include/lldb/Symbol/ObjectFile.h:676 + const char *GetCStrFromSection(Section *section, + lldb::offset_t section_offset) const; Can you add a doxygen comment for the method?

[Lldb-commits] [PATCH] D120578: [lldb] Implement ObjectFile::GetCStrFromSection

augusto2112 created this revision. augusto2112 added reviewers: aprantl, JDevlieghere. augusto2112 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D120578 Files:

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added a comment. Jim's suggestion made me think that if we make a subcommand for this, it would be nice to have some completion handling. I know it would probably require you to move away from the python function but this is just a suggestion for later improvements. Repository: rG LLVM

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

labath added a comment. In D120284#3345994 , @JDevlieghere wrote: >> I'm not entirely sure what's the best fix here. @JDevlieghere, what do you >> think? Can we just remove the output arguments from the LLDB_INSTRUMENT_VA >> invocation (given how

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

mib added a comment. In D120292#3346030 , @JDevlieghere wrote: > I like Jim's suggestion Same same ! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120292/new/ https://reviews.llvm.org/D120292

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

mib added a comment. In D120284#3345994 , @JDevlieghere wrote: >> I'm not entirely sure what's the best fix here. @JDevlieghere, what do you >> think? Can we just remove the output arguments from the LLDB_INSTRUMENT_VA >> invocation (given how logging

[Lldb-commits] [PATCH] D120292: [lldb] Add lldb.find helper function

JDevlieghere added a comment. I like Jim's suggestion Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120292/new/ https://reviews.llvm.org/D120292 ___ lldb-commits mailing list lldb-commits@lists.llvm.org

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

JDevlieghere added a comment. > I'm not entirely sure what's the best fix here. @JDevlieghere, what do you > think? Can we just remove the output arguments from the LLDB_INSTRUMENT_VA > invocation (given how logging their entry values is pretty useless)? Yup, the way I dealt with that for the

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Prepare decouple instance and plugin names

JDevlieghere accepted this revision. JDevlieghere added a comment. (Still) LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119146/new/ https://reviews.llvm.org/D119146 ___ lldb-commits mailing list

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

zequanwu updated this revision to Diff 411446. zequanwu marked 5 inline comments as done. zequanwu added a comment. update. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119963/new/ https://reviews.llvm.org/D119963 Files:

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

MForster added a comment. > The backtrace is pretty much useless Yes, sorry, that's all I had. Just added some evidence. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120284/new/ https://reviews.llvm.org/D120284

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

labath added a comment. The backtrace is pretty much useless, but what is happening is that the LLDB_INSTRUMENT_VA macro inside SBDebugger::GetProgressFromEvent is trying to log the uninitialized output variable, which angers the gods of sanitation. I'm not entirely sure what's the best fix

[Lldb-commits] [lldb] 4729a72 - Revert "[lldb/test] Fix TestProgressReporting.py race issue with the event listener"

Author: Michael Forster Date: 2022-02-25T13:07:49Z New Revision: 4729a72acec31b46e167b16f50efacab9d16da9c URL: https://github.com/llvm/llvm-project/commit/4729a72acec31b46e167b16f50efacab9d16da9c DIFF: https://github.com/llvm/llvm-project/commit/4729a72acec31b46e167b16f50efacab9d16da9c.diff

[Lldb-commits] [PATCH] D120284: [lldb/test] Fix TestProgressReporting.py race issue with the event listener

MForster added a comment. This fails under MSAN: ==3096==WARNING: MemorySanitizer: use-of-uninitialized-value #0 0x7f0e7899ce18 (/build/work/73ffa3b6f1cbc2218b7b71e21a3dd1e2e53b/google3/runfiles/google3/third_party/py/lldb/dotest_wrapper.par/@0x3a0b9000+0x2e3e18) (BuildId:

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

andcarminati added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); labath wrote: > JDevlieghere wrote: > >

[Lldb-commits] [lldb] cc7bf4a - [LLDB] XFAIL TestUnambiguousTailCalls.py for Arm/Linux

Author: Muhammad Omair Javaid Date: 2022-02-25T17:09:50+05:00 New Revision: cc7bf4afeefc6d3951871dcb091873243a563646 URL: https://github.com/llvm/llvm-project/commit/cc7bf4afeefc6d3951871dcb091873243a563646 DIFF:

[Lldb-commits] [PATCH] D119146: [lldb/Platform] Decouple instance and plugin names

labath updated this revision to Diff 411366. labath added a comment. Reduce the scope of the patch to GetName interface changes. Given the direction of the discourse thread, it seems unlikely that we will be able to determine the instance name at object creation time. We will likely need a

[Lldb-commits] [PATCH] D114627: [lldb] add new overload for SymbolFile::FindTypes that accepts a scope

lassefolger added a comment. I'm still planning to look into this just couldn't find the time this week and the last. Sorry for the delay. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114627/new/ https://reviews.llvm.org/D114627

[Lldb-commits] [lldb] 317a2b1 - [LLDB] Remove XFAIL from minidebuginfo-set-and-hit-breakpoint.test

Author: Muhammad Omair Javaid Date: 2022-02-25T15:55:05+05:00 New Revision: 317a2b1f6004708b28969c47b48526f6378c4e64 URL: https://github.com/llvm/llvm-project/commit/317a2b1f6004708b28969c47b48526f6378c4e64 DIFF:

[Lldb-commits] [PATCH] D120320: [lldb/driver] Fix SIGTSTP handling

labath added inline comments. Comment at: lldb/tools/driver/Driver.cpp:673-674 +static void sigtstp_handler(int signo) { if (g_driver != nullptr) g_driver->GetDebugger().SaveInputTerminalState(); JDevlieghere wrote: > andcarminati wrote: > >

[Lldb-commits] [PATCH] D119963: [LLDB] Dump valid ranges of variables

labath added inline comments. Comment at: lldb/source/Core/Address.cpp:739 - s->PutCString(", location = "); - var_sp->DumpLocationForAddress(s, *this); - s->PutCString(", decl = "); zequanwu wrote: > labath wrote: > > This

[Lldb-commits] [PATCH] D120517: PlatformMacOSX should be activated for lldb built to run on an iOS etc device

This revision was automatically updated to reflect the committed changes. Closed by commit rGcd2ba23efb3e: PlatformMacOSX should be activated for lldb built to run on an iOS etc device (authored by jasonmolenda). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [lldb] cd2ba23 - PlatformMacOSX should be activated for lldb built to run on an iOS etc device

Author: Jason Molenda Date: 2022-02-25T00:55:54-08:00 New Revision: cd2ba23efb3e282d86cf7a94952f0bf61677fa7f URL: https://github.com/llvm/llvm-project/commit/cd2ba23efb3e282d86cf7a94952f0bf61677fa7f DIFF: https://github.com/llvm/llvm-project/commit/cd2ba23efb3e282d86cf7a94952f0bf61677fa7f.diff