wallace requested changes to this revision.
wallace added a comment.
This revision now requires changes to proceed.
in terms of functionality, everything is right, but you need to do some
improvements
Comment at: lldb/docs/lldb-gdb-remote.txt:454-479
+//}],
+//... othe
Author: Jonas Devlieghere
Date: 2022-02-28T20:30:06-08:00
New Revision: 4429cf146e8ad393ec1d4e6bddab73b7e53957d2
URL:
https://github.com/llvm/llvm-project/commit/4429cf146e8ad393ec1d4e6bddab73b7e53957d2
DIFF:
https://github.com/llvm/llvm-project/commit/4429cf146e8ad393ec1d4e6bddab73b7e53957d2.d
Author: Jonas Devlieghere
Date: 2022-02-28T15:32:15-08:00
New Revision: 3a167c4a90b0352ff3cca576392882e45b70dc36
URL:
https://github.com/llvm/llvm-project/commit/3a167c4a90b0352ff3cca576392882e45b70dc36
DIFF:
https://github.com/llvm/llvm-project/commit/3a167c4a90b0352ff3cca576392882e45b70dc36.d
This revision was landed with ongoing or failed builds.
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa83cf7a84628: [Support] Allow the ability to change
WithColor's auto detection function (authored by JDevlieghere).
Herald added a project: LLDB.
Re
Author: Jonas Devlieghere
Date: 2022-02-28T15:03:04-08:00
New Revision: a83cf7a84628a9e3a24cfd33c69f786cf74df4ec
URL:
https://github.com/llvm/llvm-project/commit/a83cf7a84628a9e3a24cfd33c69f786cf74df4ec
DIFF:
https://github.com/llvm/llvm-project/commit/a83cf7a84628a9e3a24cfd33c69f786cf74df4ec.d
zequanwu updated this revision to Diff 411898.
zequanwu marked 2 inline comments as done.
zequanwu added a comment.
Remove unnecessary `location_list_base_addr` parameter from `GetDescription()`
as it doesn't do filtering when dumping.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST A
jj10306 updated this revision to Diff 411862.
jj10306 marked 3 inline comments as done.
jj10306 edited the summary of this revision.
jj10306 added a comment.
Address comments, still need to handle uint64_t JSON serialization correctly. I
plan to proceed with decoder and schema changes now that in
jj10306 marked 21 inline comments as done.
jj10306 added inline comments.
Comment at: lldb/include/lldb/Utility/TraceIntelPTGDBRemotePackets.h:51
+ int64_t m_time_shift;
+ int64_t m_time_zero;
+};
wallace wrote:
> jj10306 wrote:
> > What is the suggested way to
ljmf00 added a comment.
Meanwhile, a commit will land Linux stable branches soon to fix this issue:
https://git.kernel.org/pub/scm/linux/kernel/git/tip/tip.git/commit/?id=44cad52cc14ae10062f142ec16ede489bccf4469
. Do we have an alternative way to fix this, e.g. a custom XFAIL flag for
specific
