[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere updated this revision to Diff 414590. JDevlieghere added a comment. Include TargetConditionals.h CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121444/new/ https://reviews.llvm.org/D121444 Files: lldb/source/Plugins/Platform/MacOSX/PlatformDarwin.h lldb/source/Plugins/P

[Lldb-commits] [PATCH] D121444: [lldb] Fix platform selection on Apple Silicon (again)

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, friss, labath. Herald added a project: All. JDevlieghere requested review of this revision. This patch is another attempt to fix platform selection on Apple Silicon. It partially undoes D117340

[Lldb-commits] [PATCH] D121443: [lldb] Add a getter for the process' system architecture

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, labath, jingham. Herald added a project: All. JDevlieghere requested review of this revision. This patch adds a getter for the process' system architecture. I went with `Process::GetSystemArchitecture` to match `Platf

[Lldb-commits] [PATCH] D121442: [lldb] Don't overwrite the host arch (from qHostInfo) with the process arch (from qProcessInfo)

JDevlieghere created this revision. JDevlieghere added reviewers: jasonmolenda, labath, mgorny. Herald added a project: All. JDevlieghere requested review of this revision. Don't overwrite the host architecture (obtained from qHostInfo in GDBRemoteCommunicationClient::GetHostInfo) with the proces

[Lldb-commits] [PATCH] D121030: [LLDB][NativePDB] Fix infinite recursion when a class has static member with the class type.

zequanwu updated this revision to Diff 414529. zequanwu added a comment. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. We simply shouldn't complete the types of static members at all, which is how dwarf does it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST

[Lldb-commits] [lldb] 14e4d2e - [lldb] Remove unused include in ScriptedProcessInterface.h

Author: Dave Lee Date: 2022-03-10T14:56:21-08:00 New Revision: 14e4d2e5643e505039588d50b31e29e3042009f5 URL: https://github.com/llvm/llvm-project/commit/14e4d2e5643e505039588d50b31e29e3042009f5 DIFF: https://github.com/llvm/llvm-project/commit/14e4d2e5643e505039588d50b31e29e3042009f5.diff LOG:

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

aprantl added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/x86/DW_OP_deref_size_static_var.s:1 +# RUN: llvm-mc -filetype=obj -o %t -triple x86_64-apple-macosx10.15.0 %s +# RUN: %lldb %t -o "target variable ug" -b | FileCheck %s Out of curiosity:

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

aprantl added a comment. This is nice, I have a few mostly stylistic comments inline. Comment at: lldb/source/Expression/DWARFExpression.cpp:947 +llvm::Optional +ResolveAndLoadFileAddress(ExecutionContext *exe_ctx, lldb::ModuleSP module_sp, Maybe add a Doxyge

[Lldb-commits] [PATCH] D96655: [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan

This revision was not accepted when it landed; it landed in state "Needs Review". This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG47f652d69517: [lldb] Call ThreadPlan::DiscardPlan from Thread::Dis

[Lldb-commits] [lldb] 47f652d - [lldb] Call ThreadPlan::DiscardPlan from Thread::DiscardPlan

Author: Dave Lee Date: 2022-03-10T13:58:08-08:00 New Revision: 47f652d69517336fb0f6fbdcd6bf4dc962ae5e65 URL: https://github.com/llvm/llvm-project/commit/47f652d69517336fb0f6fbdcd6bf4dc962ae5e65 DIFF: https://github.com/llvm/llvm-project/commit/47f652d69517336fb0f6fbdcd6bf4dc962ae5e65.diff LOG:

[Lldb-commits] [lldb] c604207 - lldb/ObjectFile, Disassembler: read some state from the executable

Author: Saleem Abdulrasool Date: 2022-03-10T21:42:06Z New Revision: c6042076081025bc8060637b05fbeb24dbb82538 URL: https://github.com/llvm/llvm-project/commit/c6042076081025bc8060637b05fbeb24dbb82538 DIFF: https://github.com/llvm/llvm-project/commit/c6042076081025bc8060637b05fbeb24dbb82538.diff

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. In D121078#3373139 , @philnik wrote: > In D121078#3373081 , @SimplyDanny > wrote: > >> I'm happy that you found a reasonable compromise. I like it too. ;) >> >> Now, I ask you to help

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

philnik added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are all tak

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

aaron.ballman added a comment. In D121078#3373081 , @SimplyDanny wrote: > I'm happy that you found a reasonable compromise. I like it too. ;) > > Now, I ask you to help me a little bit with the workflow and the test > failures. The review comments are a

[Lldb-commits] [PATCH] D121078: Replace links to archived mailing lists by links to Discourse forums

SimplyDanny added a comment. I'm happy that you found a reasonable compromise. I like it too. ;) Now, I ask you to help me a little bit with the workflow and the test failures. The review comments are all taken care of as far as I see. One reviewer approved the changes, others are still in a "n

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

RKSimon added a comment. @serge-sans-paille Any luck with tracking down https://lab.llvm.org/buildbot/#/builders/67/builds/6136 ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121168/new/ https://reviews.llvm.org/D121168 _

[Lldb-commits] [PATCH] D121168: Cleanup includes: LLVMTarget

This revision was automatically updated to reflect the committed changes. Closed by commit rG3c4410dfcaaf: Cleanup includes: LLVMTarget (authored by serge-sans-paille). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121168/new/ https://reviews.llvm.o

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

shafik added a comment. There can probably be some more refactoring wrt to the `Value` class which also does a lot of the same work but there are enough differences that I think any attempt at that should be left for a separate PR. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121408/n

[Lldb-commits] [PATCH] D121408: Fixing DWARFExpression handling of ValueType::FileAddress case for DW_OP_deref_size

shafik created this revision. shafik added reviewers: aprantl, labath, jingham. Herald added a project: All. shafik requested review of this revision. Herald added a reviewer: jdoerfert. Herald added a subscriber: sstefan1. Currently `DW_OP_deref_size` just drops the `ValueType::FileAddress` case

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGMT with the SysV ABI updated as well. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121348/new/ https://reviews.llvm.org/D121348

[Lldb-commits] [lldb] c24199e - [lldb] Always listen for progress events in the default event handler

Author: Jonas Devlieghere Date: 2022-03-10T12:51:27-08:00 New Revision: c24199e8e885800147aa98ce2b48b5d830bd51ed URL: https://github.com/llvm/llvm-project/commit/c24199e8e885800147aa98ce2b48b5d830bd51ed DIFF: https://github.com/llvm/llvm-project/commit/c24199e8e885800147aa98ce2b48b5d830bd51ed.d

[Lldb-commits] [PATCH] D119508: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG5e9c9b324a1f: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and… (authored by zequanwu). Repository: rG LLVM Github Monorepo CHANGES SINC

[Lldb-commits] [lldb] 5e9c9b3 - [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

Author: Zequan Wu Date: 2022-03-10T12:40:31-08:00 New Revision: 5e9c9b324a1f7f904b733852d0a05a43e9783cbb URL: https://github.com/llvm/llvm-project/commit/5e9c9b324a1f7f904b733852d0a05a43e9783cbb DIFF: https://github.com/llvm/llvm-project/commit/5e9c9b324a1f7f904b733852d0a05a43e9783cbb.diff LOG

[Lldb-commits] [PATCH] D119508: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

zequanwu updated this revision to Diff 414464. zequanwu added a comment. address comment Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D119508/new/ https://reviews.llvm.org/D119508 Files: lldb/include/lldb/Utility/RangeMap.h lldb/source/Plugins

[Lldb-commits] [lldb] e3dfa30 - [lldb] Remove extra space in step logging message

Author: Dave Lee Date: 2022-03-10T12:02:58-08:00 New Revision: e3dfa30501c55c4c4cb10e7554b404afa400cc08 URL: https://github.com/llvm/llvm-project/commit/e3dfa30501c55c4c4cb10e7554b404afa400cc08 DIFF: https://github.com/llvm/llvm-project/commit/e3dfa30501c55c4c4cb10e7554b404afa400cc08.diff LOG:

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

jingham added a comment. In D121348#3373170 , @labath wrote: > I don't think this is a peculiarity of the darwin ABI. I'm pretty sure i've > ran into this on the "sysv" ABI as well. > > If we're going to disallow this, then I think we should do the same

[Lldb-commits] [PATCH] D121305: [lldb/gdb-remote] Remove ancient debugserver workaround

This revision was automatically updated to reflect the committed changes. Closed by commit rGed1a83befe65: [lldb/gdb-remote] Remove ancient debugserver workaround (authored by labath). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121305/new/ https:

[Lldb-commits] [lldb] ed1a83b - [lldb/gdb-remote] Remove ancient debugserver workaround

Author: Pavel Labath Date: 2022-03-10T20:26:54+01:00 New Revision: ed1a83befe6569e8bc67846a98dcf3eaa6dd978a URL: https://github.com/llvm/llvm-project/commit/ed1a83befe6569e8bc67846a98dcf3eaa6dd978a DIFF: https://github.com/llvm/llvm-project/commit/ed1a83befe6569e8bc67846a98dcf3eaa6dd978a.diff

[Lldb-commits] [PATCH] D121316: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG6aa48034f9e6: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM (authored by mib). Repository: rG LLVM Github Monore

[Lldb-commits] [PATCH] D121038: [lldb/crashlog] Make interactive mode display more user-friendly

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8d097a6b932c: [lldb/crashlog] Make interactive mode display more user-friendly (authored by mib). Repository: rG LLVM Github Monorepo CHANGES SIN

[Lldb-commits] [lldb] deb359a - [lldb/crashlog] Reformat module loading logs (NFC)

Author: Med Ismail Bennani Date: 2022-03-10T11:06:59-08:00 New Revision: deb359aab33ed52ee167b5875c6e97bf6dbded15 URL: https://github.com/llvm/llvm-project/commit/deb359aab33ed52ee167b5875c6e97bf6dbded15 DIFF: https://github.com/llvm/llvm-project/commit/deb359aab33ed52ee167b5875c6e97bf6dbded15.

[Lldb-commits] [lldb] 8d097a6 - [lldb/crashlog] Make interactive mode display more user-friendly

Author: Med Ismail Bennani Date: 2022-03-10T11:06:59-08:00 New Revision: 8d097a6b932c8eb0ee114282aa5456f1d0242d01 URL: https://github.com/llvm/llvm-project/commit/8d097a6b932c8eb0ee114282aa5456f1d0242d01 DIFF: https://github.com/llvm/llvm-project/commit/8d097a6b932c8eb0ee114282aa5456f1d0242d01.

[Lldb-commits] [lldb] 6aa4803 - [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM

Author: Med Ismail Bennani Date: 2022-03-10T11:06:59-08:00 New Revision: 6aa48034f9e6eeca731bac0c33688a3396531a3c URL: https://github.com/llvm/llvm-project/commit/6aa48034f9e6eeca731bac0c33688a3396531a3c DIFF: https://github.com/llvm/llvm-project/commit/6aa48034f9e6eeca731bac0c33688a3396531a3c.

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

labath added a comment. I don't think this is a peculiarity of the darwin ABI. I'm pretty sure i've ran into this on the "sysv" ABI as well. If we're going to disallow this, then I think we should do the same for ABISysV_arm64 as well -- it looks like an identical change to ABISysV_arm64 shoul

[Lldb-commits] [PATCH] D121316: [lldb/Plugin] Test that a scripted process blueprint can be loaded for the dSYM

JDevlieghere accepted this revision. JDevlieghere added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D121316/new/ https://reviews.llvm.org/D121316 ___

[Lldb-commits] [PATCH] D119508: [LLDB][NativePDB] Add support for S_DEFRANGE_REGISTER and S_DEFRANGE_SUBFIELD_REGISTER

labath accepted this revision. labath added inline comments. This revision is now accepted and ready to land. Comment at: lldb/source/Symbol/Variable.cpp:251 +GetScopeRange().IsEmpty() || GetScopeRange().FindEntryThatContains( + add

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

jj10306 added a comment. Due to the size and expanding scope of this diff, I'm going to split this into several smaller diffs. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120595/new/ https://reviews.llvm.org/D120595 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D120595: [WIP][trace][intelpt] Add TSC to Nanosecond conversion for IntelPT traces

wallace added inline comments. Comment at: lldb/docs/lldb-gdb-remote.txt:455 +//}], +//"tsc_conversion"?: Optional<{ +// "kind": , wallace wrote: > wallace wrote: > > wallace wrote: > > > The ? After the key name makes Optional<> redundant. Just keep

[Lldb-commits] [lldb] 3c4410d - Cleanup includes: LLVMTarget

Author: serge-sans-paille Date: 2022-03-10T10:00:29+01:00 New Revision: 3c4410dfcaafdb3d772a79c130b6e69f64aa7712 URL: https://github.com/llvm/llvm-project/commit/3c4410dfcaafdb3d772a79c130b6e69f64aa7712 DIFF: https://github.com/llvm/llvm-project/commit/3c4410dfcaafdb3d772a79c130b6e69f64aa7712.d

[Lldb-commits] [PATCH] D121348: Don't try to get memory returns for ABIMacOSX_arm64

jasonmolenda added a comment. Ach, that's unfortunate. So a caller can allocate space for the return object, pass that address to a callee in x8, but when callee returns, x8 has been overwritten. Agree that this is the only right way to behave. Repository: rG LLVM Github Monorepo CHANGES